Allowed non-this, non-super code before super call in derived classes with property initializers by JoshuaKGoldberg · Pull Request #29374 · microsoft/TypeScript

JoshuaKGoldberg · 2019-01-11T15:57:58Z

Starts on #8277 by allowing the non-this, non-super code to be root-level statements in the constructor. This will now be allowed:

classBase{}classDerivedextendsBase{publicprop=true;constructor(publicparamProp=true){console.log("Hello, world!");super();}}

It feels wrong to put a new forEachChild loop in the checker, though in the vast majority of user files this will be a very quick one. Is there a better way to check for a reference to super or this?

Edit 2/28/2020: I've ~~mostly~~ resolved the merge conflicts introduced by both # private fields & useDefineForClassFields~~, but I'm not confident my approach is still a valid one. I'd greatly appreciate it if someone could confirm I'm on the right track~~!
~~Oh, and gulp runtests passes locally (on Windows). I'll try a Mac to see if there's some odd encoding/whitespace behavior with the failing test...~~ ✔️

Edit 3/11/2021: It seems this is fairly close to merging.

Edit 1/13/2022: I bought this PR a birthday cake for its third birthday. https://twitter.com/JoshuaKGoldberg/status/1481654056422567944

Fixesmicrosoft#8277. It feels wrong to put a new `forEachChild` loop in the checker, though in the vast majority of user files this will be a very quick one. Is there a better way to check for a reference to `super` or `this`?

weswigham · 2019-01-11T21:10:32Z

It feels wrong to put a new forEachChild loop in the checker, though in the vast majority of user files this will be a very quick one. Is there a better way to check for a reference to super or this?

TransformFlags.Super | TransformFlags.ContainsSuper for super at least.

…boundaries ```ts function () { return this; } ``` It was immediately going to `ts.forEachChild` so the statement itself wasn't being counted as a new `this` scope.

ajafff

This is getting very complex very fast. I wonder if there's an easier way using the control flow graph?

… case

As per discussion in the issue, it would be ideal to consider any block that always ends up calling to super() the equivalent of a root-level super() statement. This would be valid: ```ts foo = 1; constructor() { condition() ? super(1) : super(0); this.foo; } ``` ...as it would compile to the equivalent of: ```ts function () { condition() ? super(1) : super(0); this.foo = 1; this.foo; } That change would a bit more intense and I'm very timid, so leaving it out of this PR. In the meantime the requirement is that the super() statement must itself be root-level.

RyanCavanaugh · 2019-01-25T00:27:05Z

cc @ahejlsberg for review

JoshuaKGoldberg · 2019-04-02T18:52:39Z

Ping @ahejlsberg - is there anything that needs to be done here? It'd be nice to have this in 😄

JoshuaKGoldberg · 2019-07-16T17:59:21Z

Correction: ping, @weswigham?

pkoch · 2022-01-14T02:09:50Z

@rbuckton Is there anything else that @JoshuaKGoldberg can do to move this forward?

rbuckton · 2022-01-14T02:22:55Z

@typescript-bot user test this inline

typescript-bot · 2022-01-14T02:22:59Z

Heya @rbuckton, I'm starting to run the inline community code test suite on this PR at 1b3dd6d. Hold tight - I'll update this comment with the log link once the build has been queued.

rbuckton · 2022-01-14T04:28:47Z

@rbuckton Is there anything else that @JoshuaKGoldberg can do to move this forward?

Nope, it looks ready to go actually, and just in time for 4.6 beta.

JoshuaKGoldberg · 2022-01-14T14:32:17Z

Fantastic, thanks so much for the reviews & merge @rbuckton!

If any issues come out of this change I'm available to try to fix, if that's helpful.

NaveedAhmadHematmal · 2022-01-14T18:16:02Z

The longest-living PR I have ever seen. 😳

lukescott · 2022-01-20T17:10:30Z

YES!!! Thank you!🎉 🎉 🎉

callumok2004 · 2022-01-22T17:09:49Z

🥳🎉🎉

iJungleboy · 2022-03-07T07:50:23Z

Amazing work and perseverance. Awesome!

EstopaceMA · 2022-03-18T16:15:58Z

Man! Awesome. The perseverance! 🎉

vladboss61 · 2022-07-07T21:04:58Z

Does it mean that now super is going to be invoked the first time never mind where he is located in the constructor?

…rosoft/TypeScript#29374 The minimum TypeScript dependency is lifted to 4.6.2

jfortier-haptiq · 2022-07-28T15:27:06Z

Congrats, apparently the cake did it's job! 🎉

gbersac · 2022-07-28T15:31:49Z

Guy you've made it reddit programmer humor front page! https://www.reddit.com/r/ProgrammerHumor/comments/waa0lz/if_youre_ever_frustrated_that_your_github_prs/

taylus · 2022-07-28T18:36:28Z

grats on the PR

upq · 2022-07-28T19:55:49Z

Congrats !! Happy for you!
Might as well be the most famous PR yet ... from branding perspective I recommend you naming the PR
Suggestion: Des Supa

ajafff suggested changes Jan 11, 2019
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

Used new isNewThisScope utility and dummy prop in baselines
dbd3a2a

ajafff suggested changes Jan 11, 2019
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated
Comment threadsrc/compiler/utilities.ts Outdated

Accounted for parameters and get/set accessor bodies
5aa79cd

ajafff reviewed Jan 11, 2019
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated

Accounted for class extensions
02516cc

JoshuaKGoldberg commented Jan 12, 2019
View reviewed changes

Comment threadtests/baselines/reference/derivedClassSuperProperties.errors.txt Outdated

(node|statement)RefersToSuperOrThis wasn't checking root level scope …
00b4a2b
…boundaries ```ts function () { return this; } ``` It was immediately going to `ts.forEachChild` so the statement itself wasn't being counted as a new `this` scope.

ajafff suggested changes Jan 12, 2019
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated
Comment threadsrc/compiler/checker.ts Outdated
Comment threadsrc/compiler/utilities.ts Outdated
Comment threadsrc/compiler/utilities.ts Outdated
Comment threadsrc/compiler/utilities.ts Outdated

ajafff reviewed Jan 12, 2019
View reviewed changes

Comment threadtests/baselines/reference/derivedClassSuperProperties.js

JoshuaKGoldberg mentioned this pull request Jan 13, 2019
Added error for class properties used within their own declaration #29395
Merged

Better 'references' name and comments; accounted for more method edge…
6d06b21
… case

JoshuaKGoldberg commented Jan 14, 2019
View reviewed changes

Comment threadtests/baselines/reference/derivedClassSuperProperties.errors.txt Outdated

JoshuaKGoldberg mentioned this pull request Jan 14, 2019
Always allow code before super call when it does not use "this" #8277
Closed

Josh Goldberg added 3 commits January 15, 2019 14:40

Merge branch 'master'
da71ed9

Fixed error number following 'master' merge
b4a9ac2

ajafff suggested changes Jan 18, 2019
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated

Josh Goldberg added 2 commits January 20, 2019 20:30

Added decorator test cases
0d91548

Again allowed arrow functions
e4dca14

RyanCavanaugh assigned weswigham Jan 25, 2019

MaxGraey mentioned this pull request Jan 30, 2019
Implement calls to 'super()' AssemblyScript/assemblyscript#445
Merged

nicolo-ribaudo mentioned this pull request Feb 28, 2019
@babel/plugin-transform-typescript can insert public property initialization before the call to super. babel/babel#9609
Closed

RyanCavanaugh added this to the TypeScript 3.6.0 milestone Jul 12, 2019

Merge branch 'master'
c8fc681

rbuckton approved these changes Jan 14, 2022
View reviewed changes

rbuckton merged commit b7fee7f into microsoft:mainJan 14, 2022

JoshuaKGoldberg deleted the non-this-super-before-super branch January 14, 2022 14:31

JoshuaKGoldberg mentioned this pull request Jan 24, 2022
Remove older emit support over time #47573
Closed
5 tasks

kitsonk mentioned this pull request Feb 14, 2022
fix(io/buffer): super and initialized prop denoland/std#1917
Merged

This was referenced Mar 3, 2022
Argument becomes implicit any when a void-returning overload follows a non-void-returning signature #48088
Open
Blog post: code-before-super JoshuaKGoldberg/Goldblog#335
Merged

johnnyreilly mentioned this pull request Apr 1, 2022
[RFC] Towards Non-Fungible Types #48513
Closed

This was referenced Apr 13, 2022
No-op string in constructor is repeated and reordered when constructor assignment is used #48671
Closed
Fixed multiple prologue directives with parameter properties #48687
Merged

p-szm mentioned this pull request Apr 19, 2022
Wrong constructor code generated when target is ES5 #48761
Closed

jlusty mentioned this pull request Apr 19, 2022
Missing parameter properties when using class with private fields #48771
Closed

AgnesToulet mentioned this pull request Jun 2, 2022
Repository Dispatch: improve error message for fork PRs grafana/grafana-github-actions#97
Merged

eemeli added a commit to messageformat/messageformat that referenced this pull request Jul 16, 2022
fix(mf2): Use private member for ResolvedMessage cache, thanks tomic…
0fbf543
…rosoft/TypeScript#29374 The minimum TypeScript dependency is lifted to 4.6.2

microsoft locked as resolved and limited conversation to collaborators Jul 28, 2022

Uh oh!

Conversation

JoshuaKGoldberg commented Jan 11, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weswigham commented Jan 11, 2019

Uh oh!

Uh oh!

Uh oh!

ajafff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RyanCavanaugh commented Jan 25, 2019

Uh oh!

JoshuaKGoldberg commented Apr 2, 2019

Uh oh!

JoshuaKGoldberg commented Jul 16, 2019

Uh oh!

pkoch commented Jan 14, 2022

Uh oh!

rbuckton commented Jan 14, 2022

Uh oh!

typescript-bot commented Jan 14, 2022

Uh oh!

rbuckton commented Jan 14, 2022

Uh oh!

JoshuaKGoldberg commented Jan 14, 2022

Uh oh!

NaveedAhmadHematmal commented Jan 14, 2022

Uh oh!

lukescott commented Jan 20, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

callumok2004 commented Jan 22, 2022

Uh oh!

iJungleboy commented Mar 7, 2022

Uh oh!

EstopaceMA commented Mar 18, 2022

Uh oh!

vladboss61 commented Jul 7, 2022

Uh oh!

jfortier-haptiq commented Jul 28, 2022

Uh oh!

gbersac commented Jul 28, 2022

Uh oh!

taylus commented Jul 28, 2022

Uh oh!

upq commented Jul 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JoshuaKGoldberg commented Jan 11, 2019•
edited
Loading

lukescott commented Jan 20, 2022•
edited
Loading