Skip to content

Revert change to strict property initialization checks - #29756

Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fixStrictPropertyInitialization
Feb 5, 2019
Merged

Revert change to strict property initialization checks#29756
Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fixStrictPropertyInitialization

Conversation

@ahejlsberg

@ahejlsbergAnders Hejlsberg (ahejlsberg) commented Feb 5, 2019

Copy link
Copy Markdown
Member

#29714 included a slight change to make strict property initialization checks more conservative. Turns out that isn't workable (it was inconsistent in its handling of any and broke the nightly build), so this PR reverts the change. The actual issue that #29714 fixed is unaffected by this.

@weswigham

Copy link
Copy Markdown
Member

If we're reverting the bit that causes it, we should add a test case:

// @strict: true// @target: es6classMetadata{private_parent: Metadata|undefined;private_map: {[key: string]: any};constructor(parent?: Metadata){this._parent=parent;this._map=Object.create(parent ? parent._map : null);}}

so we know if it regresses before we get to publishing the nightly 😄

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ahejlsberg@weswigham