Skip to content

Allow identical type parameter lists to merge in union signatures - #31023

Merged
Wesley Wigham (weswigham) merged 7 commits into
microsoft:masterfrom
weswigham:better-signature-identity-checks
Dec 16, 2020
Merged

Allow identical type parameter lists to merge in union signatures#31023
Wesley Wigham (weswigham) merged 7 commits into
microsoft:masterfrom
weswigham:better-signature-identity-checks

Conversation

@weswigham

@weswighamWesley Wigham (weswigham) commented Apr 18, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Finishes fixing #30717
Fixes#36307
Fixes#36390 mostly (for all but the reduce case, since that has overloads)

In the first linked issue, the call tmp.get('t') was allowed because the two differing signatures were seen as "identical" by compareSignaturesIdentical, since it erased the type parameters to any (causing their different return types to both look like any). We have since fixed that, however the call was still flagged as an error, but it'd be nice for it to succeed since, ultimately, only the return types differ. So I now allow unions of signatures to merge when their type parameter lists are identical - when this is the case, all following union signature element parameter/return types are instantiated with a mapping of their type parameters into the type parameters from the first type parameter list found. Type parameter defaults are not considered in this mapping (otherwise .then on promise really doesn't work).

@weswighamWesley Wigham (weswigham) mentioned this pull request Jun 24, 2019
Merged
@weswighamWesley Wigham (weswigham) mentioned this pull request Aug 29, 2019
Merged
@weswighamWesley Wigham (weswigham) mentioned this pull request Oct 29, 2019
Closed
@sandersnNathan Shively-Sanders (sandersn) added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 1, 2020
@weswighamWesley Wigham (weswigham) mentioned this pull request Feb 12, 2020
Closed
@RyanCavanaughRyan Cavanaugh (RyanCavanaugh) mentioned this pull request Feb 26, 2020
Closed
@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 3, 2020

Copy link
Copy Markdown
Member

The linked issue is now fixed, so I'm closing this. Wesley Wigham (@weswigham) feel free to re-open if that's not correct.

@weswigham

Wesley Wigham (weswigham) commented Mar 4, 2020

Copy link
Copy Markdown
MemberAuthor

Mmm this was still open because it also happens to fix another suite of issues to do will calling unions of signatures with type parameters; it does need a bit of a refresh, though.

@weswighamWesley Wigham (weswigham) changed the title Have signature identity checks look at the base constraint of type parametersAllow identical type parameter lists to merge in union signaturesMar 4, 2020
@weswigham

Wesley Wigham (weswigham) commented Mar 4, 2020

Copy link
Copy Markdown
MemberAuthor

Nathan Shively-Sanders (@sandersn) I've refreshed this PR, renamed it, and redone the OP with links to relevant issues.

@weswigham

Wesley Wigham (weswigham) commented Mar 4, 2020

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 4, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at e14c58e. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 4, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at e14c58e. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 4, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the perf test suite on this PR at e14c58e. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 4, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized community code test suite on this PR at e14c58e. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..31023

Metricmaster31023DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used334,359k (± 0.04%)333,810k (± 0.02%)-549k (- 0.16%)333,698k333,995k
Parse Time1.63s (± 0.47%)1.61s (± 0.63%)-0.02s (- 1.17%)1.58s1.63s
Bind Time0.90s (± 0.83%)0.89s (± 0.63%)-0.01s (- 1.00%)0.88s0.90s
Check Time4.73s (± 0.47%)4.71s (± 0.42%)-0.02s (- 0.42%)4.68s4.76s
Emit Time5.29s (± 0.83%)5.28s (± 0.56%)-0.00s (- 0.06%)5.23s5.35s
Total Time12.54s (± 0.36%)12.49s (± 0.20%)-0.05s (- 0.40%)12.44s12.56s
Monaco - node (v10.16.3, x64)
Memory used335,273k (± 0.02%)335,299k (± 0.02%)+26k (+ 0.01%)335,161k335,463k
Parse Time1.25s (± 0.62%)1.25s (± 0.74%)-0.00s (- 0.08%)1.22s1.26s
Bind Time0.78s (± 0.64%)0.78s (± 0.67%)+0.00s (+ 0.52%)0.77s0.79s
Check Time4.71s (± 0.59%)4.71s (± 0.71%)-0.01s (- 0.17%)4.61s4.75s
Emit Time2.92s (± 0.75%)2.93s (± 1.22%)+0.01s (+ 0.41%)2.85s3.03s
Total Time9.65s (± 0.51%)9.66s (± 0.45%)+0.01s (+ 0.08%)9.52s9.73s
TFS - node (v10.16.3, x64)
Memory used299,480k (± 0.02%)299,496k (± 0.01%)+16k (+ 0.01%)299,410k299,574k
Parse Time0.94s (± 0.82%)0.93s (± 0.39%)-0.01s (- 0.74%)0.93s0.94s
Bind Time0.75s (± 0.94%)0.74s (± 0.80%)-0.00s (- 0.53%)0.73s0.76s
Check Time4.26s (± 0.43%)4.26s (± 0.46%)+0.00s (+ 0.00%)4.21s4.31s
Emit Time3.04s (± 0.75%)3.03s (± 0.84%)-0.02s (- 0.49%)2.97s3.08s
Total Time8.99s (± 0.47%)8.96s (± 0.41%)-0.03s (- 0.30%)8.87s9.05s
material-ui - node (v10.16.3, x64)
Memory used488,952k (± 0.02%)488,704k (± 0.01%)-249k (- 0.05%)488,554k488,894k
Parse Time1.77s (± 0.50%)1.77s (± 0.50%)+0.01s (+ 0.51%)1.75s1.79s
Bind Time0.68s (± 1.07%)0.69s (± 1.00%)+0.00s (+ 0.44%)0.67s0.70s
Check Time13.52s (± 0.51%)13.59s (± 0.87%)+0.07s (+ 0.53%)13.40s13.87s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.97s (± 0.49%)16.05s (± 0.79%)+0.08s (+ 0.50%)15.86s16.35s
Angular - node (v12.1.0, x64)
Memory used310,048k (± 0.07%)309,512k (± 0.07%)-537k (- 0.17%)308,697k309,755k
Parse Time1.57s (± 0.70%)1.57s (± 0.64%)0.00s ( 0.00%)1.56s1.60s
Bind Time0.87s (± 0.77%)0.88s (± 0.42%)+0.00s (+ 0.23%)0.87s0.88s
Check Time4.64s (± 1.04%)4.62s (± 0.59%)-0.03s (- 0.58%)4.58s4.71s
Emit Time5.46s (± 0.92%)5.48s (± 1.04%)+0.02s (+ 0.31%)5.39s5.66s
Total Time12.55s (± 0.75%)12.54s (± 0.60%)-0.00s (- 0.04%)12.44s12.77s
Monaco - node (v12.1.0, x64)
Memory used315,207k (± 0.02%)315,192k (± 0.02%)-15k (- 0.00%)315,072k315,301k
Parse Time1.20s (± 0.79%)1.21s (± 0.83%)+0.00s (+ 0.25%)1.19s1.23s
Bind Time0.74s (± 1.03%)0.75s (± 0.66%)+0.01s (+ 1.36%)0.74s0.76s
Check Time4.55s (± 0.45%)4.55s (± 0.54%)+0.00s (+ 0.11%)4.52s4.62s
Emit Time2.95s (± 0.86%)2.94s (± 0.92%)-0.01s (- 0.37%)2.89s3.01s
Total Time9.44s (± 0.33%)9.45s (± 0.40%)+0.01s (+ 0.06%)9.38s9.55s
TFS - node (v12.1.0, x64)
Memory used281,763k (± 0.02%)281,699k (± 0.02%)-64k (- 0.02%)281,557k281,842k
Parse Time0.93s (± 0.82%)0.92s (± 0.67%)-0.01s (- 0.65%)0.91s0.93s
Bind Time0.71s (± 0.84%)0.71s (± 0.99%)+0.00s (+ 0.71%)0.70s0.73s
Check Time4.16s (± 0.74%)4.17s (± 0.51%)+0.01s (+ 0.12%)4.12s4.20s
Emit Time3.07s (± 0.88%)3.08s (± 0.52%)+0.01s (+ 0.33%)3.05s3.12s
Total Time8.86s (± 0.52%)8.88s (± 0.21%)+0.01s (+ 0.12%)8.83s8.93s
material-ui - node (v12.1.0, x64)
Memory used466,424k (± 0.01%)466,181k (± 0.01%)-243k (- 0.05%)466,106k466,388k
Parse Time1.74s (± 0.51%)1.74s (± 0.39%)0.00s ( 0.00%)1.74s1.77s
Bind Time0.62s (± 0.95%)0.63s (± 1.10%)+0.00s (+ 0.16%)0.61s0.64s
Check Time12.15s (± 0.97%)11.98s (± 0.34%)-0.16s (- 1.33%)11.90s12.06s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.52s (± 0.84%)14.35s (± 0.32%)-0.16s (- 1.12%)14.26s14.45s
Angular - node (v8.9.0, x64)
Memory used329,433k (± 0.02%)328,935k (± 0.02%)-498k (- 0.15%)328,845k329,112k
Parse Time2.11s (± 0.52%)2.10s (± 0.31%)-0.01s (- 0.66%)2.08s2.11s
Bind Time0.92s (± 0.73%)0.92s (± 0.56%)+0.00s (+ 0.44%)0.91s0.93s
Check Time5.51s (± 0.69%)5.49s (± 0.44%)-0.01s (- 0.27%)5.46s5.56s
Emit Time6.25s (± 0.50%)6.19s (± 0.99%)-0.06s (- 0.91%)6.04s6.34s
Total Time14.78s (± 0.36%)14.70s (± 0.56%)-0.08s (- 0.54%)14.51s14.92s
Monaco - node (v8.9.0, x64)
Memory used333,547k (± 0.01%)333,557k (± 0.01%)+10k (+ 0.00%)333,442k333,628k
Parse Time1.54s (± 0.75%)1.53s (± 0.58%)-0.01s (- 0.32%)1.52s1.56s
Bind Time0.90s (± 1.25%)0.90s (± 1.01%)0.00s ( 0.00%)0.88s0.92s
Check Time5.38s (± 0.49%)5.40s (± 0.39%)+0.03s (+ 0.48%)5.34s5.44s
Emit Time3.51s (± 0.59%)3.51s (± 0.61%)+0.00s (+ 0.06%)3.46s3.57s
Total Time11.33s (± 0.33%)11.35s (± 0.25%)+0.02s (+ 0.18%)11.27s11.40s
TFS - node (v8.9.0, x64)
Memory used298,864k (± 0.01%)298,874k (± 0.02%)+10k (+ 0.00%)298,796k299,029k
Parse Time1.25s (± 0.36%)1.25s (± 0.55%)-0.00s (- 0.16%)1.23s1.26s
Bind Time0.75s (± 0.63%)0.75s (± 0.94%)-0.00s (- 0.13%)0.74s0.77s
Check Time4.81s (± 0.26%)4.85s (± 1.86%)+0.05s (+ 0.96%)4.74s5.05s
Emit Time3.34s (± 2.40%)3.28s (± 3.52%)-0.06s (- 1.86%)2.98s3.41s
Total Time10.15s (± 0.79%)10.13s (± 0.57%)-0.02s (- 0.20%)10.02s10.31s
material-ui - node (v8.9.0, x64)
Memory used494,775k (± 0.01%)494,520k (± 0.01%)-255k (- 0.05%)494,383k494,640k
Parse Time2.11s (± 0.53%)2.09s (± 0.42%)-0.01s (- 0.62%)2.08s2.11s
Bind Time0.81s (± 1.07%)0.81s (± 1.58%)-0.00s (- 0.49%)0.78s0.84s
Check Time19.61s (± 0.60%)19.40s (± 0.72%)-0.21s (- 1.09%)19.19s19.85s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time22.53s (± 0.56%)22.30s (± 0.63%)-0.23s (- 1.03%)22.11s22.75s
Angular - node (v8.9.0, x86)
Memory used188,926k (± 0.03%)188,719k (± 0.01%)-206k (- 0.11%)188,663k188,789k
Parse Time2.06s (± 0.55%)2.04s (± 0.45%)-0.02s (- 0.78%)2.03s2.06s
Bind Time1.07s (± 0.63%)1.07s (± 0.54%)-0.00s (- 0.37%)1.06s1.08s
Check Time5.02s (± 0.62%)5.04s (± 0.39%)+0.02s (+ 0.44%)5.00s5.08s
Emit Time6.15s (± 0.76%)6.16s (± 1.08%)+0.01s (+ 0.23%)6.02s6.36s
Total Time14.30s (± 0.54%)14.31s (± 0.51%)+0.02s (+ 0.11%)14.16s14.53s
Monaco - node (v8.9.0, x86)
Memory used189,231k (± 0.01%)189,220k (± 0.01%)-11k (- 0.01%)189,150k189,271k
Parse Time1.58s (± 0.75%)1.59s (± 0.64%)+0.00s (+ 0.25%)1.57s1.61s
Bind Time0.76s (± 0.64%)0.77s (± 0.62%)+0.00s (+ 0.39%)0.76s0.78s
Check Time5.31s (± 2.12%)5.39s (± 1.56%)+0.08s (+ 1.49%)5.21s5.53s
Emit Time3.00s (± 3.43%)2.95s (± 2.86%)-0.05s (- 1.73%)2.84s3.14s
Total Time10.66s (± 0.47%)10.69s (± 0.45%)+0.03s (+ 0.29%)10.60s10.86s
TFS - node (v8.9.0, x86)
Memory used170,466k (± 0.02%)170,433k (± 0.02%)-33k (- 0.02%)170,362k170,529k
Parse Time1.28s (± 0.55%)1.28s (± 0.62%)+0.00s (+ 0.08%)1.27s1.30s
Bind Time0.72s (± 1.17%)0.72s (± 1.08%)+0.00s (+ 0.28%)0.71s0.74s
Check Time4.60s (± 0.56%)4.61s (± 0.62%)+0.01s (+ 0.26%)4.56s4.70s
Emit Time2.96s (± 0.82%)2.97s (± 3.00%)+0.01s (+ 0.27%)2.81s3.30s
Total Time9.56s (± 0.37%)9.58s (± 0.82%)+0.03s (+ 0.26%)9.44s9.86s
material-ui - node (v8.9.0, x86)
Memory used277,213k (± 0.01%)277,110k (± 0.01%)-102k (- 0.04%)277,010k277,195k
Parse Time2.17s (± 0.43%)2.17s (± 0.70%)-0.00s (- 0.05%)2.14s2.20s
Bind Time0.68s (± 0.70%)0.68s (± 0.88%)-0.00s (- 0.15%)0.67s0.69s
Check Time17.62s (± 0.60%)17.66s (± 0.62%)+0.04s (+ 0.24%)17.46s17.96s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.47s (± 0.54%)20.51s (± 0.57%)+0.04s (+ 0.19%)20.31s20.85s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3102310
Baselinemaster10

@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Mar 4, 2020
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham

Wesley Wigham (weswigham) commented Mar 4, 2020

Copy link
Copy Markdown
MemberAuthor

Perf looks good, user and DT tests look fine, and RWC baseline diff is the removal of a few errors on calls we can now actually resolve (all of them .map), so this looks pretty good.

@RangunaLuis Pais (Ranguna) mentioned this pull request May 9, 2020
Closed
@nateabele

Nate Abele (nateabele) commented May 21, 2020

Copy link
Copy Markdown

Glad to see movement on this. I keep running into it when I try to do basically any non-trivial data modeling.

@kripodKristóf Poduszló (kripod) mentioned this pull request Jul 8, 2020
Closed
@kripodKristóf Poduszló (kripod) mentioned this pull request Jul 15, 2020
Closed
@justjake

Jake Teton-Landis (justjake) commented Jul 19, 2020

Copy link
Copy Markdown

Is this going to make it into TS 4.0?

andrewbranch
Andrew Branch (andrewbranch) approved these changes Sep 22, 2020
View reviewed changes
Comment threadsrc/compiler/checker.ts
}

function combineUnionParameters(left: Signature, right: Signature) {
function combineUnionParameters(left: Signature, right: Signature, mapper: TypeMapper | undefined) {

@andrewbranchAndrew Branch (andrewbranch)Sep 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it took me a second to grok what this was for. Would it have worked to just instantiateSignature(right, mapper) and pass that in instead of instantiating each parameter type on demand?

@andrewbranch

Andrew Branch (andrewbranch) commented Sep 22, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 22, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at e14c58e. You can monitor the build here.

@weswigham

Wesley Wigham (weswigham) commented Dec 15, 2020

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized community code test suite on this PR at 3037443. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at 3037443. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at 3037443. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the perf test suite on this PR at 3037443. You can monitor the build here.

Update: The results are in!

@RyanCavanaughRyan Cavanaugh (RyanCavanaugh) mentioned this pull request Dec 15, 2020
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..31023

Metricmaster31023DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used345,031k (± 0.02%)345,079k (± 0.03%)+49k (+ 0.01%)344,853k345,286k
Parse Time1.99s (± 0.53%)1.98s (± 0.46%)-0.01s (- 0.55%)1.96s2.00s
Bind Time0.82s (± 0.60%)0.83s (± 0.70%)+0.00s (+ 0.24%)0.82s0.84s
Check Time4.99s (± 0.75%)4.98s (± 0.34%)-0.01s (- 0.14%)4.95s5.03s
Emit Time5.34s (± 0.68%)5.34s (± 0.82%)+0.01s (+ 0.11%)5.24s5.43s
Total Time13.15s (± 0.55%)13.14s (± 0.44%)-0.01s (- 0.09%)12.97s13.24s
Compiler-Unions - node (v10.16.3, x64)
Memory used205,420k (± 0.06%)205,417k (± 0.06%)-4k (- 0.00%)204,990k205,619k
Parse Time0.79s (± 0.85%)0.79s (± 0.87%)-0.00s (- 0.13%)0.78s0.81s
Bind Time0.50s (± 0.80%)0.50s (± 1.50%)-0.00s (- 0.40%)0.48s0.51s
Check Time12.10s (± 0.51%)12.10s (± 0.78%)+0.00s (+ 0.04%)11.92s12.29s
Emit Time2.33s (± 1.07%)2.36s (± 1.46%)+0.03s (+ 1.20%)2.30s2.47s
Total Time15.71s (± 0.36%)15.74s (± 0.58%)+0.03s (+ 0.19%)15.55s15.93s
Monaco - node (v10.16.3, x64)
Memory used354,920k (± 0.02%)354,947k (± 0.02%)+27k (+ 0.01%)354,747k355,109k
Parse Time1.60s (± 0.48%)1.60s (± 0.63%)+0.01s (+ 0.31%)1.58s1.63s
Bind Time0.73s (± 0.68%)0.73s (± 0.50%)+0.00s (+ 0.00%)0.72s0.73s
Check Time5.13s (± 0.44%)5.14s (± 0.47%)+0.01s (+ 0.25%)5.08s5.18s
Emit Time2.83s (± 1.10%)2.82s (± 0.56%)-0.01s (- 0.28%)2.79s2.86s
Total Time10.28s (± 0.37%)10.29s (± 0.32%)+0.00s (+ 0.04%)10.22s10.36s
TFS - node (v10.16.3, x64)
Memory used307,932k (± 0.01%)307,898k (± 0.02%)-34k (- 0.01%)307,750k308,103k
Parse Time1.24s (± 0.48%)1.24s (± 0.59%)+0.00s (+ 0.16%)1.22s1.25s
Bind Time0.68s (± 0.49%)0.68s (± 0.72%)+0.00s (+ 0.59%)0.67s0.69s
Check Time4.58s (± 0.38%)4.62s (± 0.53%)+0.04s (+ 0.96%)4.57s4.67s
Emit Time2.94s (± 0.92%)2.96s (± 0.81%)+0.02s (+ 0.65%)2.92s3.03s
Total Time9.44s (± 0.45%)9.50s (± 0.50%)+0.07s (+ 0.69%)9.42s9.63s
material-ui - node (v10.16.3, x64)
Memory used489,874k (± 0.01%)489,919k (± 0.01%)+45k (+ 0.01%)489,819k490,040k
Parse Time2.07s (± 0.58%)2.07s (± 0.39%)+0.00s (+ 0.15%)2.05s2.09s
Bind Time0.65s (± 0.73%)0.66s (± 0.72%)+0.01s (+ 1.55%)0.65s0.67s
Check Time13.63s (± 0.51%)13.76s (± 0.68%)+0.13s (+ 0.92%)13.54s13.95s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time16.35s (± 0.46%)16.48s (± 0.57%)+0.14s (+ 0.84%)16.27s16.68s
Angular - node (v12.1.0, x64)
Memory used322,835k (± 0.02%)322,868k (± 0.02%)+33k (+ 0.01%)322,703k323,007k
Parse Time1.96s (± 0.46%)1.96s (± 0.38%)+0.00s (+ 0.05%)1.94s1.97s
Bind Time0.81s (± 0.42%)0.81s (± 0.64%)-0.00s (- 0.25%)0.80s0.83s
Check Time4.90s (± 0.55%)4.90s (± 0.36%)+0.01s (+ 0.12%)4.87s4.94s
Emit Time5.49s (± 0.46%)5.50s (± 0.59%)+0.01s (+ 0.16%)5.42s5.59s
Total Time13.16s (± 0.27%)13.17s (± 0.30%)+0.02s (+ 0.13%)13.11s13.29s
Compiler-Unions - node (v12.1.0, x64)
Memory used191,685k (± 0.03%)191,640k (± 0.03%)-46k (- 0.02%)191,507k191,726k
Parse Time0.77s (± 0.98%)0.78s (± 0.61%)+0.00s (+ 0.39%)0.77s0.79s
Bind Time0.49s (± 0.60%)0.50s (± 1.11%)+0.01s (+ 2.03%)0.49s0.51s
Check Time10.81s (± 0.79%)10.93s (± 1.19%)+0.12s (+ 1.16%)10.66s11.29s
Emit Time2.35s (± 0.91%)2.38s (± 1.01%)+0.03s (+ 1.06%)2.31s2.43s
Total Time14.43s (± 0.57%)14.59s (± 0.90%)+0.16s (+ 1.09%)14.33s14.93s
Monaco - node (v12.1.0, x64)
Memory used336,972k (± 0.01%)337,043k (± 0.01%)+71k (+ 0.02%)336,943k337,162k
Parse Time1.58s (± 0.57%)1.59s (± 1.19%)+0.01s (+ 0.82%)1.55s1.64s
Bind Time0.71s (± 1.05%)0.71s (± 0.73%)-0.00s (- 0.28%)0.70s0.72s
Check Time4.93s (± 0.35%)4.92s (± 0.49%)-0.00s (- 0.10%)4.88s4.99s
Emit Time2.85s (± 0.54%)2.86s (± 0.60%)+0.01s (+ 0.46%)2.84s2.91s
Total Time10.07s (± 0.19%)10.08s (± 0.58%)+0.01s (+ 0.14%)9.97s10.27s
TFS - node (v12.1.0, x64)
Memory used292,204k (± 0.02%)292,179k (± 0.01%)-25k (- 0.01%)292,118k292,257k
Parse Time1.25s (± 0.62%)1.25s (± 0.66%)+0.00s (+ 0.32%)1.24s1.27s
Bind Time0.65s (± 0.56%)0.65s (± 1.02%)-0.00s (- 0.61%)0.64s0.66s
Check Time4.52s (± 0.63%)4.53s (± 0.65%)+0.01s (+ 0.11%)4.48s4.62s
Emit Time2.96s (± 0.79%)2.95s (± 0.75%)-0.01s (- 0.30%)2.90s3.00s
Total Time9.39s (± 0.50%)9.39s (± 0.43%)-0.00s (- 0.03%)9.29s9.48s
material-ui - node (v12.1.0, x64)
Memory used467,870k (± 0.01%)467,677k (± 0.08%)-194k (- 0.04%)466,634k468,045k
Parse Time2.07s (± 0.47%)2.08s (± 0.59%)+0.01s (+ 0.43%)2.05s2.11s
Bind Time0.64s (± 1.01%)0.64s (± 1.18%)+0.00s (+ 0.31%)0.63s0.67s
Check Time12.05s (± 0.57%)12.25s (± 1.06%)+0.20s (+ 1.68%)12.08s12.57s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.76s (± 0.46%)14.97s (± 0.83%)+0.22s (+ 1.47%)14.80s15.27s
Angular - node (v8.9.0, x64)
Memory used347,697k (± 0.03%)347,714k (± 0.02%)+17k (+ 0.00%)347,543k347,827k
Parse Time2.52s (± 0.55%)2.51s (± 0.29%)-0.02s (- 0.63%)2.50s2.53s
Bind Time0.87s (± 0.69%)0.87s (± 0.95%)0.00s ( 0.00%)0.85s0.88s
Check Time5.63s (± 0.76%)5.65s (± 0.83%)+0.02s (+ 0.36%)5.55s5.76s
Emit Time6.32s (± 1.34%)6.31s (± 0.59%)-0.00s (- 0.06%)6.19s6.37s
Total Time15.34s (± 0.79%)15.34s (± 0.48%)+0.00s (+ 0.03%)15.22s15.52s
Compiler-Unions - node (v8.9.0, x64)
Memory used213,198k (± 0.02%)213,193k (± 0.02%)-5k (- 0.00%)213,106k213,287k
Parse Time0.95s (± 0.59%)0.94s (± 0.63%)-0.00s (- 0.42%)0.93s0.96s
Bind Time0.58s (± 0.96%)0.58s (± 0.86%)-0.00s (- 0.35%)0.57s0.59s
Check Time14.85s (± 0.88%)14.92s (± 0.57%)+0.07s (+ 0.45%)14.81s15.23s
Emit Time2.76s (± 1.89%)2.74s (± 2.49%)-0.02s (- 0.73%)2.61s2.87s
Total Time19.13s (± 0.80%)19.18s (± 0.70%)+0.05s (+ 0.25%)18.95s19.57s
Monaco - node (v8.9.0, x64)
Memory used358,784k (± 0.01%)358,832k (± 0.01%)+49k (+ 0.01%)358,755k358,916k
Parse Time1.92s (± 0.46%)1.93s (± 0.41%)+0.01s (+ 0.26%)1.91s1.95s
Bind Time0.91s (± 0.74%)0.91s (± 0.68%)+0.00s (+ 0.44%)0.90s0.93s
Check Time5.70s (± 0.46%)5.67s (± 0.70%)-0.03s (- 0.56%)5.60s5.80s
Emit Time3.41s (± 0.73%)3.40s (± 0.42%)-0.01s (- 0.23%)3.36s3.43s
Total Time11.94s (± 0.32%)11.91s (± 0.45%)-0.03s (- 0.28%)11.80s12.09s
TFS - node (v8.9.0, x64)
Memory used310,509k (± 0.02%)310,574k (± 0.01%)+65k (+ 0.02%)310,482k310,657k
Parse Time1.57s (± 0.54%)1.57s (± 0.51%)+0.00s (+ 0.06%)1.56s1.59s
Bind Time0.68s (± 0.54%)0.69s (± 0.53%)+0.00s (+ 0.15%)0.68s0.69s
Check Time5.33s (± 0.52%)5.34s (± 0.63%)+0.02s (+ 0.28%)5.26s5.40s
Emit Time2.99s (± 0.60%)2.97s (± 0.56%)-0.01s (- 0.40%)2.94s3.01s
Total Time10.57s (± 0.34%)10.58s (± 0.31%)+0.01s (+ 0.10%)10.52s10.65s
material-ui - node (v8.9.0, x64)
Memory used497,029k (± 0.01%)497,055k (± 0.02%)+26k (+ 0.01%)496,883k497,412k
Parse Time2.49s (± 0.53%)2.51s (± 0.67%)+0.02s (+ 0.88%)2.47s2.55s
Bind Time0.81s (± 1.87%)0.82s (± 1.20%)+0.01s (+ 1.23%)0.81s0.85s
Check Time18.25s (± 0.32%)18.16s (± 1.03%)-0.09s (- 0.50%)17.72s18.51s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time21.56s (± 0.33%)21.49s (± 0.92%)-0.06s (- 0.28%)21.01s21.90s
Angular - node (v8.9.0, x86)
Memory used199,437k (± 0.02%)199,438k (± 0.02%)+1k (+ 0.00%)199,332k199,524k
Parse Time2.44s (± 1.03%)2.44s (± 1.23%)-0.00s (- 0.12%)2.39s2.52s
Bind Time1.02s (± 0.56%)1.02s (± 1.27%)-0.00s (- 0.39%)0.99s1.05s
Check Time5.10s (± 0.72%)5.08s (± 0.35%)-0.02s (- 0.39%)5.04s5.13s
Emit Time6.12s (± 1.07%)6.10s (± 0.79%)-0.02s (- 0.29%)5.96s6.20s
Total Time14.68s (± 0.62%)14.64s (± 0.37%)-0.04s (- 0.29%)14.50s14.80s
Compiler-Unions - node (v8.9.0, x86)
Memory used128,197k (± 0.03%)128,185k (± 0.03%)-12k (- 0.01%)128,094k128,248k
Parse Time0.96s (± 0.79%)0.97s (± 0.77%)+0.01s (+ 0.62%)0.95s0.98s
Bind Time0.49s (± 0.91%)0.49s (± 0.68%)+0.00s (+ 0.41%)0.48s0.50s
Check Time13.99s (± 0.28%)14.02s (± 0.55%)+0.04s (+ 0.26%)13.90s14.22s
Emit Time2.62s (± 1.28%)2.62s (± 0.75%)0.00s ( 0.00%)2.57s2.65s
Total Time18.06s (± 0.30%)18.10s (± 0.41%)+0.04s (+ 0.22%)17.99s18.28s
Monaco - node (v8.9.0, x86)
Memory used203,282k (± 0.02%)203,287k (± 0.02%)+6k (+ 0.00%)203,167k203,354k
Parse Time1.97s (± 0.50%)1.99s (± 1.32%)+0.02s (+ 0.76%)1.95s2.06s
Bind Time0.72s (± 1.06%)0.72s (± 0.92%)+0.00s (+ 0.56%)0.71s0.74s
Check Time5.76s (± 1.54%)5.74s (± 1.40%)-0.02s (- 0.36%)5.48s5.86s
Emit Time2.82s (± 3.58%)2.86s (± 2.96%)+0.04s (+ 1.28%)2.72s3.11s
Total Time11.27s (± 0.25%)11.31s (± 0.45%)+0.04s (+ 0.32%)11.17s11.43s
TFS - node (v8.9.0, x86)
Memory used177,650k (± 0.02%)177,688k (± 0.02%)+38k (+ 0.02%)177,625k177,743k
Parse Time1.61s (± 1.04%)1.60s (± 0.88%)-0.01s (- 0.37%)1.58s1.63s
Bind Time0.65s (± 0.76%)0.65s (± 0.34%)+0.00s (+ 0.77%)0.65s0.66s
Check Time4.91s (± 0.77%)4.88s (± 0.44%)-0.03s (- 0.55%)4.83s4.92s
Emit Time2.85s (± 0.66%)2.84s (± 0.53%)-0.01s (- 0.28%)2.79s2.87s
Total Time10.01s (± 0.57%)9.97s (± 0.39%)-0.04s (- 0.35%)9.90s10.05s
material-ui - node (v8.9.0, x86)
Memory used279,908k (± 0.02%)279,880k (± 0.01%)-28k (- 0.01%)279,769k279,974k
Parse Time2.54s (± 0.47%)2.54s (± 0.46%)+0.00s (+ 0.04%)2.52s2.57s
Bind Time0.70s (± 1.27%)0.72s (± 5.90%)+0.01s (+ 1.84%)0.68s0.85s
Check Time16.64s (± 0.50%)16.71s (± 0.87%)+0.07s (+ 0.44%)16.41s17.05s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time19.89s (± 0.42%)19.98s (± 0.75%)+0.09s (+ 0.46%)19.77s20.41s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-197-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v8.9.0, x64)
  • Compiler-Unions - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3102310
Baselinemaster10

@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Dec 16, 2020
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham

Wesley Wigham (weswigham) commented Dec 16, 2020

Copy link
Copy Markdown
MemberAuthor

All baselines still look good, excellent.

@weswigham
Wesley Wigham (weswigham) merged commit b217f22 into microsoft:masterDec 16, 2020
@andrewbranch

Andrew Branch (andrewbranch) commented Dec 16, 2020

Copy link
Copy Markdown
Member

Happy to see this merged! 🥳

@kripodKristóf Poduszló (kripod) mentioned this pull request Dec 27, 2020
Closed
@rafgraphRafael Pedicini (rafgraph) mentioned this pull request Apr 2, 2021
Open
This was referenced Jun 1, 2021
Closed
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes
@ahejlsbergAnders Hejlsberg (ahejlsberg)Awaiting requested review from ahejlsberg
@sandersnNathan Shively-Sanders (sandersn)Awaiting requested review from sandersn

Assignees

@ahejlsbergAnders Hejlsberg (ahejlsberg)

Labels

Author: TeamFor Milestone BugPRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

7 participants

@weswigham@sandersn@typescript-bot@nateabele@justjake@andrewbranch@ahejlsberg