Fix relations for instantiations of same generic signature by ahejlsberg · Pull Request #31029 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2019-04-19T00:22:12Z

Anders Hejlsberg (ahejlsberg) · 2019-04-19T01:06:58Z

TypeScript Bot (@typescript-bot) test this

TypeScript Bot (typescript-bot) · 2019-04-19T01:07:01Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 78f54c5. You can monitor the build here. It should now contribute to this PR's status checks.

Anders Hejlsberg (ahejlsberg) · 2019-04-19T01:07:21Z

TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2019-04-19T01:07:23Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 78f54c5. You can monitor the build here. It should now contribute to this PR's status checks.

Ryan Cavanaugh (RyanCavanaugh) · 2019-04-19T04:16:23Z

RWC summary

One error elaboration change (possibly unrelated?)

A somewhat interesting example

interfaceAlpha<S>{foo<TextendsS>(s: T): any;}interfaceBetaextendsAlpha<"b">{}interfaceGammaextendsAlpha<"c">{}// Previously not an error// Now an error because of conflicting definitions of 'foo'interfaceDeltaextendsBeta,Gamma{}

This one is from TSLint:

exportfunctionancestorWhere<Textendsts.Node>(node: ts.Node,predicate: (n: ts.Node)=>n is T): T|undefined;exportfunctionancestorWhere(node: ts.Node,predicate: (n: ts.Node)=>boolean): ts.Node|undefined;~~~~~~~~~~~~~!!!errorTS2394: Thisoverloadsignatureisnotcompatiblewithitsimplementationsignature.!!!relatedTS2750language/utils.ts:98:17: Theimplementationsignature is declaredhere.exportfunctionancestorWhere<Textendsts.Node>(node: ts.Node,predicate: (n: ts.Node)=>n is T): T|undefined{

Jack Williams (jack-williams) · 2019-04-19T07:53:45Z

Does this also fix #30988?

EDIT: No

Anders Hejlsberg (ahejlsberg) · 2019-04-21T00:28:06Z

TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2019-04-21T00:28:08Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at df50477. You can monitor the build here. It should now contribute to this PR's status checks.

Anders Hejlsberg (ahejlsberg) · 2019-04-21T03:56:08Z

TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2019-04-21T03:56:42Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at df50477. You can monitor the build here. It should now contribute to this PR's status checks.

Anders Hejlsberg (ahejlsberg) · 2019-04-21T18:26:44Z

TypeScript Bot (@typescript-bot) test this

TypeScript Bot (typescript-bot) · 2019-04-21T18:26:47Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 39c263b. You can monitor the build here. It should now contribute to this PR's status checks.

Anders Hejlsberg (ahejlsberg) · 2019-04-21T18:27:27Z

TypeScript Bot (@typescript-bot) run dt slower

TypeScript Bot (typescript-bot) · 2019-04-21T18:27:29Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the Definitely Typed test suite on this PR at 39c263b. You can monitor the build here. It should now contribute to this PR's status checks.

Anders Hejlsberg (ahejlsberg) · 2019-04-21T22:40:56Z

Wesley Wigham (@weswigham) Looks like the DT test runner has an issue. The last three runs above all failed with OOM errors towards the end, but not in a consistent spot.

Wesley Wigham (weswigham) · 2019-04-22T04:56:44Z

Even the "slower" runner is still running DT in multiple threads in parallel on a single container, so the output log order isn't strictly deterministic. Since in the container-sharded run only one shard runs OOM I'd wager a specific package is running OOM - Nathan Shively-Sanders (@sandersn) do you know if we can get better logging so we know which?

Anders Hejlsberg (ahejlsberg) · 2019-04-22T13:55:27Z

The RWC tests now look good. One insignificant change in an error elaboration and one new error related to multiple inherited methods. Since we've always had a rule that multiple inherited methods must be identical I think the new error is fine. The methods aren't identical, we just failed to detect it before.

There are two issues in Ember that are uncovered by the stricter checking. One is in ember/v2Observable.addObserver and Observable.removeObserver, both of which use keyof this and their Target type parameter in both co- and contra-variant positions. We didn't detect it before because Target was erased to any during checking. Another is use of the non-distributive Pick type in various getter and setter methods in Observable. Both are relatively easy to fix.

Even with fixes, I did notice that ember__array jumps from about 4 seconds to about 9 seconds of check time. It's directly related to Observable's use of keyof this in many places. It generates large union types that sometimes are turned into large intersection types (in contra-variant positions).

Also, we need to figure out what the OOM error in the DT runs is about.

Nathan Shively-Sanders (sandersn) · 2019-04-22T14:23:20Z

Wesley Wigham (@weswigham) are you starting dtslint-runner with 4GB of max old space? The nightly run does that, so that may already be true.

Ron Buckton (@rbuckton) improved types-publisher’s parallel runner to report oom failures correctly on Friday. Probably the right thing to do is port that code to dtslint-runner.

Anders Hejlsberg (@ahejlsberg) I believe you can run dtslint-runner with a local typescript and only one thread, so you can that as a workaround for now.

Wesley Wigham (weswigham) · 2019-04-24T16:53:18Z

TypeScript Bot (@typescript-bot) run dt since now it should log what's running OOM.

TypeScript Bot (typescript-bot) · 2019-04-24T16:53:22Z

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at c2b79df. You can monitor the build here. It should now contribute to this PR's status checks.

Nathan Shively-Sanders (sandersn) · 2019-04-24T18:12:38Z

strophe is still running out of memory
Edit: Nope, it was styled-components/v3

Nathan Shively-Sanders (sandersn) · 2020-02-26T22:31:26Z

I think this looks good as long as it no longer breaks DT. I'll merge from master and re-run.

Nathan Shively-Sanders (sandersn) · 2020-02-26T23:11:56Z

Unfortunately when I merge from master, another test is now broken, bestChoiceType. I may have made a mistake trying to convert the callbackCheck usage to checkMode. Anders Hejlsberg (@ahejlsberg) can you try merging from master and see if you run into the same problem?

# Conflicts: # src/compiler/checker.ts # tests/baselines/reference/keyofAndIndexedAccess2.errors.txt # tests/baselines/reference/keyofAndIndexedAccess2.symbols

Anders Hejlsberg (ahejlsberg) · 2020-03-07T00:12:25Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2020-03-07T00:12:30Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at e262f49. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-03-07T00:12:30Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at e262f49. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-03-07T00:12:30Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the perf test suite on this PR at e262f49. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2020-03-07T00:49:25Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..31029

_Metric	_master	₃₁₀₂₉	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{334,430k (± 0.02%)}	_{333,942k (± 0.02%)}	_{-488k (- 0.15%)}	_333,826k	_334,043k
_{Parse Time}	_{1.63s (± 0.37%)}	_{1.63s (± 0.42%)}	_{+0.00s (+ 0.06%)}	_1.61s	_1.64s
_{Bind Time}	_{0.90s (± 0.92%)}	_{0.89s (± 0.91%)}	_{-0.00s (- 0.33%)}	_0.88s	_0.91s
_{Check Time}	_{4.72s (± 0.61%)}	_{4.72s (± 0.46%)}	_{+0.00s (+ 0.08%)}	_4.67s	_4.77s
_{Emit Time}	_{5.28s (± 0.67%)}	_{5.30s (± 0.44%)}	_{+0.01s (+ 0.23%)}	_5.25s	_5.37s
_{Total Time}	_{12.52s (± 0.48%)}	_{12.54s (± 0.36%)}	_{+0.02s (+ 0.13%)}	_12.44s	_12.65s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{335,336k (± 0.02%)}	_{335,394k (± 0.02%)}	_{+58k (+ 0.02%)}	_335,304k	_335,532k
_{Parse Time}	_{1.26s (± 0.58%)}	_{1.25s (± 0.60%)}	_{-0.00s (- 0.32%)}	_1.24s	_1.27s
_{Bind Time}	_{0.78s (± 0.61%)}	_{0.78s (± 0.48%)}	_{-0.00s (- 0.26%)}	_0.77s	_0.78s
_{Check Time}	_{4.73s (± 0.56%)}	_{4.70s (± 0.47%)}	_{-0.03s (- 0.70%)}	_4.64s	_4.75s
_{Emit Time}	_{2.92s (± 0.93%)}	_{2.93s (± 1.01%)}	_{+0.01s (+ 0.24%)}	_2.89s	_3.02s
_{Total Time}	_{9.69s (± 0.48%)}	_{9.66s (± 0.38%)}	_{-0.03s (- 0.35%)}	_9.59s	_9.74s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{299,533k (± 0.02%)}	_{299,491k (± 0.02%)}	_{-42k (- 0.01%)}	_299,324k	_299,620k
_{Parse Time}	_{0.95s (± 0.59%)}	_{0.94s (± 0.50%)}	_{-0.00s (- 0.53%)}	_0.93s	_0.95s
_{Bind Time}	_{0.75s (± 0.77%)}	_{0.75s (± 0.67%)}	_{-0.00s (- 0.67%)}	_0.73s	_0.75s
_{Check Time}	_{4.25s (± 0.59%)}	_{4.24s (± 0.53%)}	_{-0.01s (- 0.19%)}	_4.20s	_4.29s
_{Emit Time}	_{3.04s (± 0.62%)}	_{3.05s (± 0.63%)}	_{+0.01s (+ 0.33%)}	_3.01s	_3.10s
_{Total Time}	_{8.99s (± 0.40%)}	_{8.98s (± 0.31%)}	_{-0.01s (- 0.06%)}	_8.93s	_9.04s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{489,098k (± 0.01%)}	_{488,879k (± 0.02%)}	_{-219k (- 0.04%)}	_488,583k	_489,012k
_{Parse Time}	_{1.78s (± 0.50%)}	_{1.78s (± 0.38%)}	_{-0.00s (- 0.06%)}	_1.76s	_1.79s
_{Bind Time}	_{0.69s (± 0.53%)}	_{0.68s (± 1.09%)}	_{-0.00s (- 0.44%)}	_0.66s	_0.70s
_{Check Time}	_{13.51s (± 0.82%)}	_{13.63s (± 0.75%)}	_{+0.12s (+ 0.90%)}	_13.45s	_13.87s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.98s (± 0.71%)}	_{16.09s (± 0.65%)}	_{+0.12s (+ 0.73%)}	_15.89s	_16.34s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{310,183k (± 0.03%)}	_{309,652k (± 0.06%)}	_{-531k (- 0.17%)}	_308,971k	_309,967k
_{Parse Time}	_{1.58s (± 0.42%)}	_{1.58s (± 0.87%)}	_{-0.00s (- 0.00%)}	_1.55s	_1.60s
_{Bind Time}	_{0.87s (± 0.81%)}	_{0.87s (± 1.04%)}	_{+0.00s (+ 0.23%)}	_0.85s	_0.89s
_{Check Time}	_{4.62s (± 0.52%)}	_{4.63s (± 0.92%)}	_{+0.01s (+ 0.26%)}	_4.57s	_4.78s
_{Emit Time}	_{5.50s (± 1.59%)}	_{5.46s (± 0.95%)}	_{-0.04s (- 0.75%)}	_5.38s	_5.62s
_{Total Time}	_{12.57s (± 0.71%)}	_{12.54s (± 0.63%)}	_{-0.03s (- 0.22%)}	_12.38s	_12.77s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{315,221k (± 0.02%)}	_{315,262k (± 0.02%)}	_{+41k (+ 0.01%)}	_315,054k	_315,361k
_{Parse Time}	_{1.21s (± 0.62%)}	_{1.21s (± 0.87%)}	_{-0.00s (- 0.08%)}	_1.19s	_1.23s
_{Bind Time}	_{0.74s (± 0.90%)}	_{0.74s (± 0.75%)}	_{-0.01s (- 0.67%)}	_0.73s	_0.75s
_{Check Time}	_{4.55s (± 0.55%)}	_{4.56s (± 0.68%)}	_{+0.02s (+ 0.35%)}	_4.47s	_4.64s
_{Emit Time}	_{2.95s (± 1.09%)}	_{2.95s (± 0.66%)}	_{+0.01s (+ 0.20%)}	_2.92s	_3.00s
_{Total Time}	_{9.45s (± 0.47%)}	_{9.47s (± 0.49%)}	_{+0.02s (+ 0.17%)}	_9.32s	_9.56s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{281,810k (± 0.03%)}	_{281,743k (± 0.02%)}	_{-67k (- 0.02%)}	_281,571k	_281,869k
_{Parse Time}	_{0.93s (± 0.89%)}	_{0.93s (± 0.48%)}	_{-0.01s (- 0.64%)}	_0.92s	_0.94s
_{Bind Time}	_{0.70s (± 1.16%)}	_{0.71s (± 0.52%)}	_{+0.00s (+ 0.43%)}	_0.70s	_0.71s
_{Check Time}	_{4.19s (± 0.59%)}	_{4.19s (± 0.44%)}	_{-0.00s (- 0.02%)}	_4.16s	_4.24s
_{Emit Time}	_{3.08s (± 0.80%)}	_{3.08s (± 0.68%)}	_{0.00s ( 0.00%)}	_3.04s	_3.13s
_{Total Time}	_{8.90s (± 0.62%)}	_{8.90s (± 0.28%)}	_{-0.00s (- 0.00%)}	_8.84s	_8.95s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{466,467k (± 0.01%)}	_{466,106k (± 0.06%)}	_{-361k (- 0.08%)}	_465,372k	_466,451k
_{Parse Time}	_{1.76s (± 0.53%)}	_{1.76s (± 0.63%)}	_{+0.00s (+ 0.06%)}	_1.74s	_1.79s
_{Bind Time}	_{0.63s (± 1.11%)}	_{0.62s (± 1.17%)}	_{-0.01s (- 1.11%)}	_0.61s	_0.64s
_{Check Time}	_{12.06s (± 0.76%)}	_{12.12s (± 0.80%)}	_{+0.06s (+ 0.51%)}	_11.96s	_12.35s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.45s (± 0.67%)}	_{14.51s (± 0.70%)}	_{+0.06s (+ 0.38%)}	_14.34s	_14.75s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{329,420k (± 0.02%)}	_{329,059k (± 0.01%)}	_{-361k (- 0.11%)}	_328,991k	_329,170k
_{Parse Time}	_{2.11s (± 0.26%)}	_{2.11s (± 0.42%)}	_{-0.00s (- 0.09%)}	_2.09s	_2.13s
_{Bind Time}	_{0.92s (± 0.76%)}	_{0.92s (± 0.94%)}	_{+0.00s (+ 0.33%)}	_0.90s	_0.94s
_{Check Time}	_{5.47s (± 0.49%)}	_{5.55s (± 0.66%)}	_{+0.08s (+ 1.46%)}	_5.50s	_5.65s
_{Emit Time}	_{6.21s (± 0.69%)}	_{6.28s (± 1.37%)}	_{+0.07s (+ 1.18%)}	_6.01s	_6.43s
_{Total Time}	_{14.72s (± 0.37%)}	_{14.87s (± 0.45%)}	_{+0.15s (+ 1.04%)}	_14.73s	_15.02s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{333,603k (± 0.01%)}	_{333,609k (± 0.02%)}	_{+6k (+ 0.00%)}	_333,460k	_333,755k
_{Parse Time}	_{1.54s (± 0.40%)}	_{1.54s (± 0.54%)}	_{+0.01s (+ 0.39%)}	_1.53s	_1.57s
_{Bind Time}	_{0.91s (± 1.00%)}	_{0.91s (± 1.34%)}	_{-0.00s (- 0.44%)}	_0.89s	_0.94s
_{Check Time}	_{5.40s (± 0.48%)}	_{5.40s (± 0.38%)}	_{-0.01s (- 0.11%)}	_5.35s	_5.45s
_{Emit Time}	_{3.52s (± 0.50%)}	_{3.52s (± 0.29%)}	_{-0.00s (- 0.06%)}	_3.50s	_3.55s
_{Total Time}	_{11.37s (± 0.35%)}	_{11.37s (± 0.16%)}	_{-0.01s (- 0.05%)}	_11.33s	_11.43s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{298,929k (± 0.01%)}	_{298,947k (± 0.02%)}	_{+19k (+ 0.01%)}	_298,853k	_299,036k
_{Parse Time}	_{1.25s (± 0.49%)}	_{1.25s (± 0.49%)}	_{0.00s ( 0.00%)}	_1.24s	_1.26s
_{Bind Time}	_{0.75s (± 0.90%)}	_{0.75s (± 0.74%)}	_{-0.00s (- 0.27%)}	_0.74s	_0.76s
_{Check Time}	_{4.91s (± 1.83%)}	_{4.85s (± 1.72%)}	_{-0.06s (- 1.18%)}	_4.73s	_5.13s
_{Emit Time}	_{3.28s (± 2.78%)}	_{3.34s (± 2.28%)}	_{+0.06s (+ 1.83%)}	_3.07s	_3.48s
_{Total Time}	_{10.19s (± 0.36%)}	_{10.20s (± 0.50%)}	_{+0.01s (+ 0.08%)}	_10.10s	_10.31s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{494,854k (± 0.01%)}	_{494,823k (± 0.01%)}	_{-31k (- 0.01%)}	_494,718k	_494,936k
_{Parse Time}	_{2.10s (± 0.35%)}	_{2.12s (± 1.10%)}	_{+0.01s (+ 0.67%)}	_2.08s	_2.20s
_{Bind Time}	_{0.81s (± 0.83%)}	_{0.81s (± 0.99%)}	_{+0.00s (+ 0.12%)}	_0.79s	_0.82s
_{Check Time}	_{19.50s (± 0.81%)}	_{19.66s (± 0.74%)}	_{+0.16s (+ 0.82%)}	_19.27s	_19.95s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.40s (± 0.74%)}	_{22.58s (± 0.71%)}	_{+0.17s (+ 0.77%)}	_22.19s	_22.89s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{188,980k (± 0.02%)}	_{188,745k (± 0.03%)}	_{-235k (- 0.12%)}	_188,593k	_188,855k
_{Parse Time}	_{2.06s (± 0.50%)}	_{2.05s (± 0.63%)}	_{-0.01s (- 0.58%)}	_2.02s	_2.08s
_{Bind Time}	_{1.08s (± 0.64%)}	_{1.07s (± 1.03%)}	_{-0.00s (- 0.47%)}	_1.06s	_1.11s
_{Check Time}	_{5.04s (± 0.55%)}	_{5.04s (± 0.56%)}	_{+0.00s (+ 0.06%)}	_5.00s	_5.12s
_{Emit Time}	_{6.17s (± 0.89%)}	_{6.11s (± 0.41%)}	_{-0.05s (- 0.86%)}	_6.07s	_6.20s
_{Total Time}	_{14.35s (± 0.49%)}	_{14.28s (± 0.41%)}	_{-0.07s (- 0.49%)}	_14.19s	_14.49s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{189,247k (± 0.01%)}	_{189,250k (± 0.03%)}	_{+3k (+ 0.00%)}	_189,073k	_189,313k
_{Parse Time}	_{1.59s (± 0.92%)}	_{1.59s (± 0.51%)}	_{-0.00s (- 0.13%)}	_1.57s	_1.60s
_{Bind Time}	_{0.76s (± 0.68%)}	_{0.77s (± 1.52%)}	_{+0.01s (+ 1.31%)}	_0.76s	_0.81s
_{Check Time}	_{5.30s (± 1.62%)}	_{5.22s (± 1.15%)}	_{-0.07s (- 1.40%)}	_5.13s	_5.39s
_{Emit Time}	_{3.05s (± 3.43%)}	_{3.14s (± 2.79%)}	_{+0.09s (+ 2.85%)}	_2.84s	_3.28s
_{Total Time}	_{10.70s (± 0.37%)}	_{10.72s (± 0.55%)}	_{+0.02s (+ 0.16%)}	_10.59s	_10.90s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{170,470k (± 0.02%)}	_{170,463k (± 0.02%)}	_{-7k (- 0.00%)}	_170,370k	_170,553k
_{Parse Time}	_{1.29s (± 1.40%)}	_{1.28s (± 0.39%)}	_{-0.01s (- 0.70%)}	_1.27s	_1.29s
_{Bind Time}	_{0.71s (± 0.56%)}	_{0.71s (± 0.48%)}	_{+0.00s (+ 0.56%)}	_0.71s	_0.72s
_{Check Time}	_{4.58s (± 0.57%)}	_{4.62s (± 0.57%)}	_{+0.04s (+ 0.90%)}	_4.55s	_4.67s
_{Emit Time}	_{3.01s (± 2.38%)}	_{2.95s (± 1.05%)}	_{-0.06s (- 1.86%)}	_2.89s	_3.01s
_{Total Time}	_{9.58s (± 0.91%)}	_{9.57s (± 0.48%)}	_{-0.02s (- 0.19%)}	_9.47s	_9.66s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{277,292k (± 0.01%)}	_{277,231k (± 0.01%)}	_{-61k (- 0.02%)}	_277,139k	_277,331k
_{Parse Time}	_{2.18s (± 0.61%)}	_{2.17s (± 0.39%)}	_{-0.01s (- 0.50%)}	_2.15s	_2.19s
_{Bind Time}	_{0.68s (± 0.91%)}	_{0.69s (± 1.70%)}	_{+0.01s (+ 1.17%)}	_0.66s	_0.71s
_{Check Time}	_{17.67s (± 0.71%)}	_{17.58s (± 0.52%)}	_{-0.09s (- 0.50%)}	_17.43s	_17.84s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{20.54s (± 0.62%)}	_{20.44s (± 0.47%)}	_{-0.09s (- 0.46%)}	_20.28s	_20.72s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₁₀₂₉	₁₀
_Baseline	_master	₁₀

Nathan Shively-Sanders (sandersn) · 2020-03-12T23:13:58Z

Anders Hejlsberg (@ahejlsberg) unfortunately, this now needs another merge from master

Nathan Shively-Sanders (sandersn) · 2020-03-17T20:41:35Z

In the design meeting, we decided to see whether it makes sense to put this under strictFunctionTypes, or some other strict flag -- possibly a new one.

Nathan Shively-Sanders (sandersn) · 2020-10-20T22:10:41Z

Anders Hejlsberg (@ahejlsberg) Is it worthwhile to keep working on this fix? It's been inactive for 6 months now.

Nathan Shively-Sanders (sandersn) · 2021-03-11T15:12:05Z

This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable.

Anders Hejlsberg (ahejlsberg) added 5 commits April 18, 2019 17:00

Use getBaseSignature when relating instantiations of the same signature
02b861e

Accept new baselines
bd80641

Add tests
fda21f1

Accept new baselines
34feb07

Fix lint error
78f54c5

Improve checking of instantiations of same signature
df50477

Fix bivariant checking of signatures returning type predicates
39c263b

Merge branch 'master' into fixGenericSignatureRelation
c2b79df

This comment has been minimized.
Sign in to view

Daniel Rosenwasser (DanielRosenwasser) added this to the TypeScript 3.6.1 milestone Jul 19, 2019

Wesley Wigham (weswigham) mentioned this pull request Sep 11, 2019
how generic type and type inference works changed #33278
Closed

This was referenced Sep 23, 2019
Assigning incompatible types does not raise an error #33551
Closed
Generic type param used as generic type constraint causes variance issues? #33561
Closed

Ryan Cavanaugh (RyanCavanaugh) modified the milestones: TypeScript 3.6.1, TypeScript 3.7.0, Backlog Sep 25, 2019

Nathan Shively-Sanders (sandersn) added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 1, 2020

Anders Hejlsberg (ahejlsberg) added 2 commits March 5, 2020 17:31

Merge branch 'master' into fixGenericSignatureRelation
27a80c1
# Conflicts: # src/compiler/checker.ts # tests/baselines/reference/keyofAndIndexedAccess2.errors.txt # tests/baselines/reference/keyofAndIndexedAccess2.symbols

Accept new baselines
e262f49

Nathan Shively-Sanders (sandersn) approved these changes Mar 11, 2020
View reviewed changes

Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser) and Ryan Cavanaugh (RyanCavanaugh)March 13, 2020 18:10

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Mar 13, 2020
Design Meeting Notes, 3/13/2020 #37389
Closed

Wesley Wigham (weswigham) mentioned this pull request Jun 24, 2020
Erase type parameters to a type which behaves as never in a union and unknown in an intersection or any otherwise #39217
Closed

Wesley Wigham (weswigham) mentioned this pull request Oct 22, 2020
Contravariance broke in 3.8 when combining spreading parameter list with conditional type #37400
Closed

Nathan Shively-Sanders (sandersn) closed this Mar 11, 2021

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025

Uh oh!

Conversation

Anders Hejlsberg (ahejlsberg) commented Apr 19, 2019

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 19, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 19, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 19, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 19, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) commented Apr 19, 2019

Uh oh!

Jack Williams (jack-williams) commented Apr 19, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 21, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 21, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 21, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 21, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 21, 2019

Uh oh!

Wesley Wigham (weswigham) commented Apr 22, 2019

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Apr 22, 2019

Uh oh!

Nathan Shively-Sanders (sandersn) commented Apr 22, 2019

Uh oh!

This comment has been minimized.

Wesley Wigham (weswigham) commented Apr 24, 2019

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Apr 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 26, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 26, 2020

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 7, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 7, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 12, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 17, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Oct 20, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 11, 2021

TypeScript Bot (typescript-bot) commented Apr 19, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 19, 2019•
edited
Loading

Jack Williams (jack-williams) commented Apr 19, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 21, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 21, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 21, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 21, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 24, 2019•
edited
Loading

Nathan Shively-Sanders (sandersn) commented Apr 24, 2019•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 7, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 7, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 7, 2020•
edited
Loading