Skip to content

Improved parameter names for call signatures resulting from unions - #32056

Merged
Wesley Wigham (weswigham) merged 1 commit into
microsoft:masterfrom
dragomirtitian:GH-31845-Improve-tooltip-for-functions
Jul 11, 2019
Merged

Improved parameter names for call signatures resulting from unions#32056
Wesley Wigham (weswigham) merged 1 commit into
microsoft:masterfrom
dragomirtitian:GH-31845-Improve-tooltip-for-functions

Conversation

@dragomirtitian

@dragomirtitianTitian Cernicova-Dragomir (dragomirtitian) commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

Fixes#31845

@fatcerberus

Bruce Pascoe (fatcerberus) commented Jun 24, 2019

Copy link
Copy Markdown

calledUnionsOfDissimilarTyeshaveGoodDisplay.ts

I chuckled a bit at this filename, not sure why.

@dragomirtitian

Titian Cernicova-Dragomir (dragomirtitian) commented Jun 24, 2019

Copy link
Copy Markdown
ContributorAuthor

Bruce Pascoe (@fatcerberus) It was there when I started, it amused me too 😄

@dragomirtitian

Titian Cernicova-Dragomir (dragomirtitian) commented Jul 11, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Wesley Wigham (@weswigham) Any thought on this PR since it touches your code ? The issue was that if the methods had different parameter length combineUnionParameters would end up calling getParameterNameAtPosition with an invalid parameter index. getParameterNameAtPosition would just return the string 'unknown' in this case and since this was different from the name in the longer function it would fall back to `arg${i}`.

The fix was to use the name of the parameter in the function with more parameters.

weswigham
Wesley Wigham (weswigham) approved these changes Jul 11, 2019
View reviewed changes

@weswighamWesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement to me ❤️

@weswigham
Wesley Wigham (weswigham) merged commit d2c9d6c into microsoft:masterJul 11, 2019
@weswighamWesley Wigham (weswigham) mentioned this pull request Feb 9, 2021
Merged
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswighamWesley Wigham (weswigham)weswigham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IntelliSense shows incorrect parameter names (TypeScript)

3 participants

@dragomirtitian@fatcerberus@weswigham