Make lower priority inference when source is completely matched in target

[Anders Hejlsberg (ahejlsberg)]

Fixes#33131.

[Wesley Wigham (weswigham)]

👍

[Wesley Wigham (weswigham)]

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) pack this for our more ravenous users :V

[TypeScript Bot (typescript-bot)]

Heya Wesley Wigham (@weswigham), I've started to run the tarball bundle task on this PR at 5de180e. You can monitor the build here. It should now contribute to this PR's status checks.

[TypeScript Bot (typescript-bot)]

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at 5de180e. You can monitor the build here. It should now contribute to this PR's status checks.

[TypeScript Bot (typescript-bot)]

Heya Wesley Wigham (@weswigham), I've started to run the parallelized community code test suite on this PR at 5de180e. You can monitor the build here. It should now contribute to this PR's status checks.

[Wesley Wigham (weswigham)]

TypeScript Bot (@typescript-bot) test this because "tets this" isn't a command

[TypeScript Bot (typescript-bot)]

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at 5de180e. You can monitor the build here. It should now contribute to this PR's status checks.

[Anders Hejlsberg (ahejlsberg)]

TypeScript Bot (@typescript-bot) perf test this

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the perf test suite on this PR at 5de180e. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Hey Wesley Wigham (@weswigham), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/42865/artifacts?artifactName=tgz&fileId=B4D2DA4BFA4D7649E338946AF0D126AFA9B454E084859514E0EBE4A87EDA3F8802&fileName=/typescript-3.7.0-insiders.20190905.tgz"
}
}

and then running npm install.

[TypeScript Bot (typescript-bot)]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[Wesley Wigham (weswigham)]

Ack, a single lint failure. The user baselines look ok, though.

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..33252

Metric	master	33252	Delta	Best	Worst
Angular - node (v12.1.0, x64)
Memory used	325,572k (± 0.01%)	325,851k (± 0.01%)	+279k (+ 0.09%)	325,756k	325,952k
Parse Time	1.59s (± 0.52%)	1.59s (± 1.00%)	-0.00s (- 0.25%)	1.56s	1.63s
Bind Time	0.83s (± 0.99%)	0.82s (± 1.20%)	-0.01s (- 1.09%)	0.79s	0.84s
Check Time	4.50s (± 0.67%)	4.46s (± 0.54%)	-0.04s (- 0.84%)	4.41s	4.52s
Emit Time	5.62s (± 0.91%)	5.60s (± 0.51%)	-0.02s (- 0.28%)	5.55s	5.67s
Total Time	12.54s (± 0.61%)	12.47s (± 0.48%)	-0.07s (- 0.54%)	12.35s	12.59s
Monaco - node (v12.1.0, x64)
Memory used	345,948k (± 0.02%)	345,921k (± 0.01%)	-27k (- 0.01%)	345,805k	346,006k
Parse Time	1.31s (± 0.52%)	1.31s (± 0.63%)	0.00s ( 0.00%)	1.29s	1.33s
Bind Time	0.72s (± 1.15%)	0.72s (± 0.94%)	-0.00s (- 0.00%)	0.71s	0.74s
Check Time	4.53s (± 0.28%)	4.51s (± 0.52%)	-0.02s (- 0.35%)	4.48s	4.58s
Emit Time	3.03s (± 0.78%)	3.03s (± 0.81%)	0.00s ( 0.00%)	2.98s	3.08s
Total Time	9.60s (± 0.19%)	9.59s (± 0.48%)	-0.02s (- 0.17%)	9.50s	9.70s
TFS - node (v12.1.0, x64)
Memory used	301,355k (± 0.02%)	301,407k (± 0.02%)	+52k (+ 0.02%)	301,209k	301,510k
Parse Time	1.03s (± 0.91%)	1.03s (± 0.54%)	+0.00s (+ 0.19%)	1.02s	1.04s
Bind Time	0.67s (± 0.78%)	0.67s (± 0.67%)	-0.00s (- 0.15%)	0.66s	0.68s
Check Time	4.11s (± 1.04%)	4.11s (± 0.88%)	0.00s ( 0.00%)	4.04s	4.20s
Emit Time	3.12s (± 0.78%)	3.10s (± 1.01%)	-0.02s (- 0.55%)	3.04s	3.15s
Total Time	8.93s (± 0.70%)	8.91s (± 0.64%)	-0.02s (- 0.19%)	8.78s	9.04s
Angular - node (v8.9.0, x64)
Memory used	344,227k (± 0.02%)	344,512k (± 0.02%)	+284k (+ 0.08%)	344,408k	344,656k
Parse Time	2.08s (± 0.60%)	2.07s (± 0.33%)	-0.00s (- 0.10%)	2.06s	2.09s
Bind Time	0.86s (± 0.55%)	0.86s (± 1.22%)	+0.00s (+ 0.35%)	0.84s	0.88s
Check Time	5.33s (± 0.80%)	5.33s (± 0.69%)	+0.01s (+ 0.11%)	5.26s	5.41s
Emit Time	6.40s (± 1.92%)	6.47s (± 0.63%)	+0.07s (+ 1.13%)	6.37s	6.55s
Total Time	14.66s (± 0.93%)	14.74s (± 0.39%)	+0.08s (+ 0.55%)	14.60s	14.86s
Monaco - node (v8.9.0, x64)
Memory used	363,669k (± 0.02%)	363,743k (± 0.01%)	+75k (+ 0.02%)	363,670k	363,862k
Parse Time	1.62s (± 0.71%)	1.62s (± 0.45%)	+0.00s (+ 0.25%)	1.61s	1.64s
Bind Time	0.93s (± 0.75%)	0.93s (± 1.32%)	+0.00s (+ 0.11%)	0.91s	0.96s
Check Time	5.39s (± 1.07%)	5.40s (± 0.86%)	+0.01s (+ 0.20%)	5.26s	5.48s
Emit Time	3.46s (± 3.21%)	3.50s (± 2.64%)	+0.04s (+ 1.10%)	3.13s	3.60s
Total Time	11.39s (± 0.60%)	11.45s (± 0.94%)	+0.05s (+ 0.47%)	11.10s	11.63s
TFS - node (v8.9.0, x64)
Memory used	317,703k (± 0.02%)	317,689k (± 0.01%)	-14k (- 0.00%)	317,609k	317,784k
Parse Time	1.30s (± 0.63%)	1.30s (± 0.68%)	+0.00s (+ 0.08%)	1.29s	1.33s
Bind Time	0.82s (± 4.09%)	0.79s (± 5.60%)	-0.03s (- 3.90%)	0.70s	0.86s
Check Time	4.63s (± 1.02%)	4.67s (± 1.58%)	+0.05s (+ 0.99%)	4.53s	4.82s
Emit Time	3.26s (± 0.65%)	3.24s (± 0.67%)	-0.02s (- 0.58%)	3.18s	3.29s
Total Time	10.01s (± 0.39%)	10.01s (± 0.41%)	-0.01s (- 0.06%)	9.91s	10.08s
Angular - node (v8.9.0, x86)
Memory used	195,004k (± 0.01%)	195,123k (± 0.03%)	+119k (+ 0.06%)	194,985k	195,270k
Parse Time	2.01s (± 0.72%)	2.00s (± 0.34%)	-0.01s (- 0.40%)	1.99s	2.02s
Bind Time	0.99s (± 0.45%)	0.99s (± 0.67%)	+0.00s (+ 0.20%)	0.98s	1.01s
Check Time	4.86s (± 0.74%)	4.84s (± 0.54%)	-0.02s (- 0.39%)	4.78s	4.92s
Emit Time	6.17s (± 0.58%)	6.15s (± 0.48%)	-0.03s (- 0.44%)	6.09s	6.21s
Total Time	14.03s (± 0.48%)	13.98s (± 0.30%)	-0.05s (- 0.35%)	13.90s	14.09s
Monaco - node (v8.9.0, x86)
Memory used	203,226k (± 0.02%)	203,180k (± 0.02%)	-46k (- 0.02%)	203,047k	203,244k
Parse Time	1.68s (± 0.72%)	1.68s (± 0.63%)	+0.01s (+ 0.54%)	1.67s	1.71s
Bind Time	0.75s (± 0.63%)	0.75s (± 1.00%)	+0.00s (+ 0.13%)	0.74s	0.77s
Check Time	5.17s (± 0.46%)	5.14s (± 0.43%)	-0.03s (- 0.48%)	5.10s	5.21s
Emit Time	3.35s (± 0.57%)	3.37s (± 1.25%)	+0.02s (+ 0.48%)	3.32s	3.52s
Total Time	10.95s (± 0.30%)	10.95s (± 0.41%)	-0.00s (- 0.03%)	10.89s	11.10s
TFS - node (v8.9.0, x86)
Memory used	178,545k (± 0.01%)	178,511k (± 0.02%)	-35k (- 0.02%)	178,465k	178,636k
Parse Time	1.37s (± 0.84%)	1.37s (± 0.74%)	-0.00s (- 0.29%)	1.35s	1.39s
Bind Time	0.67s (± 0.71%)	0.67s (± 1.20%)	+0.00s (+ 0.15%)	0.65s	0.69s
Check Time	4.54s (± 1.05%)	4.51s (± 0.36%)	-0.02s (- 0.53%)	4.48s	4.55s
Emit Time	3.04s (± 1.12%)	3.00s (± 0.80%)	-0.05s (- 1.48%)	2.95s	3.07s
Total Time	9.62s (± 0.90%)	9.54s (± 0.27%)	-0.08s (- 0.81%)	9.50s	9.62s
Angular - node (v9.0.0, x64)
Memory used	343,848k (± 0.02%)	344,142k (± 0.01%)	+294k (+ 0.09%)	344,047k	344,237k
Parse Time	1.80s (± 0.71%)	1.80s (± 0.44%)	-0.00s (- 0.06%)	1.78s	1.82s
Bind Time	0.82s (± 1.11%)	0.82s (± 0.89%)	-0.00s (- 0.12%)	0.80s	0.83s
Check Time	5.12s (± 0.84%)	5.08s (± 0.95%)	-0.03s (- 0.63%)	5.00s	5.22s
Emit Time	6.14s (± 1.49%)	6.10s (± 1.59%)	-0.03s (- 0.55%)	5.86s	6.30s
Total Time	13.88s (± 0.61%)	13.81s (± 0.81%)	-0.06s (- 0.47%)	13.55s	14.04s
Monaco - node (v9.0.0, x64)
Memory used	363,388k (± 0.01%)	363,438k (± 0.01%)	+50k (+ 0.01%)	363,347k	363,545k
Parse Time	1.39s (± 0.42%)	1.38s (± 0.63%)	-0.00s (- 0.36%)	1.37s	1.41s
Bind Time	0.87s (± 0.77%)	0.87s (± 1.23%)	+0.00s (+ 0.46%)	0.86s	0.91s
Check Time	5.46s (± 0.35%)	5.48s (± 0.66%)	+0.02s (+ 0.35%)	5.40s	5.56s
Emit Time	3.06s (± 0.72%)	3.06s (± 1.11%)	0.00s ( 0.00%)	3.03s	3.16s
Total Time	10.78s (± 0.33%)	10.80s (± 0.71%)	+0.02s (+ 0.19%)	10.68s	11.03s
TFS - node (v9.0.0, x64)
Memory used	317,431k (± 0.01%)	317,439k (± 0.01%)	+8k (+ 0.00%)	317,357k	317,511k
Parse Time	1.10s (± 1.13%)	1.09s (± 0.41%)	-0.01s (- 1.09%)	1.08s	1.10s
Bind Time	0.66s (± 0.67%)	0.66s (± 0.67%)	0.00s ( 0.00%)	0.65s	0.67s
Check Time	4.68s (± 0.74%)	4.68s (± 0.66%)	-0.01s (- 0.17%)	4.61s	4.76s
Emit Time	3.41s (± 1.14%)	3.35s (± 1.76%)	-0.06s (- 1.67%)	3.15s	3.42s
Total Time	9.86s (± 0.68%)	9.78s (± 0.79%)	-0.08s (- 0.78%)	9.53s	9.94s
Angular - node (v9.0.0, x86)
Memory used	195,113k (± 0.02%)	195,270k (± 0.02%)	+158k (+ 0.08%)	195,185k	195,340k
Parse Time	1.74s (± 0.90%)	1.73s (± 1.06%)	-0.01s (- 0.29%)	1.70s	1.78s
Bind Time	0.95s (± 1.26%)	0.95s (± 1.07%)	-0.00s (- 0.53%)	0.92s	0.97s
Check Time	4.54s (± 0.50%)	4.56s (± 0.86%)	+0.01s (+ 0.33%)	4.50s	4.65s
Emit Time	5.90s (± 0.76%)	5.89s (± 0.80%)	-0.01s (- 0.22%)	5.79s	6.00s
Total Time	13.13s (± 0.52%)	13.12s (± 0.70%)	-0.01s (- 0.05%)	12.97s	13.38s
Monaco - node (v9.0.0, x86)
Memory used	203,240k (± 0.02%)	203,265k (± 0.02%)	+25k (+ 0.01%)	203,144k	203,339k
Parse Time	1.43s (± 0.93%)	1.43s (± 0.59%)	-0.00s (- 0.28%)	1.41s	1.45s
Bind Time	0.69s (± 1.13%)	0.69s (± 0.50%)	-0.00s (- 0.29%)	0.68s	0.69s
Check Time	5.00s (± 0.60%)	5.01s (± 0.50%)	+0.01s (+ 0.16%)	4.96s	5.08s
Emit Time	3.28s (± 0.61%)	3.27s (± 0.73%)	-0.01s (- 0.46%)	3.21s	3.34s
Total Time	10.41s (± 0.43%)	10.39s (± 0.35%)	-0.02s (- 0.20%)	10.33s	10.47s
TFS - node (v9.0.0, x86)
Memory used	178,566k (± 0.02%)	178,600k (± 0.02%)	+34k (+ 0.02%)	178,481k	178,677k
Parse Time	1.14s (± 0.99%)	1.13s (± 0.60%)	-0.01s (- 0.44%)	1.11s	1.14s
Bind Time	0.61s (± 0.78%)	0.61s (± 0.56%)	0.00s ( 0.00%)	0.61s	0.62s
Check Time	4.40s (± 0.54%)	4.41s (± 0.90%)	+0.00s (+ 0.11%)	4.34s	4.49s
Emit Time	2.93s (± 0.72%)	2.93s (± 0.64%)	-0.00s (- 0.03%)	2.90s	2.98s
Total Time	9.08s (± 0.42%)	9.08s (± 0.52%)	0.00s ( 0.00%)	8.99s	9.17s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-161-generic
Architecture	x64
Available Memory	16 GB
Available Memory	13 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)
• node (v9.0.0, x64)
• node (v9.0.0, x86)

Scenarios

• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Angular - node (v9.0.0, x64)
• Angular - node (v9.0.0, x86)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• Monaco - node (v9.0.0, x64)
• Monaco - node (v9.0.0, x86)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)
• TFS - node (v9.0.0, x64)
• TFS - node (v9.0.0, x86)

Benchmark	Name	Iterations
Current	33252	10
Baseline	master	10

[Bruce Pascoe (fatcerberus)]

pack this for our more ravenous users :V

🐽

[Eric Anderson (ericanderson)]

TypeScript Bot (@typescript-bot) cherry-pick this into release-3.6

[Nathan Shively-Sanders (sandersn)]

sudo TypeScript Bot (@typescript-bot) cherry-pick this into release-3.6

[Nathan Shively-Sanders (sandersn)]

(Thanks for the attempt Eric Anderson (@ericanderson), but typescript-bot has a hardcoded list of people it listens to.)

[Nathan Shively-Sanders (sandersn)]

TypeScript Bot (@typescript-bot) cherry-pick this into release-3.6

[Nathan Shively-Sanders (sandersn)]

TypeScript Bot (@typescript-bot) cherry-pick this to release-3.6

[TypeScript Bot (typescript-bot)]

Hey Nathan Shively-Sanders (@sandersn), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.6 manually.

[Nathan Shively-Sanders (sandersn)]

Whew! TypeScript Bot (@typescript-bot), I thought you were dead!

(Hooray for bad natural language parsers.)

[TypeScript Bot (typescript-bot)]

Hey Nathan Shively-Sanders (@sandersn), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.6 manually.

[TypeScript Bot (typescript-bot)]

Hey Nathan Shively-Sanders (@sandersn), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.6 manually.

[Nathan Shively-Sanders (sandersn)]

Fine, I cherry-picked it myself, TypeScript Bot (@typescript-bot). It's in release-3.6 now.

[Bruce Pascoe (fatcerberus)]

typescript-bot seems to be glitchy lately. Delayed reactions to commands, not closing issues it claims to have closed, etc.