Uh oh!
There was an error while loading. Please reload this page.
Fix incorrect parameter types for AsyncIterator next/return - #33354
Merged
Conversation
Brian Kim 김남제 (brainkim)
left a comment
There was a problem hiding this comment.
Added a little note based on looking at the spec. Thanks for working on this!
Uh oh!
There was an error while loading. Please reload this page.
Ron Buckton (rbuckton)force-pushed
the
fix33239
branch
from
September 10, 2019 20:03
06bcf01 to
5d9f956CompareBrian Kim 김남제 (brainkim)
approved these changes
Sep 10, 2019
Member
Can you add the original code from the issue as a test? |
Ron Buckton (rbuckton)force-pushed
the
fix33239
branch
from
September 10, 2019 21:09
5d9f956 to
83ed0c6CompareRon Buckton (rbuckton)force-pushed
the
fix33239
branch
from
September 10, 2019 21:14
83ed0c6 to
b800013CompareRon Buckton (rbuckton)
commented
Sep 10, 2019
ContributorAuthor
cc: Wesley Wigham (@weswigham) can you review? suggested reviewers is broken because I changed checker.ts. |
Ron Buckton (rbuckton)
commented
Sep 10, 2019
ContributorAuthor
Daniel Rosenwasser (@DanielRosenwasser): I added a test for the original issue and also to verify the correct inferred type for the result of |
Wesley Wigham (weswigham)
approved these changes
Sep 10, 2019
Member
Ryan Cavanaugh (@RyanCavanaugh) mentioned that this would be suitable for a 3.6.4. Let's chat on Monday on whether that's the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#33239