Switch to ES Map/Set internally by rbuckton · Pull Request #33771 · microsoft/TypeScript

rbuckton · 2019-10-02T23:09:32Z

Currently leaving this as a Draft PR for discussion. This improves our Map shim to support non-string keys, and adds a shim for Set so that we might consider using it in the compiler as well.

These shims exist for a vanishingly rare corner case of TypeScript running in an environment without native implementations (at this point, primarily just IE).

rbuckton · 2020-06-19T07:10:36Z

@typescript-bot perf test
@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-06-19T07:10:39Z

Heya @rbuckton, I've started to run the parallelized community code test suite on this PR at 79eb8ee. You can monitor the build here.

typescript-bot · 2020-06-19T07:10:39Z

Heya @rbuckton, I've started to run the extended test suite on this PR at 79eb8ee. You can monitor the build here.

typescript-bot · 2020-06-19T07:10:39Z

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at 79eb8ee. You can monitor the build here.

typescript-bot · 2020-06-19T07:10:39Z

Heya @rbuckton, I've started to run the perf test suite on this PR at 79eb8ee. You can monitor the build here.

Update: The results are in!

typescript-bot · 2020-06-19T07:55:43Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..33771

_Metric	_master	₃₃₇₇₁	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{340,339k (± 0.01%)}	_{339,863k (± 0.02%)}	_{-475k (- 0.14%)}	_339,715k	_340,021k
_{Parse Time}	_{1.99s (± 0.85%)}	_{1.99s (± 0.55%)}	_{-0.00s (- 0.25%)}	_1.97s	_2.01s
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.80s (± 0.72%)}	_{-0.00s (- 0.12%)}	_0.79s	_0.81s
_{Check Time}	_{4.73s (± 0.57%)}	_{4.70s (± 0.31%)}	_{-0.03s (- 0.57%)}	_4.67s	_4.74s
_{Emit Time}	_{5.22s (± 0.80%)}	_{5.15s (± 0.61%)}	_{-0.07s (- 1.36%)}	_5.08s	_5.22s
_{Total Time}	_{12.74s (± 0.45%)}	_{12.64s (± 0.31%)}	_{-0.10s (- 0.78%)}	_12.54s	_12.69s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{338,915k (± 0.02%)}	_{338,981k (± 0.02%)}	_{+66k (+ 0.02%)}	_338,848k	_339,169k
_{Parse Time}	_{1.58s (± 0.41%)}	_{1.58s (± 0.60%)}	_{-0.00s (- 0.32%)}	_1.56s	_1.61s
_{Bind Time}	_{0.70s (± 0.83%)}	_{0.70s (± 1.04%)}	_{+0.00s (+ 0.14%)}	_0.68s	_0.71s
_{Check Time}	_{4.86s (± 0.44%)}	_{4.86s (± 0.65%)}	_{+0.00s (+ 0.02%)}	_4.78s	_4.93s
_{Emit Time}	_{2.75s (± 0.94%)}	_{2.75s (± 1.00%)}	_{+0.00s (+ 0.00%)}	_2.69s	_2.82s
_{Total Time}	_{9.89s (± 0.46%)}	_{9.88s (± 0.45%)}	_{-0.01s (- 0.07%)}	_9.81s	_9.98s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{301,939k (± 0.08%)}	_{301,897k (± 0.02%)}	_{-42k (- 0.01%)}	_301,785k	_302,051k
_{Parse Time}	_{1.21s (± 0.84%)}	_{1.21s (± 0.63%)}	_{-0.00s (- 0.41%)}	_1.18s	_1.22s
_{Bind Time}	_{0.66s (± 0.76%)}	_{0.65s (± 0.89%)}	_{-0.01s (- 0.76%)}	_0.63s	_0.66s
_{Check Time}	_{4.37s (± 0.69%)}	_{4.36s (± 0.34%)}	_{-0.01s (- 0.21%)}	_4.32s	_4.39s
_{Emit Time}	_{2.89s (± 0.99%)}	_{2.90s (± 0.79%)}	_{+0.00s (+ 0.17%)}	_2.86s	_2.97s
_{Total Time}	_{9.12s (± 0.64%)}	_{9.12s (± 0.39%)}	_{-0.01s (- 0.09%)}	_9.03s	_9.21s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{459,485k (± 0.01%)}	_{459,320k (± 0.01%)}	_{-165k (- 0.04%)}	_459,216k	_459,494k
_{Parse Time}	_{2.05s (± 0.53%)}	_{2.05s (± 0.47%)}	_{-0.00s (- 0.15%)}	_2.03s	_2.07s
_{Bind Time}	_{0.66s (± 1.63%)}	_{0.65s (± 1.28%)}	_{-0.01s (- 1.97%)}	_0.63s	_0.67s
_{Check Time}	_{12.81s (± 0.67%)}	_{12.88s (± 0.99%)}	_{+0.07s (+ 0.52%)}	_12.66s	_13.20s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.52s (± 0.54%)}	_{15.58s (± 0.83%)}	_{+0.06s (+ 0.37%)}	_15.34s	_15.87s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{317,771k (± 0.02%)}	_{317,337k (± 0.01%)}	_{-434k (- 0.14%)}	_317,253k	_317,400k
_{Parse Time}	_{1.97s (± 0.67%)}	_{1.95s (± 1.07%)}	_{-0.02s (- 0.86%)}	_1.91s	_1.99s
_{Bind Time}	_{0.78s (± 0.79%)}	_{0.78s (± 0.83%)}	_{-0.00s (- 0.13%)}	_0.77s	_0.79s
_{Check Time}	_{4.58s (± 0.61%)}	_{4.58s (± 0.42%)}	_{-0.00s (- 0.09%)}	_4.53s	_4.62s
_{Emit Time}	_{5.34s (± 0.99%)}	_{5.38s (± 1.28%)}	_{+0.04s (+ 0.71%)}	_5.25s	_5.54s
_{Total Time}	_{12.67s (± 0.64%)}	_{12.68s (± 0.76%)}	_{+0.01s (+ 0.09%)}	_12.50s	_12.95s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{321,471k (± 0.02%)}	_{321,455k (± 0.02%)}	_{-16k (- 0.01%)}	_321,349k	_321,576k
_{Parse Time}	_{1.54s (± 0.91%)}	_{1.53s (± 0.58%)}	_{-0.01s (- 0.58%)}	_1.51s	_1.55s
_{Bind Time}	_{0.67s (± 0.71%)}	_{0.67s (± 0.77%)}	_{-0.00s (- 0.30%)}	_0.66s	_0.68s
_{Check Time}	_{4.65s (± 0.59%)}	_{4.65s (± 0.51%)}	_{+0.00s (+ 0.04%)}	_4.60s	_4.70s
_{Emit Time}	_{2.79s (± 0.73%)}	_{2.81s (± 0.82%)}	_{+0.02s (+ 0.72%)}	_2.77s	_2.87s
_{Total Time}	_{9.66s (± 0.53%)}	_{9.67s (± 0.36%)}	_{+0.01s (+ 0.16%)}	_9.57s	_9.75s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{286,358k (± 0.02%)}	_{286,360k (± 0.03%)}	_{+2k (+ 0.00%)}	_286,261k	_286,697k
_{Parse Time}	_{1.23s (± 0.77%)}	_{1.22s (± 0.54%)}	_{-0.01s (- 1.13%)}	_1.21s	_1.24s
_{Bind Time}	_{0.62s (± 1.42%)}	_{0.62s (± 1.20%)}	_{-0.00s (- 0.48%)}	_0.60s	_0.64s
_{Check Time}	_{4.28s (± 0.60%)}	_{4.26s (± 0.31%)}	_{-0.02s (- 0.40%)}	_4.23s	_4.28s
_{Emit Time}	_{2.95s (± 1.63%)}	_{2.91s (± 0.97%)}	_{-0.04s (- 1.25%)}	_2.87s	_2.99s
_{Total Time}	_{9.08s (± 0.54%)}	_{9.01s (± 0.33%)}	_{-0.07s (- 0.74%)}	_8.94s	_9.09s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{437,853k (± 0.06%)}	_{437,446k (± 0.09%)}	_{-407k (- 0.09%)}	_436,451k	_437,807k
_{Parse Time}	_{2.03s (± 0.69%)}	_{2.01s (± 0.68%)}	_{-0.02s (- 0.79%)}	_1.99s	_2.05s
_{Bind Time}	_{0.64s (± 0.70%)}	_{0.63s (± 1.16%)}	_{-0.01s (- 1.57%)}	_0.62s	_0.65s
_{Check Time}	_{11.58s (± 1.08%)}	_{11.61s (± 1.26%)}	_{+0.03s (+ 0.24%)}	_11.33s	_12.00s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.26s (± 0.94%)}	_{14.25s (± 1.06%)}	_{-0.00s (- 0.01%)}	_13.97s	_14.66s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{336,820k (± 0.02%)}	_{336,482k (± 0.01%)}	_{-339k (- 0.10%)}	_336,339k	_336,547k
_{Parse Time}	_{2.49s (± 0.40%)}	_{2.49s (± 0.46%)}	_{-0.00s (- 0.04%)}	_2.46s	_2.51s
_{Bind Time}	_{0.83s (± 0.96%)}	_{0.83s (± 0.69%)}	_{-0.00s (- 0.24%)}	_0.82s	_0.84s
_{Check Time}	_{5.31s (± 0.54%)}	_{5.34s (± 0.51%)}	_{+0.04s (+ 0.66%)}	_5.26s	_5.39s
_{Emit Time}	_{5.84s (± 1.65%)}	_{5.93s (± 1.01%)}	_{+0.09s (+ 1.47%)}	_5.85s	_6.13s
_{Total Time}	_{14.48s (± 0.71%)}	_{14.60s (± 0.40%)}	_{+0.12s (+ 0.80%)}	_14.50s	_14.77s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{340,275k (± 0.02%)}	_{340,274k (± 0.01%)}	_{-1k (- 0.00%)}	_340,177k	_340,389k
_{Parse Time}	_{1.86s (± 0.43%)}	_{1.87s (± 0.64%)}	_{+0.01s (+ 0.32%)}	_1.85s	_1.91s
_{Bind Time}	_{0.87s (± 0.57%)}	_{0.86s (± 0.79%)}	_{-0.00s (- 0.23%)}	_0.85s	_0.88s
_{Check Time}	_{5.34s (± 0.63%)}	_{5.35s (± 0.46%)}	_{+0.00s (+ 0.09%)}	_5.28s	_5.40s
_{Emit Time}	_{3.23s (± 0.71%)}	_{3.21s (± 0.36%)}	_{-0.02s (- 0.56%)}	_3.18s	_3.23s
_{Total Time}	_{11.30s (± 0.43%)}	_{11.29s (± 0.32%)}	_{-0.01s (- 0.09%)}	_11.23s	_11.37s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{303,635k (± 0.02%)}	_{303,624k (± 0.02%)}	_{-11k (- 0.00%)}	_303,531k	_303,721k
_{Parse Time}	_{1.54s (± 0.84%)}	_{1.54s (± 0.54%)}	_{+0.01s (+ 0.59%)}	_1.53s	_1.56s
_{Bind Time}	_{0.65s (± 0.85%)}	_{0.65s (± 0.80%)}	_{-0.00s (- 0.15%)}	_0.64s	_0.66s
_{Check Time}	_{5.00s (± 1.74%)}	_{4.93s (± 1.55%)}	_{-0.07s (- 1.38%)}	_4.83s	_5.11s
_{Emit Time}	_{3.04s (± 2.55%)}	_{3.10s (± 3.19%)}	_{+0.05s (+ 1.77%)}	_2.84s	_3.23s
_{Total Time}	_{10.24s (± 0.33%)}	_{10.23s (± 0.52%)}	_{-0.01s (- 0.10%)}	_10.08s	_10.36s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{463,634k (± 0.01%)}	_{463,383k (± 0.01%)}	_{-251k (- 0.05%)}	_463,291k	_463,450k
_{Parse Time}	_{2.39s (± 0.60%)}	_{2.37s (± 0.49%)}	_{-0.02s (- 0.67%)}	_2.35s	_2.40s
_{Bind Time}	_{0.77s (± 1.52%)}	_{0.77s (± 1.30%)}	_{-0.00s (- 0.52%)}	_0.75s	_0.80s
_{Check Time}	_{17.12s (± 1.31%)}	_{16.91s (± 1.14%)}	_{-0.21s (- 1.20%)}	_16.42s	_17.20s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (±222.80%)}	_{🔻+0.00s (+ ∞%)}	_0.00s	_0.01s
_{Total Time}	_{20.28s (± 1.19%)}	_{20.05s (± 0.98%)}	_{-0.23s (- 1.11%)}	_19.57s	_20.36s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{193,337k (± 0.02%)}	_{193,172k (± 0.02%)}	_{-165k (- 0.09%)}	_193,074k	_193,281k
_{Parse Time}	_{2.45s (± 0.96%)}	_{2.42s (± 0.85%)}	_{-0.03s (- 1.10%)}	_2.38s	_2.48s
_{Bind Time}	_{0.98s (± 0.97%)}	_{0.97s (± 0.77%)}	_{-0.01s (- 0.92%)}	_0.95s	_0.98s
_{Check Time}	_{4.80s (± 0.57%)}	_{4.79s (± 0.63%)}	_{-0.01s (- 0.23%)}	_4.73s	_4.85s
_{Emit Time}	_{5.97s (± 1.22%)}	_{5.92s (± 1.25%)}	_{-0.05s (- 0.92%)}	_5.70s	_6.09s
_{Total Time}	_{14.20s (± 0.74%)}	_{14.10s (± 0.68%)}	_{-0.10s (- 0.74%)}	_13.83s	_14.32s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{193,279k (± 0.03%)}	_{193,295k (± 0.01%)}	_{+16k (+ 0.01%)}	_193,241k	_193,346k
_{Parse Time}	_{1.90s (± 0.63%)}	_{1.90s (± 0.82%)}	_{-0.00s (- 0.05%)}	_1.87s	_1.94s
_{Bind Time}	_{0.68s (± 0.87%)}	_{0.68s (± 0.70%)}	_{-0.00s (- 0.15%)}	_0.67s	_0.69s
_{Check Time}	_{5.44s (± 0.40%)}	_{5.44s (± 0.47%)}	_{-0.00s (- 0.02%)}	_5.39s	_5.50s
_{Emit Time}	_{2.67s (± 0.87%)}	_{2.67s (± 0.69%)}	_{-0.00s (- 0.11%)}	_2.64s	_2.73s
_{Total Time}	_{10.70s (± 0.43%)}	_{10.69s (± 0.42%)}	_{-0.00s (- 0.05%)}	_10.61s	_10.81s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{173,586k (± 0.03%)}	_{173,598k (± 0.02%)}	_{+12k (+ 0.01%)}	_173,516k	_173,659k
_{Parse Time}	_{1.58s (± 0.72%)}	_{1.57s (± 0.57%)}	_{-0.00s (- 0.25%)}	_1.56s	_1.60s
_{Bind Time}	_{0.62s (± 0.55%)}	_{0.63s (± 1.59%)}	_{+0.01s (+ 1.62%)}	_0.61s	_0.66s
_{Check Time}	_{4.66s (± 0.53%)}	_{4.65s (± 1.04%)}	_{-0.01s (- 0.15%)}	_4.55s	_4.77s
_{Emit Time}	_{2.81s (± 1.91%)}	_{2.80s (± 1.57%)}	_{-0.02s (- 0.53%)}	_2.70s	_2.90s
_{Total Time}	_{9.66s (± 0.60%)}	_{9.65s (± 0.82%)}	_{-0.02s (- 0.17%)}	_9.49s	_9.84s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{262,444k (± 0.02%)}	_{262,304k (± 0.02%)}	_{-140k (- 0.05%)}	_262,208k	_262,415k
_{Parse Time}	_{2.44s (± 0.70%)}	_{2.45s (± 0.73%)}	_{+0.00s (+ 0.04%)}	_2.41s	_2.49s
_{Bind Time}	_{0.67s (± 1.59%)}	_{0.66s (± 1.40%)}	_{-0.00s (- 0.60%)}	_0.65s	_0.69s
_{Check Time}	_{15.55s (± 0.49%)}	_{15.48s (± 0.70%)}	_{-0.07s (- 0.44%)}	_15.30s	_15.81s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{18.67s (± 0.43%)}	_{18.60s (± 0.52%)}	_{-0.07s (- 0.37%)}	_18.44s	_18.88s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₃₇₇₁	₁₀
_Baseline	_master	₁₀

# Conflicts: # src/services/refactors/extractSymbol.ts

sheetalkamat · 2020-06-22T18:09:47Z

 if (!options.noEmit && !options.suppressOutputPathCheck) {
 const emitHost = getEmitHost();
- const emitFilesSeen = createMap<true>();
+ const emitFilesSeen = new Set<string>();


Key as path

This breaks verifyEmitFilePath unless we cast the key to Path.

emitFilesSeen.add(emitFileKey); is path in there though.

rbuckton · 2020-06-22T21:53:08Z

@sheetalkamat: I've made most of the suggested key changes, but there are some that would result in type errors that I do not have enough context to resolve.

rbuckton · 2020-06-22T22:00:34Z

While there are still some outstanding cases to investigate regarding keys, I don't know that they should be a blocker for this PR. Without this PR those keys are currently still typed as string anyways, and there is a long tail of cases where we are still using Maps as Set-likes, or with string keys that are coerced, that I plan to address over time rather than in a single PR.

# Conflicts: # src/server/project.ts # src/services/types.ts

rbuckton · 2020-06-24T00:35:53Z

@sheetalkamat can you take another look?

sheetalkamat

Apart from two suggestions things look good.

Here are two questions i still have:
1: There are some places where you replaced createMap() with new Map() but not all. Was there a reason for that
2. Do we really care about performance of shim implementaion if we were really using the native maps before.. Why not use .toString() on key for shim to keep it simple and compact if its going to be used rarely.

sheetalkamat · 2020-06-24T18:39:38Z

Sorry didnt notice your questions on the previous comments,going through them now

rbuckton · 2020-06-24T22:49:06Z

Here are two questions i still have:
1: There are some places where you replaced createMap() with new Map() but not all. Was there a reason for that

Those were mostly ad-hoc. I am planning on putting together a follow-up PR that replaces all other references and removes createMap.

Do we really care about performance of shim implementaion if we were really using the native maps before.. Why not use .toString() on key for shim to keep it simple and compact if its going to be used rarely.

Using .toString won't work for non-primitive values, and wouldn't handle cases like null, undefined, true, false, +Infinity, -Infinity, and NaN. The approach in this PR is to give these types different buckets to work with to avoid collisions (i.e. 1 and "1" should not collide) and still have moderately fast lookup time for common cases (i.e., strings and numbers).

If the recommendation is to ignore performance for the shim and simplify the design, then I'd likely just do away with the buckets and use the linked list implementation used for other values for everything.

One of the stated goals for this PR is to allow us to have non-primitive keys. While I am not making heavy use of it in this PR, I plan to migrate some of our maps/sets to accept Node or Symbol keys in follow-up PRs, in an effort to reduce the unnecessary overhead of calling getNodeId or getSymbolId just to use as a key for a Map/Set.

# Conflicts: # src/compiler/transformers/utilities.ts

rbuckton · 2020-06-25T22:01:11Z

@sheetalkamat: I've put together a simpler (though less performant) version of the shim that just uses a linked list. Should I use that one instead?

rbuckton · 2020-06-25T22:46:05Z

I'll go ahead and switch to the simpler Map/Set implementation that just leverages a linked list. It will be less performant, but also takes up less memory and reduces the file-size cost of the shim.

rbuckton · 2020-06-25T22:48:12Z

@sheetalkamat: Would you care to take one more look over the shim implementation? I repurposed the existing doubly-linked list that was added to preserve iteration order, which should result in less memory usage overall.

rbuckton · 2020-06-25T23:11:12Z

@sheetalkamat: I've filed #39264 which leverages the work in this PR and comprehensively removes calls to createMap, as well as some other related cleanup.

* upstream/master: LEGO: check in for master to temporary branch. Preserve newlines between try/catch/finally, if/else, do/while (microsoft#39280) not narrow static property without type annotation in constructor. (microsoft#39252) Switch to ES Map/Set internally (microsoft#33771) fix(38840): omit completions for a spread like argument in a function definition (microsoft#38897) fix(38785): include in NavigationBar child items from default exported functions (microsoft#38915) LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Avoid effect of element access expression (microsoft#39174) Update typescript-eslint to 3.4.1-alpha.1 (microsoft#39260) Handle 'keyof' for generic tuple types (microsoft#39218) Disable unsound T[K] rule in subtype relations (microsoft#39249) LEGO: check in for master to temporary branch. Upgrade typescript-eslint version (microsoft#39242) Handle recursive type references up to a certain level of expansion in inference (microsoft#38011) Do not consider binding patterns in contextual types for return type inference where all the signature type parameters have defaults (microsoft#39081) LEGO: check in for master to temporary branch. # Conflicts: # src/compiler/program.ts # src/compiler/types.ts

rbuckton requested review from DanielRosenwasser, RyanCavanaugh and weswigham October 2, 2019 23:09

rbuckton force-pushed the esMapSetShim branch 3 times, most recently from e4769a2 to 374ce8bCompare October 7, 2019 20:49

j-oliveras mentioned this pull request Oct 8, 2019
Add shim for ES Promise #33863
Closed

rbuckton force-pushed the esMapSetShim branch from 374ce8b to a8c5fe1Compare June 16, 2020 21:08

typescript-bot assigned rbuckton Jun 16, 2020

typescript-bot added the Author: Team label Jun 16, 2020

rbuckton changed the title ~~ES Map/Set/WeakMap/WeakSet shims~~Switch to ES Map/Set/WeakMap/WeakSet internallyJun 18, 2020

DanielRosenwasser mentioned this pull request Jun 18, 2020
Design Meeting Notes, 6/18/2020 #39154
Closed

rbuckton changed the title ~~Switch to ES Map/Set/WeakMap/WeakSet internally~~Switch to ES Map/Set internallyJun 19, 2020

rbuckton marked this pull request as ready for review June 19, 2020 06:44

rbuckton added 4 commits June 18, 2020 23:45

Add full implemention of Map and Set to shims
24fa19d

Update default Map interface
eb3c9f4

Remove WeakMap/WeakSet
f773f18

Add tests for set shim
c6fc934

rbuckton force-pushed the esMapSetShim branch from 7743935 to 79eb8eeCompare June 19, 2020 07:09

Update most usages of Map<K, true> to Set
2f48428

rbuckton force-pushed the esMapSetShim branch from 79eb8ee to 2f48428Compare June 20, 2020 04:06

rbuckton requested review from andrewbranch and sheetalkamat June 22, 2020 16:54

sheetalkamat reviewed Jun 22, 2020
View reviewed changes

Comment threadsrc/compiler/binder.ts Outdated

sheetalkamat reviewed Jun 22, 2020
View reviewed changes

Comment threadsrc/compiler/program.ts Outdated

sheetalkamat reviewed Jun 22, 2020
View reviewed changes

Comment threadsrc/compiler/program.ts Outdated

sheetalkamat reviewed Jun 22, 2020
View reviewed changes

Comment threadsrc/compiler/program.ts Outdated

Merge branch 'master' into esMapSetShim
c86b1b8
# Conflicts: # src/services/refactors/extractSymbol.ts

sheetalkamat requested changes Jun 22, 2020
View reviewed changes

PR Feedback
d0b29e8

rbuckton added 2 commits June 22, 2020 18:53

Fix lint issues
92626a6

Merge branch 'master' into esMapSetShim
15264b7
# Conflicts: # src/server/project.ts # src/services/types.ts

sheetalkamat approved these changes Jun 24, 2020
View reviewed changes

Comment threadsrc/harness/virtualFileSystemWithWatch.ts Outdated

rbuckton added 3 commits June 24, 2020 15:55

Change key in fsWatchCallback
d76ce7b

Merge branch 'master' into esMapSetShim
9d0394f
# Conflicts: # src/compiler/transformers/utilities.ts

Merge branch 'master' into esMapSetShim
f7ddeeb

Simpler shim, more tests
fc50c27

rbuckton added 2 commits June 25, 2020 15:51

Merge branch 'master' into esMapSetShim
7ed4a9e

Fix typo in collection shim
661fa61

rbuckton mentioned this pull request Jun 25, 2020
Migrate maps and sets #39264
Merged

sheetalkamat approved these changes Jun 26, 2020
View reviewed changes

rbuckton merged commit eb2f4e2 into masterJun 26, 2020

rbuckton deleted the esMapSetShim branch June 26, 2020 17:12

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Uh oh!

Conversation

rbuckton commented Oct 2, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rbuckton commented Jun 19, 2020

Uh oh!

typescript-bot commented Jun 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 19, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sheetalkamatJun 22, 2020

Choose a reason for hiding this comment

Uh oh!

rbucktonJun 22, 2020

Choose a reason for hiding this comment

Uh oh!

sheetalkamatJun 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbuckton commented Jun 22, 2020

Uh oh!

rbuckton commented Jun 22, 2020

Uh oh!

rbuckton commented Jun 24, 2020

Uh oh!

sheetalkamat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sheetalkamat commented Jun 24, 2020

Uh oh!

rbuckton commented Jun 24, 2020

Uh oh!

rbuckton commented Jun 25, 2020

Uh oh!

rbuckton commented Jun 25, 2020

Uh oh!

rbuckton commented Jun 25, 2020

Uh oh!

rbuckton commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rbuckton commented Oct 2, 2019•
edited
Loading

typescript-bot commented Jun 19, 2020•
edited
Loading

typescript-bot commented Jun 19, 2020•
edited
Loading

typescript-bot commented Jun 19, 2020•
edited
Loading

typescript-bot commented Jun 19, 2020•
edited
Loading