Skip to content

Fix alias naming and structure bugs in js declarations - #34786

Merged
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
weswigham:fix-js-declaration-bugs
Oct 30, 2019
Merged

Fix alias naming and structure bugs in js declarations#34786
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
weswigham:fix-js-declaration-bugs

Conversation

@weswigham

@weswighamWesley Wigham (weswigham) commented Oct 28, 2019

Copy link
Copy Markdown
Member

Fixes#33626

@weswigham

Wesley Wigham (weswigham) commented Oct 28, 2019

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the tarball bundle task on this PR at f6dbbfd. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/51345/artifacts?artifactName=tgz&fileId=BE8227D37C4FBD85D3EC6A4F2B506E69739A0B654874B0793F8371FF9400A48102&fileName=/typescript-3.8.0-insiders.20191028.tgz"
}
}

and then running npm install.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), something went wrong when looking for the build artifact. (You can check the log here).

@weswighamWesley Wigham (weswigham) mentioned this pull request Oct 28, 2019
Closed
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Oct 29, 2019
View reviewed changes

@sandersnNathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this address the most recent repro on the bug's thread? Let me know if I need to re-review.

Comment threadsrc/compiler/checker.ts Outdated
@weswigham

Wesley Wigham (weswigham) commented Oct 29, 2019

Copy link
Copy Markdown
MemberAuthor

Nathan Shively-Sanders (@sandersn) one more line of change and an additional test for that new case~

@weswigham

Wesley Wigham (weswigham) commented Oct 29, 2019

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) pack this again just cuz

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 29, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the tarball bundle task on this PR at ca5f764. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/51580/artifacts?artifactName=tgz&fileId=2D5A2A07D78EC360247C2C72F1E8337CF422D29DB76FE7B0A85A211722010B9702&fileName=/typescript-3.8.0-insiders.20191029.tgz"
}
}

and then running npm install.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), something went wrong when looking for the build artifact. (You can check the log here).

@weswigham
Wesley Wigham (weswigham) merged commit d28672d into microsoft:masterOct 30, 2019
@weswigham

Wesley Wigham (weswigham) commented Oct 30, 2019

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick this into release-3.7

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 30, 2019
@weswigham@typescript-bot
Cherry-pick PRmicrosoft#34786into release-3.7
3b3bd52
Component commits:
f6dbbfd Fix alias naming and structure bugs in js declarations
3005f18 Merge branch 'master' into fix-js-declaration-bugs
3bd49e4 Add another test case and change condition for ns merge to require signature or export content
ca5f764 Fix typo in comment
@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Oct 30, 2019
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), I've opened #34833 for you.

@weswigham
Wesley Wigham (weswigham) deleted the fix-js-declaration-bugs branch October 30, 2019 20:24
Wesley Wigham (weswigham) pushed a commit that referenced this pull request Oct 30, 2019
TypeScript Bot@weswigham
Cherry-pick PR#34786into release-3.7 (#34833)
60bf24d
Component commits:
f6dbbfd Fix alias naming and structure bugs in js declarations
3005f18 Merge branch 'master' into fix-js-declaration-bugs
3bd49e4 Add another test case and change condition for ns merge to require signature or export content
ca5f764 Fix typo in comment
@weswighamWesley Wigham (weswigham) mentioned this pull request Oct 30, 2019
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn approved these changes
@andrewbranchAndrew Branch (andrewbranch)Awaiting requested review from andrewbranch

Assignees

@weswighamWesley Wigham (weswigham)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JS declarations for an export assigned class expression can conflict with local names

3 participants

@weswigham@typescript-bot@sandersn