Skip to content

Fix isInJsxText after JSXOpeningElement with type arguments - #34958

Merged
Andrew Branch (andrewbranch) merged 2 commits into
microsoft:masterfrom
andrewbranch:bug/34110
Nov 6, 2019
Merged

Fix isInJsxText after JSXOpeningElement with type arguments#34958
Andrew Branch (andrewbranch) merged 2 commits into
microsoft:masterfrom
andrewbranch:bug/34110

Conversation

@andrewbranch

@andrewbranchAndrew Branch (andrewbranch) commented Nov 6, 2019

Copy link
Copy Markdown
Member

Fixes#34110

amcasey
Andrew Casey (amcasey) approved these changes Nov 6, 2019
View reviewed changes

@amcaseyAndrew Casey (amcasey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've convinced myself it's correct, but I have some thoughts on readability.

Comment threadsrc/services/completions.ts
Comment threadsrc/services/completions.ts Outdated
@andrewbranch
Andrew Branch (andrewbranch) merged commit f2146a6 into microsoft:masterNov 6, 2019
@varemenosAdonis Kakoulidis (varemenos) mentioned this pull request Feb 19, 2023
Closed
@andrewbranchAndrew Branch (andrewbranch) mentioned this pull request Feb 21, 2023
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamatSheetal Nandi (sheetalkamat)Awaiting requested review from sheetalkamat
1 more reviewer
@amcaseyAndrew Casey (amcasey)amcasey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@andrewbranchAndrew Branch (andrewbranch)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generic react component (TSX) and intellisense not working

2 participants

@andrewbranch@amcasey