Uh oh!
There was an error while loading. Please reload this page.
Fix import type resolution in jsdoc, mark 2 - #35057
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoNov 12, 2019
Merged
Fix import type resolution in jsdoc, mark 2#35057Nathan Shively-Sanders (sandersn) merged 1 commit into
Nathan Shively-Sanders (sandersn) merged 1 commit into
Conversation
Fake alias resolution only applies when the import type is followed by a qualified name. Otherwise the alias is sufficiently resolved already.
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Branch (andrewbranch) and Wesley Wigham (weswigham)November 12, 2019 17:28
Wesley Wigham (weswigham)
approved these changes
Nov 12, 2019
Andrew Branch (andrewbranch)
approved these changes
Nov 12, 2019
Nathan Shively-Sanders (sandersn)
deleted the
fix-import-type-resolution-in-jsdoc
branch
November 12, 2019 20:44
MemberAuthor
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.7 |
TypeScript Bot (typescript-bot)
commented
Nov 12, 2019
Contributor
Hey Nathan Shively-Sanders (@sandersn), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
Nathan Shively-Sanders (sandersn) added a commit
that referenced
this pull request
Nov 12, 2019
Fake alias resolution only applies when the import type is followed by a qualified name. Otherwise the alias is sufficiently resolved already.
MemberAuthor
Manually cherry-picked and merged dfe2f07 to 3.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fake alias resolution only applies when the import type is followed by a qualified name. Otherwise the alias is sufficiently resolved already. The previous fix over-applied.
Fixes#34926