Uh oh!
There was an error while loading. Please reload this page.
Check combined intersection properties against target index signatures - #35143
Conversation
Anders Hejlsberg (ahejlsberg)
commented
Nov 16, 2019
TypeScript Bot (@typescript-bot) test this |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at b1f746b. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at b1f746b. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at b1f746b. You can monitor the build here. It should now contribute to this PR's status checks. |
TypeScript Bot (typescript-bot)
commented
Nov 16, 2019
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Anders Hejlsberg (ahejlsberg)
commented
Nov 17, 2019
TypeScript Bot (@typescript-bot) test this |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 3d8a9c8. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at 3d8a9c8. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 3d8a9c8. You can monitor the build here. It should now contribute to this PR's status checks. |
TypeScript Bot (typescript-bot)
commented
Nov 17, 2019
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Anders Hejlsberg (ahejlsberg)
commented
Jan 9, 2020
TypeScript Bot (@typescript-bot) test this |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 0ace61c. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at 0ace61c. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 0ace61c. You can monitor the build here. It should now contribute to this PR's status checks. |
TypeScript Bot (typescript-bot)
commented
Jan 9, 2020
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Anders Hejlsberg (ahejlsberg)
commented
Jan 9, 2020
TypeScript Bot (@typescript-bot) test this |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at f87aea3. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at f87aea3. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at f87aea3. You can monitor the build here. It should now contribute to this PR's status checks. |
Anders Hejlsberg (ahejlsberg)
commented
Jan 9, 2020
Issues in test suites are all preexisting conditions. |
microsoft#35143) * Check combined intersection properties against target index signatures * Add tests * Accept new baselines * Less aggressive check for index signatures * Track intersection membership state for both source and target * Minor fixes
With this PR we check that all constituents of an intersection source type relate to index signatures in the target type. For example:
Previously, no error was reported above.
Fixes#32484.