Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/compiler/moduleNameResolver.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ import {
versionMajorMinor,
VersionRange,
} from "./_namespaces/ts";
import {
getPnpApi,
getPnpTypeRoots,
} from "./pnp";

/** @internal */
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void {
Expand DownExpand Up@@ -471,7 +475,7 @@ export function getEffectiveTypeRoots(options: CompilerOptions, host: GetEffecti
* Returns the path to every node_modules/@types directory from some ancestor directory.
* Returns undefined if there are none.
*/
function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
function getNodeModulesTypeRoots(currentDirectory: string) {
let typeRoots: string[] | undefined;
forEachAncestorDirectory(normalizePath(currentDirectory), directory => {
const atTypes = combinePaths(directory, nodeModulesAtTypes);
Expand All@@ -486,6 +490,18 @@ function arePathsEqual(path1: string, path2: string, host: ModuleResolutionHost)
return comparePaths(path1, path2, !useCaseSensitiveFileNames) === Comparison.EqualTo;
}

function getDefaultTypeRoots(currentDirectory: string): string[] | undefined {
const nmTypes = getNodeModulesTypeRoots(currentDirectory);
const pnpTypes = getPnpTypeRoots(currentDirectory);

if (nmTypes?.length) {
return [...nmTypes, ...pnpTypes];
}
else if (pnpTypes.length) {
return pnpTypes;
}
}

function getOriginalAndResolvedFileName(fileName: string, host: ModuleResolutionHost, traceEnabled: boolean) {
const resolvedFileName = realPath(fileName, host, traceEnabled);
const pathsAreEqual = arePathsEqual(fileName, resolvedFileName, host);
Expand DownExpand Up@@ -770,6 +786,18 @@ export function resolvePackageNameToPackageJson(
): PackageJsonInfo | undefined {
const moduleResolutionState = getTemporaryModuleResolutionState(cache?.getPackageJsonInfoCache(), host, options);

const pnpapi = getPnpApi(containingDirectory);
if (pnpapi) {
try {
const resolution = pnpapi.resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
const candidate = normalizeSlashes(resolution).replace(/\/$/, "");
return getPackageJsonInfo(candidate, /*onlyRecordFailures*/ false, moduleResolutionState);
}
catch {
return;
}
}

return forEachAncestorDirectory(containingDirectory, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const nodeModulesFolder = combinePaths(ancestorDirectory, "node_modules");
Expand DownExpand Up@@ -2938,7 +2966,16 @@ function loadModuleFromNearestNodeModulesDirectoryWorker(extensions: Extensions,
}

function lookup(extensions: Extensions) {
return forEachAncestorDirectory(normalizeSlashes(directory), ancestorDirectory => {
const issuer = normalizeSlashes(directory);
if (getPnpApi(issuer)) {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, issuer, redirectedReference, state);
if (resolutionFromCache) {
return resolutionFromCache;
}
return toSearchResult(loadModuleFromImmediateNodeModulesDirectoryPnP(extensions, moduleName, issuer, state, typesScopeOnly, cache, redirectedReference));
}

return forEachAncestorDirectory(issuer, ancestorDirectory => {
if (getBaseFileName(ancestorDirectory) !== "node_modules") {
const resolutionFromCache = tryFindNonRelativeModuleNameInCache(cache, moduleName, mode, ancestorDirectory, redirectedReference, state);
if (resolutionFromCache) {
Expand DownExpand Up@@ -2977,11 +3014,34 @@ function loadModuleFromImmediateNodeModulesDirectory(extensions: Extensions, mod
}
}

function loadModuleFromImmediateNodeModulesDirectoryPnP(extensions: Extensions, moduleName: string, directory: string, state: ModuleResolutionState, typesScopeOnly: boolean, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const issuer = normalizeSlashes(directory);

if (!typesScopeOnly) {
const packageResult = tryLoadModuleUsingPnpResolution(extensions, moduleName, issuer, state, cache, redirectedReference);
if (packageResult) {
return packageResult;
}
}

if (extensions & Extensions.Declaration) {
return tryLoadModuleUsingPnpResolution(Extensions.Declaration, `@types/${mangleScopedPackageNameWithTrace(moduleName, state)}`, issuer, state, cache, redirectedReference);
}
}

function loadModuleFromSpecificNodeModulesDirectory(extensions: Extensions, moduleName: string, nodeModulesDirectory: string, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(nodeModulesDirectory, moduleName));
const { packageName, rest } = parsePackageName(moduleName);
const packageDirectory = combinePaths(nodeModulesDirectory, packageName);
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, nodeModulesDirectoryExists, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromPnpResolution(extensions: Extensions, packageDirectory: string, rest: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined): Resolved | undefined {
const candidate = normalizePath(combinePaths(packageDirectory, rest));
return loadModuleFromSpecificNodeModulesDirectoryImpl(extensions, /*nodeModulesDirectoryExists*/ true, state, cache, redirectedReference, candidate, rest, packageDirectory);
}

function loadModuleFromSpecificNodeModulesDirectoryImpl(extensions: Extensions, nodeModulesDirectoryExists: boolean, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined, candidate: string, rest: string, packageDirectory: string): Resolved | undefined {
let rootPackageInfo: PackageJsonInfo | undefined;
// First look for a nested package.json, as in `node_modules/foo/bar/package.json`.
let packageInfo = getPackageJsonInfo(candidate, !nodeModulesDirectoryExists, state);
Expand DownExpand Up@@ -3306,3 +3366,22 @@ function useCaseSensitiveFileNames(state: ModuleResolutionState) {
typeof state.host.useCaseSensitiveFileNames === "boolean" ? state.host.useCaseSensitiveFileNames :
state.host.useCaseSensitiveFileNames();
}

function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
try {
const resolution = getPnpApi(containingDirectory).resolveToUnqualified(packageName, `${containingDirectory}/`, { considerBuiltins: false });
return normalizeSlashes(resolution).replace(/\/$/, "");
}
catch {
// Nothing to do
}
}

function tryLoadModuleUsingPnpResolution(extensions: Extensions, moduleName: string, containingDirectory: string, state: ModuleResolutionState, cache: ModuleResolutionCache | undefined, redirectedReference: ResolvedProjectReference | undefined) {
const { packageName, rest } = parsePackageName(moduleName);

const packageResolution = loadPnpPackageResolution(packageName, containingDirectory);
return packageResolution
? loadModuleFromPnpResolution(extensions, packageResolution, rest, state, cache, redirectedReference)
: undefined;
}
93 changes: 79 additions & 14 deletions src/compiler/moduleSpecifiers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ import {
NodeFlags,
NodeModulePathParts,
normalizePath,
PackagePathParts,
Path,
pathContainsNodeModules,
pathIsBareSpecifier,
Expand All@@ -110,6 +111,9 @@ import {
TypeChecker,
UserPreferences,
} from "./_namespaces/ts";
import {
getPnpApi,
} from "./pnp";

// Used by importFixes, getEditsForFileRename, and declaration emit to synthesize import module specifiers.

Expand DownExpand Up@@ -641,7 +645,17 @@ function getAllModulePathsWorker(importingFileName: Path, importedFileName: stri
host,
/*preferSymlinks*/ true,
(path, isRedirect) => {
const isInNodeModules = pathContainsNodeModules(path);
let isInNodeModules = pathContainsNodeModules(path);

const pnpapi = getPnpApi(path);
if (!isInNodeModules && pnpapi) {
const fromLocator = pnpapi.findPackageLocator(importingFileName);
const toLocator = pnpapi.findPackageLocator(path);
if (fromLocator && toLocator && fromLocator !== toLocator) {
isInNodeModules = true;
}
}

allFileNames.set(path, { path: getCanonicalFileName(path), isRedirect, isInNodeModules });
importedFileFromNodeModules = importedFileFromNodeModules || isInNodeModules;
// don't return value, so we collect everything
Expand DownExpand Up@@ -907,7 +921,51 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
if (!host.fileExists || !host.readFile) {
return undefined;
}
const parts: NodeModulePathParts = getNodeModulePathParts(path)!;
let parts: NodeModulePathParts | PackagePathParts | undefined = getNodeModulePathParts(path);

let pnpPackageName: string | undefined;

const pnpApi = getPnpApi(path);
if (pnpApi) {
const fromLocator = pnpApi.findPackageLocator(importingSourceFile.fileName);
const toLocator = pnpApi.findPackageLocator(path);

// Don't use the package name when the imported file is inside
// the source directory (prefer a relative path instead)
if (fromLocator === toLocator) {
return undefined;
}

if (fromLocator && toLocator) {
const fromInfo = pnpApi.getPackageInformation(fromLocator);
if (toLocator.reference === fromInfo.packageDependencies.get(toLocator.name)) {
pnpPackageName = toLocator.name;
}
else {
// Aliased dependencies
for (const [name, reference] of fromInfo.packageDependencies) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
pnpPackageName = name;
break;
}
}
}
}

if (!parts) {
const toInfo = pnpApi.getPackageInformation(toLocator);
parts = {
topLevelNodeModulesIndex: undefined,
topLevelPackageNameIndex: undefined,
// The last character from packageLocation is the trailing "/", we want to point to it
packageRootIndex: toInfo.packageLocation.length - 1,
fileNameIndex: path.lastIndexOf(`/`),
};
}
}
}

if (!parts) {
return undefined;
}
Expand DownExpand Up@@ -952,19 +1010,26 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
return undefined;
}

const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
// If PnP is enabled the node_modules entries we'll get will always be relevant even if they
// are located in a weird path apparently outside of the source directory
if (typeof process.versions.pnp === "undefined") {
const globalTypingsCacheLocation = host.getGlobalTypingsCacheLocation && host.getGlobalTypingsCacheLocation();
// Get a path that's relative to node_modules or the importing file's path
// if node_modules folder is in this folder or any of its parent folders, no need to keep it.
const pathToTopLevelNodeModules = getCanonicalFileName(moduleSpecifier.substring(0, parts.topLevelNodeModulesIndex));
if (!(startsWith(sourceDirectory, pathToTopLevelNodeModules) || globalTypingsCacheLocation && startsWith(getCanonicalFileName(globalTypingsCacheLocation), pathToTopLevelNodeModules))) {
return undefined;
}
}

// If the module was found in @types, get the actual Node package name
const nodeModulesDirectoryName = moduleSpecifier.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = typeof pnpPackageName !== "undefined"
? pnpPackageName + moduleSpecifier.substring(parts.packageRootIndex)
: moduleSpecifier.substring(parts.topLevelPackageNameIndex! + 1);

const packageNameFromPath = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
// For classic resolution, only allow importing from node_modules/@types, not other node_modules
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageName === nodeModulesDirectoryName ? undefined : packageName;
return getEmitModuleResolutionKind(options) === ModuleResolutionKind.Classic && packageNameFromPath === nodeModulesDirectoryName ? undefined : packageNameFromPath;

function tryDirectoryWithPackageJson(packageRootIndex: number): { moduleFileToTry: string; packageRootPath?: string; blockedByExports?: true; verbatimFromExports?: true; } {
const packageRootPath = path.substring(0, packageRootIndex);
Expand All@@ -979,8 +1044,8 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
// The package name that we found in node_modules could be different from the package
// name in the package.json content via url/filepath dependency specifiers. We need to
// use the actual directory name, so don't look at `packageJsonContent.name` here.
const nodeModulesDirectoryName = packageRootPath.substring(parts.topLevelPackageNameIndex + 1);
const packageName = getPackageNameFromTypesPackageName(nodeModulesDirectoryName);
const nodeModulesDirectoryName = packageRootPath.substring(parts!.topLevelPackageNameIndex! + 1);
const packageName = getPackageNameFromTypesPackageName(pnpPackageName ? pnpPackageName : nodeModulesDirectoryName);
const conditions = getConditions(options, importMode === ModuleKind.ESNext);
const fromExports = packageJsonContent.exports
? tryGetModuleNameFromExports(options, path, packageRootPath, packageName, packageJsonContent.exports, conditions)
Expand DownExpand Up@@ -1046,7 +1111,7 @@ function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCan
}
else {
// No package.json exists; an index.js will still resolve as the package name
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts.packageRootIndex + 1));
const fileName = getCanonicalFileName(moduleFileToTry.substring(parts!.packageRootIndex + 1));
if (fileName === "index.d.ts" || fileName === "index.js" || fileName === "index.ts" || fileName === "index.tsx") {
return { moduleFileToTry, packageRootPath };
}
Expand Down
80 changes: 80 additions & 0 deletions src/compiler/pnp.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
import {
getDirectoryPath,
resolvePath,
} from "./path";

export function getPnpApi(path: string) {
if (typeof process.versions.pnp === "undefined") {
return;
}

const { findPnpApi } = require("module");
if (findPnpApi) {
return findPnpApi(`${path}/`);
}
}

export function getPnpApiPath(path: string): string | undefined {
// eslint-disable-next-line no-null/no-null
return getPnpApi(path)?.resolveRequest("pnpapi", /*issuer*/ null);
}

export function getPnpTypeRoots(currentDirectory: string) {
const pnpApi = getPnpApi(currentDirectory);
if (!pnpApi) {
return [];
}

// Some TS consumers pass relative paths that aren't normalized
currentDirectory = resolvePath(currentDirectory);

const currentPackage = pnpApi.findPackageLocator(`${currentDirectory}/`);
if (!currentPackage) {
return [];
}

const { packageDependencies } = pnpApi.getPackageInformation(currentPackage);

const typeRoots: string[] = [];
for (const [name, referencish] of Array.from<any>(packageDependencies.entries())) {
// eslint-disable-next-line no-null/no-null
if (name.startsWith(`@types/`) && referencish !== null) {
const dependencyLocator = pnpApi.getLocator(name, referencish);
const { packageLocation } = pnpApi.getPackageInformation(dependencyLocator);

typeRoots.push(getDirectoryPath(packageLocation));
}
}

return typeRoots;
}

export function isImportablePathPnp(fromPath: string, toPath: string): boolean {
const pnpApi = getPnpApi(fromPath);

const fromLocator = pnpApi.findPackageLocator(fromPath);
const toLocator = pnpApi.findPackageLocator(toPath);

// eslint-disable-next-line no-null/no-null
if (toLocator === null) {
return false;
}

const fromInfo = pnpApi.getPackageInformation(fromLocator);
const toReference = fromInfo.packageDependencies.get(toLocator.name);

if (toReference) {
return toReference === toLocator.reference;
}

// Aliased dependencies
for (const reference of fromInfo.packageDependencies.values()) {
if (Array.isArray(reference)) {
if (reference[0] === toLocator.name && reference[1] === toLocator.reference) {
return true;
}
}
}

return false;
}
4 changes: 4 additions & 0 deletions src/compiler/sys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1728,6 +1728,10 @@ export let sys: System = (() => {
}

function isFileSystemCaseSensitive(): boolean {
// The PnP runtime is always case-sensitive
if (typeof process.versions.pnp !== `undefined`) {
return true;
}
// win32\win64 are case insensitive platforms
if (platform === "win32" || platform === "win64") {
return false;
Expand Down
9 changes: 9 additions & 0 deletions src/compiler/utilities.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10230,6 +10230,15 @@ export interface NodeModulePathParts {
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export interface PackagePathParts {
readonly topLevelNodeModulesIndex: undefined;
readonly topLevelPackageNameIndex: undefined;
readonly packageRootIndex: number;
readonly fileNameIndex: number;
}

/** @internal */
export function getNodeModulePathParts(fullPath: string): NodeModulePathParts | undefined {
// If fullPath can't be valid module file within node_modules, returns undefined.
Expand Down
Loading