Added @ts-expect-error to @ts-ignore directives by JoshuaKGoldberg · Pull Request #36014 · microsoft/TypeScript

JoshuaKGoldberg · 2020-01-05T20:02:55Z

Similar to // @ts-ignore, but will itself cause a new error diagnostic if it does not cause an existing diagnostic to be ignored.

Technical summary:

The scanner will now keep track of CommentDirectives it comes across: both @ts-expect-error and @ts-ignore
During type checking, the program will turn those directives into a map keying them by line number
For each diagnostic, if it's preceded by a directive, that directive is marked as "used"
All @ts-expect-error directives not marked as used generate a new diagnostic error

Fixes#29394

Similar to `// @ts-ignore`, but will itself cause a new error diagnostic if it does not cause an existing diagnostic to be ignored. Technical summary: 1. The scanner will now keep track of `CommentDirective`s it comes across: both `@ts-expect-error` and `@ts-ignore` 2. During type checking, the program will turn those directives into a map keying them by line number 3. For each diagnostic, if it's preceded by a directive, that directive is marked as "used" 4. All `@ts-expect-error` directives not marked as used generate a new diagnostic error

orta · 2020-01-17T23:00:40Z

I'd like to try this in a playground:

@typescript-bot perf test
@typescript-bot pack this

typescript-bot · 2020-01-17T23:00:45Z

Heya @orta, I've started to run the perf test suite on this PR at eb5610a. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

typescript-bot · 2020-01-17T23:00:45Z

Heya @orta, I've started to run the tarball bundle task on this PR at eb5610a. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2020-01-17T23:36:33Z

@orta
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36014

Metric	master	36014	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	355,734k (± 0.01%)	356,812k (± 0.02%)	+1,078k (+ 0.30%)	356,627k	356,970k
Parse Time	1.60s (± 0.37%)	1.63s (± 0.59%)	+0.02s (+ 1.50%)	1.61s	1.65s
Bind Time	0.87s (± 0.66%)	0.88s (± 0.66%)	+0.01s (+ 1.15%)	0.87s	0.90s
Check Time	4.58s (± 0.50%)	4.58s (± 0.63%)	-0.00s (- 0.02%)	4.49s	4.64s
Emit Time	5.25s (± 0.56%)	5.27s (± 0.62%)	+0.02s (+ 0.42%)	5.16s	5.32s
Total Time	12.31s (± 0.36%)	12.37s (± 0.49%)	+0.06s (+ 0.45%)	12.14s	12.43s
Monaco - node (v10.16.3, x64)
Memory used	364,273k (± 0.01%)	366,643k (± 0.01%)	+2,369k (+ 0.65%)	366,557k	366,739k
Parse Time	1.25s (± 0.52%)	1.27s (± 0.59%)	+0.01s (+ 1.20%)	1.25s	1.28s
Bind Time	0.76s (± 0.48%)	0.76s (± 0.65%)	+0.00s (+ 0.13%)	0.76s	0.78s
Check Time	4.62s (± 0.38%)	4.73s (± 0.51%)	+0.11s (+ 2.40%)	4.67s	4.78s
Emit Time	2.94s (± 0.68%)	2.96s (± 0.71%)	+0.01s (+ 0.48%)	2.91s	3.01s
Total Time	9.58s (± 0.39%)	9.72s (± 0.42%)	+0.14s (+ 1.45%)	9.63s	9.81s
TFS - node (v10.16.3, x64)
Memory used	323,439k (± 0.02%)	322,400k (± 0.02%)	-1,038k (- 0.32%)	322,272k	322,517k
Parse Time	0.95s (± 0.38%)	0.97s (± 0.77%)	+0.02s (+ 2.22%)	0.95s	0.99s
Bind Time	0.74s (± 0.92%)	0.74s (± 1.50%)	+0.00s (+ 0.14%)	0.72s	0.76s
Check Time	4.16s (± 0.55%)	4.19s (± 0.61%)	+0.03s (+ 0.79%)	4.16s	4.26s
Emit Time	3.02s (± 0.96%)	3.04s (± 0.88%)	+0.02s (+ 0.56%)	2.96s	3.08s
Total Time	8.87s (± 0.46%)	8.94s (± 0.49%)	+0.07s (+ 0.83%)	8.84s	9.02s
Angular - node (v12.1.0, x64)
Memory used	331,474k (± 0.03%)	332,501k (± 0.02%)	+1,027k (+ 0.31%)	332,355k	332,624k
Parse Time	1.56s (± 0.61%)	1.57s (± 0.76%)	+0.02s (+ 1.03%)	1.54s	1.60s
Bind Time	0.85s (± 0.97%)	0.87s (± 0.56%)	+0.02s (+ 2.34%)	0.86s	0.88s
Check Time	4.51s (± 0.66%)	4.49s (± 0.42%)	-0.03s (- 0.60%)	4.45s	4.52s
Emit Time	5.45s (± 0.56%)	5.47s (± 0.49%)	+0.02s (+ 0.42%)	5.42s	5.54s
Total Time	12.38s (± 0.35%)	12.41s (± 0.30%)	+0.03s (+ 0.26%)	12.34s	12.50s
Monaco - node (v12.1.0, x64)
Memory used	344,024k (± 0.02%)	346,450k (± 0.02%)	+2,426k (+ 0.71%)	346,315k	346,645k
Parse Time	1.22s (± 0.64%)	1.23s (± 0.87%)	+0.01s (+ 0.66%)	1.21s	1.25s
Bind Time	0.73s (± 0.67%)	0.74s (± 1.93%)	+0.00s (+ 0.14%)	0.72s	0.79s
Check Time	4.47s (± 0.36%)	4.58s (± 0.52%)	+0.10s (+ 2.35%)	4.53s	4.63s
Emit Time	3.00s (± 0.79%)	3.00s (± 0.73%)	-0.00s (- 0.07%)	2.96s	3.05s
Total Time	9.43s (± 0.34%)	9.55s (± 0.49%)	+0.12s (+ 1.23%)	9.44s	9.62s
TFS - node (v12.1.0, x64)
Memory used	305,732k (± 0.02%)	304,692k (± 0.02%)	-1,040k (- 0.34%)	304,587k	304,823k
Parse Time	0.95s (± 0.50%)	0.95s (± 0.91%)	+0.00s (+ 0.11%)	0.93s	0.97s
Bind Time	0.69s (± 0.80%)	0.69s (± 0.68%)	-0.00s (- 0.29%)	0.68s	0.70s
Check Time	4.12s (± 0.23%)	4.14s (± 0.56%)	+0.02s (+ 0.58%)	4.06s	4.17s
Emit Time	3.10s (± 1.15%)	3.07s (± 0.83%)	-0.03s (- 0.94%)	3.01s	3.13s
Total Time	8.86s (± 0.51%)	8.85s (± 0.46%)	-0.01s (- 0.08%)	8.76s	8.93s
Angular - node (v8.9.0, x64)
Memory used	350,684k (± 0.01%)	351,726k (± 0.01%)	+1,042k (+ 0.30%)	351,662k	351,811k
Parse Time	2.09s (± 0.47%)	2.12s (± 0.78%)	+0.03s (+ 1.53%)	2.09s	2.16s
Bind Time	0.91s (± 0.73%)	0.92s (± 1.09%)	+0.01s (+ 1.20%)	0.89s	0.94s
Check Time	5.38s (± 0.63%)	5.34s (± 0.73%)	-0.04s (- 0.71%)	5.24s	5.45s
Emit Time	6.27s (± 0.96%)	6.27s (± 0.83%)	+0.00s (+ 0.06%)	6.20s	6.38s
Total Time	14.66s (± 0.61%)	14.67s (± 0.61%)	+0.01s (+ 0.07%)	14.44s	14.83s
Monaco - node (v8.9.0, x64)
Memory used	362,452k (± 0.02%)	364,715k (± 0.01%)	+2,263k (+ 0.62%)	364,632k	364,748k
Parse Time	1.57s (± 0.49%)	1.57s (± 0.22%)	-0.00s (- 0.13%)	1.56s	1.57s
Bind Time	0.96s (± 1.15%)	0.94s (± 0.81%)	-0.01s (- 1.25%)	0.93s	0.96s
Check Time	5.28s (± 1.23%)	5.45s (± 1.55%)	+0.17s (+ 3.28%)	5.28s	5.61s
Emit Time	3.43s (± 3.12%)	3.30s (± 4.55%)	-0.14s (- 4.02%)	3.02s	3.49s
Total Time	11.24s (± 0.71%)	11.26s (± 0.81%)	+0.02s (+ 0.19%)	11.06s	11.43s
TFS - node (v8.9.0, x64)
Memory used	322,674k (± 0.01%)	321,606k (± 0.01%)	-1,068k (- 0.33%)	321,536k	321,710k
Parse Time	1.27s (± 0.54%)	1.27s (± 0.51%)	+0.00s (+ 0.16%)	1.25s	1.28s
Bind Time	0.75s (± 0.91%)	0.75s (± 0.63%)	-0.00s (- 0.66%)	0.74s	0.76s
Check Time	4.79s (± 0.47%)	4.76s (± 0.54%)	-0.03s (- 0.61%)	4.71s	4.81s
Emit Time	3.22s (± 0.50%)	3.22s (± 0.43%)	-0.00s (- 0.03%)	3.19s	3.25s
Total Time	10.04s (± 0.37%)	10.00s (± 0.37%)	-0.03s (- 0.35%)	9.93s	10.07s
Angular - node (v8.9.0, x86)
Memory used	199,273k (± 0.02%)	199,831k (± 0.04%)	+558k (+ 0.28%)	199,676k	200,047k
Parse Time	2.01s (± 0.64%)	2.04s (± 0.52%)	+0.03s (+ 1.59%)	2.03s	2.08s
Bind Time	1.03s (± 0.35%)	1.03s (± 0.58%)	0.00s ( 0.00%)	1.01s	1.04s
Check Time	4.89s (± 0.60%)	4.87s (± 0.33%)	-0.02s (- 0.43%)	4.83s	4.91s
Emit Time	6.10s (± 1.93%)	6.16s (± 1.25%)	+0.06s (+ 1.00%)	6.01s	6.32s
Total Time	14.03s (± 0.97%)	14.10s (± 0.54%)	+0.07s (+ 0.53%)	13.96s	14.27s
Monaco - node (v8.9.0, x86)
Memory used	203,369k (± 0.02%)	204,511k (± 0.01%)	+1,141k (+ 0.56%)	204,463k	204,576k
Parse Time	1.60s (± 0.35%)	1.61s (± 0.72%)	+0.01s (+ 0.56%)	1.59s	1.63s
Bind Time	0.76s (± 1.35%)	0.76s (± 0.77%)	-0.00s (- 0.26%)	0.74s	0.77s
Check Time	5.08s (± 1.78%)	5.45s (± 1.22%)	+0.36s (+ 7.14%)	5.22s	5.57s
Emit Time	3.21s (± 2.34%)	2.90s (± 3.30%)	-0.31s (- 9.66%)	2.83s	3.28s
Total Time	10.65s (± 0.33%)	10.71s (± 0.56%)	+0.06s (+ 0.57%)	10.59s	10.87s
TFS - node (v8.9.0, x86)
Memory used	182,089k (± 0.02%)	181,473k (± 0.02%)	-616k (- 0.34%)	181,416k	181,569k
Parse Time	1.30s (± 0.96%)	1.32s (± 0.72%)	+0.02s (+ 1.23%)	1.30s	1.34s
Bind Time	0.71s (± 1.60%)	0.71s (± 1.32%)	-0.00s (- 0.28%)	0.70s	0.74s
Check Time	4.52s (± 0.78%)	4.54s (± 1.01%)	+0.03s (+ 0.58%)	4.46s	4.68s
Emit Time	2.99s (± 0.76%)	3.01s (± 1.58%)	+0.02s (+ 0.74%)	2.96s	3.18s
Total Time	9.52s (± 0.55%)	9.58s (± 0.85%)	+0.06s (+ 0.68%)	9.45s	9.79s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-166-generic
Architecture	x64
Available Memory	16 GB
Available Memory	5 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	36014	10
Baseline	master	10

JoshuaKGoldberg · 2020-01-26T20:29:41Z

Re that On-Demand Benchmark test failure: Monaco check time went up 7.14% (line link). but emit time decreased by almost as much (31s out of 36s), and the total time went up only by 0.57%:

│ Monaco - node (v8.9.0, x86) │
├─────────────┬────────────────────┬────────────────────┬───────────────────┬──────────┬──────────┤
│ Memory used │ 203,369k (± 0.02%) │ 204,511k (± 0.01%) │ +1,141k (+ 0.56%) │ 204,463k │ 204,576k │
│ Parse Time │ 1.60s (± 0.35%) │ 1.61s (± 0.72%) │ +0.01s (+ 0.56%) │ 1.59s │ 1.63s │
│ Bind Time │ 0.76s (± 1.35%) │ 0.76s (± 0.77%) │ -0.00s (- 0.26%) │ 0.74s │ 0.77s │
│ Check Time │ 5.08s (± 1.78%) │ 5.45s (± 1.22%) │ +0.36s (+ 7.14%) │ 5.22s │ 5.57s │
│ Emit Time │ 3.21s (± 2.34%) │ 2.90s (± 3.30%) │ -0.31s (- 9.66%) │ 2.83s │ 3.28s │
├─────────────┼────────────────────┼────────────────────┼───────────────────┼──────────┼──────────┤
│ Total Time │ 10.65s (± 0.33%) │ 10.71s (± 0.56%) │ +0.06s (+ 0.57%) │ 10.59s │ 10.87s │

...so this feels like it's not a serious performance degradation, and this PR is still valid? 😁

davidgomes · 2020-01-27T22:49:45Z

This is great!

@JoshuaKGoldberg I've also been toying around with implementing this. However, I was making @ts-ignore and @ts-expect-error pragmas instead of adding a new concept (Comment Directive).

I added the @ts-expect-error as a new pragma (and was going to add @ts-ignore too):

 "ts-expect-error": {
kind: PragmaKindFlags.AnySingleLine
}

And then I parse it in processCommentPragmas in parser.ts:

 iterateAllCommentRanges(sourceText, (range) => {
const comment = sourceText.substring(range.pos, range.end);
extractPragmas(pragmas, range, comment, PragmaKindFlags.AnySingleLine);
});

(iterateAllCommentRanges is a new function I added to scanner.ts)

While I couldn't find a formal definition of "pragmas" in programming languages, in some programming languages, a "pragma" can be in places other than just the top of the file (https://dlang.org/spec/pragma.html).

Here's my in progress diff: https://gist.github.com/davidgomes/5cb71342b6d2cf95ffa05a767eb802c7

rauschma · 2020-02-01T19:44:26Z

I’d love to have something more powerful:

//@ts-expect-error 2322 "Type 'number' is not assignable to type 'never'."

Maybe with the option to omit trailing characters of the message and/or the error number. The former could be achieved via regular expressions:

//@ts-expect-error 2322 /^Type 'number' is not assignable to type 'never'\.$/

Rationale: It’s not only a problem to expect errors where there aren’t any, but also to expect the wrong kind of error.

… ts-expect-error

orta · 2020-03-03T21:23:00Z

Re-running perf tests, I'm not really convinced this could add 7% after reading the PR

@typescript-bot perf test
@typescript-bot pack this

typescript-bot · 2020-03-03T21:23:02Z

Heya @orta, I've started to run the perf test suite on this PR at 7a5ef8a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2020-03-03T21:23:02Z

Heya @orta, I've started to run the tarball bundle task on this PR at 7a5ef8a. You can monitor the build here.

typescript-bot · 2020-03-03T21:38:50Z

Hey @orta, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/67018/artifacts?artifactName=tgz&fileId=5E21999D0FB04B583BB8D7FCD8E00648D55FEC3D17EA25E3229AC512A97BB1D902&fileName=/typescript-3.9.0-insiders.20200303.tgz"
}
}

and then running npm install.

There is also a playground for this build.

typescript-bot · 2020-03-03T22:17:18Z

@orta
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36014

_Metric	_master	₃₆₀₁₄	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{334,334k (± 0.05%)}	_{333,871k (± 0.02%)}	_{-463k (- 0.14%)}	_333,714k	_333,996k
_{Parse Time}	_{1.62s (± 0.61%)}	_{1.63s (± 0.64%)}	_{+0.01s (+ 0.62%)}	_1.62s	_1.66s
_{Bind Time}	_{0.89s (± 0.82%)}	_{0.89s (± 0.90%)}	_{+0.00s (+ 0.45%)}	_0.87s	_0.91s
_{Check Time}	_{4.70s (± 0.53%)}	_{4.73s (± 0.53%)}	_{+0.03s (+ 0.53%)}	_4.67s	_4.79s
_{Emit Time}	_{5.30s (± 0.48%)}	_{5.32s (± 1.12%)}	_{+0.03s (+ 0.49%)}	_5.22s	_5.46s
_{Total Time}	_{12.51s (± 0.28%)}	_{12.57s (± 0.54%)}	_{+0.07s (+ 0.52%)}	_12.42s	_12.75s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{335,259k (± 0.01%)}	_{335,293k (± 0.02%)}	_{+34k (+ 0.01%)}	_335,184k	_335,482k
_{Parse Time}	_{1.25s (± 0.82%)}	_{1.26s (± 0.49%)}	_{+0.01s (+ 0.64%)}	_1.25s	_1.28s
_{Bind Time}	_{0.78s (± 0.94%)}	_{0.78s (± 0.47%)}	_{-0.00s (- 0.26%)}	_0.77s	_0.78s
_{Check Time}	_{4.72s (± 0.64%)}	_{4.71s (± 0.41%)}	_{-0.00s (- 0.11%)}	_4.66s	_4.74s
_{Emit Time}	_{2.93s (± 0.71%)}	_{2.90s (± 0.52%)}	_{-0.03s (- 0.92%)}	_2.87s	_2.94s
_{Total Time}	_{9.67s (± 0.33%)}	_{9.64s (± 0.32%)}	_{-0.03s (- 0.27%)}	_9.58s	_9.72s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{299,484k (± 0.02%)}	_{299,513k (± 0.02%)}	_{+29k (+ 0.01%)}	_299,396k	_299,660k
_{Parse Time}	_{0.94s (± 0.59%)}	_{0.94s (± 0.63%)}	_{+0.00s (+ 0.32%)}	_0.93s	_0.96s
_{Bind Time}	_{0.74s (± 0.49%)}	_{0.75s (± 0.80%)}	_{+0.00s (+ 0.27%)}	_0.73s	_0.76s
_{Check Time}	_{4.27s (± 0.49%)}	_{4.25s (± 0.49%)}	_{-0.02s (- 0.52%)}	_4.20s	_4.28s
_{Emit Time}	_{3.03s (± 0.75%)}	_{3.03s (± 0.70%)}	_{+0.00s (+ 0.10%)}	_2.98s	_3.07s
_{Total Time}	_{8.99s (± 0.37%)}	_{8.97s (± 0.32%)}	_{-0.01s (- 0.13%)}	_8.93s	_9.04s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{488,881k (± 0.01%)}	_{488,611k (± 0.02%)}	_{-269k (- 0.06%)}	_488,423k	_488,854k
_{Parse Time}	_{1.77s (± 0.34%)}	_{1.78s (± 0.70%)}	_{+0.00s (+ 0.28%)}	_1.75s	_1.82s
_{Bind Time}	_{0.68s (± 0.76%)}	_{0.68s (± 0.50%)}	_{+0.00s (+ 0.29%)}	_0.68s	_0.69s
_{Check Time}	_{13.62s (± 0.93%)}	_{13.58s (± 0.86%)}	_{-0.04s (- 0.31%)}	_13.38s	_13.84s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.08s (± 0.81%)}	_{16.04s (± 0.78%)}	_{-0.03s (- 0.21%)}	_15.83s	_16.32s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{309,968k (± 0.14%)}	_{309,704k (± 0.02%)}	_{-264k (- 0.09%)}	_309,558k	_309,856k
_{Parse Time}	_{1.58s (± 0.53%)}	_{1.58s (± 0.39%)}	_{+0.00s (+ 0.13%)}	_1.57s	_1.60s
_{Bind Time}	_{0.87s (± 0.87%)}	_{0.87s (± 0.95%)}	_{+0.01s (+ 0.92%)}	_0.86s	_0.90s
_{Check Time}	_{4.62s (± 0.69%)}	_{4.62s (± 0.70%)}	_{+0.00s (+ 0.06%)}	_4.54s	_4.69s
_{Emit Time}	_{5.48s (± 1.25%)}	_{5.44s (± 0.83%)}	_{-0.03s (- 0.60%)}	_5.38s	_5.54s
_{Total Time}	_{12.54s (± 0.75%)}	_{12.52s (± 0.59%)}	_{-0.02s (- 0.17%)}	_12.40s	_12.69s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{315,184k (± 0.01%)}	_{315,263k (± 0.02%)}	_{+79k (+ 0.03%)}	_315,157k	_315,384k
_{Parse Time}	_{1.20s (± 0.40%)}	_{1.21s (± 0.62%)}	_{+0.01s (+ 0.91%)}	_1.19s	_1.22s
_{Bind Time}	_{0.74s (± 1.10%)}	_{0.75s (± 0.74%)}	_{+0.00s (+ 0.67%)}	_0.74s	_0.76s
_{Check Time}	_{4.55s (± 0.26%)}	_{4.57s (± 0.62%)}	_{+0.02s (+ 0.42%)}	_4.53s	_4.66s
_{Emit Time}	_{2.96s (± 0.72%)}	_{2.98s (± 0.87%)}	_{+0.02s (+ 0.57%)}	_2.92s	_3.03s
_{Total Time}	_{9.46s (± 0.28%)}	_{9.51s (± 0.51%)}	_{+0.05s (+ 0.58%)}	_9.39s	_9.63s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{281,780k (± 0.02%)}	_{281,741k (± 0.02%)}	_{-39k (- 0.01%)}	_281,586k	_281,833k
_{Parse Time}	_{0.92s (± 0.79%)}	_{0.93s (± 1.34%)}	_{+0.01s (+ 1.30%)}	_0.91s	_0.96s
_{Bind Time}	_{0.71s (± 0.97%)}	_{0.71s (± 0.84%)}	_{+0.00s (+ 0.14%)}	_0.69s	_0.72s
_{Check Time}	_{4.18s (± 0.72%)}	_{4.19s (± 0.48%)}	_{+0.01s (+ 0.33%)}	_4.15s	_4.24s
_{Emit Time}	_{3.08s (± 1.35%)}	_{3.08s (± 0.87%)}	_{-0.00s (- 0.13%)}	_3.01s	_3.13s
_{Total Time}	_{8.89s (± 0.57%)}	_{8.91s (± 0.46%)}	_{+0.03s (+ 0.30%)}	_8.83s	_9.00s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{466,312k (± 0.02%)}	_{466,106k (± 0.01%)}	_{-206k (- 0.04%)}	_466,003k	_466,237k
_{Parse Time}	_{1.74s (± 0.33%)}	_{1.75s (± 0.42%)}	_{+0.01s (+ 0.40%)}	_1.74s	_1.77s
_{Bind Time}	_{0.62s (± 0.95%)}	_{0.63s (± 0.54%)}	_{+0.00s (+ 0.48%)}	_0.62s	_0.63s
_{Check Time}	_{12.05s (± 0.54%)}	_{12.08s (± 0.82%)}	_{+0.03s (+ 0.23%)}	_11.89s	_12.25s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.41s (± 0.46%)}	_{14.45s (± 0.69%)}	_{+0.04s (+ 0.28%)}	_14.26s	_14.63s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{329,366k (± 0.01%)}	_{328,978k (± 0.01%)}	_{-387k (- 0.12%)}	_328,871k	_329,088k
_{Parse Time}	_{2.11s (± 0.32%)}	_{2.12s (± 1.18%)}	_{+0.01s (+ 0.66%)}	_2.09s	_2.21s
_{Bind Time}	_{0.92s (± 0.87%)}	_{0.93s (± 0.82%)}	_{+0.00s (+ 0.43%)}	_0.91s	_0.94s
_{Check Time}	_{5.51s (± 0.44%)}	_{5.51s (± 0.56%)}	_{-0.00s (- 0.09%)}	_5.44s	_5.59s
_{Emit Time}	_{6.23s (± 0.90%)}	_{6.27s (± 0.90%)}	_{+0.04s (+ 0.63%)}	_6.17s	_6.44s
_{Total Time}	_{14.78s (± 0.43%)}	_{14.82s (± 0.52%)}	_{+0.05s (+ 0.33%)}	_14.67s	_15.05s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{333,576k (± 0.02%)}	_{333,611k (± 0.01%)}	_{+35k (+ 0.01%)}	_333,550k	_333,687k
_{Parse Time}	_{1.54s (± 0.66%)}	_{1.54s (± 0.38%)}	_{+0.01s (+ 0.52%)}	_1.53s	_1.56s
_{Bind Time}	_{0.90s (± 0.66%)}	_{0.91s (± 1.27%)}	_{+0.01s (+ 1.23%)}	_0.88s	_0.93s
_{Check Time}	_{5.40s (± 0.60%)}	_{5.37s (± 0.73%)}	_{-0.03s (- 0.56%)}	_5.25s	_5.44s
_{Emit Time}	_{3.55s (± 0.56%)}	_{3.55s (± 0.65%)}	_{+0.01s (+ 0.14%)}	_3.49s	_3.60s
_{Total Time}	_{11.38s (± 0.36%)}	_{11.37s (± 0.44%)}	_{-0.01s (- 0.08%)}	_11.23s	_11.44s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{298,881k (± 0.02%)}	_{298,919k (± 0.02%)}	_{+38k (+ 0.01%)}	_298,834k	_299,038k
_{Parse Time}	_{1.25s (± 0.53%)}	_{1.25s (± 0.27%)}	_{0.00s ( 0.00%)}	_1.25s	_1.26s
_{Bind Time}	_{0.75s (± 0.69%)}	_{0.75s (± 1.29%)}	_{0.00s ( 0.00%)}	_0.74s	_0.78s
_{Check Time}	_{4.83s (± 1.44%)}	_{4.87s (± 1.67%)}	_{+0.05s (+ 0.95%)}	_4.75s	_5.12s
_{Emit Time}	_{3.34s (± 1.92%)}	_{3.29s (± 2.39%)}	_{-0.05s (- 1.53%)}	_3.04s	_3.40s
_{Total Time}	_{10.17s (± 0.32%)}	_{10.16s (± 0.51%)}	_{-0.01s (- 0.08%)}	_10.04s	_10.28s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{494,722k (± 0.01%)}	_{494,521k (± 0.01%)}	_{-201k (- 0.04%)}	_494,404k	_494,650k
_{Parse Time}	_{2.11s (± 0.53%)}	_{2.11s (± 0.77%)}	_{+0.00s (+ 0.24%)}	_2.09s	_2.16s
_{Bind Time}	_{0.82s (± 1.35%)}	_{0.82s (± 1.02%)}	_{-0.00s (- 0.24%)}	_0.80s	_0.83s
_{Check Time}	_{19.54s (± 0.47%)}	_{19.58s (± 0.77%)}	_{+0.05s (+ 0.24%)}	_19.28s	_19.95s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.46s (± 0.47%)}	_{22.51s (± 0.65%)}	_{+0.05s (+ 0.24%)}	_22.22s	_22.88s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{188,954k (± 0.03%)}	_{188,755k (± 0.03%)}	_{-199k (- 0.11%)}	_188,624k	_188,855k
_{Parse Time}	_{2.05s (± 0.77%)}	_{2.06s (± 0.67%)}	_{+0.01s (+ 0.34%)}	_2.03s	_2.10s
_{Bind Time}	_{1.07s (± 1.10%)}	_{1.07s (± 0.93%)}	_{+0.00s (+ 0.37%)}	_1.06s	_1.09s
_{Check Time}	_{5.07s (± 0.95%)}	_{5.02s (± 0.55%)}	_{-0.05s (- 0.91%)}	_4.97s	_5.11s
_{Emit Time}	_{6.19s (± 1.27%)}	_{6.15s (± 0.86%)}	_{-0.04s (- 0.69%)}	_5.99s	_6.25s
_{Total Time}	_{14.38s (± 0.92%)}	_{14.30s (± 0.48%)}	_{-0.08s (- 0.52%)}	_14.12s	_14.44s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{189,214k (± 0.02%)}	_{189,263k (± 0.03%)}	_{+49k (+ 0.03%)}	_189,113k	_189,383k
_{Parse Time}	_{1.58s (± 0.99%)}	_{1.59s (± 0.41%)}	_{+0.00s (+ 0.25%)}	_1.58s	_1.61s
_{Bind Time}	_{0.77s (± 0.87%)}	_{0.77s (± 0.72%)}	_{+0.00s (+ 0.13%)}	_0.76s	_0.78s
_{Check Time}	_{5.35s (± 1.51%)}	_{5.39s (± 1.28%)}	_{+0.03s (+ 0.64%)}	_5.20s	_5.47s
_{Emit Time}	_{3.01s (± 3.38%)}	_{2.97s (± 3.07%)}	_{-0.04s (- 1.30%)}	_2.84s	_3.22s
_{Total Time}	_{10.71s (± 0.33%)}	_{10.71s (± 0.41%)}	_{-0.00s (- 0.01%)}	_10.61s	_10.79s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{170,430k (± 0.02%)}	_{170,441k (± 0.03%)}	_{+11k (+ 0.01%)}	_170,334k	_170,531k
_{Parse Time}	_{1.28s (± 0.73%)}	_{1.28s (± 0.83%)}	_{+0.00s (+ 0.31%)}	_1.27s	_1.32s
_{Bind Time}	_{0.72s (± 0.77%)}	_{0.72s (± 1.17%)}	_{+0.00s (+ 0.14%)}	_0.70s	_0.74s
_{Check Time}	_{4.62s (± 1.13%)}	_{4.60s (± 0.65%)}	_{-0.02s (- 0.37%)}	_4.52s	_4.66s
_{Emit Time}	_{2.99s (± 1.87%)}	_{3.01s (± 1.57%)}	_{+0.02s (+ 0.80%)}	_2.96s	_3.19s
_{Total Time}	_{9.61s (± 0.58%)}	_{9.62s (± 0.37%)}	_{+0.01s (+ 0.10%)}	_9.56s	_9.74s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{277,168k (± 0.02%)}	_{277,026k (± 0.01%)}	_{-142k (- 0.05%)}	_276,958k	_277,079k
_{Parse Time}	_{2.17s (± 0.38%)}	_{2.17s (± 0.59%)}	_{+0.00s (+ 0.00%)}	_2.15s	_2.20s
_{Bind Time}	_{0.69s (± 1.16%)}	_{0.69s (± 0.75%)}	_{+0.00s (+ 0.15%)}	_0.68s	_0.70s
_{Check Time}	_{17.72s (± 0.80%)}	_{17.57s (± 0.43%)}	_{-0.15s (- 0.85%)}	_17.43s	_17.74s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{20.58s (± 0.69%)}	_{20.44s (± 0.37%)}	_{-0.15s (- 0.71%)}	_20.30s	_20.59s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₆₀₁₄	₁₀
_Baseline	_master	₁₀

orta · 2020-03-04T14:12:49Z

These numbers make more sense to me - basically everything is varying in the 0.x range on a plus or minus which is basically just normal noise in perf tests.

orta

Looks good, happy to merge based on your answer to the my comment above

ExE-Boss · 2020-03-04T21:27:34Z

This would make it possible to deprecate $ExpectError in dtslint.

It would also reduce noise in IDEs, as $ExpectError still results in the error being shown in the IDE.

orta · 2020-03-05T15:37:26Z

OK, this looks good to go - thanks!

I don't know if it's in TypeScript, or in vscode, but we should also get // @ts-expect-error to show up in the autocomplete in comments too, but I'm good for that to be another PR.

The playground doesn't show any of those options.

JoshuaKGoldberg · 2020-03-05T16:09:31Z

👍 It's in vscode, in a list of directives: microsoft/vscode#92093

eps1lon · 2020-03-05T17:01:46Z

I love this! Does this mean we can use @ts-expect instead of the tslint expect rule and $ExpectError?

orta · 2020-03-05T18:08:50Z

I think so, yep

tmillr · 2020-08-25T10:06:04Z

As someone else already mentioned, I second that it would be nice to be able to specify exactly what error to expect (by its id/code etc). I've only used ts-ignore a few times but have already ran into the problem where I think I'm ignoring one error just to have it transform into another completely unrelated error however, unknowingly, since this transformation happened in "the meantime" while the ts-ignore directive was still active/in-place the whole time. So the new error that the old error "transformed into" went completely unnoticed from what I remember (until I removed the directive of course, which was when I found out about the change). Now I try to just avoid ts-ignore altogether because of such potential situations that may arise because it's just not worth taking that kind of a risk imo.

asktree · 2021-04-05T19:00:23Z

related to @Tyler1205 's comment I would like to be able to specify number of errors, and that might be easier to handle.

Asaf-S · 2021-07-05T07:40:26Z

related to @Tyler1205 's comment I would like to be able to specify number of errors, and that might be easier to handle.

I agree, this is really needed as you can never know if you are blocking more than 1 error, or the wrong kind of error

JoshuaKGoldberg force-pushed the ts-expect-error branch from 152655c to 9918231Compare January 5, 2020 20:47

JoshuaKGoldberg force-pushed the ts-expect-error branch from 9918231 to eb5610aCompare January 5, 2020 20:48

JoshuaKGoldberg mentioned this pull request Jan 25, 2020
Possibility of writing "no-useless-ts-ignore-comments" rule typescript-eslint/typescript-eslint#236
Closed

sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 3, 2020

Merge branch 'master' ofhttps://github.com/microsoft/TypeScriptinto…
7a5ef8a
… ts-expect-error

orta approved these changes Mar 4, 2020
View reviewed changes

Comment threadsrc/compiler/program.ts Outdated

JoshuaKGoldberg requested a review from orta March 4, 2020 22:25

JoshuaKGoldberg added 2 commits March 5, 2020 10:06

Renamed to getDiagnosticsWithPrecedingDirectives per suggestion
6290212

Added JSDoc comment I thought I did already
88b0f89

orta merged commit ffde923 into microsoft:masterMar 5, 2020

orta added the Update Docs on Next Release Indicates that this PR affects docs label Mar 5, 2020

JoshuaKGoldberg deleted the ts-expect-error branch March 5, 2020 15:45

JoshuaKGoldberg mentioned this pull request Mar 5, 2020
Added completion entry for @ts-expect-error directive microsoft/vscode#92093
Merged

eps1lon mentioned this pull request Mar 5, 2020
Migrate from tslint to eslint mui/material-ui#19413
Closed

This was referenced Mar 5, 2020
TS 3.9+ should suggest @ts-expect-error directives microsoft/vscode#92116
Closed
[ban-ts-comment] // @ts-expect-error should be recognized typescript-eslint/typescript-eslint#1709
Closed

IllusionMH mentioned this pull request Mar 14, 2020
Invalidate unnecessary 'as any' and '@ts-ignore' #37391
Closed

jtbandes mentioned this pull request Mar 15, 2021
/* eslint-expect-error */ — continuous verification of eslint config eslint/eslint#14212
Closed

github-actionsBot mentioned this pull request Aug 14, 2022
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164
Merged

mrazauskas mentioned this pull request Jun 4, 2025
docs: rename "directive comments" to "comment directives" typescript-eslint/typescript-eslint#11268
Merged
3 tasks

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Uh oh!

Conversation

JoshuaKGoldberg commented Jan 5, 2020

Uh oh!

orta commented Jan 17, 2020

Uh oh!

typescript-bot commented Jan 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 17, 2020

Uh oh!

JoshuaKGoldberg commented Jan 26, 2020

Uh oh!

davidgomes commented Jan 27, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rauschma commented Feb 1, 2020

Uh oh!

orta commented Mar 3, 2020

Uh oh!

typescript-bot commented Mar 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 3, 2020

Uh oh!

orta commented Mar 4, 2020

Uh oh!

orta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ExE-Boss commented Mar 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orta commented Mar 5, 2020

Uh oh!

JoshuaKGoldberg commented Mar 5, 2020

Uh oh!

eps1lon commented Mar 5, 2020

Uh oh!

orta commented Mar 5, 2020

Uh oh!

tmillr commented Aug 25, 2020

Uh oh!

asktree commented Apr 5, 2021

Uh oh!

Asaf-S commented Jul 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

typescript-bot commented Jan 17, 2020•
edited
Loading

typescript-bot commented Jan 17, 2020•
edited
Loading

davidgomes commented Jan 27, 2020•
edited
Loading

typescript-bot commented Mar 3, 2020•
edited
Loading

typescript-bot commented Mar 3, 2020•
edited
Loading

typescript-bot commented Mar 3, 2020•
edited
Loading

ExE-Boss commented Mar 4, 2020•
edited
Loading