Skip to content

No template refactor on plain strings - #36785

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 3 commits into
masterfrom
noTemplateRefactorOnPlainStrings
Feb 13, 2020
Merged

No template refactor on plain strings#36785
Daniel Rosenwasser (DanielRosenwasser) merged 3 commits into
masterfrom
noTemplateRefactorOnPlainStrings

Conversation

@DanielRosenwasser

Copy link
Copy Markdown
Member

Fixes#36784

@DanielRosenwasser

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick this to release-3.8

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #36786 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 13, 2020
Component commits:
206d39e Add/convert to failing tests.
11e827b Stop offering to convert single string literals to template expressions.
7d3ad0c Ensure we're actually testing for single quotes.
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the noTemplateRefactorOnPlainStrings branch February 13, 2020 20:22
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Feb 13, 2020
Component commits:
206d39e Add/convert to failing tests.
11e827b Stop offering to convert single string literals to template expressions.
7d3ad0c Ensure we're actually testing for single quotes.
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't offer Convert to template string refactoring for simple strings

3 participants

@DanielRosenwasser@typescript-bot@sheetalkamat