Skip to content

Handle getScriptVersion correctly to ensure program structure is checked correctly - #36808

Merged
Sheetal Nandi (sheetalkamat) merged 6 commits into
masterfrom
isUptoDate
Feb 26, 2020
Merged

Handle getScriptVersion correctly to ensure program structure is checked correctly#36808
Sheetal Nandi (sheetalkamat) merged 6 commits into
masterfrom
isUptoDate

Conversation

@sheetalkamat

@sheetalkamatSheetal Nandi (sheetalkamat) commented Feb 14, 2020

Copy link
Copy Markdown
Member

Fixes#36748

@sheetalkamat
Fix tests when there are project references but has disableSourceOfPr…
4382d1c
…ojectReferenceRedirect
@sheetalkamat
Handle getScriptVersion correctly to ensure program structure is chec…
0952bf7
…ked correctly
Fixes#36748
@sheetalkamat
Harness's language service host doesnt have getProjectVersion.
d5e5b79
This means earlier we were creating fresh program everytime we did LS operation
Now we reuse same program, so quick info depends on order of quickinfo demands
@sheetalkamat
Because same program is used, it unvails a bug that if export= is e…
05ccdcf
…valuated before finding references, it cant find all definitions from the merge
sandersn
Nathan Shively-Sanders (sandersn) reviewed Feb 19, 2020
View reviewed changes

@sandersnNathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context to understand this change. From the bug, it sounds like the fix applies to language service API users. Does it affect our usage of the language service too?

Comment threadsrc/server/editorServices.ts Outdated
Comment threadsrc/server/editorServices.ts
Comment threadsrc/server/project.ts Outdated
Comment threadsrc/server/scriptInfo.ts
Comment threadtests/cases/fourslash/findAllRefs_importType_js.ts
sandersn
Nathan Shively-Sanders (sandersn) reviewed Feb 19, 2020
View reviewed changes
Comment threadtests/cases/fourslash/findAllRefs_importType_js.ts
@sheetalkamat@sandersn
Update src/server/project.ts
5de007c
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@sheetalkamat
Make clearSourceMapperCache required
252ba7f
@sheetalkamatSheetal Nandi (sheetalkamat) mentioned this pull request Feb 24, 2020
Closed
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Feb 24, 2020

Copy link
Copy Markdown
MemberAuthor

Nathan Shively-Sanders (@sandersn) have resolved all the comments.. Please take a look.. thanks

@jakebaileyJake Bailey (jakebailey) mentioned this pull request Jul 11, 2023
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn approved these changes
@amcaseyAndrew Casey (amcasey)Awaiting requested review from amcasey
@andrewbranchAndrew Branch (andrewbranch)Awaiting requested review from andrewbranch
@elibarzilayEli Barzilay (elibarzilay)Awaiting requested review from elibarzilay
@ortaOrta Therox (orta)Awaiting requested review from orta
@rbucktonRon Buckton (rbuckton)Awaiting requested review from rbuckton
@RyanCavanaughRyan Cavanaugh (RyanCavanaugh)Awaiting requested review from RyanCavanaugh
@weswighamWesley Wigham (weswigham)Awaiting requested review from weswigham

Assignees

@sandersnNathan Shively-Sanders (sandersn)

@sheetalkamatSheetal Nandi (sheetalkamat)

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isProgramUpToDate reports false because it expects HostCache to include typescript/lib/*.d.ts files

3 participants

@sheetalkamat@sandersn@typescript-bot