Uh oh!
There was an error while loading. Please reload this page.
Make processTaggedTemplateExpression visit a returned node - #38596
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Wenlu Wang (Kingwl)
approved these changes
May 15, 2020
Wenlu Wang (Kingwl)
left a comment
Contributor
There was a problem hiding this comment.
Sorry, my bad.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
May 15, 2020
This problem was introduced in 70399e1 (from PR microsoft#23801), which added a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`, before that, it would fallback to the default of `visitNode`. So re-add that happen in `processTaggedTemplateExpression`. Since it doesn't hurt, I left a `Debug.checkDefined(property.name)` instead of `!`-ing it. Fixesmicrosoft#38558.
Eli Barzilay (elibarzilay)force-pushed
the
38558
branch
from
May 15, 2020 21:58
f8d63fb to
ea1e0abCompareRon Buckton (rbuckton)
approved these changes
May 15, 2020
Elias Junior (eliasjnior)
commented
May 18, 2020
I could run with |
Andrei (dandrei)
commented
May 21, 2020
Elias Junior (@eliasjnior) that's because the problem didn't exist in |
Eli Barzilay (elibarzilay)
commented
May 21, 2020
ContributorAuthor
Andrei (@dandrei): this is most likely a different problem -- #38383 (which I couldn't reproduce). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem was introduced in 70399e1 (from PR #23801), which added
a
visitTaggedTemplateExpressioncase forTaggedTemplateExpression,before that, it would fallback to the default of
visitNode. So re-addthat happen in
processTaggedTemplateExpression.Since it doesn't hurt, I left a
Debug.checkDefined(property.name)instead of
!-ing it.Fixes#38558.