Uh oh!
There was an error while loading. Please reload this page.
Make hasCorrectArity handle tuples properly - #38795
Conversation
Ryan Cavanaugh (RyanCavanaugh)
commented
May 27, 2020
TypeScript Bot (@typescript-bot) test this |
Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 3d08da4. You can monitor the build here. |
Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the parallelized community code test suite on this PR at 3d08da4. You can monitor the build here. |
TypeScript Bot (typescript-bot)
commented
May 27, 2020
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
This completes the work that started in PR microsoft#33069, and fixesmicrosoft#32835. There are probably two additional related changes that are needed to make this more complete: * Fix the code that composes the error message (see the first two `FIXME`s in `callWithSpread3.ts`). * Fix the code that checks the argument types (second two `FIXME`s). * There is also an error in `genericRestParameters1.ts` which changed but should not be an error in the first place. Added a `FIXME` there too. (Probably will work if the previous iterm is done.) In addition, `getEffectiveCallArguments` munges the arguments in case of a spread in the last argument which might be better to avoid. (I think that there are cases where it wouldn't work anyway, such as a spread of an array followed by a spread of an empty array.)
3d08da4 to
f505150CompareEli Barzilay (elibarzilay)
commented
May 27, 2020
(After this is merged, there should be two new issues for the |
Nathan Shively-Sanders (sandersn)
commented
Jun 2, 2020
I just looked at the user test failures and there's nothing new there. |
Nathan Shively-Sanders (sandersn)
commented
Jun 9, 2020
Nothing in the RWC failures either. |
This completes the work that started in PR #33069, and fixes#32835.
(Includes that PR in a separate commit.)
There are probably two additional related changes that are needed to
make this more complete:
Fix the code that composes the error message (see the first two
FIXMEs incallWithSpread3.ts).Fix the code that checks the argument types (second two
FIXMEs).There is also an error in
genericRestParameters1.tswhich changedbut should not be an error in the first place. Added a
FIXMEtheretoo. (Probably will work if the previous iterm is done.)
In addition,
getEffectiveCallArgumentsmunges the arguments in case ofa spread in the last argument which might be better to avoid. (I think
that there are cases where it wouldn't work anyway, such as a spread of
an array followed by a spread of an empty array.)