Uh oh!
There was an error while loading. Please reload this page.
Fix isSameEntityName - #38999
Merged
Andrew Branch (andrewbranch) merged 3 commits intoJun 10, 2020
Merged
Conversation
Andrew Branch (andrewbranch)
requested a review
from Nathan Shively-Sanders (sandersn)June 9, 2020 22:55
Andrew Branch (andrewbranch)
commented
Jun 9, 2020
MemberAuthor
A tangential point is that the logic I meant probably doesn’t make sense for |
Sheetal Nandi (sheetalkamat)
approved these changes
Jun 9, 2020
Andrew Branch (andrewbranch)force-pushed
the
bug/38412
branch
from
June 9, 2020 23:16
1f9e9ae to
4141c14CompareAndrew Branch (andrewbranch)
commented
Jun 9, 2020
MemberAuthor
The failing test is failing on master. |
Nathan Shively-Sanders (sandersn)
approved these changes
Jun 10, 2020
AllenLee (cangSDARM) added a commit
to cangSDARM/TypeScript
that referenced
this pull request
Jun 15, 2020
* upstream/master: (22 commits) Small fix in `getIsContextSensitiveAssignmentOrContextType` Simplify `visitObjectLiteralExpression` Fix handling of `aruments` in the emitter Fix declaration emit for property references of imported object literal types (microsoft#39055) Fix casing for wild card keys for implicit globs to get wild card directories to watch (microsoft#39049) DOM update 2020-06-12 fix(a11y): make ISSUE_TEMPLATE/Bug_report.md more accessible for folks with screen readers (microsoft#39013) Update request-pr-review script to latest version of octokit (microsoft#39031) pin version of octokit skip implements types with no symbols isDynamicName skips parentheses for element access Allow `e: unknown` in `catch` arguments Serialize (noncontextual) keyword named namespace members with export declarations in both declaration emitters (microsoft#38982) Patch to use this.timeout() > 0 rather than this.enableTimeout() to work with mocha 8+ Handle missing return type nodes and nested type references missing type arguments in existing jsdoc node serialization (microsoft#39011) Add containerName to CallHierarchyItem (microsoft#38997) Fix isSameEntityName (microsoft#38999) Fix typo for 'blocklist' (microsoft#39001) remove errant tab Switch to isSymbolAccessible for both. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#38412
I misrefactored this utility function 8 months ago, resulting in the JS
being interpreted more like
when trying to decide if
rollupMoment__defaultis ever referenced. In JS, we don’t count these kinds of conditional assignment as a usage, so it appeared thatrollupMoment__defaultwas never used at all, causing the import to be elided.