Add error for missing await in conditionals by Jack-Works · Pull Request #39175 · microsoft/TypeScript

Jack Works (Jack-Works) · 2020-06-20T08:29:11Z

Daniel Rosenwasser (DanielRosenwasser) · 2020-06-22T20:40:43Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test dt
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2020-06-22T20:40:47Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at 49ee464. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-06-22T20:40:47Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 49ee464. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2020-06-22T20:40:47Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at 49ee464. You can monitor the build here.

Daniel Rosenwasser (DanielRosenwasser) · 2020-06-22T20:43:42Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2020-06-22T20:43:45Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at 49ee464. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-06-22T21:00:38Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/77391/artifacts?artifactName=tgz&fileId=064113E0A813A04752FE56147E7B13F436B18C253E6A75A293CFF3415CFC69B702&fileName=/typescript-4.0.0-insiders.20200622.tgz"
}
}

and then running npm install.

There is also a playground for this build.

TypeScript Bot (typescript-bot) · 2020-06-22T21:04:58Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

TypeScript Bot (typescript-bot) · 2020-06-22T21:24:24Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39175

_Metric	_master	₃₉₁₇₅	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{340,391k (± 0.01%)}	_{339,886k (± 0.02%)}	_{-504k (- 0.15%)}	_339,764k	_340,023k
_{Parse Time}	_{1.99s (± 0.62%)}	_{1.98s (± 0.73%)}	_{-0.01s (- 0.60%)}	_1.96s	_2.01s
_{Bind Time}	_{0.80s (± 0.74%)}	_{0.80s (± 0.73%)}	_{-0.01s (- 0.87%)}	_0.79s	_0.81s
_{Check Time}	_{4.74s (± 0.35%)}	_{4.69s (± 0.58%)}	_{-0.05s (- 1.01%)}	_4.64s	_4.76s
_{Emit Time}	_{5.22s (± 0.56%)}	_{5.18s (± 0.77%)}	_{-0.04s (- 0.73%)}	_5.08s	_5.28s
_{Total Time}	_{12.75s (± 0.34%)}	_{12.64s (± 0.62%)}	_{-0.10s (- 0.82%)}	_12.48s	_12.84s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{338,891k (± 0.01%)}	_{338,944k (± 0.02%)}	_{+54k (+ 0.02%)}	_338,811k	_339,119k
_{Parse Time}	_{1.57s (± 0.77%)}	_{1.59s (± 0.51%)}	_{+0.01s (+ 0.83%)}	_1.57s	_1.60s
_{Bind Time}	_{0.70s (± 0.71%)}	_{0.70s (± 0.74%)}	_{+0.00s (+ 0.43%)}	_0.69s	_0.71s
_{Check Time}	_{4.86s (± 0.49%)}	_{4.86s (± 0.33%)}	_{+0.00s (+ 0.08%)}	_4.82s	_4.90s
_{Emit Time}	_{2.75s (± 0.84%)}	_{2.76s (± 0.81%)}	_{+0.01s (+ 0.36%)}	_2.71s	_2.81s
_{Total Time}	_{9.88s (± 0.37%)}	_{9.91s (± 0.28%)}	_{+0.03s (+ 0.29%)}	_9.85s	_9.97s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{301,843k (± 0.02%)}	_{301,912k (± 0.03%)}	_{+69k (+ 0.02%)}	_301,735k	_302,050k
_{Parse Time}	_{1.21s (± 0.58%)}	_{1.21s (± 0.51%)}	_{0.00s ( 0.00%)}	_1.20s	_1.23s
_{Bind Time}	_{0.64s (± 0.92%)}	_{0.66s (± 0.76%)}	_{+0.01s (+ 1.71%)}	_0.64s	_0.66s
_{Check Time}	_{4.35s (± 0.56%)}	_{4.37s (± 0.53%)}	_{+0.02s (+ 0.44%)}	_4.31s	_4.42s
_{Emit Time}	_{2.86s (± 1.35%)}	_{2.89s (± 1.17%)}	_{+0.02s (+ 0.84%)}	_2.82s	_2.98s
_{Total Time}	_{9.07s (± 0.62%)}	_{9.13s (± 0.47%)}	_{+0.06s (+ 0.62%)}	_9.05s	_9.24s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{459,543k (± 0.02%)}	_{459,200k (± 0.01%)}	_{-343k (- 0.07%)}	_459,133k	_459,293k
_{Parse Time}	_{2.05s (± 0.76%)}	_{2.04s (± 0.54%)}	_{-0.01s (- 0.44%)}	_2.01s	_2.06s
_{Bind Time}	_{0.66s (± 1.43%)}	_{0.66s (± 1.24%)}	_{+0.00s (+ 0.00%)}	_0.64s	_0.67s
_{Check Time}	_{12.82s (± 0.62%)}	_{12.85s (± 0.66%)}	_{+0.03s (+ 0.22%)}	_12.71s	_13.08s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.52s (± 0.57%)}	_{15.54s (± 0.59%)}	_{+0.02s (+ 0.15%)}	_15.39s	_15.80s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{317,804k (± 0.03%)}	_{317,179k (± 0.09%)}	_{-626k (- 0.20%)}	_316,000k	_317,459k
_{Parse Time}	_{1.96s (± 0.78%)}	_{1.95s (± 0.62%)}	_{-0.01s (- 0.71%)}	_1.92s	_1.98s
_{Bind Time}	_{0.78s (± 0.60%)}	_{0.78s (± 1.46%)}	_{+0.00s (+ 0.26%)}	_0.77s	_0.81s
_{Check Time}	_{4.61s (± 0.56%)}	_{4.59s (± 0.74%)}	_{-0.02s (- 0.35%)}	_4.53s	_4.70s
_{Emit Time}	_{5.34s (± 0.48%)}	_{5.38s (± 1.58%)}	_{+0.04s (+ 0.81%)}	_5.29s	_5.68s
_{Total Time}	_{12.69s (± 0.37%)}	_{12.71s (± 0.80%)}	_{+0.02s (+ 0.13%)}	_12.55s	_12.97s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{321,481k (± 0.02%)}	_{321,460k (± 0.01%)}	_{-21k (- 0.01%)}	_321,349k	_321,554k
_{Parse Time}	_{1.54s (± 0.94%)}	_{1.54s (± 1.22%)}	_{+0.01s (+ 0.39%)}	_1.52s	_1.59s
_{Bind Time}	_{0.68s (± 1.70%)}	_{0.68s (± 0.98%)}	_{+0.00s (+ 0.44%)}	_0.67s	_0.70s
_{Check Time}	_{4.65s (± 0.60%)}	_{4.66s (± 0.49%)}	_{+0.02s (+ 0.39%)}	_4.61s	_4.72s
_{Emit Time}	_{2.79s (± 0.82%)}	_{2.81s (± 0.77%)}	_{+0.01s (+ 0.54%)}	_2.77s	_2.88s
_{Total Time}	_{9.66s (± 0.56%)}	_{9.70s (± 0.50%)}	_{+0.04s (+ 0.43%)}	_9.61s	_9.86s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{286,349k (± 0.03%)}	_{286,369k (± 0.02%)}	_{+20k (+ 0.01%)}	_286,223k	_286,512k
_{Parse Time}	_{1.23s (± 0.94%)}	_{1.23s (± 0.61%)}	_{-0.00s (- 0.08%)}	_1.22s	_1.25s
_{Bind Time}	_{0.63s (± 1.09%)}	_{0.63s (± 1.50%)}	_{+0.00s (+ 0.16%)}	_0.61s	_0.65s
_{Check Time}	_{4.27s (± 0.35%)}	_{4.28s (± 0.57%)}	_{+0.01s (+ 0.21%)}	_4.22s	_4.33s
_{Emit Time}	_{2.93s (± 0.88%)}	_{2.93s (± 0.86%)}	_{-0.00s (- 0.07%)}	_2.89s	_3.01s
_{Total Time}	_{9.06s (± 0.33%)}	_{9.07s (± 0.39%)}	_{+0.01s (+ 0.07%)}	_8.97s	_9.15s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{437,981k (± 0.02%)}	_{437,600k (± 0.06%)}	_{-381k (- 0.09%)}	_436,582k	_437,800k
_{Parse Time}	_{2.02s (± 0.52%)}	_{2.02s (± 0.72%)}	_{+0.01s (+ 0.30%)}	_1.99s	_2.06s
_{Bind Time}	_{0.63s (± 0.75%)}	_{0.63s (± 1.11%)}	_{-0.00s (- 0.63%)}	_0.61s	_0.64s
_{Check Time}	_{11.46s (± 0.61%)}	_{11.63s (± 0.93%)}	_{+0.17s (+ 1.45%)}	_11.41s	_11.81s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.11s (± 0.48%)}	_{14.28s (± 0.79%)}	_{+0.17s (+ 1.19%)}	_14.05s	_14.45s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{336,794k (± 0.01%)}	_{336,488k (± 0.02%)}	_{-306k (- 0.09%)}	_336,364k	_336,615k
_{Parse Time}	_{2.50s (± 0.53%)}	_{2.50s (± 0.47%)}	_{+0.01s (+ 0.20%)}	_2.47s	_2.52s
_{Bind Time}	_{0.83s (± 0.36%)}	_{0.82s (± 0.45%)}	_{-0.00s (- 0.36%)}	_0.82s	_0.83s
_{Check Time}	_{5.30s (± 0.57%)}	_{5.34s (± 0.58%)}	_{+0.03s (+ 0.62%)}	_5.29s	_5.43s
_{Emit Time}	_{5.86s (± 1.37%)}	_{5.91s (± 0.74%)}	_{+0.05s (+ 0.77%)}	_5.79s	_6.03s
_{Total Time}	_{14.49s (± 0.74%)}	_{14.57s (± 0.44%)}	_{+0.08s (+ 0.53%)}	_14.43s	_14.72s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{340,278k (± 0.02%)}	_{340,268k (± 0.01%)}	_{-10k (- 0.00%)}	_340,143k	_340,322k
_{Parse Time}	_{1.87s (± 0.48%)}	_{1.86s (± 0.45%)}	_{-0.00s (- 0.05%)}	_1.85s	_1.89s
_{Bind Time}	_{0.87s (± 0.55%)}	_{0.87s (± 0.42%)}	_{-0.00s (- 0.12%)}	_0.86s	_0.87s
_{Check Time}	_{5.36s (± 0.67%)}	_{5.36s (± 0.67%)}	_{+0.00s (+ 0.02%)}	_5.30s	_5.47s
_{Emit Time}	_{3.22s (± 0.57%)}	_{3.24s (± 0.82%)}	_{+0.01s (+ 0.34%)}	_3.18s	_3.31s
_{Total Time}	_{11.31s (± 0.41%)}	_{11.32s (± 0.58%)}	_{+0.01s (+ 0.08%)}	_11.19s	_11.52s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{303,621k (± 0.01%)}	_{303,595k (± 0.02%)}	_{-27k (- 0.01%)}	_303,461k	_303,713k
_{Parse Time}	_{1.53s (± 0.69%)}	_{1.53s (± 0.50%)}	_{+0.00s (+ 0.07%)}	_1.52s	_1.55s
_{Bind Time}	_{0.65s (± 0.85%)}	_{0.65s (± 1.02%)}	_{+0.00s (+ 0.15%)}	_0.64s	_0.67s
_{Check Time}	_{4.94s (± 1.65%)}	_{4.94s (± 1.44%)}	_{+0.00s (+ 0.02%)}	_4.81s	_5.13s
_{Emit Time}	_{3.08s (± 3.17%)}	_{3.12s (± 2.07%)}	_{+0.04s (+ 1.43%)}	_2.95s	_3.19s
_{Total Time}	_{10.20s (± 0.61%)}	_{10.25s (± 0.35%)}	_{+0.05s (+ 0.46%)}	_10.13s	_10.31s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{463,645k (± 0.02%)}	_{463,368k (± 0.01%)}	_{-277k (- 0.06%)}	_463,244k	_463,507k
_{Parse Time}	_{2.37s (± 0.55%)}	_{2.38s (± 0.25%)}	_{+0.00s (+ 0.08%)}	_2.36s	_2.39s
_{Bind Time}	_{0.78s (± 1.15%)}	_{0.77s (± 0.76%)}	_{-0.01s (- 1.16%)}	_0.76s	_0.78s
_{Check Time}	_{16.96s (± 0.67%)}	_{16.94s (± 0.96%)}	_{-0.01s (- 0.06%)}	_16.49s	_17.18s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{20.10s (± 0.58%)}	_{20.09s (± 0.80%)}	_{-0.02s (- 0.08%)}	_19.64s	_20.31s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{193,334k (± 0.02%)}	_{193,147k (± 0.01%)}	_{-187k (- 0.10%)}	_193,075k	_193,190k
_{Parse Time}	_{2.43s (± 0.63%)}	_{2.43s (± 1.08%)}	_{+0.00s (+ 0.16%)}	_2.37s	_2.48s
_{Bind Time}	_{0.98s (± 0.78%)}	_{0.97s (± 0.57%)}	_{-0.00s (- 0.31%)}	_0.96s	_0.98s
_{Check Time}	_{4.79s (± 0.44%)}	_{4.78s (± 0.58%)}	_{-0.01s (- 0.21%)}	_4.73s	_4.84s
_{Emit Time}	_{5.91s (± 0.88%)}	_{5.94s (± 0.43%)}	_{+0.03s (+ 0.52%)}	_5.90s	_6.01s
_{Total Time}	_{14.11s (± 0.54%)}	_{14.12s (± 0.39%)}	_{+0.02s (+ 0.13%)}	_14.02s	_14.27s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{193,294k (± 0.02%)}	_{193,280k (± 0.02%)}	_{-14k (- 0.01%)}	_193,209k	_193,358k
_{Parse Time}	_{1.92s (± 1.37%)}	_{1.90s (± 0.40%)}	_{-0.02s (- 1.25%)}	_1.88s	_1.91s
_{Bind Time}	_{0.68s (± 1.21%)}	_{0.68s (± 0.76%)}	_{-0.00s (- 0.44%)}	_0.67s	_0.69s
_{Check Time}	_{5.47s (± 0.57%)}	_{5.47s (± 0.78%)}	_{-0.01s (- 0.16%)}	_5.40s	_5.60s
_{Emit Time}	_{2.66s (± 0.77%)}	_{2.67s (± 0.96%)}	_{+0.01s (+ 0.23%)}	_2.62s	_2.73s
_{Total Time}	_{10.74s (± 0.59%)}	_{10.71s (± 0.51%)}	_{-0.03s (- 0.31%)}	_10.63s	_10.89s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{173,586k (± 0.03%)}	_{173,574k (± 0.01%)}	_{-12k (- 0.01%)}	_173,532k	_173,623k
_{Parse Time}	_{1.57s (± 0.70%)}	_{1.58s (± 0.80%)}	_{+0.01s (+ 0.70%)}	_1.56s	_1.62s
_{Bind Time}	_{0.62s (± 1.00%)}	_{0.62s (± 0.76%)}	_{+0.00s (+ 0.16%)}	_0.61s	_0.63s
_{Check Time}	_{4.62s (± 0.58%)}	_{4.66s (± 0.70%)}	_{+0.04s (+ 0.76%)}	_4.61s	_4.73s
_{Emit Time}	_{2.79s (± 0.80%)}	_{2.79s (± 1.10%)}	_{-0.00s (- 0.11%)}	_2.74s	_2.88s
_{Total Time}	_{9.60s (± 0.36%)}	_{9.64s (± 0.52%)}	_{+0.04s (+ 0.41%)}	_9.55s	_9.77s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{262,483k (± 0.02%)}	_{262,272k (± 0.01%)}	_{-211k (- 0.08%)}	_262,186k	_262,365k
_{Parse Time}	_{2.44s (± 0.79%)}	_{2.44s (± 0.71%)}	_{-0.00s (- 0.04%)}	_2.40s	_2.49s
_{Bind Time}	_{0.67s (± 1.66%)}	_{0.66s (± 1.33%)}	_{-0.00s (- 0.60%)}	_0.65s	_0.68s
_{Check Time}	_{15.45s (± 0.51%)}	_{15.54s (± 0.50%)}	_{+0.09s (+ 0.61%)}	_15.43s	_15.71s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{18.55s (± 0.52%)}	_{18.64s (± 0.46%)}	_{+0.09s (+ 0.47%)}	_18.51s	_18.86s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₉₁₇₅	₁₀
_Baseline	_master	₁₀

Jack Works (Jack-Works) · 2020-06-23T00:22:58Z

https://github.com/typescript-bot/TypeScript/pull/49/files#diff-0e62d568d28b82cee9e66b2b8fafd290R7

Is this a possible bug in vscode? 🤔

Daniel Rosenwasser (DanielRosenwasser) · 2020-06-23T19:27:43Z

Matt Bierner (@mjbvz) if we can get some of the numbers down, we'd like to get this merged in for a future release. Like Jack Works (@Jack-Works) mentioned, I think this check might've caught a potential bug in VS Code in an un-awaited promise.

Matt Bierner (mjbvz) · 2020-06-23T20:28:06Z

Thanks Jack Works (@Jack-Works)!

The error in editorActions looks like it should not cause problems. We can probably just remove the conditional

The error in server looks like bad typings since the value really can be undefined (but we don't type it that way)

Jack Works (Jack-Works) · 2020-06-24T02:01:43Z

Another question, should it behave like the check to function? If the variable is undefined | Promise, and use as a if condition. If it is not used in the if body, should it be an error?

Jack Works (Jack-Works) · 2020-07-16T07:16:34Z

How's going 👀

TypeScript Bot (typescript-bot) · 2020-11-12T06:42:00Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Jack Works (Jack-Works) · 2020-11-12T06:44:25Z

rebased to master and merge conflict resolved

TypeScript Bot (typescript-bot) · 2020-11-12T16:03:36Z

The TypeScript team hasn't accepted the linked issue #25330. If you can get it accepted, this PR will have a better chance of being reviewed.

Jack Works (Jack-Works) · 2021-01-21T04:13:18Z

rebased to master and merge conflict resolved

Jack Works (Jack-Works) · 2021-02-06T06:58:50Z

rebased to master and conflict resolved

Eli Barzilay (elibarzilay)

See the comments.

(Another pickiness: the title of the PR and the commit could be better, since it's not only in if statements. The title of the linked issue is probably good for this PR too.)

Eli Barzilay (elibarzilay) · 2021-02-16T16:41:07Z

Rebased, resolved conflicts, squashed; re-edited the PR subject and the commit message.

TypeScript Bot (typescript-bot) mentioned this pull request Jun 22, 2020
🤖 User test baselines have changed for await-in-cond typescript-bot/TypeScript#49
Open

Nathan Shively-Sanders (sandersn) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 4, 2020

Nathan Shively-Sanders (sandersn) assigned Eli Barzilay (elibarzilay)Sep 4, 2020

uhyo (uhyo) mentioned this pull request Oct 10, 2020
Remove errors for invalid escape sequences in tagged template literals #41030
Closed

Jack Works (Jack-Works)force-pushed the await-in-cond branch from 49ee464 to 8c97320Compare November 12, 2020 06:41

Jack Works (Jack-Works) mentioned this pull request Nov 12, 2020
Error on forget to use await on Promise in if condition #41511
Closed

Jack Works (Jack-Works)force-pushed the await-in-cond branch from 8c97320 to f55a7c7Compare January 21, 2021 04:13

Jack Works (Jack-Works)force-pushed the await-in-cond branch from f55a7c7 to d345d44Compare February 6, 2021 06:58

Eli Barzilay (elibarzilay) suggested changes Feb 12, 2021
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated
Comment threadsrc/compiler/checker.ts

Jack Works (Jack-Works) changed the title ~~Error on forget to use await on Promise in if condition~~Add error for missing await in conditional (if or ternary expr)Feb 13, 2021

Add error for missing await in conditionals
bcbe12d

Eli Barzilay (elibarzilay)force-pushed the await-in-cond branch from 212ceb6 to bcbe12dCompare February 16, 2021 16:39

Eli Barzilay (elibarzilay) changed the title ~~Add error for missing await in conditional (if or ternary expr)~~Add error for missing await in conditionalsFeb 16, 2021

Eli Barzilay (elibarzilay) approved these changes Feb 16, 2021
View reviewed changes

Eli Barzilay (elibarzilay) merged commit bb8b9db into microsoft:masterFeb 16, 2021

Jack Works (Jack-Works) deleted the await-in-cond branch February 17, 2021 07:24

This was referenced Apr 5, 2021
Inconsistent missing await in conditional errors, invalid quick fix #43514
Closed
Non-nullable promises shouldn't be allowable in conditions #34717
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025

Uh oh!

Conversation

Jack Works (Jack-Works) commented Jun 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jun 22, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jun 22, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 22, 2020

Uh oh!

Jack Works (Jack-Works) commented Jun 23, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jun 23, 2020

Uh oh!

Matt Bierner (mjbvz) commented Jun 23, 2020

Uh oh!

Jack Works (Jack-Works) commented Jun 24, 2020

Uh oh!

Jack Works (Jack-Works) commented Jul 16, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 12, 2020

Uh oh!

Jack Works (Jack-Works) commented Nov 12, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 12, 2020

Uh oh!

Jack Works (Jack-Works) commented Jan 21, 2021

Uh oh!

Jack Works (Jack-Works) commented Feb 6, 2021

Uh oh!

Eli Barzilay (elibarzilay) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Eli Barzilay (elibarzilay) commented Feb 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Jack Works (Jack-Works) commented Jun 20, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 22, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 22, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 22, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 22, 2020•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 22, 2020•
edited
Loading