Skip to content

support overload signature for deprecated. - #39221

Closed
Wenlu Wang (Kingwl) wants to merge 13 commits into
microsoft:masterfrom
Kingwl:overload_deprecated
Closed

support overload signature for deprecated.#39221
Wenlu Wang (Kingwl) wants to merge 13 commits into
microsoft:masterfrom
Kingwl:overload_deprecated

Conversation

@Kingwl

@KingwlWenlu Wang (Kingwl) commented Jun 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#39212

This or follow the below rules:

  1. If symbol is not point to a function or signature or method: mark as deprecated.
  2. else if all signature(one or every) has been deprecated: mark as deprecated.
  3. else if symbol is used by callExpression and the resolved signature has been deprecated: mark call as deprecated

@Kingwl

Wenlu Wang (Kingwl) commented Jun 24, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.
TypeScript Bot (@typescript-bot) pack this.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at 482a4d3. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 482a4d3. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/77648/artifacts?artifactName=tgz&fileId=62A15C5419483393738884156DA901104C35846BC0F615FE869E3C1F68D341D002&fileName=/typescript-4.0.0-insiders.20200624.tgz"
}
}

and then running npm install.

There is also a playground for this build.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used340,499k (± 0.02%)339,854k (± 0.02%)-645k (- 0.19%)339,777k340,067k
Parse Time1.99s (± 0.72%)1.99s (± 0.29%)-0.00s (- 0.10%)1.98s2.00s
Bind Time0.82s (± 0.82%)0.82s (± 1.08%)+0.01s (+ 0.86%)0.81s0.85s
Check Time4.72s (± 0.54%)4.73s (± 0.37%)+0.00s (+ 0.04%)4.69s4.76s
Emit Time5.18s (± 0.68%)5.19s (± 0.67%)+0.01s (+ 0.12%)5.12s5.26s
Total Time12.72s (± 0.53%)12.73s (± 0.32%)+0.01s (+ 0.09%)12.65s12.85s
Monaco - node (v10.16.3, x64)
Memory used338,967k (± 0.03%)339,044k (± 0.02%)+76k (+ 0.02%)338,882k339,284k
Parse Time1.58s (± 0.84%)1.58s (± 0.60%)0.00s ( 0.00%)1.56s1.60s
Bind Time0.71s (± 0.66%)0.72s (± 0.84%)+0.01s (+ 0.70%)0.71s0.73s
Check Time4.84s (± 0.54%)4.87s (± 0.51%)+0.03s (+ 0.70%)4.81s4.94s
Emit Time2.74s (± 0.42%)2.76s (± 1.01%)+0.02s (+ 0.73%)2.72s2.85s
Total Time9.87s (± 0.39%)9.93s (± 0.44%)+0.06s (+ 0.63%)9.83s10.02s
TFS - node (v10.16.3, x64)
Memory used301,981k (± 0.03%)301,997k (± 0.03%)+17k (+ 0.01%)301,827k302,258k
Parse Time1.21s (± 0.73%)1.22s (± 0.81%)+0.01s (+ 0.41%)1.20s1.24s
Bind Time0.66s (± 1.43%)0.67s (± 1.31%)+0.01s (+ 0.75%)0.64s0.68s
Check Time4.35s (± 0.50%)4.37s (± 0.54%)+0.02s (+ 0.48%)4.31s4.42s
Emit Time2.90s (± 0.98%)2.89s (± 1.13%)-0.02s (- 0.52%)2.80s2.94s
Total Time9.13s (± 0.49%)9.15s (± 0.54%)+0.01s (+ 0.15%)9.03s9.22s
material-ui - node (v10.16.3, x64)
Memory used459,762k (± 0.01%)459,434k (± 0.01%)-328k (- 0.07%)459,352k459,553k
Parse Time2.05s (± 0.60%)2.04s (± 0.54%)-0.00s (- 0.15%)2.03s2.08s
Bind Time0.66s (± 1.47%)0.67s (± 1.21%)+0.01s (+ 2.12%)0.65s0.69s
Check Time12.93s (± 0.76%)12.83s (± 0.77%)-0.10s (- 0.77%)12.66s13.07s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.64s (± 0.69%)15.55s (± 0.68%)-0.09s (- 0.57%)15.36s15.83s
Angular - node (v12.1.0, x64)
Memory used317,868k (± 0.02%)317,451k (± 0.02%)-417k (- 0.13%)317,342k317,590k
Parse Time1.97s (± 0.70%)1.96s (± 0.76%)-0.01s (- 0.51%)1.94s2.00s
Bind Time0.80s (± 0.95%)0.80s (± 0.65%)+0.00s (+ 0.38%)0.79s0.81s
Check Time4.60s (± 0.38%)4.61s (± 0.31%)+0.01s (+ 0.20%)4.58s4.65s
Emit Time5.33s (± 0.65%)5.33s (± 0.47%)-0.01s (- 0.11%)5.28s5.38s
Total Time12.70s (± 0.32%)12.69s (± 0.35%)-0.00s (- 0.03%)12.62s12.81s
Monaco - node (v12.1.0, x64)
Memory used321,477k (± 0.02%)321,481k (± 0.02%)+4k (+ 0.00%)321,359k321,609k
Parse Time1.56s (± 0.51%)1.55s (± 0.88%)-0.01s (- 0.39%)1.52s1.58s
Bind Time0.69s (± 0.65%)0.69s (± 0.48%)+0.00s (+ 0.29%)0.68s0.70s
Check Time4.64s (± 0.45%)4.68s (± 0.55%)+0.04s (+ 0.88%)4.62s4.72s
Emit Time2.81s (± 0.58%)2.82s (± 0.50%)+0.02s (+ 0.53%)2.80s2.86s
Total Time9.70s (± 0.38%)9.75s (± 0.41%)+0.05s (+ 0.55%)9.68s9.82s
TFS - node (v12.1.0, x64)
Memory used286,452k (± 0.03%)286,487k (± 0.03%)+35k (+ 0.01%)286,281k286,678k
Parse Time1.24s (± 1.01%)1.24s (± 0.66%)+0.00s (+ 0.24%)1.22s1.26s
Bind Time0.64s (± 0.81%)0.64s (± 1.25%)+0.00s (+ 0.47%)0.63s0.67s
Check Time4.28s (± 0.44%)4.29s (± 0.34%)+0.02s (+ 0.42%)4.25s4.32s
Emit Time2.91s (± 0.61%)2.96s (± 1.87%)+0.05s (+ 1.72%)2.88s3.17s
Total Time9.06s (± 0.41%)9.14s (± 0.75%)+0.07s (+ 0.83%)9.05s9.38s
material-ui - node (v12.1.0, x64)
Memory used438,135k (± 0.01%)437,621k (± 0.07%)-514k (- 0.12%)436,704k437,986k
Parse Time2.03s (± 0.34%)2.02s (± 0.68%)-0.00s (- 0.05%)2.00s2.06s
Bind Time0.63s (± 0.94%)0.64s (± 1.06%)+0.01s (+ 1.58%)0.63s0.66s
Check Time11.61s (± 0.72%)11.63s (± 1.52%)+0.02s (+ 0.17%)11.40s12.09s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.27s (± 0.60%)14.29s (± 1.32%)+0.03s (+ 0.19%)14.03s14.79s
Angular - node (v8.9.0, x64)
Memory used337,039k (± 0.01%)336,678k (± 0.01%)-360k (- 0.11%)336,548k336,778k
Parse Time2.50s (± 0.48%)2.50s (± 0.42%)0.00s ( 0.00%)2.48s2.53s
Bind Time0.85s (± 0.58%)0.85s (± 0.76%)+0.00s (+ 0.24%)0.84s0.86s
Check Time5.36s (± 0.53%)5.39s (± 0.30%)+0.03s (+ 0.60%)5.35s5.42s
Emit Time5.86s (± 1.46%)5.92s (± 1.45%)+0.06s (+ 1.07%)5.69s6.06s
Total Time14.56s (± 0.75%)14.66s (± 0.61%)+0.10s (+ 0.68%)14.42s14.78s
Monaco - node (v8.9.0, x64)
Memory used340,355k (± 0.02%)340,333k (± 0.01%)-23k (- 0.01%)340,273k340,471k
Parse Time1.87s (± 0.40%)1.87s (± 0.40%)-0.00s (- 0.16%)1.85s1.88s
Bind Time0.88s (± 0.63%)0.88s (± 0.45%)-0.00s (- 0.11%)0.87s0.89s
Check Time5.39s (± 0.50%)5.40s (± 0.36%)+0.01s (+ 0.26%)5.36s5.44s
Emit Time3.23s (± 0.66%)3.23s (± 0.60%)+0.00s (+ 0.03%)3.19s3.28s
Total Time11.37s (± 0.39%)11.38s (± 0.27%)+0.02s (+ 0.16%)11.33s11.45s
TFS - node (v8.9.0, x64)
Memory used303,715k (± 0.01%)303,744k (± 0.02%)+29k (+ 0.01%)303,641k303,878k
Parse Time1.54s (± 0.50%)1.54s (± 0.50%)-0.00s (- 0.13%)1.53s1.56s
Bind Time0.66s (± 0.89%)0.67s (± 0.86%)+0.01s (+ 0.90%)0.66s0.68s
Check Time4.97s (± 1.64%)4.96s (± 1.20%)-0.00s (- 0.04%)4.87s5.11s
Emit Time3.09s (± 2.20%)3.09s (± 2.42%)+0.00s (+ 0.06%)2.91s3.20s
Total Time10.26s (± 0.41%)10.26s (± 0.33%)+0.00s (+ 0.05%)10.19s10.33s
material-ui - node (v8.9.0, x64)
Memory used463,932k (± 0.01%)463,639k (± 0.01%)-293k (- 0.06%)463,545k463,763k
Parse Time2.39s (± 0.48%)2.38s (± 0.54%)-0.00s (- 0.21%)2.36s2.42s
Bind Time0.77s (± 0.88%)0.79s (± 1.33%)+0.02s (+ 2.45%)0.77s0.82s
Check Time17.13s (± 1.00%)17.06s (± 1.08%)-0.07s (- 0.44%)16.69s17.52s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.29s (± 0.86%)20.23s (± 0.95%)-0.06s (- 0.30%)19.83s20.72s
Angular - node (v8.9.0, x86)
Memory used193,501k (± 0.02%)193,327k (± 0.02%)-174k (- 0.09%)193,247k193,396k
Parse Time2.43s (± 0.65%)2.42s (± 0.76%)-0.01s (- 0.25%)2.39s2.46s
Bind Time0.97s (± 1.24%)0.99s (± 1.16%)+0.02s (+ 1.54%)0.97s1.01s
Check Time4.78s (± 0.70%)4.83s (± 0.87%)+0.05s (+ 1.00%)4.75s4.93s
Emit Time5.86s (± 0.75%)5.86s (± 0.79%)-0.00s (- 0.07%)5.73s5.93s
Total Time14.05s (± 0.41%)14.10s (± 0.44%)+0.06s (+ 0.40%)13.94s14.27s
Monaco - node (v8.9.0, x86)
Memory used193,373k (± 0.02%)193,404k (± 0.03%)+31k (+ 0.02%)193,295k193,489k
Parse Time1.90s (± 0.61%)1.90s (± 0.64%)-0.00s (- 0.21%)1.87s1.92s
Bind Time0.70s (± 0.67%)0.70s (± 0.82%)-0.00s (- 0.00%)0.69s0.71s
Check Time5.47s (± 0.70%)5.46s (± 1.53%)-0.01s (- 0.24%)5.15s5.57s
Emit Time2.66s (± 1.14%)2.70s (± 2.99%)+0.04s (+ 1.39%)2.62s3.01s
Total Time10.74s (± 0.46%)10.75s (± 0.42%)+0.02s (+ 0.15%)10.60s10.83s
TFS - node (v8.9.0, x86)
Memory used173,660k (± 0.03%)173,675k (± 0.03%)+15k (+ 0.01%)173,579k173,774k
Parse Time1.58s (± 0.78%)1.58s (± 0.82%)+0.01s (+ 0.44%)1.56s1.61s
Bind Time0.64s (± 0.58%)0.64s (± 1.18%)+0.01s (+ 1.42%)0.63s0.67s
Check Time4.63s (± 0.61%)4.64s (± 0.50%)+0.01s (+ 0.26%)4.59s4.69s
Emit Time2.80s (± 1.05%)2.77s (± 1.38%)-0.02s (- 0.82%)2.68s2.84s
Total Time9.64s (± 0.48%)9.64s (± 0.46%)+0.00s (+ 0.05%)9.54s9.73s
material-ui - node (v8.9.0, x86)
Memory used262,667k (± 0.02%)262,536k (± 0.01%)-131k (- 0.05%)262,463k262,580k
Parse Time2.46s (± 0.83%)2.44s (± 0.63%)-0.02s (- 0.77%)2.42s2.48s
Bind Time0.67s (± 1.22%)0.68s (± 1.47%)+0.02s (+ 2.55%)0.66s0.71s
Check Time15.70s (± 0.78%)15.63s (± 0.73%)-0.07s (- 0.47%)15.36s15.95s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.84s (± 0.66%)18.76s (± 0.68%)-0.08s (- 0.42%)18.47s19.13s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@Kingwl

Wenlu Wang (Kingwl) commented Jun 24, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at 482a4d3. You can monitor the build here.

Update: The results are in!

weswigham
Wesley Wigham (weswigham) reviewed Jun 24, 2020
View reviewed changes

@weswighamWesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also try to change it up so that we report the "x is deprecated" suggestion when a call resolves to one of the deprecated signatures?

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used340,499k (± 0.02%)339,959k (± 0.02%)-540k (- 0.16%)339,765k340,146k
Parse Time1.99s (± 0.72%)1.98s (± 0.67%)-0.01s (- 0.35%)1.95s2.01s
Bind Time0.82s (± 0.82%)0.83s (± 1.49%)+0.01s (+ 1.35%)0.80s0.85s
Check Time4.72s (± 0.54%)4.75s (± 0.48%)+0.02s (+ 0.53%)4.71s4.82s
Emit Time5.18s (± 0.68%)5.19s (± 0.59%)+0.01s (+ 0.12%)5.14s5.25s
Total Time12.72s (± 0.53%)12.75s (± 0.43%)+0.03s (+ 0.26%)12.66s12.90s
Monaco - node (v10.16.3, x64)
Memory used338,967k (± 0.03%)339,037k (± 0.03%)+70k (+ 0.02%)338,850k339,259k
Parse Time1.58s (± 0.84%)1.59s (± 0.62%)+0.00s (+ 0.32%)1.56s1.61s
Bind Time0.71s (± 0.66%)0.71s (± 0.67%)+0.00s (+ 0.42%)0.70s0.72s
Check Time4.84s (± 0.54%)4.89s (± 0.74%)+0.05s (+ 1.12%)4.80s4.97s
Emit Time2.74s (± 0.42%)2.76s (± 0.71%)+0.02s (+ 0.73%)2.73s2.81s
Total Time9.87s (± 0.39%)9.95s (± 0.49%)+0.08s (+ 0.84%)9.83s10.04s
TFS - node (v10.16.3, x64)
Memory used301,981k (± 0.03%)301,941k (± 0.02%)-39k (- 0.01%)301,859k302,065k
Parse Time1.21s (± 0.73%)1.22s (± 0.63%)+0.00s (+ 0.16%)1.20s1.23s
Bind Time0.66s (± 1.43%)0.67s (± 0.54%)+0.01s (+ 1.35%)0.67s0.68s
Check Time4.35s (± 0.50%)4.37s (± 0.41%)+0.02s (+ 0.48%)4.33s4.40s
Emit Time2.90s (± 0.98%)2.89s (± 1.24%)-0.01s (- 0.28%)2.80s2.97s
Total Time9.13s (± 0.49%)9.15s (± 0.39%)+0.02s (+ 0.23%)9.04s9.23s
material-ui - node (v10.16.3, x64)
Memory used459,762k (± 0.01%)459,445k (± 0.01%)-317k (- 0.07%)459,348k459,558k
Parse Time2.05s (± 0.60%)2.05s (± 0.63%)-0.00s (- 0.10%)2.02s2.08s
Bind Time0.66s (± 1.47%)0.66s (± 1.59%)+0.00s (+ 0.61%)0.64s0.68s
Check Time12.93s (± 0.76%)12.90s (± 0.67%)-0.03s (- 0.21%)12.71s13.14s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.64s (± 0.69%)15.61s (± 0.60%)-0.02s (- 0.15%)15.41s15.87s
Angular - node (v12.1.0, x64)
Memory used317,868k (± 0.02%)317,465k (± 0.02%)-403k (- 0.13%)317,342k317,671k
Parse Time1.97s (± 0.70%)1.96s (± 0.93%)-0.01s (- 0.46%)1.93s2.00s
Bind Time0.80s (± 0.95%)0.80s (± 0.56%)+0.00s (+ 0.25%)0.79s0.81s
Check Time4.60s (± 0.38%)4.62s (± 0.40%)+0.02s (+ 0.35%)4.57s4.65s
Emit Time5.33s (± 0.65%)5.35s (± 0.74%)+0.02s (+ 0.28%)5.29s5.47s
Total Time12.70s (± 0.32%)12.72s (± 0.38%)+0.03s (+ 0.20%)12.64s12.84s
Monaco - node (v12.1.0, x64)
Memory used321,477k (± 0.02%)321,470k (± 0.01%)-7k (- 0.00%)321,407k321,533k
Parse Time1.56s (± 0.51%)1.55s (± 0.77%)-0.01s (- 0.51%)1.52s1.58s
Bind Time0.69s (± 0.65%)0.69s (± 0.98%)+0.01s (+ 0.87%)0.68s0.71s
Check Time4.64s (± 0.45%)4.69s (± 0.51%)+0.04s (+ 0.95%)4.66s4.76s
Emit Time2.81s (± 0.58%)2.82s (± 0.99%)+0.01s (+ 0.39%)2.76s2.89s
Total Time9.70s (± 0.38%)9.75s (± 0.50%)+0.06s (+ 0.58%)9.67s9.85s
TFS - node (v12.1.0, x64)
Memory used286,452k (± 0.03%)286,458k (± 0.03%)+6k (+ 0.00%)286,331k286,673k
Parse Time1.24s (± 1.01%)1.24s (± 0.62%)+0.00s (+ 0.32%)1.22s1.26s
Bind Time0.64s (± 0.81%)0.65s (± 0.73%)+0.01s (+ 1.25%)0.64s0.66s
Check Time4.28s (± 0.44%)4.29s (± 0.30%)+0.02s (+ 0.47%)4.27s4.33s
Emit Time2.91s (± 0.61%)2.92s (± 0.81%)+0.01s (+ 0.27%)2.88s2.97s
Total Time9.06s (± 0.41%)9.10s (± 0.40%)+0.04s (+ 0.42%)9.05s9.19s
material-ui - node (v12.1.0, x64)
Memory used438,135k (± 0.01%)437,721k (± 0.05%)-414k (- 0.09%)436,823k437,974k
Parse Time2.03s (± 0.34%)2.02s (± 0.44%)-0.00s (- 0.10%)2.00s2.04s
Bind Time0.63s (± 0.94%)0.65s (± 0.95%)+0.02s (+ 2.37%)0.63s0.66s
Check Time11.61s (± 0.72%)11.64s (± 1.05%)+0.03s (+ 0.27%)11.38s11.97s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.27s (± 0.60%)14.31s (± 0.86%)+0.04s (+ 0.31%)14.05s14.63s
Angular - node (v8.9.0, x64)
Memory used337,039k (± 0.01%)336,641k (± 0.02%)-398k (- 0.12%)336,551k336,780k
Parse Time2.50s (± 0.48%)2.50s (± 0.41%)-0.00s (- 0.16%)2.48s2.52s
Bind Time0.85s (± 0.58%)0.84s (± 0.95%)-0.00s (- 0.47%)0.83s0.87s
Check Time5.36s (± 0.53%)5.38s (± 0.62%)+0.03s (+ 0.52%)5.30s5.45s
Emit Time5.86s (± 1.46%)5.93s (± 0.68%)+0.07s (+ 1.11%)5.83s6.02s
Total Time14.56s (± 0.75%)14.65s (± 0.47%)+0.09s (+ 0.60%)14.47s14.78s
Monaco - node (v8.9.0, x64)
Memory used340,355k (± 0.02%)340,385k (± 0.01%)+30k (+ 0.01%)340,313k340,438k
Parse Time1.87s (± 0.40%)1.87s (± 0.35%)-0.00s (- 0.05%)1.85s1.88s
Bind Time0.88s (± 0.63%)0.88s (± 0.45%)-0.00s (- 0.34%)0.87s0.89s
Check Time5.39s (± 0.50%)5.39s (± 0.37%)+0.00s (+ 0.04%)5.34s5.45s
Emit Time3.23s (± 0.66%)3.22s (± 0.37%)-0.01s (- 0.22%)3.19s3.24s
Total Time11.37s (± 0.39%)11.36s (± 0.28%)-0.01s (- 0.06%)11.26s11.40s
TFS - node (v8.9.0, x64)
Memory used303,715k (± 0.01%)303,707k (± 0.01%)-8k (- 0.00%)303,652k303,821k
Parse Time1.54s (± 0.50%)1.54s (± 0.34%)-0.00s (- 0.13%)1.53s1.55s
Bind Time0.66s (± 0.89%)0.67s (± 0.66%)+0.01s (+ 1.20%)0.66s0.68s
Check Time4.97s (± 1.64%)5.00s (± 2.09%)+0.04s (+ 0.79%)4.80s5.23s
Emit Time3.09s (± 2.20%)3.05s (± 2.60%)-0.04s (- 1.20%)2.89s3.17s
Total Time10.26s (± 0.41%)10.26s (± 0.42%)+0.01s (+ 0.09%)10.18s10.37s
material-ui - node (v8.9.0, x64)
Memory used463,932k (± 0.01%)463,634k (± 0.01%)-298k (- 0.06%)463,524k463,728k
Parse Time2.39s (± 0.48%)2.37s (± 0.37%)-0.02s (- 0.71%)2.36s2.40s
Bind Time0.77s (± 0.88%)0.79s (± 1.20%)+0.01s (+ 1.68%)0.76s0.81s
Check Time17.13s (± 1.00%)17.13s (± 0.51%)-0.00s (- 0.02%)16.92s17.32s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.29s (± 0.86%)20.29s (± 0.44%)-0.00s (- 0.02%)20.08s20.48s
Angular - node (v8.9.0, x86)
Memory used193,501k (± 0.02%)193,301k (± 0.02%)-200k (- 0.10%)193,201k193,370k
Parse Time2.43s (± 0.65%)2.44s (± 0.71%)+0.01s (+ 0.54%)2.41s2.49s
Bind Time0.97s (± 1.24%)0.98s (± 1.12%)+0.01s (+ 0.82%)0.96s1.00s
Check Time4.78s (± 0.70%)4.84s (± 0.82%)+0.05s (+ 1.11%)4.75s4.92s
Emit Time5.86s (± 0.75%)5.88s (± 1.20%)+0.01s (+ 0.19%)5.77s6.10s
Total Time14.05s (± 0.41%)14.14s (± 0.58%)+0.09s (+ 0.62%)13.96s14.31s
Monaco - node (v8.9.0, x86)
Memory used193,373k (± 0.02%)193,385k (± 0.02%)+12k (+ 0.01%)193,302k193,480k
Parse Time1.90s (± 0.61%)1.91s (± 0.86%)+0.00s (+ 0.11%)1.87s1.93s
Bind Time0.70s (± 0.67%)0.70s (± 1.26%)-0.00s (- 0.00%)0.69s0.73s
Check Time5.47s (± 0.70%)5.49s (± 0.45%)+0.02s (+ 0.31%)5.43s5.54s
Emit Time2.66s (± 1.14%)2.67s (± 0.87%)+0.01s (+ 0.41%)2.63s2.72s
Total Time10.74s (± 0.46%)10.76s (± 0.42%)+0.03s (+ 0.27%)10.65s10.88s
TFS - node (v8.9.0, x86)
Memory used173,660k (± 0.03%)173,718k (± 0.02%)+58k (+ 0.03%)173,625k173,798k
Parse Time1.58s (± 0.78%)1.59s (± 0.91%)+0.01s (+ 0.63%)1.56s1.61s
Bind Time0.64s (± 0.58%)0.64s (± 0.56%)+0.01s (+ 1.42%)0.64s0.65s
Check Time4.63s (± 0.61%)4.67s (± 0.50%)+0.04s (+ 0.84%)4.63s4.72s
Emit Time2.80s (± 1.05%)2.80s (± 1.31%)-0.00s (- 0.00%)2.70s2.90s
Total Time9.64s (± 0.48%)9.69s (± 0.63%)+0.05s (+ 0.57%)9.56s9.83s
material-ui - node (v8.9.0, x86)
Memory used262,667k (± 0.02%)262,500k (± 0.02%)-168k (- 0.06%)262,406k262,637k
Parse Time2.46s (± 0.83%)2.44s (± 0.72%)-0.03s (- 1.06%)2.41s2.48s
Bind Time0.67s (± 1.22%)0.68s (± 0.76%)+0.01s (+ 2.10%)0.67s0.69s
Check Time15.70s (± 0.78%)15.63s (± 0.39%)-0.07s (- 0.47%)15.52s15.76s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.84s (± 0.66%)18.75s (± 0.39%)-0.09s (- 0.47%)18.62s18.88s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@Kingwl

Wenlu Wang (Kingwl) commented Jun 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Update for rules. Let me know if something is incorrect.

@KingwlWenlu Wang (Kingwl) changed the title support overload atsignaturesupport overload signature for deprecated.Jun 24, 2020
@weswigham

Wesley Wigham (weswigham) commented Jun 24, 2020

Copy link
Copy Markdown
Member

Daniel Rosenwasser (@DanielRosenwasser) this look good to you? It looks like it resolves the issue pretty well to me.

@Kingwl

Wenlu Wang (Kingwl) commented Jun 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Matt Bierner (@mjbvz) please look at this changes.

DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Jun 24, 2020
View reviewed changes
Comment threadsrc/compiler/binder.ts Outdated
sandersn
Nathan Shively-Sanders (sandersn) requested changes Jun 24, 2020
View reviewed changes

@sandersnNathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes, but the big one is that we need to make sure performance is still OK, because this adds a symbol property and does work in the binder for every signature, even non-deprecated ones.

Comment threadsrc/compiler/binder.ts Outdated
Comment on lines +550 to +551
else if (hasDeprecated) {

@sandersnNathan Shively-Sanders (sandersn)Jun 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elseif(hasDeprecated){
elseif(hasDeprecated){

Comment threadsrc/compiler/types.ts Outdated
/* @internal */ isReplaceableByMethod?: boolean; // Can this Javascript class property be replaced by a method symbol?
/* @internal */ isAssigned?: boolean; // True if the symbol is a parameter with assignments
/* @internal */ assignmentDeclarationMembers?: Map<Declaration>; // detected late-bound assignment declarations associated with the symbol
/* @internal */ allSignatureDeprecated?: boolean; // All signatures have the deprecated tag

@sandersnNathan Shively-Sanders (sandersn)Jun 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an s: allSignaturesDeprecated

Comment threadsrc/compiler/binder.ts Outdated
symbol.flags &= ~SymbolFlags.Deprecated;
}
}
else if (hasDeprecated) {

@sandersnNathan Shively-Sanders (sandersn)Jun 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged signatures/other things will end up deprecating the whole thing, right?

/** @deprecated */interfaceF{}functionF(){}

@sandersnNathan Shively-Sanders (sandersn)Jun 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later: No, the code correctly unsets the flag, but please add a test like this (or point me to an existing one).

@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Jun 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same fear - I don't really understand why it needs to check the symbol if the resolved signature is already there though.

@KingwlWenlu Wang (Kingwl)Jun 25, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because to avoid duplicate diagnostic. eg:

/* @deprecated */
declare function foo (); void;
foo;
~~~ // foo is deprecated. checked by identifier
foo();
~~~ // foo is deprecated. checked by identifier
~~~~~ // (): void is deprecated. checked by callExpression

DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Jun 24, 2020
View reviewed changes
Comment threadsrc/compiler/binder.ts Outdated
@Kingwl

Wenlu Wang (Kingwl) commented Jun 25, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at fcd722a. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used343,856k (± 0.02%)343,406k (± 0.01%)-450k (- 0.13%)343,302k343,472k
Parse Time2.01s (± 0.78%)2.01s (± 0.68%)+0.01s (+ 0.40%)1.99s2.05s
Bind Time0.82s (± 0.68%)0.84s (± 1.21%)+0.02s (+ 2.31%)0.82s0.87s
Check Time4.72s (± 0.43%)4.73s (± 0.62%)+0.00s (+ 0.08%)4.65s4.81s
Emit Time5.18s (± 0.47%)5.18s (± 0.79%)+0.00s (+ 0.10%)5.11s5.30s
Total Time12.73s (± 0.30%)12.76s (± 0.52%)+0.03s (+ 0.26%)12.64s12.92s
Monaco - node (v10.16.3, x64)
Memory used339,027k (± 0.03%)339,050k (± 0.01%)+22k (+ 0.01%)338,970k339,147k
Parse Time1.59s (± 0.65%)1.59s (± 0.57%)+0.00s (+ 0.19%)1.57s1.61s
Bind Time0.71s (± 0.91%)0.72s (± 0.69%)+0.00s (+ 0.56%)0.71s0.73s
Check Time4.85s (± 0.76%)4.88s (± 0.54%)+0.03s (+ 0.66%)4.83s4.97s
Emit Time2.75s (± 0.69%)2.75s (± 0.62%)+0.00s (+ 0.15%)2.72s2.79s
Total Time9.90s (± 0.58%)9.95s (± 0.39%)+0.05s (+ 0.45%)9.86s10.07s
TFS - node (v10.16.3, x64)
Memory used301,943k (± 0.02%)301,977k (± 0.02%)+34k (+ 0.01%)301,825k302,093k
Parse Time1.21s (± 0.83%)1.22s (± 1.02%)+0.01s (+ 0.49%)1.19s1.24s
Bind Time0.67s (± 0.60%)0.67s (± 1.05%)-0.00s (- 0.30%)0.65s0.68s
Check Time4.37s (± 0.41%)4.36s (± 0.60%)-0.01s (- 0.11%)4.29s4.41s
Emit Time2.91s (± 0.68%)2.91s (± 1.21%)-0.01s (- 0.27%)2.79s2.97s
Total Time9.17s (± 0.34%)9.16s (± 0.26%)-0.01s (- 0.07%)9.10s9.20s
material-ui - node (v10.16.3, x64)
Memory used459,346k (± 0.01%)459,107k (± 0.01%)-239k (- 0.05%)458,917k459,219k
Parse Time2.04s (± 0.38%)2.06s (± 0.40%)+0.02s (+ 0.73%)2.04s2.08s
Bind Time0.65s (± 1.54%)0.68s (± 1.38%)+0.03s (+ 3.98%)0.66s0.70s
Check Time12.85s (± 0.64%)12.97s (± 0.61%)+0.11s (+ 0.89%)12.84s13.13s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.55s (± 0.59%)15.70s (± 0.47%)+0.15s (+ 0.99%)15.57s15.86s
Angular - node (v12.1.0, x64)
Memory used321,092k (± 0.02%)320,645k (± 0.02%)-447k (- 0.14%)320,518k320,860k
Parse Time1.99s (± 0.54%)2.00s (± 0.81%)+0.01s (+ 0.55%)1.97s2.03s
Bind Time0.80s (± 0.61%)0.83s (± 1.28%)+0.02s (+ 2.74%)0.81s0.86s
Check Time4.59s (± 0.55%)4.62s (± 0.52%)+0.03s (+ 0.72%)4.56s4.66s
Emit Time5.32s (± 0.46%)5.36s (± 0.43%)+0.05s (+ 0.90%)5.33s5.42s
Total Time12.70s (± 0.37%)12.82s (± 0.33%)+0.12s (+ 0.93%)12.73s12.90s
Monaco - node (v12.1.0, x64)
Memory used321,488k (± 0.02%)321,524k (± 0.02%)+36k (+ 0.01%)321,396k321,656k
Parse Time1.55s (± 0.99%)1.55s (± 1.07%)+0.00s (+ 0.13%)1.51s1.58s
Bind Time0.69s (± 1.32%)0.69s (± 0.49%)+0.00s (+ 0.58%)0.69s0.70s
Check Time4.66s (± 0.72%)4.67s (± 0.63%)+0.01s (+ 0.32%)4.60s4.73s
Emit Time2.79s (± 0.77%)2.80s (± 0.41%)+0.01s (+ 0.21%)2.77s2.82s
Total Time9.69s (± 0.60%)9.72s (± 0.34%)+0.03s (+ 0.30%)9.63s9.78s
TFS - node (v12.1.0, x64)
Memory used286,477k (± 0.02%)286,504k (± 0.02%)+26k (+ 0.01%)286,375k286,670k
Parse Time1.23s (± 0.96%)1.24s (± 0.59%)+0.01s (+ 0.49%)1.22s1.25s
Bind Time0.63s (± 0.71%)0.64s (± 0.35%)+0.01s (+ 1.42%)0.64s0.65s
Check Time4.27s (± 0.42%)4.30s (± 0.79%)+0.03s (+ 0.63%)4.22s4.37s
Emit Time2.91s (± 0.78%)2.92s (± 0.91%)+0.01s (+ 0.41%)2.85s2.98s
Total Time9.05s (± 0.37%)9.10s (± 0.44%)+0.05s (+ 0.54%)9.01s9.20s
material-ui - node (v12.1.0, x64)
Memory used437,764k (± 0.01%)437,459k (± 0.05%)-305k (- 0.07%)436,551k437,686k
Parse Time2.03s (± 0.59%)2.03s (± 0.46%)+0.00s (+ 0.10%)2.01s2.05s
Bind Time0.63s (± 1.15%)0.66s (± 0.76%)+0.02s (+ 3.64%)0.64s0.66s
Check Time11.58s (± 0.55%)11.70s (± 1.03%)+0.12s (+ 1.05%)11.45s11.95s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.24s (± 0.49%)14.38s (± 0.84%)+0.14s (+ 1.01%)14.14s14.63s
Angular - node (v8.9.0, x64)
Memory used340,382k (± 0.01%)340,038k (± 0.02%)-343k (- 0.10%)339,951k340,243k
Parse Time2.53s (± 0.59%)2.53s (± 0.54%)-0.00s (- 0.04%)2.50s2.57s
Bind Time0.86s (± 1.12%)0.87s (± 0.79%)+0.01s (+ 0.81%)0.85s0.88s
Check Time5.37s (± 0.69%)5.39s (± 0.73%)+0.02s (+ 0.39%)5.26s5.46s
Emit Time5.98s (± 1.52%)5.93s (± 0.93%)-0.04s (- 0.72%)5.83s6.11s
Total Time14.74s (± 0.81%)14.73s (± 0.50%)-0.01s (- 0.08%)14.55s14.88s
Monaco - node (v8.9.0, x64)
Memory used340,367k (± 0.02%)340,424k (± 0.01%)+57k (+ 0.02%)340,360k340,510k
Parse Time1.88s (± 0.47%)1.88s (± 0.31%)-0.00s (- 0.16%)1.87s1.89s
Bind Time0.88s (± 0.45%)0.89s (± 0.50%)+0.01s (+ 1.02%)0.88s0.90s
Check Time5.39s (± 0.59%)5.40s (± 0.45%)+0.01s (+ 0.22%)5.35s5.46s
Emit Time3.22s (± 0.44%)3.23s (± 0.65%)+0.01s (+ 0.43%)3.19s3.27s
Total Time11.37s (± 0.33%)11.39s (± 0.32%)+0.03s (+ 0.25%)11.32s11.48s
TFS - node (v8.9.0, x64)
Memory used303,715k (± 0.03%)303,714k (± 0.02%)-1k (- 0.00%)303,627k303,870k
Parse Time1.54s (± 0.42%)1.54s (± 0.48%)+0.00s (+ 0.33%)1.53s1.57s
Bind Time0.67s (± 0.78%)0.67s (± 0.66%)+0.00s (+ 0.45%)0.66s0.68s
Check Time5.00s (± 1.38%)5.01s (± 1.00%)+0.01s (+ 0.28%)4.93s5.13s
Emit Time3.03s (± 2.42%)3.03s (± 2.76%)+0.00s (+ 0.03%)2.87s3.16s
Total Time10.23s (± 0.36%)10.26s (± 0.36%)+0.03s (+ 0.28%)10.19s10.33s
material-ui - node (v8.9.0, x64)
Memory used463,576k (± 0.01%)463,278k (± 0.01%)-298k (- 0.06%)463,151k463,418k
Parse Time2.40s (± 0.37%)2.39s (± 0.78%)-0.00s (- 0.21%)2.35s2.44s
Bind Time0.78s (± 1.47%)0.80s (± 1.33%)+0.01s (+ 1.66%)0.77s0.82s
Check Time17.27s (± 0.97%)17.21s (± 0.81%)-0.06s (- 0.35%)16.86s17.52s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.45s (± 0.82%)20.39s (± 0.71%)-0.06s (- 0.27%)20.06s20.74s
Angular - node (v8.9.0, x86)
Memory used195,255k (± 0.03%)195,085k (± 0.03%)-170k (- 0.09%)195,001k195,228k
Parse Time2.44s (± 0.66%)2.45s (± 0.51%)+0.01s (+ 0.20%)2.42s2.48s
Bind Time0.99s (± 1.16%)1.01s (± 1.05%)+0.02s (+ 1.72%)0.98s1.03s
Check Time4.80s (± 0.49%)4.83s (± 0.56%)+0.03s (+ 0.54%)4.76s4.89s
Emit Time5.94s (± 1.46%)5.93s (± 1.42%)-0.00s (- 0.05%)5.77s6.17s
Total Time14.17s (± 0.69%)14.21s (± 0.74%)+0.04s (+ 0.31%)13.97s14.45s
Monaco - node (v8.9.0, x86)
Memory used193,419k (± 0.03%)193,423k (± 0.03%)+4k (+ 0.00%)193,316k193,556k
Parse Time1.91s (± 0.76%)1.91s (± 0.49%)-0.00s (- 0.00%)1.90s1.94s
Bind Time0.69s (± 0.80%)0.70s (± 0.57%)+0.01s (+ 1.30%)0.69s0.71s
Check Time5.46s (± 0.41%)5.48s (± 1.21%)+0.02s (+ 0.37%)5.26s5.60s
Emit Time2.67s (± 1.01%)2.71s (± 3.48%)+0.04s (+ 1.57%)2.63s3.08s
Total Time10.74s (± 0.44%)10.81s (± 0.66%)+0.07s (+ 0.65%)10.68s10.98s
TFS - node (v8.9.0, x86)
Memory used173,673k (± 0.02%)173,673k (± 0.02%)0k ( 0.00%)173,627k173,766k
Parse Time1.60s (± 1.62%)1.58s (± 0.47%)-0.01s (- 0.75%)1.57s1.61s
Bind Time0.64s (± 1.10%)0.64s (± 0.46%)+0.00s (+ 0.47%)0.64s0.65s
Check Time4.61s (± 0.67%)4.65s (± 0.52%)+0.04s (+ 0.91%)4.61s4.71s
Emit Time2.77s (± 1.55%)2.81s (± 1.07%)+0.04s (+ 1.34%)2.76s2.89s
Total Time9.61s (± 0.74%)9.68s (± 0.53%)+0.07s (+ 0.75%)9.58s9.81s
material-ui - node (v8.9.0, x86)
Memory used262,477k (± 0.02%)262,327k (± 0.02%)-151k (- 0.06%)262,213k262,418k
Parse Time2.45s (± 0.82%)2.45s (± 0.38%)+0.00s (+ 0.08%)2.43s2.48s
Bind Time0.67s (± 1.60%)0.68s (± 1.00%)+0.01s (+ 2.09%)0.67s0.70s
Check Time15.55s (± 0.25%)15.64s (± 0.43%)+0.10s (+ 0.63%)15.53s15.87s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.66s (± 0.21%)18.78s (± 0.40%)+0.12s (+ 0.63%)18.67s19.04s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@Kingwl

Wenlu Wang (Kingwl) commented Jun 25, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at fcd722a. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used343,856k (± 0.02%)343,404k (± 0.02%)-452k (- 0.13%)343,285k343,548k
Parse Time2.01s (± 0.78%)2.00s (± 0.72%)-0.00s (- 0.20%)1.98s2.04s
Bind Time0.82s (± 0.68%)0.84s (± 1.06%)+0.02s (+ 2.68%)0.82s0.86s
Check Time4.72s (± 0.43%)4.71s (± 0.53%)-0.01s (- 0.32%)4.65s4.77s
Emit Time5.18s (± 0.47%)5.19s (± 0.57%)+0.02s (+ 0.31%)5.16s5.27s
Total Time12.73s (± 0.30%)12.75s (± 0.50%)+0.02s (+ 0.15%)12.66s12.94s
Monaco - node (v10.16.3, x64)
Memory used339,027k (± 0.03%)339,093k (± 0.03%)+65k (+ 0.02%)338,888k339,426k
Parse Time1.59s (± 0.65%)1.58s (± 0.47%)-0.01s (- 0.50%)1.57s1.60s
Bind Time0.71s (± 0.91%)0.72s (± 0.95%)+0.00s (+ 0.56%)0.70s0.73s
Check Time4.85s (± 0.76%)4.88s (± 0.56%)+0.03s (+ 0.58%)4.82s4.93s
Emit Time2.75s (± 0.69%)2.77s (± 0.89%)+0.02s (+ 0.65%)2.73s2.84s
Total Time9.90s (± 0.58%)9.95s (± 0.41%)+0.05s (+ 0.46%)9.86s10.06s
TFS - node (v10.16.3, x64)
Memory used301,943k (± 0.02%)301,980k (± 0.03%)+37k (+ 0.01%)301,822k302,200k
Parse Time1.21s (± 0.83%)1.21s (± 0.48%)-0.01s (- 0.58%)1.20s1.22s
Bind Time0.67s (± 0.60%)0.67s (± 1.12%)-0.00s (- 0.60%)0.64s0.68s
Check Time4.37s (± 0.41%)4.35s (± 0.48%)-0.01s (- 0.32%)4.33s4.41s
Emit Time2.91s (± 0.68%)2.90s (± 1.25%)-0.02s (- 0.55%)2.82s2.98s
Total Time9.17s (± 0.34%)9.12s (± 0.52%)-0.04s (- 0.47%)9.04s9.25s
material-ui - node (v10.16.3, x64)
Memory used459,346k (± 0.01%)459,123k (± 0.01%)-224k (- 0.05%)458,989k459,199k
Parse Time2.04s (± 0.38%)2.04s (± 0.75%)-0.00s (- 0.00%)2.02s2.09s
Bind Time0.65s (± 1.54%)0.67s (± 1.53%)+0.02s (+ 2.29%)0.65s0.69s
Check Time12.85s (± 0.64%)12.90s (± 0.66%)+0.05s (+ 0.39%)12.70s13.08s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.55s (± 0.59%)15.61s (± 0.56%)+0.07s (+ 0.42%)15.42s15.80s
Angular - node (v12.1.0, x64)
Memory used321,092k (± 0.02%)320,670k (± 0.09%)-422k (- 0.13%)319,590k320,918k
Parse Time1.99s (± 0.54%)1.99s (± 0.96%)-0.00s (- 0.05%)1.96s2.05s
Bind Time0.80s (± 0.61%)0.82s (± 1.15%)+0.01s (+ 1.62%)0.81s0.85s
Check Time4.59s (± 0.55%)4.62s (± 0.61%)+0.03s (+ 0.59%)4.56s4.70s
Emit Time5.32s (± 0.46%)5.37s (± 0.79%)+0.05s (+ 0.92%)5.28s5.49s
Total Time12.70s (± 0.37%)12.79s (± 0.53%)+0.09s (+ 0.70%)12.61s12.98s
Monaco - node (v12.1.0, x64)
Memory used321,488k (± 0.02%)321,523k (± 0.02%)+35k (+ 0.01%)321,411k321,614k
Parse Time1.55s (± 0.99%)1.55s (± 0.67%)-0.00s (- 0.19%)1.53s1.57s
Bind Time0.69s (± 1.32%)0.69s (± 1.73%)+0.00s (+ 0.58%)0.68s0.74s
Check Time4.66s (± 0.72%)4.66s (± 0.58%)+0.01s (+ 0.13%)4.61s4.74s
Emit Time2.79s (± 0.77%)2.78s (± 0.39%)-0.01s (- 0.36%)2.76s2.81s
Total Time9.69s (± 0.60%)9.69s (± 0.40%)+0.00s (+ 0.01%)9.62s9.80s
TFS - node (v12.1.0, x64)
Memory used286,477k (± 0.02%)286,487k (± 0.02%)+9k (+ 0.00%)286,350k286,581k
Parse Time1.23s (± 0.96%)1.24s (± 0.62%)+0.00s (+ 0.24%)1.22s1.26s
Bind Time0.63s (± 0.71%)0.64s (± 0.96%)+0.01s (+ 1.42%)0.63s0.65s
Check Time4.27s (± 0.42%)4.27s (± 0.54%)-0.00s (- 0.07%)4.20s4.31s
Emit Time2.91s (± 0.78%)2.91s (± 0.91%)+0.00s (+ 0.14%)2.86s2.97s
Total Time9.05s (± 0.37%)9.06s (± 0.50%)+0.01s (+ 0.12%)8.96s9.17s
material-ui - node (v12.1.0, x64)
Memory used437,764k (± 0.01%)437,579k (± 0.01%)-185k (- 0.04%)437,443k437,702k
Parse Time2.03s (± 0.59%)2.02s (± 0.49%)-0.00s (- 0.25%)2.00s2.04s
Bind Time0.63s (± 1.15%)0.65s (± 1.12%)+0.02s (+ 2.53%)0.63s0.66s
Check Time11.58s (± 0.55%)11.61s (± 0.89%)+0.03s (+ 0.27%)11.34s11.86s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.24s (± 0.49%)14.28s (± 0.72%)+0.04s (+ 0.29%)14.02s14.53s
Angular - node (v8.9.0, x64)
Memory used340,382k (± 0.01%)340,000k (± 0.01%)-382k (- 0.11%)339,905k340,059k
Parse Time2.53s (± 0.59%)2.51s (± 0.33%)-0.02s (- 0.67%)2.50s2.53s
Bind Time0.86s (± 1.12%)0.86s (± 0.78%)-0.00s (- 0.23%)0.84s0.87s
Check Time5.37s (± 0.69%)5.35s (± 0.46%)-0.03s (- 0.47%)5.29s5.41s
Emit Time5.98s (± 1.52%)5.90s (± 1.13%)-0.07s (- 1.20%)5.66s6.00s
Total Time14.74s (± 0.81%)14.62s (± 0.56%)-0.11s (- 0.78%)14.33s14.73s
Monaco - node (v8.9.0, x64)
Memory used340,367k (± 0.02%)340,413k (± 0.01%)+46k (+ 0.01%)340,308k340,530k
Parse Time1.88s (± 0.47%)1.87s (± 0.41%)-0.01s (- 0.48%)1.85s1.89s
Bind Time0.88s (± 0.45%)0.89s (± 0.56%)+0.01s (+ 0.80%)0.88s0.90s
Check Time5.39s (± 0.59%)5.41s (± 0.44%)+0.02s (+ 0.46%)5.34s5.44s
Emit Time3.22s (± 0.44%)3.24s (± 0.70%)+0.02s (+ 0.50%)3.18s3.29s
Total Time11.37s (± 0.33%)11.40s (± 0.37%)+0.04s (+ 0.34%)11.26s11.49s
TFS - node (v8.9.0, x64)
Memory used303,715k (± 0.03%)303,731k (± 0.02%)+16k (+ 0.01%)303,606k303,830k
Parse Time1.54s (± 0.42%)1.54s (± 0.34%)+0.00s (+ 0.20%)1.53s1.55s
Bind Time0.67s (± 0.78%)0.67s (± 0.74%)-0.00s (- 0.45%)0.66s0.68s
Check Time5.00s (± 1.38%)4.88s (± 0.60%)-0.12s (- 2.44%)4.82s4.94s
Emit Time3.03s (± 2.42%)3.16s (± 0.44%)+0.13s (+ 4.36%)3.13s3.19s
Total Time10.23s (± 0.36%)10.25s (± 0.38%)+0.01s (+ 0.13%)10.17s10.33s
material-ui - node (v8.9.0, x64)
Memory used463,576k (± 0.01%)463,306k (± 0.01%)-271k (- 0.06%)463,143k463,393k
Parse Time2.40s (± 0.37%)2.39s (± 0.66%)-0.01s (- 0.42%)2.35s2.42s
Bind Time0.78s (± 1.47%)0.79s (± 1.42%)+0.01s (+ 1.02%)0.77s0.81s
Check Time17.27s (± 0.97%)17.30s (± 1.02%)+0.03s (+ 0.19%)16.83s17.68s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.45s (± 0.82%)20.48s (± 0.86%)+0.03s (+ 0.14%)20.03s20.89s
Angular - node (v8.9.0, x86)
Memory used195,255k (± 0.03%)195,050k (± 0.02%)-205k (- 0.11%)194,967k195,106k
Parse Time2.44s (± 0.66%)2.44s (± 0.49%)-0.00s (- 0.08%)2.42s2.47s
Bind Time0.99s (± 1.16%)1.01s (± 0.99%)+0.02s (+ 1.72%)0.99s1.04s
Check Time4.80s (± 0.49%)4.82s (± 0.68%)+0.02s (+ 0.44%)4.75s4.91s
Emit Time5.94s (± 1.46%)5.94s (± 1.02%)+0.00s (+ 0.03%)5.85s6.10s
Total Time14.17s (± 0.69%)14.21s (± 0.65%)+0.04s (+ 0.28%)14.04s14.45s
Monaco - node (v8.9.0, x86)
Memory used193,419k (± 0.03%)193,416k (± 0.02%)-4k (- 0.00%)193,316k193,511k
Parse Time1.91s (± 0.76%)1.94s (± 1.13%)+0.02s (+ 1.31%)1.88s2.00s
Bind Time0.69s (± 0.80%)0.71s (± 0.91%)+0.02s (+ 2.31%)0.70s0.73s
Check Time5.46s (± 0.41%)5.46s (± 1.10%)0.00s ( 0.00%)5.26s5.55s
Emit Time2.67s (± 1.01%)2.72s (± 3.53%)+0.05s (+ 1.87%)2.64s3.10s
Total Time10.74s (± 0.44%)10.83s (± 0.57%)+0.09s (+ 0.82%)10.73s11.02s
TFS - node (v8.9.0, x86)
Memory used173,673k (± 0.02%)173,700k (± 0.02%)+28k (+ 0.02%)173,624k173,782k
Parse Time1.60s (± 1.62%)1.58s (± 1.13%)-0.01s (- 0.75%)1.55s1.63s
Bind Time0.64s (± 1.10%)0.64s (± 0.63%)-0.00s (- 0.00%)0.63s0.65s
Check Time4.61s (± 0.67%)4.65s (± 1.13%)+0.04s (+ 0.76%)4.56s4.78s
Emit Time2.77s (± 1.55%)2.76s (± 0.95%)-0.01s (- 0.43%)2.71s2.82s
Total Time9.61s (± 0.74%)9.62s (± 0.71%)+0.01s (+ 0.12%)9.49s9.81s
material-ui - node (v8.9.0, x86)
Memory used262,477k (± 0.02%)262,363k (± 0.02%)-115k (- 0.04%)262,232k262,481k
Parse Time2.45s (± 0.82%)2.46s (± 0.78%)+0.01s (+ 0.45%)2.42s2.51s
Bind Time0.67s (± 1.60%)0.68s (± 1.98%)+0.01s (+ 1.19%)0.66s0.72s
Check Time15.55s (± 0.25%)15.62s (± 0.66%)+0.08s (+ 0.50%)15.37s15.89s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.66s (± 0.21%)18.76s (± 0.64%)+0.10s (+ 0.53%)18.50s19.07s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 26, 2020

Copy link
Copy Markdown
Member

After discussing this one-on-one, I think the best thing is to switch away from SymbolFlags.Deprecated and make the checker look at NodeFlags.Deprecated for specific declarations.

@Kingwl

Wenlu Wang (Kingwl) commented Jun 27, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 27, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at 2410ea6. You can monitor the build here.

Update: The results are in!

@Kingwl

Wenlu Wang (Kingwl) commented Jun 27, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 27, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at aab7a32. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used344,004k (± 0.02%)343,499k (± 0.03%)-505k (- 0.15%)343,306k343,714k
Parse Time2.01s (± 0.62%)2.01s (± 0.44%)+0.01s (+ 0.45%)2.00s2.03s
Bind Time0.83s (± 1.36%)0.83s (± 1.14%)-0.00s (- 0.24%)0.81s0.86s
Check Time4.73s (± 0.77%)4.76s (± 0.37%)+0.03s (+ 0.68%)4.72s4.80s
Emit Time5.21s (± 0.98%)5.16s (± 0.44%)-0.06s (- 1.07%)5.09s5.21s
Total Time12.77s (± 0.63%)12.75s (± 0.29%)-0.02s (- 0.13%)12.65s12.81s
Monaco - node (v10.16.3, x64)
Memory used339,139k (± 0.03%)339,049k (± 0.02%)-90k (- 0.03%)338,929k339,187k
Parse Time1.58s (± 0.31%)1.59s (± 0.81%)+0.00s (+ 0.13%)1.57s1.63s
Bind Time0.72s (± 0.81%)0.71s (± 0.78%)-0.01s (- 1.26%)0.70s0.72s
Check Time4.88s (± 0.67%)4.90s (± 0.48%)+0.02s (+ 0.39%)4.85s4.96s
Emit Time2.76s (± 0.93%)2.75s (± 0.96%)-0.01s (- 0.29%)2.70s2.80s
Total Time9.94s (± 0.50%)9.95s (± 0.50%)+0.00s (+ 0.02%)9.86s10.04s
TFS - node (v10.16.3, x64)
Memory used301,984k (± 0.03%)302,024k (± 0.04%)+39k (+ 0.01%)301,756k302,302k
Parse Time1.22s (± 0.47%)1.22s (± 0.69%)-0.00s (- 0.08%)1.20s1.24s
Bind Time0.67s (± 0.71%)0.67s (± 0.67%)+0.00s (+ 0.15%)0.65s0.67s
Check Time4.38s (± 0.50%)4.40s (± 0.58%)+0.02s (+ 0.48%)4.36s4.49s
Emit Time2.89s (± 0.87%)2.92s (± 1.24%)+0.04s (+ 1.32%)2.85s3.03s
Total Time9.15s (± 0.39%)9.21s (± 0.65%)+0.06s (+ 0.62%)9.10s9.37s
material-ui - node (v10.16.3, x64)
Memory used459,391k (± 0.02%)459,144k (± 0.01%)-247k (- 0.05%)459,051k459,246k
Parse Time2.04s (± 0.48%)2.04s (± 0.46%)+0.00s (+ 0.10%)2.02s2.06s
Bind Time0.66s (± 1.67%)0.66s (± 1.45%)-0.01s (- 1.06%)0.63s0.67s
Check Time12.95s (± 0.71%)12.93s (± 0.85%)-0.02s (- 0.19%)12.72s13.18s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.65s (± 0.61%)15.62s (± 0.76%)-0.03s (- 0.20%)15.38s15.89s
Angular - node (v12.1.0, x64)
Memory used321,124k (± 0.02%)320,649k (± 0.02%)-476k (- 0.15%)320,511k320,881k
Parse Time1.99s (± 0.70%)2.01s (± 0.61%)+0.02s (+ 0.85%)1.97s2.03s
Bind Time0.81s (± 0.46%)0.81s (± 0.84%)+0.00s (+ 0.12%)0.79s0.82s
Check Time4.63s (± 0.50%)4.65s (± 0.66%)+0.02s (+ 0.39%)4.59s4.70s
Emit Time5.34s (± 0.59%)5.36s (± 1.14%)+0.02s (+ 0.36%)5.29s5.57s
Total Time12.77s (± 0.40%)12.82s (± 0.54%)+0.06s (+ 0.45%)12.68s12.98s
Monaco - node (v12.1.0, x64)
Memory used321,473k (± 0.01%)321,571k (± 0.01%)+98k (+ 0.03%)321,451k321,651k
Parse Time1.55s (± 0.88%)1.56s (± 0.57%)+0.01s (+ 0.90%)1.55s1.59s
Bind Time0.69s (± 0.69%)0.69s (± 1.05%)-0.00s (- 0.14%)0.68s0.71s
Check Time4.65s (± 0.53%)4.69s (± 0.55%)+0.03s (+ 0.69%)4.62s4.73s
Emit Time2.80s (± 0.56%)2.81s (± 0.69%)+0.01s (+ 0.39%)2.76s2.86s
Total Time9.70s (± 0.39%)9.75s (± 0.41%)+0.05s (+ 0.57%)9.67s9.84s
TFS - node (v12.1.0, x64)
Memory used286,485k (± 0.02%)286,535k (± 0.03%)+50k (+ 0.02%)286,346k286,801k
Parse Time1.24s (± 0.57%)1.23s (± 0.89%)-0.01s (- 0.56%)1.21s1.25s
Bind Time0.64s (± 1.47%)0.64s (± 0.97%)-0.00s (- 0.16%)0.62s0.65s
Check Time4.26s (± 0.41%)4.30s (± 0.50%)+0.04s (+ 0.85%)4.24s4.33s
Emit Time2.90s (± 0.57%)2.92s (± 1.04%)+0.02s (+ 0.52%)2.84s2.97s
Total Time9.04s (± 0.36%)9.08s (± 0.45%)+0.04s (+ 0.49%)8.99s9.16s
material-ui - node (v12.1.0, x64)
Memory used437,554k (± 0.07%)437,495k (± 0.05%)-59k (- 0.01%)436,734k437,744k
Parse Time2.02s (± 0.93%)2.03s (± 0.73%)+0.01s (+ 0.25%)2.00s2.07s
Bind Time0.63s (± 1.07%)0.64s (± 1.20%)+0.00s (+ 0.16%)0.62s0.65s
Check Time11.72s (± 1.30%)11.70s (± 1.02%)-0.02s (- 0.20%)11.44s12.00s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.38s (± 1.09%)14.36s (± 0.89%)-0.02s (- 0.12%)14.09s14.68s
Angular - node (v8.9.0, x64)
Memory used340,440k (± 0.02%)340,062k (± 0.01%)-379k (- 0.11%)339,969k340,177k
Parse Time2.54s (± 0.68%)2.52s (± 0.43%)-0.02s (- 0.63%)2.50s2.56s
Bind Time0.86s (± 0.46%)0.86s (± 0.80%)-0.01s (- 0.58%)0.85s0.88s
Check Time5.38s (± 0.64%)5.37s (± 0.47%)-0.00s (- 0.07%)5.33s5.46s
Emit Time5.98s (± 1.76%)5.90s (± 0.93%)-0.07s (- 1.25%)5.72s5.97s
Total Time14.75s (± 0.88%)14.66s (± 0.45%)-0.10s (- 0.66%)14.47s14.82s
Monaco - node (v8.9.0, x64)
Memory used340,437k (± 0.01%)340,457k (± 0.02%)+20k (+ 0.01%)340,249k340,612k
Parse Time1.88s (± 0.37%)1.87s (± 0.36%)-0.01s (- 0.32%)1.86s1.89s
Bind Time0.89s (± 0.54%)0.88s (± 0.70%)-0.01s (- 0.68%)0.87s0.90s
Check Time5.41s (± 0.51%)5.39s (± 0.46%)-0.01s (- 0.22%)5.34s5.46s
Emit Time3.24s (± 0.90%)3.24s (± 0.95%)-0.00s (- 0.03%)3.19s3.33s
Total Time11.42s (± 0.24%)11.39s (± 0.44%)-0.03s (- 0.25%)11.30s11.53s
TFS - node (v8.9.0, x64)
Memory used303,742k (± 0.01%)303,723k (± 0.02%)-20k (- 0.01%)303,541k303,806k
Parse Time1.55s (± 0.96%)1.55s (± 0.57%)+0.00s (+ 0.00%)1.53s1.57s
Bind Time0.67s (± 0.97%)0.67s (± 1.03%)-0.00s (- 0.45%)0.65s0.68s
Check Time4.97s (± 1.60%)5.04s (± 1.76%)+0.07s (+ 1.39%)4.88s5.20s
Emit Time3.11s (± 2.13%)3.03s (± 2.30%)-0.08s (- 2.70%)2.91s3.16s
Total Time10.30s (± 0.64%)10.28s (± 0.46%)-0.02s (- 0.19%)10.14s10.36s
material-ui - node (v8.9.0, x64)
Memory used463,658k (± 0.01%)463,347k (± 0.01%)-311k (- 0.07%)463,248k463,438k
Parse Time2.39s (± 0.35%)2.39s (± 0.42%)+0.00s (+ 0.17%)2.36s2.41s
Bind Time0.78s (± 1.95%)0.77s (± 1.23%)-0.00s (- 0.51%)0.75s0.79s
Check Time17.29s (± 0.60%)17.15s (± 1.31%)-0.14s (- 0.80%)16.61s17.70s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.46s (± 0.54%)20.31s (± 1.10%)-0.15s (- 0.72%)19.75s20.86s
Angular - node (v8.9.0, x86)
Memory used195,277k (± 0.02%)195,126k (± 0.02%)-151k (- 0.08%)195,063k195,208k
Parse Time2.45s (± 0.69%)2.46s (± 0.85%)+0.01s (+ 0.24%)2.42s2.51s
Bind Time1.00s (± 1.11%)0.99s (± 0.69%)-0.01s (- 1.10%)0.97s1.00s
Check Time4.79s (± 0.78%)4.84s (± 0.55%)+0.05s (+ 0.98%)4.76s4.91s
Emit Time5.95s (± 1.35%)5.87s (± 1.07%)-0.08s (- 1.31%)5.66s5.96s
Total Time14.19s (± 0.87%)14.16s (± 0.50%)-0.04s (- 0.25%)13.96s14.26s
Monaco - node (v8.9.0, x86)
Memory used193,443k (± 0.01%)193,452k (± 0.02%)+9k (+ 0.00%)193,385k193,508k
Parse Time1.92s (± 0.91%)1.91s (± 1.22%)-0.00s (- 0.21%)1.88s1.97s
Bind Time0.70s (± 0.95%)0.70s (± 1.15%)-0.00s (- 0.29%)0.69s0.72s
Check Time5.44s (± 1.35%)5.50s (± 0.67%)+0.06s (+ 1.03%)5.43s5.59s
Emit Time2.71s (± 2.86%)2.66s (± 0.77%)-0.05s (- 1.84%)2.63s2.72s
Total Time10.78s (± 0.69%)10.77s (± 0.53%)-0.00s (- 0.03%)10.71s10.94s
TFS - node (v8.9.0, x86)
Memory used173,684k (± 0.02%)173,684k (± 0.02%)+1k (+ 0.00%)173,580k173,774k
Parse Time1.59s (± 1.79%)1.60s (± 0.86%)+0.00s (+ 0.06%)1.57s1.63s
Bind Time0.64s (± 0.63%)0.64s (± 0.35%)0.00s ( 0.00%)0.63s0.64s
Check Time4.63s (± 0.68%)4.71s (± 0.68%)+0.08s (+ 1.66%)4.66s4.81s
Emit Time2.79s (± 1.53%)2.81s (± 1.29%)+0.03s (+ 0.93%)2.70s2.90s
Total Time9.65s (± 0.56%)9.76s (± 0.60%)+0.11s (+ 1.09%)9.63s9.89s
material-ui - node (v8.9.0, x86)
Memory used262,517k (± 0.01%)262,368k (± 0.01%)-149k (- 0.06%)262,264k262,439k
Parse Time2.45s (± 0.71%)2.44s (± 0.99%)-0.02s (- 0.61%)2.41s2.53s
Bind Time0.67s (± 1.11%)0.66s (± 0.90%)-0.01s (- 0.75%)0.65s0.68s
Check Time15.72s (± 0.67%)15.62s (± 0.60%)-0.10s (- 0.64%)15.35s15.78s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.85s (± 0.54%)18.73s (± 0.57%)-0.12s (- 0.62%)18.44s18.98s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used344,004k (± 0.02%)343,492k (± 0.03%)-512k (- 0.15%)343,348k343,718k
Parse Time2.01s (± 0.62%)2.01s (± 0.62%)+0.01s (+ 0.40%)1.98s2.04s
Bind Time0.83s (± 1.36%)0.82s (± 0.82%)-0.01s (- 1.45%)0.80s0.83s
Check Time4.73s (± 0.77%)4.75s (± 0.59%)+0.03s (+ 0.59%)4.71s4.81s
Emit Time5.21s (± 0.98%)5.20s (± 0.31%)-0.01s (- 0.15%)5.18s5.24s
Total Time12.77s (± 0.63%)12.79s (± 0.34%)+0.02s (+ 0.16%)12.73s12.89s
Monaco - node (v10.16.3, x64)
Memory used339,139k (± 0.03%)339,082k (± 0.03%)-57k (- 0.02%)338,881k339,343k
Parse Time1.58s (± 0.31%)1.59s (± 0.53%)+0.01s (+ 0.38%)1.56s1.60s
Bind Time0.72s (± 0.81%)0.71s (± 0.84%)-0.00s (- 0.28%)0.70s0.73s
Check Time4.88s (± 0.67%)4.91s (± 0.49%)+0.03s (+ 0.55%)4.86s4.96s
Emit Time2.76s (± 0.93%)2.77s (± 0.64%)+0.01s (+ 0.36%)2.74s2.82s
Total Time9.94s (± 0.50%)9.98s (± 0.38%)+0.04s (+ 0.38%)9.92s10.07s
TFS - node (v10.16.3, x64)
Memory used301,984k (± 0.03%)302,017k (± 0.02%)+33k (+ 0.01%)301,851k302,174k
Parse Time1.22s (± 0.47%)1.22s (± 0.45%)+0.00s (+ 0.16%)1.21s1.23s
Bind Time0.67s (± 0.71%)0.67s (± 0.70%)+0.00s (+ 0.45%)0.66s0.68s
Check Time4.38s (± 0.50%)4.42s (± 0.49%)+0.04s (+ 0.82%)4.37s4.46s
Emit Time2.89s (± 0.87%)2.94s (± 0.83%)+0.05s (+ 1.84%)2.88s3.00s
Total Time9.15s (± 0.39%)9.24s (± 0.44%)+0.09s (+ 1.01%)9.14s9.35s
material-ui - node (v10.16.3, x64)
Memory used459,391k (± 0.02%)459,070k (± 0.01%)-320k (- 0.07%)458,936k459,209k
Parse Time2.04s (± 0.48%)2.05s (± 0.34%)+0.01s (+ 0.54%)2.03s2.06s
Bind Time0.66s (± 1.67%)0.66s (± 1.42%)+0.00s (+ 0.00%)0.64s0.68s
Check Time12.95s (± 0.71%)13.06s (± 0.75%)+0.11s (+ 0.82%)12.89s13.32s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.65s (± 0.61%)15.77s (± 0.63%)+0.12s (+ 0.75%)15.60s16.02s
Angular - node (v12.1.0, x64)
Memory used321,124k (± 0.02%)320,727k (± 0.03%)-398k (- 0.12%)320,515k320,890k
Parse Time1.99s (± 0.70%)2.00s (± 0.67%)+0.01s (+ 0.35%)1.96s2.03s
Bind Time0.81s (± 0.46%)0.81s (± 0.42%)+0.00s (+ 0.25%)0.80s0.81s
Check Time4.63s (± 0.50%)4.66s (± 0.40%)+0.03s (+ 0.63%)4.62s4.70s
Emit Time5.34s (± 0.59%)5.37s (± 0.57%)+0.02s (+ 0.39%)5.31s5.44s
Total Time12.77s (± 0.40%)12.83s (± 0.33%)+0.06s (+ 0.47%)12.75s12.92s
Monaco - node (v12.1.0, x64)
Memory used321,473k (± 0.01%)321,495k (± 0.02%)+22k (+ 0.01%)321,397k321,655k
Parse Time1.55s (± 0.88%)1.56s (± 0.82%)+0.01s (+ 0.65%)1.53s1.58s
Bind Time0.69s (± 0.69%)0.69s (± 0.48%)-0.00s (- 0.43%)0.68s0.70s
Check Time4.65s (± 0.53%)4.70s (± 0.58%)+0.04s (+ 0.95%)4.62s4.74s
Emit Time2.80s (± 0.56%)2.80s (± 0.60%)-0.00s (- 0.00%)2.77s2.85s
Total Time9.70s (± 0.39%)9.75s (± 0.37%)+0.05s (+ 0.53%)9.65s9.81s
TFS - node (v12.1.0, x64)
Memory used286,485k (± 0.02%)286,536k (± 0.03%)+51k (+ 0.02%)286,392k286,728k
Parse Time1.24s (± 0.57%)1.24s (± 0.55%)-0.00s (- 0.24%)1.22s1.25s
Bind Time0.64s (± 1.47%)0.64s (± 1.87%)+0.00s (+ 0.63%)0.63s0.69s
Check Time4.26s (± 0.41%)4.32s (± 0.55%)+0.06s (+ 1.46%)4.28s4.38s
Emit Time2.90s (± 0.57%)2.94s (± 1.27%)+0.04s (+ 1.41%)2.89s3.05s
Total Time9.04s (± 0.36%)9.14s (± 0.55%)+0.11s (+ 1.17%)9.03s9.26s
material-ui - node (v12.1.0, x64)
Memory used437,554k (± 0.07%)437,539k (± 0.02%)-14k (- 0.00%)437,416k437,742k
Parse Time2.02s (± 0.93%)2.03s (± 0.46%)+0.01s (+ 0.40%)2.01s2.06s
Bind Time0.63s (± 1.07%)0.63s (± 1.11%)-0.00s (- 0.79%)0.62s0.65s
Check Time11.72s (± 1.30%)11.61s (± 0.39%)-0.12s (- 0.99%)11.52s11.72s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.38s (± 1.09%)14.27s (± 0.34%)-0.11s (- 0.77%)14.17s14.38s
Angular - node (v8.9.0, x64)
Memory used340,440k (± 0.02%)340,074k (± 0.01%)-366k (- 0.11%)339,954k340,181k
Parse Time2.54s (± 0.68%)2.54s (± 0.76%)+0.00s (+ 0.16%)2.51s2.59s
Bind Time0.86s (± 0.46%)0.86s (± 0.43%)+0.00s (+ 0.46%)0.86s0.87s
Check Time5.38s (± 0.64%)5.40s (± 0.72%)+0.02s (+ 0.39%)5.30s5.47s
Emit Time5.98s (± 1.76%)6.01s (± 0.89%)+0.03s (+ 0.47%)5.90s6.14s
Total Time14.75s (± 0.88%)14.81s (± 0.60%)+0.06s (+ 0.39%)14.61s15.04s
Monaco - node (v8.9.0, x64)
Memory used340,437k (± 0.01%)340,412k (± 0.01%)-25k (- 0.01%)340,316k340,475k
Parse Time1.88s (± 0.37%)1.88s (± 0.64%)-0.00s (- 0.16%)1.85s1.91s
Bind Time0.89s (± 0.54%)0.89s (± 0.38%)0.00s ( 0.00%)0.88s0.89s
Check Time5.41s (± 0.51%)5.44s (± 0.50%)+0.03s (+ 0.61%)5.39s5.51s
Emit Time3.24s (± 0.90%)3.24s (± 0.45%)-0.00s (- 0.06%)3.21s3.27s
Total Time11.42s (± 0.24%)11.44s (± 0.34%)+0.03s (+ 0.23%)11.38s11.55s
TFS - node (v8.9.0, x64)
Memory used303,742k (± 0.01%)303,767k (± 0.01%)+25k (+ 0.01%)303,656k303,839k
Parse Time1.55s (± 0.96%)1.55s (± 0.53%)-0.00s (- 0.26%)1.53s1.56s
Bind Time0.67s (± 0.97%)0.67s (± 1.02%)-0.00s (- 0.30%)0.65s0.68s
Check Time4.97s (± 1.60%)5.03s (± 1.67%)+0.06s (+ 1.21%)4.90s5.26s
Emit Time3.11s (± 2.13%)3.11s (± 2.80%)+0.00s (+ 0.00%)2.91s3.20s
Total Time10.30s (± 0.64%)10.36s (± 0.53%)+0.06s (+ 0.57%)10.25s10.46s
material-ui - node (v8.9.0, x64)
Memory used463,658k (± 0.01%)463,344k (± 0.01%)-314k (- 0.07%)463,248k463,488k
Parse Time2.39s (± 0.35%)2.39s (± 0.52%)+0.00s (+ 0.08%)2.36s2.42s
Bind Time0.78s (± 1.95%)0.78s (± 0.90%)+0.00s (+ 0.13%)0.76s0.79s
Check Time17.29s (± 0.60%)17.34s (± 1.15%)+0.05s (+ 0.27%)16.95s17.76s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.46s (± 0.54%)20.51s (± 0.97%)+0.05s (+ 0.23%)20.12s20.95s
Angular - node (v8.9.0, x86)
Memory used195,277k (± 0.02%)195,090k (± 0.02%)-188k (- 0.10%)194,968k195,196k
Parse Time2.45s (± 0.69%)2.47s (± 0.71%)+0.02s (+ 0.77%)2.42s2.50s
Bind Time1.00s (± 1.11%)0.99s (± 0.96%)-0.00s (- 0.20%)0.97s1.01s
Check Time4.79s (± 0.78%)4.83s (± 0.54%)+0.04s (+ 0.79%)4.76s4.87s
Emit Time5.95s (± 1.35%)5.93s (± 0.51%)-0.02s (- 0.25%)5.86s6.01s
Total Time14.19s (± 0.87%)14.23s (± 0.38%)+0.04s (+ 0.30%)14.12s14.37s
Monaco - node (v8.9.0, x86)
Memory used193,443k (± 0.01%)193,452k (± 0.02%)+9k (+ 0.00%)193,379k193,523k
Parse Time1.92s (± 0.91%)1.92s (± 0.78%)+0.00s (+ 0.05%)1.89s1.95s
Bind Time0.70s (± 0.95%)0.70s (± 0.88%)-0.00s (- 0.14%)0.69s0.71s
Check Time5.44s (± 1.35%)5.48s (± 1.32%)+0.04s (+ 0.72%)5.25s5.59s
Emit Time2.71s (± 2.86%)2.75s (± 4.62%)+0.04s (+ 1.33%)2.62s3.13s
Total Time10.78s (± 0.69%)10.84s (± 0.72%)+0.07s (+ 0.64%)10.69s11.04s
TFS - node (v8.9.0, x86)
Memory used173,684k (± 0.02%)173,701k (± 0.03%)+17k (+ 0.01%)173,591k173,891k
Parse Time1.59s (± 1.79%)1.61s (± 1.22%)+0.02s (+ 1.13%)1.58s1.65s
Bind Time0.64s (± 0.63%)0.64s (± 0.47%)-0.00s (- 0.16%)0.63s0.64s
Check Time4.63s (± 0.68%)4.70s (± 0.36%)+0.06s (+ 1.36%)4.67s4.74s
Emit Time2.79s (± 1.53%)2.81s (± 1.36%)+0.02s (+ 0.90%)2.73s2.90s
Total Time9.65s (± 0.56%)9.75s (± 0.50%)+0.10s (+ 1.05%)9.67s9.91s
material-ui - node (v8.9.0, x86)
Memory used262,517k (± 0.01%)262,420k (± 0.02%)-97k (- 0.04%)262,311k262,513k
Parse Time2.45s (± 0.71%)2.46s (± 0.76%)+0.00s (+ 0.04%)2.42s2.50s
Bind Time0.67s (± 1.11%)0.67s (± 0.56%)-0.01s (- 0.75%)0.66s0.67s
Check Time15.72s (± 0.67%)15.75s (± 0.70%)+0.02s (+ 0.15%)15.54s15.96s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.85s (± 0.54%)18.87s (± 0.58%)+0.02s (+ 0.10%)18.64s19.07s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@Kingwl

Wenlu Wang (Kingwl) commented Jun 27, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 27, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at aab7a32. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used344,004k (± 0.02%)343,597k (± 0.03%)-407k (- 0.12%)343,391k343,881k
Parse Time2.01s (± 0.62%)2.01s (± 0.46%)+0.00s (+ 0.10%)1.98s2.03s
Bind Time0.83s (± 1.36%)0.82s (± 0.83%)-0.00s (- 0.48%)0.81s0.84s
Check Time4.73s (± 0.77%)4.77s (± 0.80%)+0.05s (+ 0.97%)4.66s4.83s
Emit Time5.21s (± 0.98%)5.20s (± 0.70%)-0.01s (- 0.19%)5.13s5.29s
Total Time12.77s (± 0.63%)12.81s (± 0.58%)+0.03s (+ 0.27%)12.63s12.96s
Monaco - node (v10.16.3, x64)
Memory used339,139k (± 0.03%)339,101k (± 0.04%)-38k (- 0.01%)338,961k339,541k
Parse Time1.58s (± 0.31%)1.59s (± 0.70%)+0.00s (+ 0.06%)1.56s1.61s
Bind Time0.72s (± 0.81%)0.72s (± 0.66%)0.00s ( 0.00%)0.71s0.73s
Check Time4.88s (± 0.67%)4.90s (± 0.59%)+0.02s (+ 0.43%)4.82s4.96s
Emit Time2.76s (± 0.93%)2.77s (± 0.85%)+0.01s (+ 0.29%)2.73s2.83s
Total Time9.94s (± 0.50%)9.98s (± 0.45%)+0.03s (+ 0.31%)9.83s10.05s
TFS - node (v10.16.3, x64)
Memory used301,984k (± 0.03%)302,073k (± 0.03%)+89k (+ 0.03%)301,923k302,243k
Parse Time1.22s (± 0.47%)1.22s (± 0.79%)-0.00s (- 0.08%)1.21s1.25s
Bind Time0.67s (± 0.71%)0.67s (± 0.60%)+0.00s (+ 0.60%)0.66s0.68s
Check Time4.38s (± 0.50%)4.41s (± 0.38%)+0.03s (+ 0.64%)4.37s4.45s
Emit Time2.89s (± 0.87%)2.89s (± 0.87%)0.00s ( 0.00%)2.83s2.94s
Total Time9.15s (± 0.39%)9.18s (± 0.46%)+0.03s (+ 0.34%)9.12s9.28s
material-ui - node (v10.16.3, x64)
Memory used459,391k (± 0.02%)459,048k (± 0.01%)-343k (- 0.07%)458,935k459,118k
Parse Time2.04s (± 0.48%)2.05s (± 0.68%)+0.01s (+ 0.49%)2.01s2.09s
Bind Time0.66s (± 1.67%)0.66s (± 1.02%)-0.01s (- 0.90%)0.65s0.67s
Check Time12.95s (± 0.71%)13.00s (± 0.89%)+0.05s (+ 0.36%)12.73s13.23s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.65s (± 0.61%)15.70s (± 0.82%)+0.05s (+ 0.31%)15.39s15.98s
Angular - node (v12.1.0, x64)
Memory used321,124k (± 0.02%)320,348k (± 0.14%)-776k (- 0.24%)319,348k320,963k
Parse Time1.99s (± 0.70%)1.99s (± 0.77%)+0.00s (+ 0.15%)1.95s2.02s
Bind Time0.81s (± 0.46%)0.81s (± 0.00%)+0.01s (+ 0.62%)0.81s0.81s
Check Time4.63s (± 0.50%)4.68s (± 0.72%)+0.05s (+ 1.17%)4.61s4.77s
Emit Time5.34s (± 0.59%)5.37s (± 0.69%)+0.02s (+ 0.43%)5.27s5.43s
Total Time12.77s (± 0.40%)12.85s (± 0.56%)+0.08s (+ 0.67%)12.64s12.98s
Monaco - node (v12.1.0, x64)
Memory used321,473k (± 0.01%)321,546k (± 0.01%)+74k (+ 0.02%)321,477k321,646k
Parse Time1.55s (± 0.88%)1.56s (± 0.74%)+0.01s (+ 0.84%)1.54s1.59s
Bind Time0.69s (± 0.69%)0.70s (± 0.71%)+0.00s (+ 0.43%)0.69s0.71s
Check Time4.65s (± 0.53%)4.67s (± 0.48%)+0.02s (+ 0.43%)4.62s4.72s
Emit Time2.80s (± 0.56%)2.81s (± 0.85%)+0.01s (+ 0.29%)2.77s2.89s
Total Time9.70s (± 0.39%)9.74s (± 0.38%)+0.04s (+ 0.44%)9.64s9.81s
TFS - node (v12.1.0, x64)
Memory used286,485k (± 0.02%)286,528k (± 0.03%)+44k (+ 0.02%)286,363k286,701k
Parse Time1.24s (± 0.57%)1.24s (± 0.61%)+0.00s (+ 0.40%)1.22s1.25s
Bind Time0.64s (± 1.47%)0.64s (± 0.96%)+0.00s (+ 0.16%)0.63s0.65s
Check Time4.26s (± 0.41%)4.32s (± 0.56%)+0.06s (+ 1.31%)4.24s4.37s
Emit Time2.90s (± 0.57%)2.94s (± 0.57%)+0.04s (+ 1.31%)2.90s2.98s
Total Time9.04s (± 0.36%)9.14s (± 0.39%)+0.10s (+ 1.10%)9.01s9.19s
material-ui - node (v12.1.0, x64)
Memory used437,554k (± 0.07%)437,478k (± 0.05%)-75k (- 0.02%)436,706k437,655k
Parse Time2.02s (± 0.93%)2.03s (± 0.34%)+0.00s (+ 0.05%)2.01s2.04s
Bind Time0.63s (± 1.07%)0.63s (± 0.88%)-0.00s (- 0.32%)0.62s0.64s
Check Time11.72s (± 1.30%)11.72s (± 0.89%)-0.01s (- 0.04%)11.49s11.96s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.38s (± 1.09%)14.38s (± 0.75%)-0.00s (- 0.03%)14.15s14.62s
Angular - node (v8.9.0, x64)
Memory used340,440k (± 0.02%)340,033k (± 0.01%)-407k (- 0.12%)339,922k340,144k
Parse Time2.54s (± 0.68%)2.54s (± 0.66%)+0.00s (+ 0.00%)2.50s2.58s
Bind Time0.86s (± 0.46%)0.86s (± 0.75%)+0.00s (+ 0.12%)0.85s0.88s
Check Time5.38s (± 0.64%)5.38s (± 0.44%)+0.00s (+ 0.04%)5.33s5.44s
Emit Time5.98s (± 1.76%)5.92s (± 1.67%)-0.06s (- 0.94%)5.63s6.11s
Total Time14.75s (± 0.88%)14.70s (± 0.69%)-0.05s (- 0.37%)14.45s14.94s
Monaco - node (v8.9.0, x64)
Memory used340,437k (± 0.01%)340,470k (± 0.01%)+34k (+ 0.01%)340,393k340,589k
Parse Time1.88s (± 0.37%)1.88s (± 0.48%)-0.00s (- 0.16%)1.86s1.90s
Bind Time0.89s (± 0.54%)0.89s (± 0.41%)-0.00s (- 0.11%)0.88s0.89s
Check Time5.41s (± 0.51%)5.42s (± 0.45%)+0.02s (+ 0.30%)5.37s5.49s
Emit Time3.24s (± 0.90%)3.25s (± 0.56%)+0.01s (+ 0.19%)3.21s3.30s
Total Time11.42s (± 0.24%)11.43s (± 0.34%)+0.01s (+ 0.13%)11.36s11.56s
TFS - node (v8.9.0, x64)
Memory used303,742k (± 0.01%)303,777k (± 0.02%)+35k (+ 0.01%)303,632k303,890k
Parse Time1.55s (± 0.96%)1.55s (± 0.48%)-0.00s (- 0.19%)1.53s1.56s
Bind Time0.67s (± 0.97%)0.67s (± 0.92%)+0.00s (+ 0.45%)0.66s0.68s
Check Time4.97s (± 1.60%)5.12s (± 1.46%)+0.15s (+ 3.04%)4.96s5.25s
Emit Time3.11s (± 2.13%)3.02s (± 3.03%)🟩-0.10s (- 3.05%)2.83s3.19s
Total Time10.30s (± 0.64%)10.35s (± 0.50%)+0.05s (+ 0.50%)10.22s10.44s
material-ui - node (v8.9.0, x64)
Memory used463,658k (± 0.01%)463,373k (± 0.01%)-285k (- 0.06%)463,219k463,496k
Parse Time2.39s (± 0.35%)2.40s (± 0.56%)+0.01s (+ 0.42%)2.36s2.42s
Bind Time0.78s (± 1.95%)0.79s (± 1.54%)+0.01s (+ 0.90%)0.76s0.82s
Check Time17.29s (± 0.60%)17.31s (± 0.98%)+0.02s (+ 0.12%)16.78s17.62s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.46s (± 0.54%)20.50s (± 0.82%)+0.04s (+ 0.18%)20.02s20.81s
Angular - node (v8.9.0, x86)
Memory used195,277k (± 0.02%)195,078k (± 0.02%)-199k (- 0.10%)195,025k195,166k
Parse Time2.45s (± 0.69%)2.44s (± 0.46%)-0.02s (- 0.61%)2.41s2.47s
Bind Time1.00s (± 1.11%)0.99s (± 1.21%)-0.00s (- 0.30%)0.97s1.03s
Check Time4.79s (± 0.78%)4.84s (± 0.59%)+0.04s (+ 0.90%)4.77s4.91s
Emit Time5.95s (± 1.35%)5.94s (± 1.58%)-0.01s (- 0.10%)5.78s6.25s
Total Time14.19s (± 0.87%)14.21s (± 0.68%)+0.02s (+ 0.16%)14.02s14.50s
Monaco - node (v8.9.0, x86)
Memory used193,443k (± 0.01%)193,433k (± 0.02%)-10k (- 0.01%)193,366k193,504k
Parse Time1.92s (± 0.91%)1.91s (± 0.75%)-0.01s (- 0.31%)1.89s1.95s
Bind Time0.70s (± 0.95%)0.70s (± 0.88%)+0.00s (+ 0.14%)0.69s0.72s
Check Time5.44s (± 1.35%)5.52s (± 0.70%)+0.07s (+ 1.38%)5.44s5.64s
Emit Time2.71s (± 2.86%)2.68s (± 1.22%)-0.03s (- 1.14%)2.63s2.79s
Total Time10.78s (± 0.69%)10.81s (± 0.47%)+0.04s (+ 0.35%)10.70s10.91s
TFS - node (v8.9.0, x86)
Memory used173,684k (± 0.02%)173,700k (± 0.02%)+16k (+ 0.01%)173,635k173,788k
Parse Time1.59s (± 1.79%)1.58s (± 1.05%)-0.01s (- 0.82%)1.56s1.64s
Bind Time0.64s (± 0.63%)0.64s (± 0.96%)+0.00s (+ 0.31%)0.63s0.66s
Check Time4.63s (± 0.68%)4.69s (± 0.49%)+0.06s (+ 1.25%)4.65s4.75s
Emit Time2.79s (± 1.53%)2.78s (± 1.02%)-0.01s (- 0.25%)2.73s2.86s
Total Time9.65s (± 0.56%)9.69s (± 0.50%)+0.04s (+ 0.41%)9.61s9.83s
material-ui - node (v8.9.0, x86)
Memory used262,517k (± 0.01%)262,368k (± 0.02%)-150k (- 0.06%)262,258k262,467k
Parse Time2.45s (± 0.71%)2.45s (± 0.49%)-0.01s (- 0.29%)2.42s2.47s
Bind Time0.67s (± 1.11%)0.67s (± 0.83%)+0.00s (+ 0.30%)0.66s0.68s
Check Time15.72s (± 0.67%)15.72s (± 0.56%)-0.01s (- 0.04%)15.47s15.86s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.85s (± 0.54%)18.84s (± 0.53%)-0.01s (- 0.05%)18.56s18.98s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

Merged
sandersn
Nathan Shively-Sanders (sandersn) reviewed Jun 29, 2020
View reviewed changes

@sandersnNathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty good fix now. It just needs to use SymbolLinks instead of Symbol.

After that's done, let's just take whichever is faster, this or #39323.

Comment threadsrc/compiler/utilities.ts Outdated
}

export function getDeprecatedFlags(symbol: Symbol) {
if (symbol.flags & SymbolFlags.Deprecated) {

@sandersnNathan Shively-Sanders (sandersn)Jun 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of modifying Symbol, please using SymbolLinks with getSymbolLinks to cache deprecatedFlags.

@sandersnNathan Shively-Sanders (sandersn)Jun 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the function should also move into the checker; pretty sure getSymbolLinks is not exported)

Comment threadsrc/compiler/utilities.ts Outdated
}

export function getDeprecatedFlags(symbol: Symbol) {
if (symbol.flags & SymbolFlags.Deprecated) {

@sandersnNathan Shively-Sanders (sandersn)Jun 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would invert the symbol.flags & SymbolFlags.Deprecated check to immediately return None.

@Kingwl

Wenlu Wang (Kingwl) commented Jun 30, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) pack this.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 30, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 11340da. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 30, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/78206/artifacts?artifactName=tgz&fileId=968583AD3AFC177CF1D2AEFDE9D9A15AF08E3D393A8BA33D190A8932A13B422702&fileName=/typescript-4.0.0-insiders.20200630.tgz"
}
}

and then running npm install.

There is also a playground for this build.

@Kingwl

Wenlu Wang (Kingwl) commented Jun 30, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 30, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at 11340da. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used343,977k (± 0.02%)343,478k (± 0.02%)-499k (- 0.15%)343,295k343,656k
Parse Time2.02s (± 0.60%)2.01s (± 0.78%)-0.00s (- 0.25%)1.98s2.05s
Bind Time0.82s (± 0.83%)0.83s (± 2.36%)+0.01s (+ 1.33%)0.80s0.89s
Check Time4.74s (± 0.57%)4.74s (± 0.60%)-0.00s (- 0.04%)4.68s4.79s
Emit Time5.20s (± 0.61%)5.17s (± 0.45%)-0.02s (- 0.42%)5.14s5.24s
Total Time12.78s (± 0.40%)12.76s (± 0.49%)-0.02s (- 0.15%)12.63s12.91s
Monaco - node (v10.16.3, x64)
Memory used339,040k (± 0.01%)339,068k (± 0.02%)+29k (+ 0.01%)338,939k339,245k
Parse Time1.60s (± 0.83%)1.59s (± 0.69%)-0.00s (- 0.31%)1.57s1.62s
Bind Time0.71s (± 0.83%)0.71s (± 0.48%)-0.00s (- 0.14%)0.71s0.72s
Check Time4.88s (± 0.58%)4.89s (± 0.42%)+0.00s (+ 0.04%)4.84s4.93s
Emit Time2.76s (± 0.85%)2.76s (± 0.71%)+0.00s (+ 0.00%)2.72s2.80s
Total Time9.96s (± 0.52%)9.95s (± 0.41%)-0.01s (- 0.06%)9.87s10.06s
TFS - node (v10.16.3, x64)
Memory used301,963k (± 0.02%)302,025k (± 0.03%)+62k (+ 0.02%)301,852k302,259k
Parse Time1.22s (± 0.71%)1.22s (± 0.39%)+0.00s (+ 0.16%)1.21s1.23s
Bind Time0.67s (± 0.86%)0.67s (± 0.86%)+0.00s (+ 0.45%)0.66s0.69s
Check Time4.39s (± 0.61%)4.41s (± 0.33%)+0.03s (+ 0.59%)4.39s4.46s
Emit Time2.91s (± 0.89%)2.93s (± 0.93%)+0.02s (+ 0.76%)2.88s3.00s
Total Time9.18s (± 0.57%)9.24s (± 0.40%)+0.05s (+ 0.59%)9.16s9.32s
material-ui - node (v10.16.3, x64)
Memory used459,413k (± 0.02%)459,075k (± 0.01%)-337k (- 0.07%)458,898k459,202k
Parse Time2.06s (± 0.37%)2.05s (± 0.52%)-0.01s (- 0.44%)2.02s2.06s
Bind Time0.66s (± 1.45%)0.66s (± 2.01%)+0.01s (+ 1.07%)0.63s0.68s
Check Time12.99s (± 0.63%)12.96s (± 0.76%)-0.03s (- 0.24%)12.72s13.13s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.71s (± 0.52%)15.67s (± 0.69%)-0.03s (- 0.22%)15.41s15.85s
Angular - node (v12.1.0, x64)
Memory used321,004k (± 0.09%)320,644k (± 0.02%)-360k (- 0.11%)320,506k320,780k
Parse Time2.00s (± 0.45%)1.99s (± 0.38%)-0.01s (- 0.50%)1.98s2.02s
Bind Time0.81s (± 0.64%)0.81s (± 0.45%)-0.00s (- 0.37%)0.80s0.81s
Check Time4.64s (± 0.63%)4.64s (± 0.45%)-0.00s (- 0.06%)4.59s4.69s
Emit Time5.38s (± 0.83%)5.33s (± 0.55%)-0.04s (- 0.82%)5.26s5.40s
Total Time12.83s (± 0.56%)12.77s (± 0.29%)-0.06s (- 0.48%)12.71s12.88s
Monaco - node (v12.1.0, x64)
Memory used321,478k (± 0.01%)321,535k (± 0.03%)+57k (+ 0.02%)321,334k321,727k
Parse Time1.56s (± 0.69%)1.55s (± 1.07%)-0.01s (- 0.58%)1.51s1.59s
Bind Time0.69s (± 0.89%)0.69s (± 0.64%)+0.00s (+ 0.14%)0.68s0.70s
Check Time4.67s (± 0.25%)4.68s (± 0.58%)+0.01s (+ 0.24%)4.63s4.74s
Emit Time2.83s (± 0.77%)2.80s (± 0.44%)-0.03s (- 1.06%)2.78s2.83s
Total Time9.75s (± 0.37%)9.73s (± 0.34%)-0.02s (- 0.26%)9.66s9.79s
TFS - node (v12.1.0, x64)
Memory used286,478k (± 0.03%)286,529k (± 0.02%)+51k (+ 0.02%)286,415k286,689k
Parse Time1.24s (± 0.50%)1.25s (± 0.66%)+0.01s (+ 0.65%)1.23s1.27s
Bind Time0.65s (± 1.36%)0.64s (± 0.87%)-0.01s (- 0.77%)0.63s0.66s
Check Time4.29s (± 0.52%)4.32s (± 0.69%)+0.03s (+ 0.63%)4.26s4.41s
Emit Time2.94s (± 0.93%)2.94s (± 1.02%)+0.00s (+ 0.17%)2.86s3.00s
Total Time9.11s (± 0.48%)9.15s (± 0.61%)+0.04s (+ 0.38%)9.00s9.23s
material-ui - node (v12.1.0, x64)
Memory used437,704k (± 0.04%)437,519k (± 0.02%)-184k (- 0.04%)437,361k437,697k
Parse Time2.04s (± 0.78%)2.04s (± 0.74%)-0.00s (- 0.20%)2.02s2.08s
Bind Time0.64s (± 0.63%)0.63s (± 0.92%)-0.01s (- 0.94%)0.62s0.64s
Check Time11.70s (± 1.35%)11.73s (± 0.43%)+0.03s (+ 0.24%)11.59s11.83s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.38s (± 1.12%)14.40s (± 0.33%)+0.02s (+ 0.15%)14.28s14.47s
Angular - node (v8.9.0, x64)
Memory used340,385k (± 0.01%)340,031k (± 0.01%)-355k (- 0.10%)339,938k340,144k
Parse Time2.54s (± 0.22%)2.55s (± 0.63%)+0.00s (+ 0.16%)2.51s2.57s
Bind Time0.86s (± 0.55%)0.86s (± 0.67%)0.00s ( 0.00%)0.85s0.87s
Check Time5.36s (± 0.45%)5.39s (± 0.50%)+0.03s (+ 0.49%)5.34s5.45s
Emit Time5.95s (± 1.09%)5.92s (± 1.07%)-0.02s (- 0.40%)5.75s6.05s
Total Time14.71s (± 0.53%)14.72s (± 0.54%)+0.00s (+ 0.03%)14.50s14.84s
Monaco - node (v8.9.0, x64)
Memory used340,475k (± 0.01%)340,436k (± 0.01%)-39k (- 0.01%)340,354k340,535k
Parse Time1.88s (± 0.52%)1.88s (± 0.35%)-0.00s (- 0.11%)1.87s1.89s
Bind Time0.88s (± 0.56%)0.88s (± 0.56%)0.00s ( 0.00%)0.87s0.89s
Check Time5.40s (± 0.44%)5.43s (± 0.38%)+0.03s (+ 0.46%)5.36s5.46s
Emit Time3.24s (± 0.63%)3.23s (± 0.51%)-0.01s (- 0.22%)3.21s3.27s
Total Time11.41s (± 0.39%)11.42s (± 0.28%)+0.01s (+ 0.09%)11.32s11.49s
TFS - node (v8.9.0, x64)
Memory used303,760k (± 0.02%)303,794k (± 0.02%)+34k (+ 0.01%)303,658k303,946k
Parse Time1.56s (± 0.58%)1.55s (± 0.26%)-0.00s (- 0.26%)1.54s1.56s
Bind Time0.67s (± 0.55%)0.67s (± 0.60%)-0.00s (- 0.59%)0.66s0.68s
Check Time5.00s (± 1.30%)5.06s (± 1.95%)+0.06s (+ 1.28%)4.86s5.26s
Emit Time3.10s (± 2.47%)3.04s (± 2.98%)-0.07s (- 2.25%)2.91s3.23s
Total Time10.34s (± 0.34%)10.32s (± 0.39%)-0.02s (- 0.18%)10.24s10.41s
material-ui - node (v8.9.0, x64)
Memory used463,609k (± 0.01%)463,373k (± 0.01%)-236k (- 0.05%)463,251k463,515k
Parse Time2.41s (± 0.62%)2.40s (± 0.33%)-0.01s (- 0.29%)2.38s2.41s
Bind Time0.78s (± 0.87%)0.78s (± 1.85%)-0.00s (- 0.13%)0.76s0.82s
Check Time17.31s (± 1.12%)17.10s (± 1.08%)-0.21s (- 1.20%)16.78s17.48s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.50s (± 0.96%)20.28s (± 0.91%)-0.22s (- 1.06%)19.96s20.65s
Angular - node (v8.9.0, x86)
Memory used195,257k (± 0.02%)195,038k (± 0.02%)-218k (- 0.11%)194,952k195,128k
Parse Time2.46s (± 0.30%)2.46s (± 0.56%)-0.00s (- 0.04%)2.43s2.50s
Bind Time0.99s (± 1.34%)1.00s (± 1.00%)+0.00s (+ 0.40%)0.98s1.02s
Check Time4.81s (± 0.54%)4.87s (± 0.53%)+0.06s (+ 1.23%)4.79s4.92s
Emit Time5.93s (± 0.96%)5.88s (± 1.42%)-0.05s (- 0.83%)5.70s6.03s
Total Time14.20s (± 0.36%)14.21s (± 0.56%)+0.01s (+ 0.08%)14.01s14.38s
Monaco - node (v8.9.0, x86)
Memory used193,438k (± 0.02%)193,461k (± 0.01%)+23k (+ 0.01%)193,418k193,527k
Parse Time1.92s (± 0.88%)1.92s (± 1.06%)+0.00s (+ 0.00%)1.88s1.98s
Bind Time0.70s (± 1.34%)0.70s (± 0.57%)-0.00s (- 0.57%)0.69s0.71s
Check Time5.47s (± 1.15%)5.52s (± 0.51%)+0.05s (+ 0.90%)5.46s5.60s
Emit Time2.70s (± 2.83%)2.68s (± 0.48%)-0.03s (- 0.96%)2.65s2.71s
Total Time10.80s (± 0.30%)10.82s (± 0.38%)+0.01s (+ 0.14%)10.74s10.90s
TFS - node (v8.9.0, x86)
Memory used173,711k (± 0.03%)173,761k (± 0.04%)+51k (+ 0.03%)173,624k173,935k
Parse Time1.60s (± 0.51%)1.60s (± 1.04%)-0.01s (- 0.44%)1.58s1.63s
Bind Time0.64s (± 0.35%)0.64s (± 0.97%)-0.00s (- 0.31%)0.63s0.65s
Check Time4.64s (± 0.71%)4.69s (± 0.90%)+0.05s (+ 0.99%)4.61s4.78s
Emit Time2.81s (± 1.05%)2.80s (± 0.89%)-0.00s (- 0.14%)2.76s2.89s
Total Time9.69s (± 0.50%)9.72s (± 0.50%)+0.03s (+ 0.34%)9.63s9.83s
material-ui - node (v8.9.0, x86)
Memory used262,525k (± 0.02%)262,395k (± 0.02%)-130k (- 0.05%)262,307k262,512k
Parse Time2.45s (± 0.41%)2.46s (± 0.89%)+0.01s (+ 0.41%)2.42s2.52s
Bind Time0.67s (± 1.01%)0.67s (± 1.40%)-0.00s (- 0.15%)0.65s0.69s
Check Time15.66s (± 0.60%)15.70s (± 0.72%)+0.04s (+ 0.27%)15.44s15.95s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.78s (± 0.47%)18.83s (± 0.64%)+0.05s (+ 0.25%)18.62s19.11s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@Kingwl

Wenlu Wang (Kingwl) commented Jul 1, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 1, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the perf test suite on this PR at 2dd4148. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39221

Metricmaster39221DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used343,940k (± 0.02%)343,499k (± 0.02%)-441k (- 0.13%)343,377k343,689k
Parse Time2.02s (± 0.47%)2.02s (± 0.47%)-0.01s (- 0.35%)1.99s2.03s
Bind Time0.82s (± 0.85%)0.82s (± 0.41%)-0.00s (- 0.12%)0.81s0.83s
Check Time4.74s (± 0.72%)4.74s (± 0.66%)-0.00s (- 0.04%)4.65s4.80s
Emit Time5.20s (± 0.68%)5.18s (± 0.64%)-0.02s (- 0.44%)5.11s5.26s
Total Time12.79s (± 0.52%)12.75s (± 0.43%)-0.04s (- 0.27%)12.64s12.87s
Monaco - node (v10.16.3, x64)
Memory used339,039k (± 0.02%)339,086k (± 0.02%)+46k (+ 0.01%)338,928k339,244k
Parse Time1.59s (± 0.69%)1.59s (± 0.55%)-0.01s (- 0.31%)1.57s1.60s
Bind Time0.71s (± 0.42%)0.72s (± 0.90%)+0.01s (+ 0.84%)0.70s0.73s
Check Time4.87s (± 0.59%)4.87s (± 0.46%)-0.00s (- 0.08%)4.81s4.91s
Emit Time2.77s (± 0.73%)2.76s (± 0.76%)-0.00s (- 0.14%)2.73s2.83s
Total Time9.94s (± 0.51%)9.94s (± 0.41%)-0.00s (- 0.05%)9.86s10.05s
TFS - node (v10.16.3, x64)
Memory used301,963k (± 0.02%)302,031k (± 0.02%)+67k (+ 0.02%)301,869k302,161k
Parse Time1.21s (± 0.81%)1.22s (± 0.71%)+0.01s (+ 0.50%)1.20s1.24s
Bind Time0.67s (± 1.00%)0.67s (± 1.34%)-0.00s (- 0.30%)0.64s0.68s
Check Time4.38s (± 0.60%)4.40s (± 0.54%)+0.03s (+ 0.64%)4.34s4.45s
Emit Time2.91s (± 0.99%)2.88s (± 0.75%)-0.03s (- 1.07%)2.82s2.91s
Total Time9.16s (± 0.61%)9.17s (± 0.40%)+0.00s (+ 0.03%)9.04s9.22s
material-ui - node (v10.16.3, x64)
Memory used459,415k (± 0.02%)459,144k (± 0.01%)-271k (- 0.06%)459,000k459,293k
Parse Time2.04s (± 0.52%)2.04s (± 0.47%)-0.00s (- 0.10%)2.02s2.06s
Bind Time0.66s (± 1.66%)0.65s (± 1.85%)-0.00s (- 0.61%)0.63s0.68s
Check Time12.88s (± 0.51%)12.95s (± 0.74%)+0.07s (+ 0.54%)12.74s13.16s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.58s (± 0.47%)15.65s (± 0.64%)+0.06s (+ 0.41%)15.40s15.85s
Angular - node (v12.1.0, x64)
Memory used321,117k (± 0.03%)320,618k (± 0.10%)-499k (- 0.16%)319,406k320,959k
Parse Time2.00s (± 0.69%)1.98s (± 0.48%)-0.02s (- 1.00%)1.96s2.01s
Bind Time0.81s (± 0.80%)0.81s (± 0.69%)-0.00s (- 0.00%)0.80s0.82s
Check Time4.63s (± 0.50%)4.65s (± 0.74%)+0.03s (+ 0.58%)4.57s4.72s
Emit Time5.32s (± 0.27%)5.36s (± 0.76%)+0.04s (+ 0.73%)5.28s5.45s
Total Time12.75s (± 0.14%)12.79s (± 0.51%)+0.05s (+ 0.36%)12.64s12.95s
Monaco - node (v12.1.0, x64)
Memory used321,534k (± 0.02%)321,536k (± 0.02%)+2k (+ 0.00%)321,382k321,821k
Parse Time1.55s (± 0.65%)1.56s (± 0.65%)+0.00s (+ 0.13%)1.54s1.58s
Bind Time0.69s (± 0.53%)0.69s (± 0.43%)+0.00s (+ 0.29%)0.68s0.69s
Check Time4.67s (± 0.62%)4.69s (± 0.45%)+0.02s (+ 0.41%)4.64s4.74s
Emit Time2.82s (± 0.64%)2.81s (± 0.75%)-0.01s (- 0.32%)2.76s2.86s
Total Time9.74s (± 0.47%)9.74s (± 0.35%)+0.01s (+ 0.07%)9.66s9.80s
TFS - node (v12.1.0, x64)
Memory used286,438k (± 0.03%)286,526k (± 0.02%)+88k (+ 0.03%)286,419k286,651k
Parse Time1.24s (± 1.11%)1.24s (± 0.55%)-0.00s (- 0.08%)1.22s1.25s
Bind Time0.64s (± 0.73%)0.64s (± 0.75%)-0.00s (- 0.47%)0.63s0.65s
Check Time4.28s (± 0.60%)4.30s (± 0.53%)+0.02s (+ 0.47%)4.28s4.36s
Emit Time2.92s (± 0.52%)2.92s (± 1.10%)+0.00s (+ 0.07%)2.86s3.01s
Total Time9.07s (± 0.34%)9.09s (± 0.43%)+0.02s (+ 0.23%)9.02s9.19s
material-ui - node (v12.1.0, x64)
Memory used437,622k (± 0.06%)437,459k (± 0.06%)-163k (- 0.04%)436,510k437,722k
Parse Time2.03s (± 0.65%)2.02s (± 0.44%)-0.00s (- 0.20%)2.01s2.04s
Bind Time0.64s (± 0.93%)0.63s (± 0.53%)-0.01s (- 0.94%)0.62s0.64s
Check Time11.65s (± 0.79%)11.61s (± 0.86%)-0.04s (- 0.36%)11.41s11.79s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.32s (± 0.70%)14.26s (± 0.68%)-0.05s (- 0.37%)14.07s14.44s
Angular - node (v8.9.0, x64)
Memory used340,414k (± 0.01%)340,069k (± 0.02%)-345k (- 0.10%)339,949k340,228k
Parse Time2.54s (± 0.42%)2.53s (± 0.47%)-0.01s (- 0.24%)2.51s2.56s
Bind Time0.85s (± 0.61%)0.86s (± 0.78%)+0.01s (+ 0.94%)0.84s0.87s
Check Time5.35s (± 0.53%)5.35s (± 0.57%)+0.00s (+ 0.02%)5.28s5.41s
Emit Time5.98s (± 1.11%)5.97s (± 1.03%)-0.02s (- 0.27%)5.78s6.09s
Total Time14.72s (± 0.52%)14.71s (± 0.47%)-0.01s (- 0.09%)14.56s14.89s
Monaco - node (v8.9.0, x64)
Memory used340,464k (± 0.02%)340,501k (± 0.01%)+36k (+ 0.01%)340,425k340,550k
Parse Time1.87s (± 0.40%)1.87s (± 0.48%)0.00s ( 0.00%)1.86s1.89s
Bind Time0.88s (± 0.67%)0.88s (± 0.54%)-0.00s (- 0.11%)0.87s0.89s
Check Time5.38s (± 0.48%)5.38s (± 0.51%)+0.01s (+ 0.13%)5.31s5.46s
Emit Time3.24s (± 0.55%)3.22s (± 0.48%)-0.01s (- 0.40%)3.19s3.25s
Total Time11.37s (± 0.38%)11.37s (± 0.26%)-0.01s (- 0.06%)11.31s11.44s
TFS - node (v8.9.0, x64)
Memory used303,752k (± 0.02%)303,766k (± 0.02%)+14k (+ 0.00%)303,690k303,879k
Parse Time1.55s (± 0.38%)1.54s (± 0.42%)-0.00s (- 0.26%)1.53s1.56s
Bind Time0.67s (± 0.66%)0.67s (± 0.75%)-0.01s (- 1.04%)0.66s0.68s
Check Time5.02s (± 1.78%)5.10s (± 1.31%)+0.08s (+ 1.53%)4.95s5.22s
Emit Time3.04s (± 2.62%)3.00s (± 2.66%)-0.04s (- 1.41%)2.90s3.18s
Total Time10.28s (± 0.47%)10.31s (± 0.48%)+0.02s (+ 0.22%)10.20s10.40s
material-ui - node (v8.9.0, x64)
Memory used463,634k (± 0.01%)463,394k (± 0.02%)-240k (- 0.05%)463,237k463,598k
Parse Time2.39s (± 0.38%)2.40s (± 0.71%)+0.01s (+ 0.29%)2.35s2.44s
Bind Time0.78s (± 1.24%)0.78s (± 1.44%)-0.01s (- 0.77%)0.76s0.81s
Check Time17.27s (± 0.69%)17.27s (± 1.02%)0.00s ( 0.00%)16.86s17.55s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time20.44s (± 0.61%)20.44s (± 0.93%)+0.00s (+ 0.01%)20.01s20.76s
Angular - node (v8.9.0, x86)
Memory used195,294k (± 0.02%)195,115k (± 0.03%)-178k (- 0.09%)195,002k195,246k
Parse Time2.46s (± 0.66%)2.45s (± 0.85%)-0.02s (- 0.69%)2.41s2.49s
Bind Time1.00s (± 1.37%)0.98s (± 0.71%)-0.02s (- 2.29%)0.96s0.99s
Check Time4.81s (± 0.59%)4.82s (± 0.51%)+0.01s (+ 0.17%)4.78s4.88s
Emit Time5.90s (± 1.16%)5.96s (± 0.82%)+0.06s (+ 1.00%)5.80s6.06s
Total Time14.18s (± 0.62%)14.20s (± 0.53%)+0.03s (+ 0.18%)13.99s14.38s
Monaco - node (v8.9.0, x86)
Memory used193,440k (± 0.02%)193,465k (± 0.02%)+24k (+ 0.01%)193,413k193,543k
Parse Time1.91s (± 0.81%)1.92s (± 0.92%)+0.01s (+ 0.47%)1.89s1.98s
Bind Time0.71s (± 1.07%)0.70s (± 0.79%)-0.00s (- 0.57%)0.69s0.71s
Check Time5.44s (± 0.98%)5.51s (± 1.33%)+0.07s (+ 1.29%)5.25s5.62s
Emit Time2.71s (± 3.40%)2.72s (± 3.25%)+0.00s (+ 0.15%)2.64s3.06s
Total Time10.77s (± 0.61%)10.85s (± 0.61%)+0.08s (+ 0.76%)10.72s10.99s
TFS - node (v8.9.0, x86)
Memory used173,680k (± 0.02%)173,725k (± 0.03%)+45k (+ 0.03%)173,622k173,820k
Parse Time1.59s (± 0.63%)1.60s (± 0.94%)+0.01s (+ 0.57%)1.58s1.65s
Bind Time0.64s (± 0.58%)0.63s (± 0.54%)-0.00s (- 0.31%)0.63s0.64s
Check Time4.63s (± 0.70%)4.68s (± 0.35%)+0.05s (+ 0.99%)4.64s4.72s
Emit Time2.79s (± 1.25%)2.79s (± 1.90%)-0.00s (- 0.11%)2.68s2.97s
Total Time9.65s (± 0.41%)9.70s (± 0.61%)+0.05s (+ 0.48%)9.58s9.88s
material-ui - node (v8.9.0, x86)
Memory used262,531k (± 0.02%)262,423k (± 0.02%)-108k (- 0.04%)262,291k262,605k
Parse Time2.45s (± 0.54%)2.46s (± 0.36%)+0.01s (+ 0.49%)2.44s2.48s
Bind Time0.67s (± 1.60%)0.67s (± 1.51%)-0.00s (- 0.75%)0.65s0.70s
Check Time15.74s (± 0.72%)15.73s (± 0.47%)-0.01s (- 0.06%)15.63s15.97s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time18.86s (± 0.55%)18.86s (± 0.42%)-0.00s (- 0.01%)18.75s19.11s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current3922110
Baselinemaster10

@Kingwl
Wenlu Wang (Kingwl) deleted the overload_deprecated branch April 20, 2021 08:57
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn requested changes
@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)DanielRosenwasser left review comments
@weswighamWesley Wigham (weswigham)weswigham left review comments

Assignees

@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document.createElement always marked deprecated

5 participants

@Kingwl@typescript-bot@weswigham@sandersn@DanielRosenwasser