Uh oh!
There was an error while loading. Please reload this page.
Make tsserver.js a library - #39291
Conversation
Andrew Casey (amcasey)
commented
Jun 27, 2020
I bet there's a cleverer way to skip the body of server.ts and I'd be happy to hear it. |
Andrew Casey (amcasey)
commented
Jun 27, 2020
FYI Matt Bierner (@mjbvz), hopefully, this will save VS Code 8MB or so. |
Andrew Casey (amcasey)
commented
Jun 27, 2020
Do I need to hook the new .d.ts file up to some sort of baseline/validation system? |
Wesley Wigham (weswigham)
commented
Jun 27, 2020
If we're considering this, the |
Andrew Casey (amcasey)
commented
Jun 27, 2020
Wesley Wigham (@weswigham) What does "merge them" mean in this context? Drop |
|
Andrew Casey (amcasey)
commented
Jun 29, 2020
I've done my best to port the functionality of |
VS Code (and probably others) currently consumes both tsserver.js and typescript.js, even though they have essentially the same content. This change makes it possible to use tsserver.js for both purposes, by suppressing the server startup code (including requires) and adding a declaration file (stripped of internals).
72b46fb to
c7bc055CompareAndrew Casey (amcasey)
commented
Jun 29, 2020
Force update was just a rebase. No manual merging required. |
Wesley Wigham (weswigham)
left a comment
There was a problem hiding this comment.
This looks OK to me; but we should also have Ron Buckton (@rbuckton) take a look over the build changes and Ryan Cavanaugh (@RyanCavanaugh) validate when we wanna take the API break (since we'll no longer be shipping a file named tsserverlibrary - though we could symlink it to preserve compatibility, admittedly).
Andrew Casey (amcasey)
commented
Jun 30, 2020
There's a weird quirk there actually - unless we manually delete it next time we update the LKG, we'll continue to ship the old one. (See also #39330) |
Wesley Wigham (weswigham)
commented
Jun 30, 2020
AFAIK when we rewrote the LKG script, the only reason it doesn't automatically delete dead files was because there was some |
Andrew Casey (amcasey)
commented
Jul 10, 2020
This would be a hack, so we're not going to pursue it. |
VS Code (and probably others) currently consumes both tsserver.js and
typescript.js, even though they have essentially the same content. This
change makes it possible to use tsserver.js for both purposes, by
suppressing the server startup code (including requires) and adding a
declaration file (stripped of internals).