Skip to content

Alias for commonjs require in JS#39770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nathan Shively-Sanders (sandersn) merged 39 commits into from
Aug 17, 2020
Merged

Alias for commonjs require in JS #39770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4f9ccd0
First attempt at aliases for require
sandersn Jul 9, 2020
d692387
Merge branch 'master' into alias-for-require
sandersn Jul 9, 2020
277d52a
test+initial support for const x=require
sandersn Jul 9, 2020
bcdc2e4
1st round of baseline improvements
sandersn Jul 9, 2020
20aa6ed
2nd round of baseline updates
sandersn Jul 9, 2020
f213707
support property access after require
sandersn Jul 10, 2020
122babd
check @type tag on require
sandersn Jul 10, 2020
f32ec4e
Merge branch 'master' into alias-for-require
sandersn Jul 10, 2020
e1e32af
forbid expando missing namespaces on aliases
sandersn Jul 10, 2020
4ddb3d0
accept error baselines that are good, actually
sandersn Jul 10, 2020
58a0b65
Scribbling on d.ts emit code
sandersn Jul 15, 2020
d885b67
use getSpecifierForModuleSymbol
sandersn Jul 15, 2020
5a0b092
hideous hack for module.exports of aliases
sandersn Jul 15, 2020
64c8c86
Merge branch 'master' into alias-for-require
sandersn Jul 23, 2020
55a13b7
Fix module.exports.x --> export list emit
sandersn Jul 23, 2020
7ce7c8c
fix isLocalImport predicate
sandersn Jul 24, 2020
ca5a57b
require only creates aliases in JS
sandersn Jul 24, 2020
e9a355d
re-handle json imports
sandersn Jul 24, 2020
febcf0e
update fourslash baseline
sandersn Jul 24, 2020
3ee9b6f
Cleanup in the checker
sandersn Jul 24, 2020
a671b45
Function for getting module name from require call
sandersn Jul 24, 2020
6dfbec3
Merge branch 'master' into alias-for-require
sandersn Jul 24, 2020
0c92277
First round of cleanup plus a new test
sandersn Jul 27, 2020
dee0561
more small cleanup
sandersn Jul 27, 2020
e32df83
more cleanup, including lint
sandersn Jul 27, 2020
f4b5124
use trackSymbol, not serializeTypeForDeclaration
sandersn Jul 27, 2020
a841988
Merge branch 'master' into alias-for-require
sandersn Jul 28, 2020
0694890
Merge branch 'master' into alias-for-require
sandersn Aug 11, 2020
781bec2
Code review comments, plus remove unneeded code
sandersn Aug 11, 2020
2bfeeeb
find all refs works
sandersn Aug 12, 2020
0ba0d90
Merge branch 'master' into alias-for-require
sandersn Aug 12, 2020
62e5b18
remove old ad-hoc code
sandersn Aug 13, 2020
2679b03
make it clear that old behaviour is not that correct
sandersn Aug 13, 2020
03fb2d4
update api baselines
sandersn Aug 13, 2020
7aeb306
remove outdated comment
sandersn Aug 13, 2020
d2c0b3c
Merge branch 'master' into alias-for-require
sandersn Aug 13, 2020
9d2ce87
Merge branch 'master' into alias-for-require
sandersn Aug 17, 2020
283a520
PR feedback
sandersn Aug 17, 2020
6c7897e
add a fail-case test (which passes!)
sandersn Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3209,7 +3209,10 @@ namespace ts {
}

if (!isBindingPattern(node.name)) {
if (isBlockOrCatchScoped(node)) {
if (isInJSFile(node) && isRequireVariableDeclaration(node, /*requireStringLiteralLikeArgument*/ true) && !getJSDocTypeTag(node)) {

@sandersnNathan Shively-Sanders (sandersn)Jul 27, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that once this works well enough, we could turn it on in TS as well, which would be pretty great.

declareSymbolAndAddToSymbolTable(node as Declaration, SymbolFlags.Alias, SymbolFlags.AliasExcludes);
}
else if (isBlockOrCatchScoped(node)) {
bindBlockScopedDeclaration(node, SymbolFlags.BlockScopedVariable, SymbolFlags.BlockScopedVariableExcludes);
}
else if (isParameterDeclaration(node)) {
Expand Down
237 changes: 151 additions & 86 deletions src/compiler/checker.ts
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src/compiler/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3937,7 +3937,8 @@ namespace ts {
* This is necessary as an identifier in short-hand property assignment can contains two meaning: property name and property value.
*/
getShorthandAssignmentValueSymbol(location: Node): Symbol | undefined;
getExportSpecifierLocalTargetSymbol(location: ExportSpecifier): Symbol | undefined;

getExportSpecifierLocalTargetSymbol(location: ExportSpecifier | Identifier): Symbol | undefined;
/**
* If a symbol is a local symbol with an associated exported symbol, returns the exported symbol.
* Otherwise returns its input.
Expand Down
15 changes: 14 additions & 1 deletion src/compiler/utilities.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1856,6 +1856,11 @@ namespace ts {
return (<ExternalModuleReference>(<ImportEqualsDeclaration>node).moduleReference).expression;
}

export function getExternalModuleRequireArgument(node: Node) {
return isRequireVariableDeclaration(node, /*requireStringLiteralLikeArgument*/ true)
&& (getLeftmostPropertyAccessExpression(node.initializer) as CallExpression).arguments[0] as StringLiteral;
}

export function isInternalModuleImportEqualsDeclaration(node: Node): node is ImportEqualsDeclaration {
return node.kind === SyntaxKind.ImportEqualsDeclaration && (<ImportEqualsDeclaration>node).moduleReference.kind !== SyntaxKind.ExternalModuleReference;
}
Expand DownExpand Up@@ -1923,7 +1928,8 @@ namespace ts {
export function isRequireVariableDeclaration(node: Node, requireStringLiteralLikeArgument: true): node is RequireVariableDeclaration;
export function isRequireVariableDeclaration(node: Node, requireStringLiteralLikeArgument: boolean): node is VariableDeclaration;
export function isRequireVariableDeclaration(node: Node, requireStringLiteralLikeArgument: boolean): node is VariableDeclaration {
return isVariableDeclaration(node) && !!node.initializer && isRequireCall(node.initializer, requireStringLiteralLikeArgument);
node = getRootDeclaration(node);
return isVariableDeclaration(node) && !!node.initializer && isRequireCall(getLeftmostPropertyAccessExpression(node.initializer), requireStringLiteralLikeArgument);
}

export function isRequireVariableStatement(node: Node, requireStringLiteralLikeArgument = true): node is RequireVariableStatement {
Expand DownExpand Up@@ -5446,6 +5452,13 @@ namespace ts {
return node.kind === SyntaxKind.NamedImports || node.kind === SyntaxKind.NamedExports;
}

export function getLeftmostPropertyAccessExpression(expr: Expression): Expression {
while (isPropertyAccessExpression(expr)) {
expr = expr.expression;
}
return expr;
}

export function getLeftmostExpression(node: Expression, stopAtCallExpressions: boolean) {
while (true) {
switch (node.kind) {
Expand Down
16 changes: 4 additions & 12 deletions src/services/goToDefinition.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,9 +34,7 @@ namespace ts.GoToDefinition {
const sigInfo = createDefinitionFromSignatureDeclaration(typeChecker, calledDeclaration);
// For a function, if this is the original function definition, return just sigInfo.
// If this is the original constructor definition, parent is the class.
if (typeChecker.getRootSymbols(symbol).some(s => symbolMatchesSignature(s, calledDeclaration)) ||
// TODO: GH#25533 Following check shouldn't be necessary if 'require' is an alias
symbol.declarations && symbol.declarations.some(d => isVariableDeclaration(d) && !!d.initializer && isRequireCall(d.initializer, /*checkArgumentIsStringLiteralLike*/ false))) {
if (typeChecker.getRootSymbols(symbol).some(s => symbolMatchesSignature(s, calledDeclaration))) {
return [sigInfo];
}
else {
Expand DownExpand Up@@ -210,15 +208,6 @@ namespace ts.GoToDefinition {
return aliased;
}
}
if (symbol && isInJSFile(node)) {
const requireCall = forEach(symbol.declarations, d => isVariableDeclaration(d) && !!d.initializer && isRequireCall(d.initializer, /*checkArgumentIsStringLiteralLike*/ true) ? d.initializer : undefined);
if (requireCall) {
const moduleSymbol = checker.getSymbolAtLocation(requireCall.arguments[0]);

@sandersnNathan Shively-Sanders (sandersn)Aug 13, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ad-hoc code has been replaced by the call to checker.getAliasedSymbol. I just had to add require calls to the list of aliases to skip past.

if (moduleSymbol) {
return checker.resolveExternalModuleSymbol(moduleSymbol);
}
}
}
return symbol;
}

Expand All@@ -240,6 +229,9 @@ namespace ts.GoToDefinition {
return true;
case SyntaxKind.ImportSpecifier:
return declaration.parent.kind === SyntaxKind.NamedImports;
case SyntaxKind.BindingElement:
case SyntaxKind.VariableDeclaration:
return isInJSFile(declaration) && isRequireVariableDeclaration(declaration, /*requireStringLiteralLikeArgument*/ true);
default:
return false;
}
Expand Down
13 changes: 10 additions & 3 deletions src/services/importTracker.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,9 +93,6 @@ namespace ts.FindAllReferences {
break;
}
}

// Don't support re-exporting 'require()' calls, so just add a single indirect user.
addIndirectUser(direct.getSourceFile());
}
break;

Expand DownExpand Up@@ -607,6 +604,8 @@ namespace ts.FindAllReferences {
case SyntaxKind.NamespaceImport:
Debug.assert((parent as ImportClause | NamespaceImport).name === node);
return true;
case SyntaxKind.BindingElement:
return isInJSFile(node) && isRequireVariableDeclaration(parent, /*requireStringLiteralLikeArgument*/ true);
default:
return false;
}
Expand All@@ -628,6 +627,14 @@ namespace ts.FindAllReferences {
if (isExportSpecifier(declaration) && !declaration.propertyName && !declaration.parent.parent.moduleSpecifier) {
return checker.getExportSpecifierLocalTargetSymbol(declaration)!;
}
else if (isPropertyAccessExpression(declaration) && isModuleExportsAccessExpression(declaration.expression) && !isPrivateIdentifier(declaration.name)) {
return checker.getExportSpecifierLocalTargetSymbol(declaration.name)!;
}
else if (isShorthandPropertyAssignment(declaration)
&& isBinaryExpression(declaration.parent.parent)
&& getAssignmentDeclarationKind(declaration.parent.parent) === AssignmentDeclarationKind.ModuleExports) {
return checker.getExportSpecifierLocalTargetSymbol(declaration.name)!;
}
}
}
return symbol;
Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/ambientRequireFunction.symbols
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,13 +4,13 @@
const fs = require("fs");
>fs : Symbol(fs, Decl(app.js, 2, 5))
>require : Symbol(require, Decl(node.d.ts, 0, 0))
>"fs" : Symbol("fs", Decl(node.d.ts, 0, 50))
>"fs" : Symbol(fs, Decl(node.d.ts, 0, 50))

const text = fs.readFileSync("/a/b/c");
>text : Symbol(text, Decl(app.js, 3, 5))
>fs.readFileSync : Symbol(readFileSync, Decl(node.d.ts, 2, 21))
>fs.readFileSync : Symbol(fs.readFileSync, Decl(node.d.ts, 2, 21))
>fs : Symbol(fs, Decl(app.js, 2, 5))
>readFileSync : Symbol(readFileSync, Decl(node.d.ts, 2, 21))
>readFileSync : Symbol(fs.readFileSync, Decl(node.d.ts, 2, 21))

=== tests/cases/compiler/node.d.ts ===
declare function require(moduleName: string): any;
Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/ambientRequireFunction.types
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,16 +2,16 @@
/// <reference path="node.d.ts"/>

const fs = require("fs");
>fs : typeof import("fs")
>require("fs") : typeof import("fs")
>fs : typeof fs
>require("fs") : typeof fs
>require : (moduleName: string) => any
>"fs" : "fs"

const text = fs.readFileSync("/a/b/c");
>text : string
>fs.readFileSync("/a/b/c") : string
>fs.readFileSync : (s: string) => string
>fs : typeof import("fs")
>fs : typeof fs
>readFileSync : (s: string) => string
>"/a/b/c" : "/a/b/c"

Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/api/tsserverlibrary.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2159,7 +2159,7 @@ declare namespace ts {
* This is necessary as an identifier in short-hand property assignment can contains two meaning: property name and property value.
*/
getShorthandAssignmentValueSymbol(location: Node): Symbol | undefined;
getExportSpecifierLocalTargetSymbol(location: ExportSpecifier): Symbol | undefined;
getExportSpecifierLocalTargetSymbol(location: ExportSpecifier | Identifier): Symbol | undefined;
/**
* If a symbol is a local symbol with an associated exported symbol, returns the exported symbol.
* Otherwise returns its input.
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/api/typescript.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2159,7 +2159,7 @@ declare namespace ts {
* This is necessary as an identifier in short-hand property assignment can contains two meaning: property name and property value.
*/
getShorthandAssignmentValueSymbol(location: Node): Symbol | undefined;
getExportSpecifierLocalTargetSymbol(location: ExportSpecifier): Symbol | undefined;
getExportSpecifierLocalTargetSymbol(location: ExportSpecifier | Identifier): Symbol | undefined;
/**
* If a symbol is a local symbol with an associated exported symbol, returns the exported symbol.
* Otherwise returns its input.
Expand Down
10 changes: 5 additions & 5 deletions tests/baselines/reference/chainedPrototypeAssignment.symbols
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,19 +3,19 @@
var mod = require('./mod');
>mod : Symbol(mod, Decl(use.js, 1, 3))
>require : Symbol(require, Decl(types.d.ts, 0, 0))
>'./mod' : Symbol("tests/cases/conformance/salsa/mod", Decl(mod.js, 0, 0))
>'./mod' : Symbol(mod, Decl(mod.js, 0, 0))

var a = new mod.A()
>a : Symbol(a, Decl(use.js, 2, 3))
>mod.A : Symbol(A, Decl(mod.js, 6, 1))
>mod.A : Symbol(mod.A, Decl(mod.js, 6, 1))
>mod : Symbol(mod, Decl(use.js, 1, 3))
>A : Symbol(A, Decl(mod.js, 6, 1))
>A : Symbol(mod.A, Decl(mod.js, 6, 1))

var b = new mod.B()
>b : Symbol(b, Decl(use.js, 3, 3))
>mod.B : Symbol(B, Decl(mod.js, 7, 13))
>mod.B : Symbol(mod.B, Decl(mod.js, 7, 13))
>mod : Symbol(mod, Decl(use.js, 1, 3))
>B : Symbol(B, Decl(mod.js, 7, 13))
>B : Symbol(mod.B, Decl(mod.js, 7, 13))

a.m('nope')
>a.m : Symbol(m, Decl(mod.js, 9, 29))
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/chainedPrototypeAssignment.types
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
=== tests/cases/conformance/salsa/use.js ===
/// <reference path='./types.d.ts'/>
var mod = require('./mod');
>mod : typeof import("tests/cases/conformance/salsa/mod")
>require('./mod') : typeof import("tests/cases/conformance/salsa/mod")
>mod : typeof mod
>require('./mod') : typeof mod
>require : (name: string) => any
>'./mod' : "./mod"

var a = new mod.A()
>a : A
>new mod.A() : A
>mod.A : typeof A
>mod : typeof import("tests/cases/conformance/salsa/mod")
>mod : typeof mod
>A : typeof A

var b = new mod.B()
>b : B
>new mod.B() : B
>mod.B : typeof B
>mod : typeof import("tests/cases/conformance/salsa/mod")
>mod : typeof mod
>B : typeof B

a.m('nope')
Expand Down
60 changes: 30 additions & 30 deletions tests/baselines/reference/checkOtherObjectAssignProperty.symbols
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,61 @@
=== tests/cases/conformance/jsdoc/importer.js ===
const mod = require("./mod1");
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>require : Symbol(require)
>"./mod1" : Symbol("tests/cases/conformance/jsdoc/mod1", Decl(mod1.js, 0, 0))
>"./mod1" : Symbol(mod, Decl(mod1.js, 0, 0))

mod.thing;
>mod.thing : Symbol(thing, Decl(mod1.js, 0, 42))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>thing : Symbol(thing, Decl(mod1.js, 0, 42))
>mod.thing : Symbol(mod.thing, Decl(mod1.js, 0, 42))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>thing : Symbol(mod.thing, Decl(mod1.js, 0, 42))

mod.other;
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>mod : Symbol(mod, Decl(importer.js, 0, 5))

mod.prop;
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>mod : Symbol(mod, Decl(importer.js, 0, 5))

mod.bad1;
>mod.bad1 : Symbol(bad1, Decl(mod1.js, 10, 72))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>bad1 : Symbol(bad1, Decl(mod1.js, 10, 72))
>mod.bad1 : Symbol(mod.bad1, Decl(mod1.js, 10, 72))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>bad1 : Symbol(mod.bad1, Decl(mod1.js, 10, 72))

mod.bad2;
>mod.bad2 : Symbol(bad2, Decl(mod1.js, 13, 44))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>bad2 : Symbol(bad2, Decl(mod1.js, 13, 44))
>mod.bad2 : Symbol(mod.bad2, Decl(mod1.js, 13, 44))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>bad2 : Symbol(mod.bad2, Decl(mod1.js, 13, 44))

mod.bad3;
>mod.bad3 : Symbol(bad3, Decl(mod1.js, 14, 77))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>bad3 : Symbol(bad3, Decl(mod1.js, 14, 77))
>mod.bad3 : Symbol(mod.bad3, Decl(mod1.js, 14, 77))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>bad3 : Symbol(mod.bad3, Decl(mod1.js, 14, 77))


mod.thing = 0;
>mod.thing : Symbol(thing, Decl(mod1.js, 0, 42))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>thing : Symbol(thing, Decl(mod1.js, 0, 42))
>mod.thing : Symbol(mod.thing, Decl(mod1.js, 0, 42))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>thing : Symbol(mod.thing, Decl(mod1.js, 0, 42))

mod.other = 0;
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>mod : Symbol(mod, Decl(importer.js, 0, 5))

mod.prop = 0;
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>mod : Symbol(mod, Decl(importer.js, 0, 5))

mod.bad1 = 0;
>mod.bad1 : Symbol(bad1, Decl(mod1.js, 10, 72))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>bad1 : Symbol(bad1, Decl(mod1.js, 10, 72))
>mod.bad1 : Symbol(mod.bad1, Decl(mod1.js, 10, 72))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>bad1 : Symbol(mod.bad1, Decl(mod1.js, 10, 72))

mod.bad2 = 0;
>mod.bad2 : Symbol(bad2, Decl(mod1.js, 13, 44))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>bad2 : Symbol(bad2, Decl(mod1.js, 13, 44))
>mod.bad2 : Symbol(mod.bad2, Decl(mod1.js, 13, 44))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>bad2 : Symbol(mod.bad2, Decl(mod1.js, 13, 44))

mod.bad3 = 0;
>mod.bad3 : Symbol(bad3, Decl(mod1.js, 14, 77))
>mod : Symbol(mod, Decl(importer.js, 0, 5), Decl(importer.js, 6, 9), Decl(importer.js, 9, 14), Decl(importer.js, 10, 14), Decl(importer.js, 11, 13) ... and 2 more)
>bad3 : Symbol(bad3, Decl(mod1.js, 14, 77))
>mod.bad3 : Symbol(mod.bad3, Decl(mod1.js, 14, 77))
>mod : Symbol(mod, Decl(importer.js, 0, 5))
>bad3 : Symbol(mod.bad3, Decl(mod1.js, 14, 77))

=== tests/cases/conformance/jsdoc/mod1.js ===
const obj = { value: 42, writable: true };
Expand Down
Loading