Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 13.8k
Template literal types and mapped type 'as' clauses#40336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
1a6676e27d91640b9c5f5815a408032e1bfced200fd2ad4c1b5b897d3b14f3d6a8e070a63a44245ea57605e2ef195ac3d4c95c000b3178d48cac2414061ba9d68670bb7b58c7b12681d272b23f3b6e8c26dc0b2a9c1f9fbb2518c62d70ca2096d0ae1488f3566337edb5e75dd6c95951e81ebb46bd94b0d38a388File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -151,6 +151,10 @@ namespace ts { | ||
| yield: SyntaxKind.YieldKeyword, | ||
| async: SyntaxKind.AsyncKeyword, | ||
| await: SyntaxKind.AwaitKeyword, | ||
| uppercase: SyntaxKind.UppercaseKeyword, | ||
| lowercase: SyntaxKind.LowercaseKeyword, | ||
| capitalize: SyntaxKind.CapitalizeKeyword, | ||
| uncapitalize: SyntaxKind.UncapitalizeKeyword, | ||
| of: SyntaxKind.OfKeyword, | ||
| }; | ||
| @@ -1508,9 +1512,9 @@ namespace ts { | ||
| } | ||
| function getIdentifierToken(): SyntaxKind.Identifier | KeywordSyntaxKind { | ||
| // Reserved words are between 2 and 11 characters long and start with a lowercase letter | ||
| // Reserved words are between 2 and 12 characters long and start with a lowercase letter | ||
| const len = tokenValue.length; | ||
| if (len >= 2 && len <= 11) { | ||
| if (len >= 2 && len <= 12) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that this change should be reverted since #40580 has removed | ||
| const ch = tokenValue.charCodeAt(0); | ||
| if (ch >= CharacterCodes.a && ch <= CharacterCodes.z) { | ||
| const keyword = textToKeyword.get(tokenValue); | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this when handling a merge conflict: