Uh oh!
There was an error while loading. Please reload this page.
Fix premature closing of AutoImportProviderProject for unbuilt monorepos - #40620
Merged
Andrew Branch (andrewbranch) merged 6 commits intoSep 24, 2020
Conversation
Andrew Branch (andrewbranch)
requested a review
from Sheetal Nandi (sheetalkamat)September 17, 2020 19:57
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Member
How'd you catch this out of curiosity? |
Andrew Branch (andrewbranch)
commented
Sep 18, 2020
MemberAuthor
I found it while testing #40637 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sheetal Nandi (sheetalkamat)
approved these changes
Sep 21, 2020
Andrew Branch (andrewbranch)
deleted the
bug/auto-import-provider-lifecycle
branch
September 24, 2020 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on something else: if an AutoImportProviderProject only knows about declaration files that will exist according to TS source files and compiler options, but do not actually exist on disk yet, it gets closed unnecessarily because
hasRoots()only considers files that actually exist.