Skip to content

fix(40640) add missing notApplicableReason in protocol - #40680

Merged
Jesse Trinity (jessetrinity) merged 2 commits into
microsoft:masterfrom
jessetrinity:fix40640
Sep 22, 2020
Merged

fix(40640) add missing notApplicableReason in protocol#40680
Jesse Trinity (jessetrinity) merged 2 commits into
microsoft:masterfrom
jessetrinity:fix40640

Conversation

@jessetrinity

@jessetrinityJesse Trinity (jessetrinity) commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Fixes#40640

protocol changes were missed in #37871

We will need to cherry pick this to release-4.0

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-botTypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 21, 2020
@jessetrinity

Jesse Trinity (jessetrinity) commented Sep 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Is there a protocol baseline that needs to be updated?

@jessetrinity
Jesse Trinity (jessetrinity) merged commit ce338a4 into microsoft:masterSep 22, 2020
@jessetrinity

Jesse Trinity (jessetrinity) commented Sep 22, 2020

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.0

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Sep 22, 2020
@jessetrinity@DanielRosenwasser
fix(40640) add missing notApplicableReason in protocol (#40680)
0744e1b
* update protocol
* fix lint error
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Sep 22, 2020

Copy link
Copy Markdown
Member

For annoying reasons, the bot doesn't cherry-pick merged PRs

@jessetrinity

Jesse Trinity (jessetrinity) commented Sep 22, 2020

Copy link
Copy Markdown
ContributorAuthor

but... I've seen it do it...

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Sep 22, 2020

Copy link
Copy Markdown
Member

Same! I have no idea how anything works. Maybe Wesley Wigham (@weswigham) knows.

Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Sep 22, 2020
@DanielRosenwasser@jessetrinity
fix(40640) add missing notApplicableReason in protocol (#40680) (#40688)
e9d8ccb
* update protocol
* fix lint error
Co-authored-by: Jesse Trinity <jesse.trinity@microsoft.com>
@weswigham

Wesley Wigham (weswigham) commented Sep 22, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Github GC's the ref if you take too long (and deleted the source branch), and once the ref is gone, it can't be picked anymore. That's about the only thing I can think of.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Sep 22, 2020

Copy link
Copy Markdown
Member

So I guess try not to delete the source branch immediately in the future and give that a shot - thanks Wesley Wigham (@weswigham)!

@jessetrinity

Jesse Trinity (jessetrinity) commented Sep 22, 2020

Copy link
Copy Markdown
ContributorAuthor

image
I don't believe I have 🤔

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Sep 22, 2020

Copy link
Copy Markdown
Member

Maybe it's a difficulty across repos too.

@weswigham

Wesley Wigham (weswigham) commented Sep 23, 2020

Copy link
Copy Markdown
Member

That's usually fine... it looks like the pipeline never even triggered, so it seems like the comment didn't even get picked up. Lemme try...

TypeScript Bot (@typescript-bot) cherrypick this into release-4.0

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 23, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the task to cherry-pick this into release-4.0 on this PR at baa8c26. You can monitor the build here.

@weswigham

Wesley Wigham (weswigham) commented Sep 23, 2020

Copy link
Copy Markdown
Member

🤷 github dropped the webhook, maybe? I dunno. Definitely triggered for me, and the accompanying logs seem fine, too (though maybe I should update the code for the latest octokit - there's some deprecation warnings).

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 23, 2020

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamatSheetal Nandi (sheetalkamat)sheetalkamat approved these changes
@PranavSenthilnathanPranav Senthilnathan (PranavSenthilnathan)Awaiting requested review from PranavSenthilnathan

Assignees

@jessetrinityJesse Trinity (jessetrinity)

Labels

For Milestone BugPRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

notApplicableReason not included in protocol.d.ts

5 participants

@jessetrinity@typescript-bot@DanielRosenwasser@weswigham@sheetalkamat