Uh oh!
There was an error while loading. Please reload this page.
Remove string literals from unions with matching template literals - #41276
Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits intoOct 27, 2020
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and Wesley Wigham (weswigham)October 27, 2020 17:48
Andrew Branch (andrewbranch)
approved these changes
Oct 27, 2020
Wesley Wigham (weswigham)
approved these changes
Oct 27, 2020
Anders Hejlsberg (ahejlsberg)
deleted the
stringAndTemplateLiteralUnions
branch
October 27, 2020 23:21
This was referenced Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently remove template literals from intersections containing matching string literals. For example
`foo${string}` & 'foox'is reduced to just'foox'. We also need to perform the complementary reduction for union types, i.e.`foo${string}` | 'foox'should reduce to just`foo${string}`. This PR adds that functionality.The following now produces no errors:
See also #40598.