Skip to content

WIP: in narrowing with record types - #41478

Closed
Jack Williams (jack-williams) wants to merge 4 commits into
microsoft:mainfrom
jack-williams:in-narrowing
Closed

WIP: in narrowing with record types#41478
Jack Williams (jack-williams) wants to merge 4 commits into
microsoft:mainfrom
jack-williams:in-narrowing

Conversation

@jack-williams

@jack-williamsJack Williams (jack-williams) commented Nov 10, 2020

Copy link
Copy Markdown
Collaborator

Fixes #

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 10, 2020
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jack-williams

Jack Williams (jack-williams) commented Nov 10, 2020

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the extended test suite on this PR at 45e3cbb. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the parallelized community code test suite on this PR at 45e3cbb. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at 45e3cbb. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41478

Metricmaster41478DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used344,450k (± 0.02%)344,463k (± 0.01%)+14k (+ 0.00%)344,352k344,543k
Parse Time1.98s (± 0.73%)1.98s (± 0.38%)-0.00s (- 0.25%)1.96s1.99s
Bind Time0.83s (± 0.81%)0.83s (± 0.74%)+0.00s (+ 0.48%)0.82s0.84s
Check Time4.97s (± 0.46%)4.99s (± 0.51%)+0.02s (+ 0.34%)4.91s5.03s
Emit Time5.38s (± 0.83%)5.33s (± 0.37%)-0.05s (- 0.93%)5.27s5.36s
Total Time13.16s (± 0.40%)13.12s (± 0.30%)-0.03s (- 0.26%)13.04s13.22s
Monaco - node (v10.16.3, x64)
Memory used354,695k (± 0.03%)354,695k (± 0.02%)-0k (- 0.00%)354,549k354,903k
Parse Time1.59s (± 0.60%)1.61s (± 0.47%)+0.01s (+ 0.69%)1.59s1.62s
Bind Time0.73s (± 0.55%)0.72s (± 0.69%)-0.00s (- 0.55%)0.72s0.74s
Check Time5.14s (± 0.62%)5.11s (± 0.61%)-0.03s (- 0.51%)5.04s5.18s
Emit Time2.81s (± 0.86%)2.80s (± 0.56%)-0.02s (- 0.60%)2.76s2.83s
Total Time10.27s (± 0.49%)10.24s (± 0.45%)-0.03s (- 0.32%)10.16s10.35s
TFS - node (v10.16.3, x64)
Memory used307,841k (± 0.02%)307,866k (± 0.01%)+25k (+ 0.01%)307,767k307,952k
Parse Time1.24s (± 0.71%)1.24s (± 0.67%)-0.00s (- 0.32%)1.22s1.25s
Bind Time0.68s (± 1.14%)0.68s (± 0.44%)+0.00s (+ 0.44%)0.68s0.69s
Check Time4.60s (± 0.62%)4.59s (± 0.43%)-0.01s (- 0.26%)4.54s4.64s
Emit Time2.96s (± 1.17%)2.95s (± 0.90%)-0.00s (- 0.14%)2.91s3.04s
Total Time9.48s (± 0.46%)9.46s (± 0.31%)-0.02s (- 0.19%)9.41s9.52s
material-ui - node (v10.16.3, x64)
Memory used489,266k (± 0.01%)489,237k (± 0.01%)-29k (- 0.01%)489,093k489,312k
Parse Time2.06s (± 0.16%)2.05s (± 0.52%)-0.01s (- 0.44%)2.03s2.08s
Bind Time0.66s (± 0.91%)0.65s (± 0.73%)-0.00s (- 0.46%)0.64s0.66s
Check Time13.62s (± 0.94%)13.57s (± 0.61%)-0.04s (- 0.30%)13.38s13.73s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time16.34s (± 0.81%)16.28s (± 0.56%)-0.05s (- 0.31%)16.07s16.46s
Angular - node (v12.1.0, x64)
Memory used322,363k (± 0.03%)322,443k (± 0.03%)+80k (+ 0.02%)322,330k322,743k
Parse Time1.97s (± 0.58%)1.97s (± 0.74%)-0.01s (- 0.41%)1.94s2.00s
Bind Time0.82s (± 0.75%)0.81s (± 0.55%)-0.01s (- 1.58%)0.80s0.82s
Check Time4.89s (± 0.58%)4.90s (± 0.37%)+0.01s (+ 0.16%)4.88s4.95s
Emit Time5.51s (± 0.77%)5.49s (± 0.85%)-0.02s (- 0.40%)5.39s5.61s
Total Time13.20s (± 0.47%)13.16s (± 0.36%)-0.03s (- 0.27%)13.07s13.26s
Monaco - node (v12.1.0, x64)
Memory used336,814k (± 0.01%)336,765k (± 0.06%)-49k (- 0.01%)335,987k336,985k
Parse Time1.58s (± 0.64%)1.58s (± 0.70%)-0.00s (- 0.13%)1.56s1.61s
Bind Time0.71s (± 1.36%)0.71s (± 0.85%)-0.00s (- 0.56%)0.69s0.72s
Check Time4.90s (± 0.63%)4.92s (± 0.78%)+0.01s (+ 0.29%)4.86s5.06s
Emit Time2.87s (± 0.61%)2.85s (± 0.73%)-0.01s (- 0.49%)2.82s2.93s
Total Time10.07s (± 0.38%)10.06s (± 0.50%)-0.01s (- 0.09%)10.00s10.23s
TFS - node (v12.1.0, x64)
Memory used292,014k (± 0.03%)292,098k (± 0.02%)+84k (+ 0.03%)291,972k292,222k
Parse Time1.26s (± 0.80%)1.25s (± 0.92%)-0.00s (- 0.24%)1.24s1.29s
Bind Time0.65s (± 0.51%)0.65s (± 0.52%)+0.00s (+ 0.46%)0.65s0.66s
Check Time4.49s (± 0.65%)4.49s (± 0.27%)-0.00s (- 0.11%)4.47s4.52s
Emit Time2.97s (± 0.94%)2.95s (± 0.69%)-0.02s (- 0.71%)2.88s2.98s
Total Time9.37s (± 0.51%)9.34s (± 0.32%)-0.03s (- 0.34%)9.29s9.42s
material-ui - node (v12.1.0, x64)
Memory used467,104k (± 0.06%)466,945k (± 0.08%)-158k (- 0.03%)466,136k467,379k
Parse Time2.09s (± 0.62%)2.08s (± 0.40%)-0.01s (- 0.72%)2.06s2.10s
Bind Time0.65s (± 0.92%)0.65s (± 1.30%)+0.00s (+ 0.46%)0.63s0.67s
Check Time12.10s (± 1.03%)12.11s (± 1.32%)+0.01s (+ 0.12%)11.90s12.57s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.83s (± 0.86%)14.84s (± 1.14%)+0.01s (+ 0.05%)14.62s15.35s
Angular - node (v8.9.0, x64)
Memory used347,023k (± 0.01%)347,040k (± 0.03%)+17k (+ 0.00%)346,799k347,231k
Parse Time2.52s (± 0.56%)2.51s (± 0.40%)-0.00s (- 0.20%)2.49s2.54s
Bind Time0.87s (± 0.38%)0.87s (± 0.55%)-0.00s (- 0.34%)0.86s0.88s
Check Time5.58s (± 0.48%)5.59s (± 0.71%)+0.01s (+ 0.14%)5.51s5.67s
Emit Time6.32s (± 0.56%)6.36s (± 0.78%)+0.04s (+ 0.65%)6.30s6.53s
Total Time15.30s (± 0.31%)15.33s (± 0.51%)+0.04s (+ 0.26%)15.19s15.55s
Monaco - node (v8.9.0, x64)
Memory used358,496k (± 0.02%)358,500k (± 0.01%)+4k (+ 0.00%)358,387k358,581k
Parse Time1.93s (± 0.75%)1.93s (± 0.30%)-0.00s (- 0.10%)1.92s1.94s
Bind Time0.91s (± 0.54%)0.91s (± 0.52%)-0.00s (- 0.44%)0.90s0.92s
Check Time5.65s (± 0.71%)5.65s (± 0.58%)0.00s ( 0.00%)5.59s5.72s
Emit Time3.42s (± 0.45%)3.41s (± 0.38%)-0.01s (- 0.41%)3.38s3.44s
Total Time11.92s (± 0.48%)11.90s (± 0.32%)-0.02s (- 0.13%)11.82s11.97s
TFS - node (v8.9.0, x64)
Memory used310,335k (± 0.02%)310,340k (± 0.01%)+4k (+ 0.00%)310,268k310,468k
Parse Time1.57s (± 0.23%)1.58s (± 0.53%)+0.01s (+ 0.57%)1.56s1.59s
Bind Time0.69s (± 0.72%)0.69s (± 0.90%)+0.00s (+ 0.44%)0.68s0.71s
Check Time5.31s (± 0.37%)5.32s (± 0.53%)+0.00s (+ 0.00%)5.28s5.41s
Emit Time2.96s (± 0.73%)2.98s (± 0.54%)+0.01s (+ 0.40%)2.94s3.02s
Total Time10.53s (± 0.22%)10.55s (± 0.37%)+0.02s (+ 0.21%)10.47s10.68s
material-ui - node (v8.9.0, x64)
Memory used496,242k (± 0.01%)496,241k (± 0.01%)-1k (- 0.00%)496,128k496,369k
Parse Time2.49s (± 0.54%)2.50s (± 0.60%)+0.01s (+ 0.52%)2.48s2.54s
Bind Time0.80s (± 0.91%)0.82s (± 0.98%)+0.02s (+ 2.51%)0.80s0.83s
Check Time18.04s (± 1.00%)18.05s (± 0.97%)+0.01s (+ 0.04%)17.80s18.63s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time21.33s (± 0.87%)21.37s (± 0.82%)+0.04s (+ 0.18%)21.12s21.93s
Angular - node (v8.9.0, x86)
Memory used199,007k (± 0.03%)199,019k (± 0.03%)+12k (+ 0.01%)198,917k199,148k
Parse Time2.43s (± 0.69%)2.43s (± 0.71%)-0.00s (- 0.08%)2.39s2.47s
Bind Time1.02s (± 1.10%)1.02s (± 0.83%)+0.00s (+ 0.00%)1.01s1.05s
Check Time5.08s (± 0.39%)5.04s (± 0.48%)-0.04s (- 0.73%)5.00s5.11s
Emit Time6.07s (± 0.71%)6.06s (± 0.95%)-0.01s (- 0.20%)5.94s6.19s
Total Time14.60s (± 0.39%)14.55s (± 0.49%)-0.05s (- 0.34%)14.36s14.66s
Monaco - node (v8.9.0, x86)
Memory used203,018k (± 0.01%)203,057k (± 0.02%)+39k (+ 0.02%)202,982k203,135k
Parse Time1.97s (± 0.75%)1.97s (± 0.54%)-0.01s (- 0.30%)1.94s1.99s
Bind Time0.72s (± 0.62%)0.72s (± 0.69%)-0.00s (- 0.28%)0.71s0.73s
Check Time5.71s (± 1.48%)5.74s (± 0.45%)+0.03s (+ 0.47%)5.69s5.82s
Emit Time2.80s (± 3.01%)2.74s (± 1.53%)-0.06s (- 2.00%)2.70s2.90s
Total Time11.20s (± 0.28%)11.17s (± 0.53%)-0.03s (- 0.27%)11.06s11.33s
TFS - node (v8.9.0, x86)
Memory used177,497k (± 0.02%)177,452k (± 0.01%)-44k (- 0.03%)177,409k177,519k
Parse Time1.62s (± 1.48%)1.62s (± 1.37%)-0.01s (- 0.43%)1.58s1.67s
Bind Time0.66s (± 1.16%)0.66s (± 1.89%)+0.00s (+ 0.31%)0.64s0.70s
Check Time4.87s (± 0.48%)4.86s (± 0.62%)-0.01s (- 0.10%)4.81s4.95s
Emit Time2.84s (± 0.82%)2.87s (± 1.26%)+0.02s (+ 0.77%)2.83s2.98s
Total Time9.99s (± 0.37%)10.00s (± 0.54%)+0.01s (+ 0.13%)9.92s10.12s
material-ui - node (v8.9.0, x86)
Memory used279,338k (± 0.01%)279,342k (± 0.02%)+5k (+ 0.00%)279,182k279,444k
Parse Time2.54s (± 0.68%)2.54s (± 0.45%)-0.01s (- 0.24%)2.52s2.57s
Bind Time0.75s (± 6.65%)0.78s (± 7.53%)+0.03s (+ 4.16%)0.69s0.88s
Check Time16.45s (± 0.73%)16.54s (± 0.87%)+0.10s (+ 0.58%)16.25s16.80s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time19.73s (± 0.61%)19.86s (± 0.83%)+0.12s (+ 0.61%)19.58s20.20s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current4147810
Baselinemaster10

@jack-williamsJack Williams (jack-williams) mentioned this pull request Nov 10, 2020
Merged
@jack-williams

Jack Williams (jack-williams) commented Nov 10, 2020

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the parallelized community code test suite on this PR at 0bebeb6. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the extended test suite on this PR at 0bebeb6. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at 0bebeb6. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41478

Metricmaster41478DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used344,450k (± 0.02%)344,500k (± 0.02%)+50k (+ 0.01%)344,325k344,705k
Parse Time1.98s (± 0.73%)1.99s (± 0.38%)+0.01s (+ 0.45%)1.98s2.01s
Bind Time0.83s (± 0.81%)0.84s (± 1.24%)+0.01s (+ 1.33%)0.82s0.87s
Check Time4.97s (± 0.46%)5.00s (± 0.39%)+0.03s (+ 0.54%)4.96s5.04s
Emit Time5.38s (± 0.83%)5.35s (± 0.67%)-0.03s (- 0.54%)5.27s5.43s
Total Time13.16s (± 0.40%)13.18s (± 0.38%)+0.02s (+ 0.15%)13.07s13.28s
Monaco - node (v10.16.3, x64)
Memory used354,695k (± 0.03%)354,705k (± 0.01%)+9k (+ 0.00%)354,516k354,763k
Parse Time1.59s (± 0.60%)1.62s (± 0.46%)+0.02s (+ 1.38%)1.60s1.63s
Bind Time0.73s (± 0.55%)0.73s (± 0.85%)+0.00s (+ 0.00%)0.72s0.74s
Check Time5.14s (± 0.62%)5.14s (± 0.50%)+0.00s (+ 0.06%)5.08s5.19s
Emit Time2.81s (± 0.86%)2.82s (± 0.72%)+0.01s (+ 0.36%)2.78s2.89s
Total Time10.27s (± 0.49%)10.31s (± 0.29%)+0.04s (+ 0.35%)10.26s10.38s
TFS - node (v10.16.3, x64)
Memory used307,841k (± 0.02%)307,918k (± 0.02%)+77k (+ 0.03%)307,785k308,125k
Parse Time1.24s (± 0.71%)1.24s (± 0.56%)+0.00s (+ 0.08%)1.22s1.25s
Bind Time0.68s (± 1.14%)0.68s (± 0.65%)+0.00s (+ 0.44%)0.67s0.69s
Check Time4.60s (± 0.62%)4.61s (± 0.67%)+0.00s (+ 0.09%)4.53s4.66s
Emit Time2.96s (± 1.17%)2.98s (± 0.52%)+0.02s (+ 0.68%)2.95s3.01s
Total Time9.48s (± 0.46%)9.51s (± 0.51%)+0.03s (+ 0.31%)9.37s9.59s
material-ui - node (v10.16.3, x64)
Memory used489,266k (± 0.01%)489,204k (± 0.01%)-62k (- 0.01%)488,980k489,317k
Parse Time2.06s (± 0.16%)2.07s (± 0.69%)+0.01s (+ 0.29%)2.05s2.11s
Bind Time0.66s (± 0.91%)0.65s (± 0.99%)-0.00s (- 0.61%)0.64s0.66s
Check Time13.62s (± 0.94%)13.55s (± 0.74%)-0.06s (- 0.46%)13.41s13.81s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time16.34s (± 0.81%)16.27s (± 0.70%)-0.06s (- 0.39%)16.11s16.58s
Angular - node (v12.1.0, x64)
Memory used322,363k (± 0.03%)322,383k (± 0.02%)+20k (+ 0.01%)322,241k322,523k
Parse Time1.97s (± 0.58%)1.98s (± 0.85%)+0.01s (+ 0.30%)1.94s2.01s
Bind Time0.82s (± 0.75%)0.82s (± 0.93%)-0.01s (- 0.61%)0.80s0.83s
Check Time4.89s (± 0.58%)4.93s (± 0.55%)+0.03s (+ 0.67%)4.87s4.98s
Emit Time5.51s (± 0.77%)5.54s (± 0.78%)+0.02s (+ 0.42%)5.46s5.65s
Total Time13.20s (± 0.47%)13.26s (± 0.54%)+0.06s (+ 0.45%)13.09s13.41s
Monaco - node (v12.1.0, x64)
Memory used336,814k (± 0.01%)336,837k (± 0.02%)+24k (+ 0.01%)336,695k336,921k
Parse Time1.58s (± 0.64%)1.59s (± 0.94%)+0.00s (+ 0.13%)1.56s1.63s
Bind Time0.71s (± 1.36%)0.71s (± 0.78%)+0.00s (+ 0.42%)0.70s0.73s
Check Time4.90s (± 0.63%)4.93s (± 0.65%)+0.02s (+ 0.49%)4.82s4.99s
Emit Time2.87s (± 0.61%)2.87s (± 0.55%)+0.00s (+ 0.00%)2.84s2.92s
Total Time10.07s (± 0.38%)10.09s (± 0.39%)+0.02s (+ 0.24%)9.98s10.18s
TFS - node (v12.1.0, x64)
Memory used292,014k (± 0.03%)292,052k (± 0.02%)+38k (+ 0.01%)291,953k292,176k
Parse Time1.26s (± 0.80%)1.25s (± 0.64%)-0.00s (- 0.32%)1.24s1.27s
Bind Time0.65s (± 0.51%)0.66s (± 0.72%)+0.01s (+ 1.08%)0.65s0.67s
Check Time4.49s (± 0.65%)4.51s (± 0.47%)+0.01s (+ 0.31%)4.46s4.55s
Emit Time2.97s (± 0.94%)2.95s (± 0.90%)-0.02s (- 0.67%)2.88s3.00s
Total Time9.37s (± 0.51%)9.37s (± 0.32%)-0.00s (- 0.05%)9.31s9.43s
material-ui - node (v12.1.0, x64)
Memory used467,104k (± 0.06%)467,130k (± 0.07%)+26k (+ 0.01%)466,247k467,479k
Parse Time2.09s (± 0.62%)2.09s (± 0.56%)+0.00s (+ 0.05%)2.06s2.12s
Bind Time0.65s (± 0.92%)0.65s (± 1.17%)0.00s ( 0.00%)0.63s0.66s
Check Time12.10s (± 1.03%)12.05s (± 0.77%)-0.05s (- 0.39%)11.88s12.32s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.83s (± 0.86%)14.79s (± 0.65%)-0.04s (- 0.29%)14.62s15.06s
Angular - node (v8.9.0, x64)
Memory used347,023k (± 0.01%)347,035k (± 0.02%)+12k (+ 0.00%)346,902k347,164k
Parse Time2.52s (± 0.56%)2.52s (± 0.41%)+0.00s (+ 0.04%)2.50s2.54s
Bind Time0.87s (± 0.38%)0.87s (± 0.78%)+0.00s (+ 0.46%)0.86s0.89s
Check Time5.58s (± 0.48%)5.65s (± 0.70%)+0.06s (+ 1.16%)5.57s5.77s
Emit Time6.32s (± 0.56%)6.34s (± 1.18%)+0.02s (+ 0.33%)6.11s6.41s
Total Time15.30s (± 0.31%)15.38s (± 0.66%)+0.09s (+ 0.58%)15.11s15.60s
Monaco - node (v8.9.0, x64)
Memory used358,496k (± 0.02%)358,489k (± 0.01%)-8k (- 0.00%)358,409k358,658k
Parse Time1.93s (± 0.75%)1.92s (± 0.39%)-0.01s (- 0.41%)1.91s1.95s
Bind Time0.91s (± 0.54%)0.91s (± 0.75%)-0.01s (- 0.88%)0.89s0.92s
Check Time5.65s (± 0.71%)5.68s (± 0.48%)+0.03s (+ 0.58%)5.64s5.74s
Emit Time3.42s (± 0.45%)3.41s (± 0.68%)-0.02s (- 0.44%)3.33s3.45s
Total Time11.92s (± 0.48%)11.92s (± 0.28%)+0.00s (+ 0.03%)11.87s12.01s
TFS - node (v8.9.0, x64)
Memory used310,335k (± 0.02%)310,334k (± 0.02%)-1k (- 0.00%)310,239k310,464k
Parse Time1.57s (± 0.23%)1.57s (± 0.51%)+0.01s (+ 0.38%)1.56s1.59s
Bind Time0.69s (± 0.72%)0.69s (± 0.58%)+0.00s (+ 0.44%)0.68s0.70s
Check Time5.31s (± 0.37%)5.34s (± 0.58%)+0.02s (+ 0.41%)5.27s5.40s
Emit Time2.96s (± 0.73%)2.96s (± 1.18%)-0.01s (- 0.17%)2.88s3.05s
Total Time10.53s (± 0.22%)10.55s (± 0.49%)+0.03s (+ 0.24%)10.43s10.66s
material-ui - node (v8.9.0, x64)
Memory used496,242k (± 0.01%)496,257k (± 0.01%)+15k (+ 0.00%)496,091k496,410k
Parse Time2.49s (± 0.54%)2.50s (± 0.43%)+0.02s (+ 0.60%)2.48s2.53s
Bind Time0.80s (± 0.91%)0.82s (± 1.48%)+0.02s (+ 2.88%)0.80s0.85s
Check Time18.04s (± 1.00%)18.17s (± 0.80%)+0.12s (+ 0.67%)17.86s18.42s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time21.33s (± 0.87%)21.49s (± 0.71%)+0.16s (+ 0.76%)21.18s21.80s
Angular - node (v8.9.0, x86)
Memory used199,007k (± 0.03%)199,020k (± 0.02%)+13k (+ 0.01%)198,908k199,079k
Parse Time2.43s (± 0.69%)2.44s (± 0.80%)+0.01s (+ 0.45%)2.40s2.48s
Bind Time1.02s (± 1.10%)1.02s (± 0.98%)+0.00s (+ 0.20%)1.01s1.05s
Check Time5.08s (± 0.39%)5.06s (± 0.56%)-0.02s (- 0.37%)4.99s5.14s
Emit Time6.07s (± 0.71%)6.15s (± 0.93%)+0.09s (+ 1.42%)6.05s6.28s
Total Time14.60s (± 0.39%)14.68s (± 0.51%)+0.08s (+ 0.58%)14.57s14.84s
Monaco - node (v8.9.0, x86)
Memory used203,018k (± 0.01%)203,032k (± 0.02%)+14k (+ 0.01%)202,982k203,172k
Parse Time1.97s (± 0.75%)1.99s (± 1.30%)+0.02s (+ 1.06%)1.96s2.07s
Bind Time0.72s (± 0.62%)0.72s (± 1.11%)+0.00s (+ 0.56%)0.71s0.75s
Check Time5.71s (± 1.48%)5.78s (± 0.48%)+0.07s (+ 1.23%)5.73s5.87s
Emit Time2.80s (± 3.01%)2.75s (± 0.77%)-0.05s (- 1.79%)2.70s2.80s
Total Time11.20s (± 0.28%)11.24s (± 0.59%)+0.04s (+ 0.40%)11.13s11.41s
TFS - node (v8.9.0, x86)
Memory used177,497k (± 0.02%)177,486k (± 0.02%)-11k (- 0.01%)177,401k177,573k
Parse Time1.62s (± 1.48%)1.62s (± 0.82%)+0.00s (+ 0.00%)1.60s1.66s
Bind Time0.66s (± 1.16%)0.65s (± 1.14%)-0.00s (- 0.76%)0.63s0.67s
Check Time4.87s (± 0.48%)4.88s (± 0.62%)+0.01s (+ 0.27%)4.79s4.94s
Emit Time2.84s (± 0.82%)2.85s (± 1.60%)+0.01s (+ 0.35%)2.75s2.98s
Total Time9.99s (± 0.37%)10.01s (± 0.55%)+0.02s (+ 0.18%)9.91s10.13s
material-ui - node (v8.9.0, x86)
Memory used279,338k (± 0.01%)279,360k (± 0.02%)+22k (+ 0.01%)279,250k279,505k
Parse Time2.54s (± 0.68%)2.55s (± 0.79%)+0.01s (+ 0.35%)2.52s2.60s
Bind Time0.75s (± 6.65%)0.77s (± 6.68%)+0.03s (+ 3.62%)0.69s0.86s
Check Time16.45s (± 0.73%)16.47s (± 0.82%)+0.02s (+ 0.15%)16.20s16.87s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time19.73s (± 0.61%)19.79s (± 0.67%)+0.06s (+ 0.30%)19.46s20.14s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current4147810
Baselinemaster10

@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Nov 10, 2020
Open
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

Closed
@jcalz

Joe Calzaretta (jcalz) commented Mar 13, 2021

Copy link
Copy Markdown
Contributor

Fixes #21732?

@sandersn

Nathan Shively-Sanders (sandersn) commented May 26, 2022

Copy link
Copy Markdown
Member

Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs.

@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@weswighamWesley Wigham (weswigham)

Labels

For Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jack-williams@typescript-bot@jcalz@sandersn@weswigham