Uh oh!
There was an error while loading. Please reload this page.
Sort import fixes by number of directory separators - #42614
Merged
Andrew Branch (andrewbranch) merged 2 commits intoFeb 3, 2021
Merged
Sort import fixes by number of directory separators#42614Andrew Branch (andrewbranch) merged 2 commits into
Andrew Branch (andrewbranch) merged 2 commits into
Conversation
Andrew Branch (andrewbranch)
requested a review
from Nathan Shively-Sanders (sandersn)February 2, 2021 20:17
Andrew Branch (andrewbranch)
requested a review
from Sheetal Nandi (sheetalkamat)February 2, 2021 20:17
Sheetal Nandi (sheetalkamat)
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the part of #41083 that can currently be fixed.
Previously, we only sorted reëxports of the same symbol (and we used absolute module specifier length, not number of directory separators). With this change, we sort all fixes together by number of directory separators. (Fix kind and package.json restrictions still take priority.)