Skip to content

Update parseInt parameter name and jsdoc - #42756

Merged
Ryan Cavanaugh (RyanCavanaugh) merged 6 commits into
microsoft:masterfrom
sangxxh:issue/42741-update-parseint-type-def
Mar 5, 2021
Merged

Update parseInt parameter name and jsdoc#42756
Ryan Cavanaugh (RyanCavanaugh) merged 6 commits into
microsoft:masterfrom
sangxxh:issue/42741-update-parseint-type-def

Conversation

@sangxxh

Copy link
Copy Markdown
Contributor

Fixes#42741

First contribution.

Update param name and docstring for parseInt to be more readable/consistent.

@typescript-botTypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Feb 11, 2021
@sangxxhSang (sangxxh) changed the title Issue/42741 update parseint type defUpdate parseInt parameter name and jsdocFeb 11, 2021
@DanielRosenwasser

Copy link
Copy Markdown
Member

Looks like the docs affect some tests. Run

gulp runtests
gulp baseline-accept
git add tests
git commit -m "Accepted baselines."
git push

@sangxxh

Sang (sangxxh) commented Feb 13, 2021

Copy link
Copy Markdown
ContributorAuthor

@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit 612a96e into microsoft:masterMar 5, 2021
@sangxxh
Sang (sangxxh) deleted the issue/42741-update-parseint-type-def branch March 5, 2021 21:03
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog BugPRs that fix a backlog bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

description of radix argument in parseInt calls string "numString", but parseInt header calls it "s"

5 participants

@sangxxh@DanielRosenwasser@RyanCavanaugh@sandersn@typescript-bot