Uh oh!
There was an error while loading. Please reload this page.
Don’t error for missing await when promise is referenced in condition body - #43593
Merged
Andrew Branch (andrewbranch) merged 2 commits intoApr 13, 2021
Merged
Conversation
Nathan Shively-Sanders (sandersn)
approved these changes
Apr 8, 2021
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Maybe now is a good time to reword the "always returns ... since it appears to" errors?
Uh oh!
There was an error while loading. Please reload this page.
Andrew Branch (andrewbranch)
commented
Apr 13, 2021
MemberAuthor
Daniel Rosenwasser (@DanielRosenwasser) are you alright with the error rewording? |
Member
Andrew Branch (@andrewbranch) I'm a little hurt that you want to undo all my hard work, but it's probably okay. |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Apr 13, 2021
ejose19
commented
Jun 7, 2021
I think this broke original implementation, see playground (as in announcement). That exact code correctly errors out in beta playground. |
Andrew Branch (andrewbranch)
commented
Jun 7, 2021
MemberAuthor
Well, that’s not great 😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#43514