Skip to content

Allow override as parameter property - #43831

Merged
andrewbranch merged 6 commits into
microsoft:masterfrom
andrewbranch:feature/override-parameter-property
Apr 28, 2021
Merged

Allow override as parameter property#43831
andrewbranch merged 6 commits into
microsoft:masterfrom
andrewbranch:feature/override-parameter-property

Conversation

@andrewbranch

Copy link
Copy Markdown
Member

Comment threadsrc/compiler/checker.ts

@DanielRosenwasserDanielRosenwasser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same sort of comment that's around the readonly modifier, then update checkGrammarModifiers

@Kingwl

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@andrewbranch@Kingwl@DanielRosenwasser@sheetalkamat@ajafff@typescript-bot