Uh oh!
There was an error while loading. Please reload this page.
Fix compiler crash on property symbols without declarations - #45190
Merged
Conversation
Gabriela Araujo Britto (gabritto)
requested review from
Nathan Shively-Sanders (sandersn) and Wesley Wigham (weswigham)July 26, 2021 20:25
Wesley Wigham (weswigham)
requested changes
Jul 27, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Gabriela Araujo Britto (gabritto)
requested a review
from Wesley Wigham (weswigham)July 27, 2021 18:03
Gabriela Araujo Britto (gabritto)
marked this pull request as ready for review
July 27, 2021 18:07
Ryan Cavanaugh (RyanCavanaugh)
commented
Jul 29, 2021
Member
Wesley Wigham (weswigham)
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#44970
In short, the checker crash was caused by the fact that properties that go through a mapped type with an
asclause don't have declarations attached to their symbols (#44609), butaddPropertyToElementList, a function used for serializing type nodes, relied on late-bound property symbols having declarations (propertySymbol.declarations).The fix here is to make the part of
addPropertyToElementListthat relies onpropertySymbol.declarationsactually check if declarations is defined before accessing it.In addition, there is now a declaration emit reporter for when we reach a late-bound symbol that has no declarations attached, as that should be an error since we shouldn't serialize that property type for declaration emit purposes.