Don't erase signature type parameters in signaturesRelatedTo

[Anders Hejlsberg (ahejlsberg)]

Fixes#48070.

[Anders Hejlsberg (ahejlsberg)]

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at b46f196. You can monitor the build here.

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at b46f196. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based community code test suite on this PR at b46f196. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at b46f196. You can monitor the build here.

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..48092

Metric	main	48092	Delta	Best	Worst
Angular - node (v14.15.1, x64)
Memory used	333,096k (± 0.00%)	333,111k (± 0.01%)	+16k (+ 0.00%)	333,070k	333,146k
Parse Time	2.03s (± 0.54%)	2.01s (± 0.39%)	-0.02s (- 0.94%)	1.99s	2.03s
Bind Time	0.89s (± 1.06%)	0.88s (± 0.53%)	-0.01s (- 1.12%)	0.87s	0.89s
Check Time	5.53s (± 0.54%)	5.51s (± 0.53%)	-0.03s (- 0.49%)	5.45s	5.58s
Emit Time	6.33s (± 0.50%)	6.31s (± 0.75%)	-0.02s (- 0.30%)	6.22s	6.42s
Total Time	14.78s (± 0.30%)	14.70s (± 0.41%)	-0.08s (- 0.55%)	14.60s	14.87s
Compiler-Unions - node (v14.15.1, x64)
Memory used	192,556k (± 0.50%)	194,018k (± 0.61%)	+1,462k (+ 0.76%)	192,379k	195,661k
Parse Time	0.85s (± 0.70%)	0.85s (± 0.58%)	0.00s ( 0.00%)	0.85s	0.87s
Bind Time	0.57s (± 0.87%)	0.57s (± 1.34%)	0.00s ( 0.00%)	0.56s	0.59s
Check Time	7.41s (± 0.56%)	7.39s (± 0.41%)	-0.02s (- 0.30%)	7.30s	7.45s
Emit Time	2.47s (± 0.47%)	2.47s (± 1.04%)	-0.00s (- 0.04%)	2.41s	2.55s
Total Time	11.30s (± 0.48%)	11.28s (± 0.22%)	-0.02s (- 0.21%)	11.25s	11.35s
Monaco - node (v14.15.1, x64)
Memory used	325,157k (± 0.00%)	325,141k (± 0.00%)	-16k (- 0.00%)	325,122k	325,194k
Parse Time	1.57s (± 0.79%)	1.56s (± 0.53%)	-0.01s (- 0.57%)	1.54s	1.58s
Bind Time	0.78s (± 1.23%)	0.77s (± 0.68%)	-0.01s (- 0.77%)	0.76s	0.78s
Check Time	5.42s (± 0.64%)	5.38s (± 0.47%)	-0.04s (- 0.72%)	5.33s	5.43s
Emit Time	3.33s (± 0.98%)	3.30s (± 0.66%)	-0.03s (- 0.81%)	3.27s	3.35s
Total Time	11.10s (± 0.56%)	11.02s (± 0.44%)	-0.08s (- 0.72%)	10.92s	11.11s
TFS - node (v14.15.1, x64)
Memory used	288,688k (± 0.01%)	288,693k (± 0.01%)	+5k (+ 0.00%)	288,654k	288,726k
Parse Time	1.34s (± 1.47%)	1.32s (± 1.10%)	-0.02s (- 1.27%)	1.30s	1.37s
Bind Time	0.73s (± 0.93%)	0.73s (± 0.85%)	-0.01s (- 0.68%)	0.72s	0.74s
Check Time	5.09s (± 0.72%)	5.07s (± 0.64%)	-0.02s (- 0.35%)	5.00s	5.16s
Emit Time	3.54s (± 1.78%)	3.46s (± 2.05%)	-0.08s (- 2.15%)	3.35s	3.61s
Total Time	10.69s (± 0.79%)	10.58s (± 0.97%)	-0.12s (- 1.08%)	10.38s	10.86s
material-ui - node (v14.15.1, x64)
Memory used	446,283k (± 0.07%)	446,461k (± 0.06%)	+178k (+ 0.04%)	445,449k	446,615k
Parse Time	1.86s (± 0.40%)	1.85s (± 0.42%)	-0.01s (- 0.64%)	1.83s	1.86s
Bind Time	0.70s (± 0.83%)	0.69s (± 0.71%)	-0.01s (- 1.28%)	0.68s	0.70s
Check Time	12.95s (± 0.88%)	12.85s (± 0.53%)	-0.10s (- 0.74%)	12.70s	13.01s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.51s (± 0.77%)	15.40s (± 0.45%)	-0.12s (- 0.75%)	15.26s	15.55s
xstate - node (v14.15.1, x64)
Memory used	535,366k (± 0.00%)	535,721k (± 0.00%)	+356k (+ 0.07%)	535,654k	535,776k
Parse Time	2.59s (± 0.73%)	2.58s (± 0.33%)	-0.01s (- 0.42%)	2.57s	2.61s
Bind Time	1.16s (± 0.96%)	1.16s (± 0.76%)	-0.01s (- 0.69%)	1.15s	1.18s
Check Time	1.50s (± 0.68%)	1.49s (± 0.27%)	-0.01s (- 0.53%)	1.48s	1.50s
Emit Time	0.07s (± 4.66%)	0.07s (± 3.14%)	-0.00s (- 2.74%)	0.07s	0.08s
Total Time	5.33s (± 0.35%)	5.31s (± 0.20%)	-0.03s (- 0.49%)	5.28s	5.33s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-210-generic
Architecture	x64
Available Memory	16 GB
Available Memory	5 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v14.15.1, x64)

Scenarios

• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	48092	10
Baseline	main	10

Developer Information:

Download Benchmark

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg)
Great news! no new errors were found between main..refs/pull/48092/merge

[Anders Hejlsberg (ahejlsberg)]

TypeScript Bot (@typescript-bot) run dt

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at b46f196. You can monitor the build here.

[Anders Hejlsberg (ahejlsberg)]

Hmm, an this appears to cause an OOM in babel__traverse on Definitely Typed. Plus a number of other somewhat inscrutable errors that probably are correct, but probably also of little value. Not sure we want to take this fix.

[Anders Hejlsberg (ahejlsberg)]

Ryan Cavanaugh (@RyanCavanaugh) Curious if you have an opinion here.

[Ryan Cavanaugh (RyanCavanaugh)]

The linked bug is a regression and also very surprising. It'd be nice if we could get this worked out

[Andrew Branch (andrewbranch)]

TypeScript Bot (@typescript-bot) pack this

[TypeScript Bot (typescript-bot)]

Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at b46f196. You can monitor the build here.

[Andrew Branch (andrewbranch)]

TypeScript Bot (@typescript-bot) pack this

[TypeScript Bot (typescript-bot)]

Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at 5d1e364. You can monitor the build here.

[TypeScript Bot (typescript-bot)]

Hey Andrew Branch (@andrewbranch), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157626/artifacts?artifactName=tgz&fileId=8AE456DFBF777DAB343BE58ED5DA2B1D703C94E6262068ACFBBC5DD091EB14FC02&fileName=/typescript-5.0.0-insiders.20230911.tgz"
}
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-48092-16".;

[TypeScript Bot (typescript-bot)]

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

• For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
• Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
• Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate