Uh oh!
There was an error while loading. Please reload this page.
Automatically create sort groups based on newlines in organize imports - #48330
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ff8df38 to
b89f697Compare
jakebailey
left a comment
There was a problem hiding this comment.
This looks about right to me, but I think what I'd like to see are a few more tests to cover cases where there are comments, e.g., what is the behavior when we have something like:
// polyfillimport"lib"// not polyfillimport{b}from"lib2"or say
import"lib"// xyzimportcfrom"C"Or similar (this isn't exhaustive). I know the original issue had some code snippets that feature comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fd96817 to
2c13fecCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aa759f0 to
24e4cd9Comparef594067 to
bd8ce22CompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Closes#41494.
Based on @RyanCavanaugh's suggestion #41494 (comment)
when organizing imports in each block of newline-contiguous
turns into