Uh oh!
There was an error while loading. Please reload this page.
Don't leak EvolvingArray out of code flow - #49943
Merged
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and Anders Hejlsberg (ahejlsberg)July 18, 2022 22:52
| Debug.fail("Unhandled type " + Debug.formatTypeFlags(type.flags)); | ||
| } | ||
| } | ||
| return type as ResolvedType; |
MemberAuthor
There was a problem hiding this comment.
Maybe this should assert each of the things that ResolvedType is assuming are defined, but I don't know how expensive that would be.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Daniel Rosenwasser (DanielRosenwasser)
requested a review
from Wesley Wigham (weswigham)July 18, 2022 23:26
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#49942
(I have no idea what I'm doing in the code flow engine)