Skip to content

Move deprecate from Debug to deprecatedCompat - #51522

Merged
jakebailey merged 2 commits into
microsoft:mainfrom
jakebailey:move-deprecation
Nov 16, 2022
Merged

Move deprecate from Debug to deprecatedCompat#51522
jakebailey merged 2 commits into
microsoft:mainfrom
jakebailey:move-deprecation

Conversation

@jakebailey

Copy link
Copy Markdown
Member

For #51443, #51441

This breaks the cycle between Debug and Version; while the current state doesn't crash (both bundled and unbundled), it only works due to some careful setup done in #51387. It's possible for a future refactor to break this unintentionally.

This was pulled out of #51455. It's a prerequisite for potentially making Debug a module rather than a namespace but probably also useful for #51504.

It also happens to reduce the code size of tsc by a little, since it doesn't use this code, but it's not really a significant amount by any means and isn't the driving force behind the PR.

@jakebailey

Copy link
Copy Markdown
MemberAuthor

@typescript-bot perf test this

@typescript-bottypescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 14, 2022
@typescript-bot

typescript-bot commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Heya @jakebailey, I've started to run the perf test suite on this PR at 89722f1. You can monitor the build here.

Update: The results are in!

@jakebaileyjakebailey changed the title Move deprecate to deprecatedCompatMove deprecate from Debug to deprecatedCompatNov 14, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51522
Metricmain51522DeltaBestWorst
Angular - node (v18.10.0, x64)
Memory used341,214k (± 0.01%)341,148k (± 0.01%)-66k (- 0.02%)341,014k341,253k
Parse Time1.57s (± 0.88%)1.56s (± 0.65%)-0.01s (- 0.51%)1.54s1.58s
Bind Time0.54s (± 0.92%)0.53s (± 0.84%)-0.00s (- 0.75%)0.52s0.54s
Check Time4.05s (± 0.79%)4.02s (± 0.71%)-0.03s (- 0.74%)3.95s4.09s
Emit Time4.27s (± 0.84%)4.26s (± 0.40%)-0.01s (- 0.33%)4.20s4.28s
Total Time10.43s (± 0.66%)10.37s (± 0.28%)-0.06s (- 0.54%)10.30s10.44s
Compiler-Unions - node (v18.10.0, x64)
Memory used188,819k (± 1.03%)189,798k (± 0.65%)+979k (+ 0.52%)184,902k190,520k
Parse Time0.62s (± 1.07%)0.62s (± 1.10%)-0.00s (- 0.65%)0.61s0.64s
Bind Time0.33s (± 0.68%)0.33s (± 1.58%)0.00s ( 0.00%)0.32s0.34s
Check Time5.01s (± 0.57%)5.02s (± 0.74%)+0.01s (+ 0.18%)4.97s5.11s
Emit Time1.55s (± 2.41%)1.52s (± 0.43%)-0.03s (- 2.00%)1.51s1.54s
Total Time7.51s (± 0.54%)7.49s (± 0.60%)-0.03s (- 0.35%)7.42s7.61s
Monaco - node (v18.10.0, x64)
Memory used320,524k (± 0.01%)320,540k (± 0.05%)+16k (+ 0.00%)320,322k321,133k
Parse Time1.18s (± 1.38%)1.16s (± 1.40%)-0.02s (- 1.86%)1.13s1.20s
Bind Time0.49s (± 1.91%)0.49s (± 2.49%)-0.00s (- 0.81%)0.47s0.51s
Check Time3.88s (± 0.60%)3.83s (± 0.40%)-0.05s (- 1.21%)3.80s3.87s
Emit Time2.28s (± 1.00%)2.23s (± 0.85%)-0.05s (- 2.11%)2.19s2.28s
Total Time7.83s (± 0.50%)7.71s (± 0.41%)-0.12s (- 1.52%)7.65s7.79s
TFS - node (v18.10.0, x64)
Memory used283,538k (± 0.24%)283,714k (± 0.25%)+177k (+ 0.06%)282,789k284,978k
Parse Time0.97s (± 1.07%)0.96s (± 1.49%)-0.01s (- 1.34%)0.93s0.99s
Bind Time0.45s (± 6.14%)0.46s (± 7.33%)+0.01s (+ 2.22%)0.43s0.55s
Check Time3.80s (± 0.59%)3.77s (± 0.49%)-0.04s (- 0.95%)3.73s3.80s
Emit Time2.22s (± 0.85%)2.18s (± 0.74%)-0.04s (- 1.76%)2.15s2.23s
Total Time7.44s (± 0.72%)7.36s (± 0.57%)-0.08s (- 1.05%)7.27s7.44s
material-ui - node (v18.10.0, x64)
Memory used436,031k (± 0.02%)435,975k (± 0.01%)-56k (- 0.01%)435,912k436,128k
Parse Time1.35s (± 0.78%)1.33s (± 0.75%)-0.02s (- 1.48%)1.31s1.35s
Bind Time0.50s (± 0.73%)0.49s (± 0.91%)-0.00s (- 0.81%)0.48s0.50s
Check Time10.40s (± 0.56%)10.24s (± 0.70%)-0.16s (- 1.52%)10.12s10.50s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time12.25s (± 0.52%)12.07s (± 0.67%)-0.18s (- 1.48%)11.95s12.36s
xstate - node (v18.10.0, x64)
Memory used518,685k (± 0.01%)518,657k (± 0.02%)-28k (- 0.01%)518,538k518,897k
Parse Time1.94s (± 0.31%)1.91s (± 0.63%)-0.03s (- 1.59%)1.89s1.94s
Bind Time0.79s (± 4.16%)0.78s (± 2.73%)-0.01s (- 1.39%)0.72s0.82s
Check Time1.06s (± 0.96%)1.03s (± 0.54%)-0.02s (- 2.18%)1.02s1.04s
Emit Time0.05s (± 0.00%)0.05s (± 0.00%)0.00s ( 0.00%)0.05s0.05s
Total Time3.84s (± 0.92%)3.77s (± 0.79%)-0.07s (- 1.82%)3.71s3.83s
Angular - node (v16.17.1, x64)
Memory used340,522k (± 0.02%)340,536k (± 0.02%)+14k (+ 0.00%)340,335k340,650k
Parse Time1.88s (± 0.66%)1.87s (± 0.53%)-0.01s (- 0.74%)1.85s1.89s
Bind Time0.65s (± 0.89%)0.64s (± 0.53%)-0.01s (- 1.53%)0.64s0.65s
Check Time5.16s (± 0.38%)5.12s (± 0.45%)-0.04s (- 0.81%)5.07s5.17s
Emit Time5.11s (± 0.76%)5.07s (± 0.74%)-0.04s (- 0.72%)4.99s5.14s
Total Time12.81s (± 0.46%)12.70s (± 0.44%)-0.10s (- 0.81%)12.57s12.81s
Compiler-Unions - node (v16.17.1, x64)
Memory used188,257k (± 0.65%)187,881k (± 0.63%)-376k (- 0.20%)186,478k189,898k
Parse Time0.79s (± 0.75%)0.79s (± 1.27%)0.00s ( 0.00%)0.78s0.82s
Bind Time0.42s (± 0.53%)0.42s (± 0.71%)-0.00s (- 0.71%)0.41s0.42s
Check Time6.05s (± 0.72%)6.04s (± 0.87%)-0.01s (- 0.13%)5.97s6.21s
Emit Time1.91s (± 0.72%)1.90s (± 1.12%)-0.00s (- 0.21%)1.83s1.94s
Total Time9.17s (± 0.47%)9.16s (± 0.64%)-0.01s (- 0.15%)9.06s9.35s
Monaco - node (v16.17.1, x64)
Memory used319,866k (± 0.01%)319,840k (± 0.01%)-26k (- 0.01%)319,779k319,922k
Parse Time1.43s (± 0.73%)1.42s (± 0.67%)-0.01s (- 0.77%)1.40s1.44s
Bind Time0.59s (± 1.00%)0.59s (± 0.76%)-0.01s (- 1.01%)0.58s0.60s
Check Time4.87s (± 0.39%)4.85s (± 0.54%)-0.02s (- 0.41%)4.79s4.89s
Emit Time2.72s (± 0.90%)2.71s (± 0.98%)-0.01s (- 0.37%)2.64s2.75s
Total Time9.61s (± 0.40%)9.57s (± 0.57%)-0.05s (- 0.49%)9.42s9.65s
TFS - node (v16.17.1, x64)
Memory used282,300k (± 0.01%)282,298k (± 0.00%)-3k (- 0.00%)282,280k282,330k
Parse Time1.17s (± 0.51%)1.17s (± 0.95%)+0.00s (+ 0.09%)1.14s1.19s
Bind Time0.65s (± 3.63%)0.65s (± 3.48%)-0.00s (- 0.15%)0.60s0.69s
Check Time4.76s (± 0.39%)4.73s (± 0.25%)-0.03s (- 0.63%)4.70s4.76s
Emit Time2.76s (± 2.01%)2.73s (± 1.68%)-0.03s (- 1.05%)2.66s2.85s
Total Time9.35s (± 0.72%)9.28s (± 0.51%)-0.07s (- 0.74%)9.19s9.41s
material-ui - node (v16.17.1, x64)
Memory used435,297k (± 0.01%)435,307k (± 0.01%)+10k (+ 0.00%)435,259k435,490k
Parse Time1.65s (± 0.50%)1.64s (± 0.81%)-0.01s (- 0.85%)1.62s1.68s
Bind Time0.50s (± 0.98%)0.50s (± 1.12%)-0.01s (- 1.19%)0.49s0.51s
Check Time11.96s (± 0.42%)11.90s (± 0.91%)-0.07s (- 0.54%)11.65s12.10s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.13s (± 0.36%)14.04s (± 0.84%)-0.09s (- 0.61%)13.78s14.22s
xstate - node (v16.17.1, x64)
Memory used516,263k (± 0.01%)516,232k (± 0.01%)-32k (- 0.01%)516,135k516,372k
Parse Time2.33s (± 0.45%)2.31s (± 0.39%)-0.02s (- 0.90%)2.29s2.33s
Bind Time0.84s (± 1.90%)0.83s (± 0.70%)-0.02s (- 2.01%)0.82s0.84s
Check Time1.36s (± 0.50%)1.36s (± 0.70%)+0.00s (+ 0.00%)1.33s1.37s
Emit Time0.06s (± 0.00%)0.06s (± 0.00%)0.00s ( 0.00%)0.06s0.06s
Total Time4.60s (± 0.44%)4.55s (± 0.37%)-0.04s (- 0.91%)4.51s4.59s
Angular - node (v14.15.1, x64)
Memory used334,041k (± 0.01%)334,030k (± 0.01%)-11k (- 0.00%)334,008k334,075k
Parse Time2.08s (± 0.55%)2.04s (± 0.59%)-0.04s (- 1.97%)2.02s2.07s
Bind Time0.70s (± 0.53%)0.70s (± 0.82%)-0.01s (- 0.71%)0.69s0.71s
Check Time5.52s (± 0.33%)5.47s (± 0.47%)-0.05s (- 0.94%)5.43s5.53s
Emit Time5.22s (± 0.68%)5.19s (± 0.67%)-0.03s (- 0.63%)5.12s5.27s
Total Time13.53s (± 0.38%)13.40s (± 0.33%)-0.13s (- 0.95%)13.29s13.49s
Compiler-Unions - node (v14.15.1, x64)
Memory used181,579k (± 0.01%)181,563k (± 0.01%)-16k (- 0.01%)181,522k181,601k
Parse Time0.90s (± 0.62%)0.89s (± 0.41%)-0.01s (- 1.34%)0.88s0.89s
Bind Time0.46s (± 0.48%)0.45s (± 0.99%)-0.01s (- 1.95%)0.44s0.46s
Check Time6.36s (± 0.45%)6.30s (± 0.46%)-0.07s (- 1.05%)6.26s6.38s
Emit Time2.04s (± 0.71%)2.04s (± 0.52%)-0.01s (- 0.39%)2.01s2.07s
Total Time9.77s (± 0.35%)9.67s (± 0.33%)-0.10s (- 1.02%)9.61s9.75s
Monaco - node (v14.15.1, x64)
Memory used314,689k (± 0.05%)314,571k (± 0.01%)-118k (- 0.04%)314,472k314,650k
Parse Time1.58s (± 0.66%)1.56s (± 0.48%)-0.02s (- 1.01%)1.55s1.58s
Bind Time0.64s (± 0.78%)0.63s (± 0.71%)-0.00s (- 0.47%)0.62s0.64s
Check Time5.21s (± 0.52%)5.17s (± 0.44%)-0.04s (- 0.77%)5.09s5.22s
Emit Time2.92s (± 0.69%)2.87s (± 1.00%)-0.05s (- 1.64%)2.82s2.94s
Total Time10.34s (± 0.41%)10.23s (± 0.44%)-0.11s (- 1.05%)10.12s10.31s
TFS - node (v14.15.1, x64)
Memory used279,310k (± 0.01%)279,314k (± 0.01%)+5k (+ 0.00%)279,281k279,346k
Parse Time1.34s (± 0.62%)1.33s (± 1.56%)-0.01s (- 0.67%)1.29s1.40s
Bind Time0.59s (± 0.80%)0.58s (± 0.63%)-0.01s (- 0.85%)0.58s0.59s
Check Time5.10s (± 0.36%)5.06s (± 0.49%)-0.04s (- 0.88%)4.99s5.11s
Emit Time3.08s (± 0.92%)3.04s (± 1.92%)-0.05s (- 1.59%)2.84s3.13s
Total Time10.12s (± 0.34%)10.01s (± 0.72%)-0.11s (- 1.08%)9.80s10.13s
material-ui - node (v14.15.1, x64)
Memory used430,756k (± 0.01%)430,747k (± 0.00%)-9k (- 0.00%)430,695k430,786k
Parse Time1.88s (± 0.46%)1.87s (± 0.35%)-0.01s (- 0.74%)1.85s1.88s
Bind Time0.54s (± 0.69%)0.53s (± 0.63%)-0.01s (- 0.93%)0.52s0.54s
Check Time12.38s (± 0.70%)12.17s (± 0.33%)-0.21s (- 1.67%)12.08s12.29s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.79s (± 0.60%)14.57s (± 0.26%)-0.23s (- 1.55%)14.47s14.66s
xstate - node (v14.15.1, x64)
Memory used504,439k (± 0.00%)504,425k (± 0.01%)-14k (- 0.00%)504,361k504,509k
Parse Time2.65s (± 0.70%)2.63s (± 0.63%)-0.03s (- 1.02%)2.59s2.68s
Bind Time0.86s (± 0.97%)0.84s (± 0.99%)-0.02s (- 2.22%)0.82s0.86s
Check Time1.49s (± 0.35%)1.47s (± 0.54%)-0.02s (- 1.14%)1.45s1.49s
Emit Time0.07s (± 0.00%)0.07s (± 0.00%)0.00s ( 0.00%)0.07s0.07s
Total Time5.07s (± 0.30%)5.00s (± 0.33%)-0.07s (- 1.28%)4.97s5.04s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current5152210
Baselinemain10

TSServer

Comparison Report - main..51522
Metricmain51522DeltaBestWorst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen1,047ms (± 0.50%)1,044ms (± 0.68%)-2ms (- 0.21%)1,034ms1,067ms
Req 2 - geterr2,568ms (± 0.75%)2,536ms (± 0.62%)-32ms (- 1.24%)2,499ms2,572ms
Req 3 - references166ms (± 0.99%)165ms (± 0.42%)-1ms (- 0.36%)163ms166ms
Req 4 - navto138ms (± 0.94%)139ms (± 2.91%)+1ms (+ 1.02%)135ms155ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo62ms (± 2.71%)61ms (± 1.45%)-1ms (- 1.46%)58ms62ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen1,102ms (± 0.50%)1,093ms (± 0.55%)-9ms (- 0.77%)1,080ms1,103ms
Req 2 - geterr1,573ms (± 0.39%)1,562ms (± 0.36%)-11ms (- 0.69%)1,549ms1,577ms
Req 3 - references171ms (± 0.98%)169ms (± 0.49%)-3ms (- 1.46%)167ms170ms
Req 4 - navto151ms (± 0.88%)150ms (± 0.50%)-1ms (- 0.53%)149ms152ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo53ms (± 1.46%)53ms (± 1.05%)-0ms (- 0.56%)52ms54ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen1,518ms (± 0.76%)1,507ms (± 0.49%)-11ms (- 0.73%)1,496ms1,525ms
Req 2 - geterr562ms (± 0.53%)551ms (± 0.79%)-11ms (- 1.99%)545ms564ms
Req 3 - references59ms (± 2.01%)58ms (± 2.04%)-1ms (- 1.69%)57ms62ms
Req 4 - navto197ms (± 1.03%)195ms (± 0.51%)-2ms (- 1.02%)193ms197ms
Req 5 - completionInfo count3,151 (± 0.00%)3,151 (± 0.00%)0 ( 0.00%)3,1513,151
Req 5 - completionInfo212ms (± 1.32%)212ms (± 1.33%)-0ms (- 0.14%)207ms219ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen1,303ms (± 0.79%)1,296ms (± 0.55%)-7ms (- 0.52%)1,275ms1,309ms
Req 2 - geterr3,153ms (± 0.65%)3,152ms (± 0.76%)-1ms (- 0.04%)3,115ms3,207ms
Req 3 - references193ms (± 1.37%)193ms (± 1.18%)-0ms (- 0.16%)188ms198ms
Req 4 - navto151ms (± 0.70%)151ms (± 0.76%)-0ms (- 0.13%)149ms153ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo59ms (± 2.55%)58ms (± 2.16%)-1ms (- 1.37%)55ms61ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen1,394ms (± 0.70%)1,375ms (± 0.92%)-20ms (- 1.42%)1,346ms1,403ms
Req 2 - geterr2,072ms (± 0.44%)2,060ms (± 0.51%)-12ms (- 0.56%)2,031ms2,074ms
Req 3 - references199ms (± 0.56%)200ms (± 0.45%)+0ms (+ 0.10%)198ms201ms
Req 4 - navto165ms (± 0.62%)164ms (± 0.98%)-1ms (- 0.79%)161ms168ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo58ms (± 2.78%)58ms (± 1.97%)+0ms (+ 0.35%)54ms59ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen1,819ms (± 0.36%)1,821ms (± 0.51%)+1ms (+ 0.08%)1,807ms1,843ms
Req 2 - geterr713ms (± 0.54%)714ms (± 0.98%)+1ms (+ 0.15%)699ms728ms
Req 3 - references69ms (± 1.39%)68ms (± 2.44%)-1ms (- 1.02%)65ms73ms
Req 4 - navto197ms (± 1.11%)197ms (± 0.97%)0ms ( 0.00%)194ms204ms
Req 5 - completionInfo count3,151 (± 0.00%)3,151 (± 0.00%)0 ( 0.00%)3,1513,151
Req 5 - completionInfo251ms (± 0.95%)253ms (± 0.84%)+1ms (+ 0.56%)249ms257ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen1,461ms (± 0.44%)1,446ms (± 0.52%)-16ms (- 1.07%)1,433ms1,463ms
Req 2 - geterr3,426ms (± 0.65%)3,380ms (± 0.61%)-46ms (- 1.34%)3,339ms3,440ms
Req 3 - references206ms (± 0.55%)206ms (± 0.46%)-1ms (- 0.29%)204ms209ms
Req 4 - navto162ms (± 0.90%)163ms (± 2.01%)+0ms (+ 0.18%)159ms175ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo66ms (± 6.92%)66ms (± 5.93%)+0ms (+ 0.46%)58ms72ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen1,530ms (± 0.58%)1,520ms (± 0.34%)-10ms (- 0.65%)1,514ms1,538ms
Req 2 - geterr2,262ms (± 0.29%)2,240ms (± 0.54%)-23ms (- 0.99%)2,224ms2,283ms
Req 3 - references213ms (± 1.28%)212ms (± 1.31%)-1ms (- 0.52%)208ms219ms
Req 4 - navto174ms (± 0.77%)173ms (± 1.01%)-2ms (- 1.09%)169ms177ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo61ms (± 7.63%)61ms (± 8.47%)-1ms (- 1.14%)55ms71ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,037ms (± 0.62%)2,007ms (± 0.32%)-30ms (- 1.45%)1,993ms2,024ms
Req 2 - geterr751ms (± 0.58%)739ms (± 0.46%)-13ms (- 1.68%)731ms746ms
Req 3 - references73ms (± 1.16%)72ms (± 1.25%)-1ms (- 1.92%)70ms74ms
Req 4 - navto222ms (± 0.64%)217ms (± 0.54%)-5ms (- 2.25%)214ms220ms
Req 5 - completionInfo count3,151 (± 0.00%)3,151 (± 0.00%)0 ( 0.00%)3,1513,151
Req 5 - completionInfo270ms (± 0.57%)271ms (± 1.62%)+2ms (+ 0.59%)265ms280ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current5152210
Baselinemain10

Startup

Comparison Report - main..51522
Metricmain51522DeltaBestWorst
tsc-startup - node (v16.17.1, x64)
Execution time120.22ms (± 0.53%)118.29ms (± 0.48%)-1.93ms (- 1.61%)115.71ms125.21ms
tsserver-startup - node (v16.17.1, x64)
Execution time201.76ms (± 0.47%)198.37ms (± 0.33%)-3.39ms (- 1.68%)195.28ms206.00ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time194.36ms (± 0.46%)192.32ms (± 0.34%)-2.05ms (- 1.05%)189.05ms200.71ms
typescript-startup - node (v16.17.1, x64)
Execution time178.93ms (± 0.45%)177.28ms (± 0.30%)-1.65ms (- 0.92%)174.78ms184.40ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current5152210
Baselinemain10

Developer Information:

Download Benchmark

@jakebailey

Copy link
Copy Markdown
MemberAuthor

Going to merge this to unblock the other PRs; if we need to reintroduce this into the compiler project we can do so but I this is okay.

@jakebailey
jakebailey merged commit 4d53a1f into microsoft:mainNov 16, 2022
@jakebailey
jakebailey deleted the move-deprecation branch November 16, 2022 00:00
@microsoftmicrosoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jakebailey@typescript-bot@DanielRosenwasser@sheetalkamat