Uh oh!
There was an error while loading. Please reload this page.
Remove webServer - #51699
Conversation
First draft; I may move some things around to be more readable.
1. Move StartSessionOptions to common next to where it's first used.
2. Inline single-use BaseLogger base class into its only child class,
Logger.
3. Start using direct imports, eg `import {} from './common'`. I hope
this is OK?!Nathan Shively-Sanders (sandersn)
commented
Dec 1, 2022
Jake Bailey (@jakebailey) The most recent commit removes |
Orta Therox (orta)
commented
Dec 2, 2022
( Not that it's too important as the URLs are hidden, but it might be worth checking if you need to write an issue on vscode-web to remove the vscode-ts-playground code which relies on this (a search in the repo for 'playground' should be enough to know. ) |
Orta Therox (@orta) where is the vscode-ts-playground code? I searched in microsoft/vscode but didn't see anything that looked definitively like it. |
Orta Therox (orta)
commented
Dec 2, 2022
Hrm, you might not have access then it's in the microsoft/vscode-web repo /cc Matt Bierner (@mjbvz) |
Nathan Shively-Sanders (sandersn)
commented
Dec 5, 2022
yep, microsoft/vscode-web is a 404 for me |
Jake Bailey (jakebailey)
commented
Dec 5, 2022
I would imagine that we'd want to switch that playground prototype into using |
Nathan Shively-Sanders (sandersn)
commented
Dec 5, 2022
yes, I just don't know where it is yet |
Matt Bierner (mjbvz)
commented
Dec 6, 2022
I also don't have access to |
Orta Therox (orta)
commented
Dec 6, 2022
Sorry, I mean the http server for vscode.dev - so that's probably the repo! |
Jake Bailey (jakebailey)
left a comment
There was a problem hiding this comment.
This looks good to me, though I believe that we may want to clean up the tsserver project a little now that there aren't two entrypoints. I had to do a bunch of movement in the module conversion to support the old web bundle, but that all is not needed now and we eliminate the common file and all of the exports and stuff.
Nathan Shively-Sanders (sandersn)
commented
Dec 6, 2022
Orta Therox (@orta) I looked for places in the vscode repo with mentions of |
webServer is now moved to vscode-web, since that's the only project that was using it. This allows tsserver to be a node-only executable instead of conditionally being startable in a webworker.
Implementation notes
processas a proxy for "running on node". It just assumes it's running on node.Jake Bailey (@jakebailey) I would like for you to check those two things when you have a chance.