Uh oh!
There was an error while loading. Please reload this page.
Switch imports back to case sensitive sorting - #51916
Closed
Jake Bailey (jakebailey) wants to merge 6 commits into
Closed
Switch imports back to case sensitive sorting#51916Jake Bailey (jakebailey) wants to merge 6 commits into
Jake Bailey (jakebailey) wants to merge 6 commits into
Conversation
Jake Bailey (jakebailey)
commented
Jan 3, 2023
MemberAuthor
If we also want Organize Imports to work, I can add in the necessary newlines or changes + eslint rule to enforce that, I was just trying to do more of a revert. But, I think people just want their editors to work better, so I can just add that change in here. |
Jake Bailey (jakebailey)
commented
Jan 3, 2023
MemberAuthor
Jake Bailey (jakebailey)
commented
Jan 3, 2023
MemberAuthor
eslint-plugin-import can do this, but, it also doesn't match organize imports. |
Ron Buckton (rbuckton)
commented
Jan 4, 2023
Contributor
Maybe we need an |
Jake Bailey (jakebailey)
commented
Jan 20, 2023
MemberAuthor
At this point I am strongly preferring #52090. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes#51617
As of the latest nightly VS Code TypeScript extension, we seem to handle things correctly.