Tweak co/contra inference logic from #52123 by jakebailey · Pull Request #52180 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2023-01-10T04:51:10Z

In the case of coAndContraVariantInferences4, we end up with Modifier as the covariant type, but that isn't a subtype of both Modifier and Decorator, so it shouldn't be chosen; we instead want Node, the contravariant inference. But, if you flip things and test for Decorator instead, Modifier is still the covariant inference, but now it doesn't match Decorator, so we get the desired result, Node.

This tweaks the logic from #52123 by ensuring that even the current inference's candidates are checked against the inferred covariant type; this effectively removes the problematic choice for the covariant type produced via union ordering.

I'm not an expert; maybe the better win is to change getCovariantInference somehow. I just tried this and was surprised that it fixed all of my examples and broke no other test.

Jake Bailey (jakebailey) · 2023-01-10T04:51:26Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-01-10T04:51:29Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at 22cfe3a. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-10T04:51:29Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 22cfe3a. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-10T04:51:29Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 22cfe3a. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-10T04:51:29Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 22cfe3a. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-10T04:51:29Z

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 22cfe3a. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-10T04:51:29Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 22cfe3a. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-10T04:53:16Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/142189/artifacts?artifactName=tgz&fileId=5C918491703160B0BD60CA07F72F23EC792D3F9FCF3796D6F854B45B5D1D5DBB02&fileName=/typescript-5.0.0-insiders.20230110.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52180-7".;

TypeScript Bot (typescript-bot) · 2023-01-10T05:04:35Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52180/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-01-10T05:10:28Z

Heya Jake Bailey (@jakebailey), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

TypeScript Bot (typescript-bot) · 2023-01-10T06:25:00Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52180/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2023-01-10T06:51:18Z

This PR turns out to only fix some of the examples in the linked issue.

Playground Link
- All fixed but one, which can be worked around by changing some.
Playground Link
- Not fixed at all.
Playground Link
- Fixed.

Anders Hejlsberg (ahejlsberg) · 2023-01-10T23:41:16Z

Interesting situation... Co-variant inferences have no common supertype, so we pick the first in anticipation of an error being issued as a result. However, we could have succeeded by picking the contra-variant inference. Yup, we could do better here. I like your proposed fix.

Anders Hejlsberg (ahejlsberg)

Approved assuming performance is unaffected and tests are clean.

Jake Bailey (jakebailey) · 2023-01-10T23:48:09Z

All user/top100/etc tests are clean; waiting on perf tests though since I have to merge a fix to main first to unblock it.

Jake Bailey (jakebailey) · 2023-01-11T00:09:26Z

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-01-11T00:09:29Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 60e15f3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-11T00:09:29Z

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 60e15f3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-11T00:11:13Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/142306/artifacts?artifactName=tgz&fileId=DE14D7E5D5144BBF8161195011F7CE0E54DD6AD8CCDBF5897C9F72065FC0856902&fileName=/typescript-5.0.0-insiders.20230111.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52180-17".;

Jake Bailey (jakebailey) · 2023-01-11T00:20:01Z

Just tested this on #49929 and it works really well; even more cases I didn't notice are fixed, including inference I worked around with this:

functioncastToNodeArray<TextendsNode>(nodes: readonlyT[]): NodeArray<T>{returncast<NodeArray<T>,readonlyT[]>(nodes,isNodeArray);}

I'll add these newly found examples as test cases here.

Jake Bailey (jakebailey) · 2023-01-11T00:28:57Z

Nah, nevermind; forgot that it was to do with the fact that I had to change cast's signature until #52123, so the above code was already not needed even before this PR, which is more about the union thing when there's ambiguity.

TypeScript Bot (typescript-bot) · 2023-01-11T01:06:52Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52180

_Metric	_main	₅₂₁₈₀	_Delta	_Best	_Worst
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{372,660k (± 0.01%)}	_{372,420k (± 0.01%)}	_{-240k (- 0.06%)}	_372,342k	_372,484k
_{Parse Time}	_{3.93s (± 0.82%)}	_{3.95s (± 1.07%)}	_{+0.01s (+ 0.34%)}	_3.91s	_4.02s
_{Bind Time}	_{1.20s (± 0.39%)}	_{1.21s (± 0.52%)}	_{+0.00s (+ 0.14%)}	_1.20s	_1.21s
_{Check Time}	_{8.60s (± 0.43%)}	_{8.64s (± 0.44%)}	_{+0.04s (+ 0.45%)}	_8.58s	_8.67s
_{Emit Time}	_{7.50s (± 0.37%)}	_{7.57s (± 1.29%)}	_{+0.06s (+ 0.85%)}	_7.47s	_7.75s
_{Total Time}	_{21.24s (± 0.18%)}	_{21.36s (± 0.73%)}	_{+0.12s (+ 0.56%)}	_21.21s	_21.64s
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{202,113k (± 1.43%)}	_{201,226k (± 1.55%)}	_{-887k (- 0.44%)}	_198,348k	_204,223k
_{Parse Time}	_{1.66s (± 1.58%)}	_{1.64s (± 1.73%)}	_{-0.02s (- 1.47%)}	_1.60s	_1.67s
_{Bind Time}	_{0.79s (± 0.15%)}	_{0.79s (± 0.40%)}	_{+0.00s (+ 0.14%)}	_0.79s	_0.80s
_{Check Time}	_{9.47s (± 1.14%)}	_{9.49s (± 0.55%)}	_{+0.02s (+ 0.20%)}	_9.42s	_9.54s
_{Emit Time}	_{2.76s (± 0.65%)}	_{2.74s (± 0.74%)}	_{-0.02s (- 0.61%)}	_2.71s	_2.76s
_{Total Time}	_{14.68s (± 0.66%)}	_{14.66s (± 0.54%)}	_{-0.03s (- 0.19%)}	_14.55s	_14.75s
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{354,119k (± 0.01%)}	_{354,151k (± 0.01%)}	_{+32k (+ 0.01%)}	_354,098k	_354,181k
_{Parse Time}	_{2.93s (± 0.59%)}	_{2.95s (± 0.72%)}	_{+0.02s (+ 0.77%)}	_2.92s	_2.97s
_{Bind Time}	_{1.04s (± 0.82%)}	_{1.04s (± 1.15%)}	_{+0.00s (+ 0.03%)}	_1.03s	_1.06s
_{Check Time}	_{7.24s (± 0.43%)}	_{7.23s (± 0.70%)}	_{-0.01s (- 0.08%)}	_7.16s	_7.29s
_{Emit Time}	_{4.27s (± 0.98%)}	_{4.30s (± 1.31%)}	_{+0.02s (+ 0.58%)}	_4.24s	_4.40s
_{Total Time}	_{15.48s (± 0.41%)}	_{15.52s (± 0.67%)}	_{+0.04s (+ 0.27%)}	_15.41s	_15.70s
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{310,022k (± 0.01%)}	_{310,193k (± 0.01%)}	_{+171k (+ 0.06%)}	_310,178k	_310,228k
_{Parse Time}	_{2.26s (± 0.50%)}	_{2.27s (± 1.01%)}	_{+0.01s (+ 0.53%)}	_2.23s	_2.30s
_{Bind Time}	_{1.16s (± 0.53%)}	_{1.15s (± 0.75%)}	_{-0.01s (- 1.13%)}	_1.13s	_1.16s
_{Check Time}	_{6.79s (± 0.62%)}	_{6.80s (± 0.71%)}	_{+0.01s (+ 0.16%)}	_6.72s	_6.85s
_{Emit Time}	_{3.93s (± 0.71%)}	_{3.94s (± 0.55%)}	_{+0.01s (+ 0.16%)}	_3.91s	_3.96s
_{Total Time}	_{14.14s (± 0.50%)}	_{14.16s (± 0.58%)}	_{+0.02s (+ 0.13%)}	_14.01s	_14.22s
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{485,241k (± 0.02%)}	_{485,287k (± 0.02%)}	_{+46k (+ 0.01%)}	_485,215k	_485,396k
_{Parse Time}	_{3.54s (± 0.68%)}	_{3.53s (± 0.35%)}	_{-0.01s (- 0.30%)}	_3.51s	_3.55s
_{Bind Time}	_{0.97s (± 0.93%)}	_{0.96s (± 1.29%)}	_{-0.01s (- 0.58%)}	_0.95s	_0.98s
_{Check Time}	_{16.91s (± 0.16%)}	_{16.88s (± 0.23%)}	_{-0.04s (- 0.21%)}	_16.82s	_16.93s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.42s (± 0.19%)}	_{21.37s (± 0.20%)}	_{-0.05s (- 0.24%)}	_21.30s	_21.43s
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{570,346k (± 0.03%)}	_{570,343k (± 0.01%)}	_{-3k (- 0.00%)}	_570,261k	_570,438k
_{Parse Time}	_{4.42s (± 0.41%)}	_{4.43s (± 0.79%)}	_{+0.01s (+ 0.25%)}	_4.39s	_4.48s
_{Bind Time}	_{1.69s (± 0.80%)}	_{1.71s (± 0.93%)}	_{+0.01s (+ 0.75%)}	_1.68s	_1.73s
_{Check Time}	_{2.61s (± 1.20%)}	_{2.61s (± 1.20%)}	_{+0.01s (+ 0.19%)}	_2.58s	_2.65s
_{Emit Time}	_{0.08s (± 0.18%)}	_{0.08s (± 0.10%)}	_{+0.00s (+ 0.07%)}	_0.08s	_0.08s
_{Total Time}	_{8.81s (± 0.38%)}	_{8.83s (± 0.28%)}	_{+0.02s (+ 0.20%)}	_8.78s	_8.85s
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{372,012k (± 0.01%)}	_{371,785k (± 0.01%)}	_{-227k (- 0.06%)}	_371,747k	_371,828k
_{Parse Time}	_{4.13s (± 0.35%)}	_{4.13s (± 0.25%)}	_{+0.00s (+ 0.09%)}	_4.12s	_4.15s
_{Bind Time}	_{1.27s (± 0.77%)}	_{1.27s (± 0.42%)}	_{+0.00s (+ 0.00%)}	_1.26s	_1.27s
_{Check Time}	_{9.31s (± 0.27%)}	_{9.32s (± 0.25%)}	_{+0.01s (+ 0.08%)}	_9.29s	_9.35s
_{Emit Time}	_{7.98s (± 0.21%)}	_{8.01s (± 0.30%)}	_{+0.03s (+ 0.40%)}	_7.98s	_8.05s
_{Total Time}	_{22.68s (± 0.17%)}	_{22.72s (± 0.19%)}	_{+0.04s (+ 0.18%)}	_22.67s	_22.79s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{200,472k (± 0.68%)}	_{199,930k (± 0.04%)}	_{-542k (- 0.27%)}	_199,786k	_200,011k
_{Parse Time}	_{1.80s (± 1.52%)}	_{1.80s (± 0.59%)}	_{+0.00s (+ 0.22%)}	_1.78s	_1.81s
_{Bind Time}	_{0.84s (± 0.80%)}	_{0.84s (± 0.52%)}	_{+0.00s (+ 0.43%)}	_0.84s	_0.85s
_{Check Time}	_{10.09s (± 1.04%)}	_{10.10s (± 0.44%)}	_{+0.01s (+ 0.05%)}	_10.04s	_10.14s
_{Emit Time}	_{3.04s (± 4.21%)}	_{3.06s (± 4.16%)}	_{+0.01s (+ 0.42%)}	_2.97s	_3.31s
_{Total Time}	_{15.77s (± 1.49%)}	_{15.79s (± 0.99%)}	_{+0.02s (+ 0.14%)}	_15.70s	_16.11s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{353,418k (± 0.01%)}	_{353,440k (± 0.01%)}	_{+22k (+ 0.01%)}	_353,402k	_353,497k
_{Parse Time}	_{3.16s (± 0.88%)}	_{3.15s (± 0.53%)}	_{-0.01s (- 0.30%)}	_3.13s	_3.17s
_{Bind Time}	_{1.12s (± 0.85%)}	_{1.12s (± 0.83%)}	_{+0.00s (+ 0.26%)}	_1.11s	_1.13s
_{Check Time}	_{7.86s (± 0.58%)}	_{7.83s (± 0.48%)}	_{-0.03s (- 0.33%)}	_7.78s	_7.86s
_{Emit Time}	_{4.50s (± 0.48%)}	_{4.50s (± 0.61%)}	_{+0.00s (+ 0.04%)}	_4.47s	_4.54s
_{Total Time}	_{16.64s (± 0.41%)}	_{16.61s (± 0.28%)}	_{-0.03s (- 0.18%)}	_16.53s	_16.66s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{309,375k (± 0.00%)}	_{309,554k (± 0.01%)}	_{+180k (+ 0.06%)}	_309,537k	_309,575k
_{Parse Time}	_{2.63s (± 1.20%)}	_{2.66s (± 1.50%)}	_{+0.03s (+ 1.19%)}	_2.61s	_2.71s
_{Bind Time}	_{1.06s (± 1.93%)}	_{1.05s (± 2.43%)}	_{-0.01s (- 1.23%)}	_1.02s	_1.10s
_{Check Time}	_{7.42s (± 0.48%)}	_{7.38s (± 0.52%)}	_{-0.03s (- 0.47%)}	_7.34s	_7.44s
_{Emit Time}	_{4.23s (± 0.48%)}	_{4.23s (± 0.40%)}	_{-0.00s (- 0.09%)}	_4.20s	_4.25s
_{Total Time}	_{15.35s (± 0.33%)}	_{15.32s (± 0.23%)}	_{-0.02s (- 0.14%)}	_15.28s	_15.37s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{484,513k (± 0.01%)}	_{484,503k (± 0.01%)}	_{-10k (- 0.00%)}	_484,449k	_484,544k
_{Parse Time}	_{3.67s (± 0.29%)}	_{3.66s (± 0.11%)}	_{-0.01s (- 0.29%)}	_3.66s	_3.67s
_{Bind Time}	_{1.01s (± 0.72%)}	_{1.01s (± 0.56%)}	_{-0.00s (- 0.23%)}	_1.00s	_1.02s
_{Check Time}	_{17.89s (± 0.60%)}	_{17.86s (± 0.35%)}	_{-0.04s (- 0.20%)}	_17.75s	_17.92s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.58s (± 0.47%)}	_{22.53s (± 0.29%)}	_{-0.05s (- 0.23%)}	_22.42s	_22.59s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{567,869k (± 0.02%)}	_{567,986k (± 0.02%)}	_{+117k (+ 0.02%)}	_567,871k	_568,200k
_{Parse Time}	_{4.74s (± 0.58%)}	_{4.75s (± 0.33%)}	_{+0.00s (+ 0.08%)}	_4.73s	_4.77s
_{Bind Time}	_{1.65s (± 0.43%)}	_{1.65s (± 0.44%)}	_{-0.00s (- 0.27%)}	_1.64s	_1.66s
_{Check Time}	_{2.84s (± 0.41%)}	_{2.83s (± 0.17%)}	_{-0.01s (- 0.28%)}	_2.83s	_2.84s
_{Emit Time}	_{0.09s (± 4.58%)}	_{0.08s (± 6.51%)}	_{🟩-0.00s (- 3.93%)}	_0.08s	_0.09s
_{Total Time}	_{9.33s (± 0.44%)}	_{9.32s (± 0.24%)}	_{-0.01s (- 0.11%)}	_9.30s	_9.35s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{365,695k (± 0.01%)}	_{365,439k (± 0.00%)}	_{-256k (- 0.07%)}	_365,423k	_365,457k
_{Parse Time}	_{4.16s (± 0.58%)}	_{4.15s (± 0.56%)}	_{-0.01s (- 0.25%)}	_4.12s	_4.19s
_{Bind Time}	_{1.30s (± 0.78%)}	_{1.30s (± 1.15%)}	_{-0.00s (- 0.19%)}	_1.29s	_1.33s
_{Check Time}	_{9.67s (± 0.91%)}	_{9.67s (± 0.55%)}	_{+0.00s (+ 0.01%)}	_9.61s	_9.74s
_{Emit Time}	_{8.20s (± 0.69%)}	_{8.22s (± 0.85%)}	_{+0.02s (+ 0.29%)}	_8.13s	_8.32s
_{Total Time}	_{23.33s (± 0.62%)}	_{23.34s (± 0.19%)}	_{+0.01s (+ 0.05%)}	_23.28s	_23.41s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{195,185k (± 0.02%)}	_{195,200k (± 0.02%)}	_{+15k (+ 0.01%)}	_195,161k	_195,242k
_{Parse Time}	_{1.85s (± 0.45%)}	_{1.86s (± 1.04%)}	_{+0.01s (+ 0.45%)}	_1.83s	_1.88s
_{Bind Time}	_{0.87s (± 0.94%)}	_{0.87s (± 0.60%)}	_{-0.00s (- 0.19%)}	_0.87s	_0.88s
_{Check Time}	_{10.12s (± 0.32%)}	_{10.16s (± 0.32%)}	_{+0.04s (+ 0.43%)}	_10.12s	_10.21s
_{Emit Time}	_{3.14s (± 0.68%)}	_{3.13s (± 0.82%)}	_{-0.01s (- 0.42%)}	_3.09s	_3.16s
_{Total Time}	_{15.98s (± 0.23%)}	_{16.01s (± 0.19%)}	_{+0.04s (+ 0.23%)}	_15.98s	_16.06s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{348,263k (± 0.00%)}	_{348,294k (± 0.00%)}	_{+31k (+ 0.01%)}	_348,285k	_348,317k
_{Parse Time}	_{3.24s (± 1.07%)}	_{3.28s (± 1.36%)}	_{+0.03s (+ 0.94%)}	_3.23s	_3.34s
_{Bind Time}	_{1.12s (± 0.91%)}	_{1.11s (± 0.45%)}	_{-0.01s (- 0.77%)}	_1.11s	_1.12s
_{Check Time}	_{8.15s (± 0.69%)}	_{8.18s (± 0.53%)}	_{+0.03s (+ 0.33%)}	_8.13s	_8.24s
_{Emit Time}	_{4.70s (± 0.77%)}	_{4.71s (± 0.73%)}	_{+0.01s (+ 0.18%)}	_4.67s	_4.76s
_{Total Time}	_{17.22s (± 0.58%)}	_{17.28s (± 0.50%)}	_{+0.06s (+ 0.34%)}	_17.20s	_17.45s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{304,280k (± 0.00%)}	_{304,471k (± 0.00%)}	_{+191k (+ 0.06%)}	_304,460k	_304,482k
_{Parse Time}	_{2.73s (± 1.20%)}	_{2.79s (± 0.88%)}	_{+0.05s (+ 1.97%)}	_2.76s	_2.82s
_{Bind Time}	_{1.09s (± 0.77%)}	_{1.10s (± 0.46%)}	_{+0.01s (+ 1.19%)}	_1.09s	_1.11s
_{Check Time}	_{7.73s (± 0.42%)}	_{7.72s (± 0.69%)}	_{-0.02s (- 0.23%)}	_7.65s	_7.78s
_{Emit Time}	_{4.60s (± 0.99%)}	_{4.59s (± 0.65%)}	_{-0.01s (- 0.25%)}	_4.56s	_4.64s
_{Total Time}	_{16.15s (± 0.58%)}	_{16.19s (± 0.30%)}	_{+0.04s (+ 0.25%)}	_16.11s	_16.25s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{479,985k (± 0.01%)}	_{479,967k (± 0.01%)}	_{-18k (- 0.00%)}	_479,911k	_480,002k
_{Parse Time}	_{3.89s (± 0.45%)}	_{3.91s (± 0.99%)}	_{+0.02s (+ 0.46%)}	_3.86s	_3.96s
_{Bind Time}	_{1.05s (± 0.56%)}	_{1.05s (± 0.99%)}	_{+0.00s (+ 0.17%)}	_1.04s	_1.07s
_{Check Time}	_{18.88s (± 0.80%)}	_{18.87s (± 0.57%)}	_{-0.01s (- 0.03%)}	_18.76s	_19.03s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.82s (± 0.71%)}	_{23.83s (± 0.61%)}	_{+0.01s (+ 0.03%)}	_23.67s	_24.05s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{556,233k (± 0.01%)}	_{556,319k (± 0.00%)}	_{+86k (+ 0.02%)}	_556,283k	_556,343k
_{Parse Time}	_{5.16s (± 1.09%)}	_{5.14s (± 0.79%)}	_{-0.02s (- 0.35%)}	_5.07s	_5.19s
_{Bind Time}	_{1.58s (± 0.74%)}	_{1.59s (± 0.86%)}	_{+0.01s (+ 0.77%)}	_1.58s	_1.62s
_{Check Time}	_{3.00s (± 0.50%)}	_{2.99s (± 0.73%)}	_{-0.01s (- 0.46%)}	_2.96s	_3.02s
_{Emit Time}	_{0.10s (± 0.08%)}	_{0.10s (± 0.16%)}	_{+0.00s (+ 0.03%)}	_0.10s	_0.10s
_{Total Time}	_{9.84s (± 0.56%)}	_{9.83s (± 0.52%)}	_{-0.01s (- 0.14%)}	_9.74s	_9.90s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₁₈₀	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52180

_Metric	_main	₅₂₁₈₀	_Delta	_Best	_Worst
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,587ms (± 1.64%)}	_{2,546ms (± 2.53%)}	_{-41ms (- 1.60%)}	_2,467ms	_2,631ms
_{Req 2 - geterr}	_{5,383ms (± 1.19%)}	_{5,356ms (± 1.08%)}	_{-26ms (- 0.49%)}	_5,284ms	_5,427ms
_{Req 3 - references}	_{372ms (± 1.09%)}	_{370ms (± 2.49%)}	_{-2ms (- 0.48%)}	_359ms	_379ms
_{Req 4 - navto}	_{317ms (±27.30%)}	_{283ms (± 1.91%)}	_{🟩-35ms (-10.98%)}	_277ms	_291ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{265ms (±35.44%)}	_{299ms (± 2.00%)}	_{+34ms (+12.92%)}	_292ms	_307ms
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,758ms (± 1.08%)}	_{2,783ms (± 0.88%)}	_{+25ms (+ 0.91%)}	_2,758ms	_2,813ms
_{Req 2 - geterr}	_{3,955ms (± 0.32%)}	_{3,988ms (± 0.61%)}	_{+33ms (+ 0.84%)}	_3,959ms	_4,013ms
_{Req 3 - references}	_{362ms (± 1.51%)}	_{361ms (± 0.92%)}	_{-1ms (- 0.36%)}	_356ms	_365ms
_{Req 4 - navto}	_{290ms (± 0.82%)}	_{294ms (± 1.56%)}	_{+4ms (+ 1.27%)}	_289ms	_302ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{67ms (± 4.08%)}	_{71ms (± 5.52%)}	_{+4ms (+ 5.95%)}	_66ms	_76ms
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,387ms (± 0.41%)}	_{3,404ms (± 0.58%)}	_{+18ms (+ 0.52%)}	_3,373ms	_3,425ms
_{Req 2 - geterr}	_{1,549ms (± 1.16%)}	_{1,549ms (± 1.73%)}	_{-0ms (- 0.01%)}	_1,514ms	_1,580ms
_{Req 3 - references}	_{101ms (± 4.11%)}	_{104ms (± 3.72%)}	_{+4ms (+ 3.60%)}	_100ms	_108ms
_{Req 4 - navto}	_{355ms (± 0.92%)}	_{362ms (± 1.57%)}	_{+6ms (+ 1.73%)}	_353ms	_367ms
_{Req 5 - completionInfo count}	_{3,154 (± 0.00%)}	_{3,154 (± 0.00%)}	_{0 ( 0.00%)}	_3,154	_3,154
_{Req 5 - completionInfo}	_{428ms (± 1.18%)}	_{431ms (± 0.63%)}	_{+3ms (+ 0.75%)}	_429ms	_435ms
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,786ms (± 0.52%)}	_{2,793ms (± 0.45%)}	_{+7ms (+ 0.25%)}	_2,775ms	_2,807ms
_{Req 2 - geterr}	_{5,862ms (± 2.34%)}	_{5,842ms (± 2.52%)}	_{-21ms (- 0.35%)}	_5,700ms	_5,999ms
_{Req 3 - references}	_{363ms (± 0.66%)}	_{363ms (± 0.70%)}	_{-0ms (- 0.01%)}	_359ms	_365ms
_{Req 4 - navto}	_{391ms (±29.52%)}	_{352ms (±31.78%)}	_{🟩-40ms (-10.11%)}	_276ms	_498ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{89ms (± 7.56%)}	_{126ms (±75.23%)}	_{🔻+38ms (+42.33%)}	_81ms	_320ms
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,934ms (± 0.44%)}	_{2,914ms (± 0.39%)}	_{-19ms (- 0.66%)}	_2,893ms	_2,925ms
_{Req 2 - geterr}	_{4,326ms (± 0.48%)}	_{4,283ms (± 0.43%)}	_{-44ms (- 1.01%)}	_4,248ms	_4,300ms
_{Req 3 - references}	_{378ms (± 0.58%)}	_{378ms (± 0.66%)}	_{+0ms (+ 0.11%)}	_375ms	_381ms
_{Req 4 - navto}	_{302ms (± 0.25%)}	_{303ms (± 1.00%)}	_{+1ms (+ 0.43%)}	_297ms	_305ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{317ms (± 0.59%)}	_{275ms (±35.18%)}	_{🟩-42ms (-13.12%)}	_77ms	_319ms
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,757ms (± 0.59%)}	_{3,765ms (± 0.40%)}	_{+7ms (+ 0.20%)}	_3,743ms	_3,786ms
_{Req 2 - geterr}	_{1,448ms (± 0.78%)}	_{1,464ms (± 1.15%)}	_{+16ms (+ 1.10%)}	_1,442ms	_1,493ms
_{Req 3 - references}	_{110ms (± 2.17%)}	_{108ms (± 3.15%)}	_{-2ms (- 2.09%)}	_104ms	_113ms
_{Req 4 - navto}	_{348ms (± 1.58%)}	_{344ms (± 1.16%)}	_{-4ms (- 1.25%)}	_337ms	_350ms
_{Req 5 - completionInfo count}	_{3,154 (± 0.00%)}	_{3,154 (± 0.00%)}	_{0 ( 0.00%)}	_3,154	_3,154
_{Req 5 - completionInfo}	_{472ms (± 1.84%)}	_{469ms (± 2.25%)}	_{-3ms (- 0.65%)}	_456ms	_483ms
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,877ms (± 0.34%)}	_{2,892ms (± 0.62%)}	_{+15ms (+ 0.53%)}	_2,868ms	_2,911ms
_{Req 2 - geterr}	_{6,112ms (± 0.42%)}	_{6,171ms (± 0.52%)}	_{+58ms (+ 0.96%)}	_6,137ms	_6,219ms
_{Req 3 - references}	_{379ms (± 0.56%)}	_{380ms (± 0.55%)}	_{+1ms (+ 0.32%)}	_379ms	_385ms
_{Req 4 - navto}	_{289ms (± 0.65%)}	_{294ms (± 0.76%)}	_{+4ms (+ 1.39%)}	_289ms	_296ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{93ms (± 5.92%)}	_{172ms (±70.70%)}	_{🔻+79ms (+84.60%)}	_87ms	_334ms
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,017ms (± 1.07%)}	_{3,022ms (± 0.89%)}	_{+5ms (+ 0.17%)}	_2,999ms	_3,072ms
_{Req 2 - geterr}	_{4,585ms (± 0.57%)}	_{4,570ms (± 0.67%)}	_{-15ms (- 0.32%)}	_4,515ms	_4,597ms
_{Req 3 - references}	_{402ms (± 0.68%)}	_{405ms (± 0.89%)}	_{+3ms (+ 0.79%)}	_400ms	_410ms
_{Req 4 - navto}	_{306ms (± 0.91%)}	_{307ms (± 1.21%)}	_{+2ms (+ 0.64%)}	_304ms	_314ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{82ms (± 8.67%)}	_{84ms (± 8.91%)}	_{+2ms (+ 2.72%)}	_77ms	_96ms
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,869ms (± 0.89%)}	_{3,851ms (± 0.59%)}	_{-18ms (- 0.47%)}	_3,815ms	_3,870ms
_{Req 2 - geterr}	_{1,465ms (± 0.94%)}	_{1,457ms (± 0.81%)}	_{-8ms (- 0.56%)}	_1,446ms	_1,479ms
_{Req 3 - references}	_{127ms (± 2.56%)}	_{125ms (± 3.47%)}	_{-2ms (- 1.55%)}	_120ms	_130ms
_{Req 4 - navto}	_{395ms (± 0.72%)}	_{395ms (± 1.10%)}	_{-1ms (- 0.14%)}	_389ms	_402ms
_{Req 5 - completionInfo count}	_{3,154 (± 0.00%)}	_{3,154 (± 0.00%)}	_{0 ( 0.00%)}	_3,154	_3,154
_{Req 5 - completionInfo}	_{496ms (± 1.82%)}	_{493ms (± 1.09%)}	_{-3ms (- 0.53%)}	_485ms	_498ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₁₈₀	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52180

_Metric	_main	₅₂₁₈₀	_Delta	_Best	_Worst
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{138.97ms (± 0.21%)}	_{139.83ms (± 0.25%)}	_{+0.86ms (+ 0.62%)}	_138.68ms	_146.08ms
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.50ms (± 0.25%)}	_{231.81ms (± 0.34%)}	_{+1.31ms (+ 0.57%)}	_229.40ms	_239.07ms
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{233.18ms (± 0.24%)}	_{234.29ms (± 0.28%)}	_{+1.10ms (+ 0.47%)}	_232.30ms	_241.27ms
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{215.36ms (± 0.22%)}	_{215.60ms (± 0.26%)}	_{+0.24ms (+ 0.11%)}	_213.35ms	_221.94ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₁₈₀	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Jake Bailey (jakebailey) · 2023-01-11T01:07:59Z

Perf looks the same (normal noise). Thanks for the review!

Jake Bailey (jakebailey) added 2 commits January 9, 2023 20:38

Add tests
1fddd46

Further tweak co/contra inference logic
22cfe3a

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey)Jan 10, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 10, 2023

Ryan Cavanaugh (RyanCavanaugh) requested a review from Anders Hejlsberg (ahejlsberg)January 10, 2023 21:16

Anders Hejlsberg (ahejlsberg) approved these changes Jan 10, 2023
View reviewed changes

Jake Bailey (jakebailey) mentioned this pull request Jan 10, 2023
Type parameter on ts.some/ts.find is too narrow when called on union of arrays, works with explicit instantiation #52179
Closed

erge branch 'main' into wtf-bug
60e15f3

Jake Bailey (jakebailey) mentioned this pull request Jan 11, 2023
Enable strictFunctionTypes #49929
Merged
11 tasks

Jake Bailey (jakebailey) merged commit 28e4c81 into microsoft:mainJan 11, 2023

Jake Bailey (jakebailey) deleted the wtf-bug branch January 11, 2023 01:08

Jake Bailey (jakebailey) mentioned this pull request Jan 12, 2023
Bump LKG and package.json to 5.0.0-dev.20230112 #51787
Merged

Anders Hejlsberg (ahejlsberg) mentioned this pull request Apr 30, 2023
Add fallback when both co- and contra-variant inference candidates exist #54072
Merged

Anders Hejlsberg (ahejlsberg) added a commit that referenced this pull request May 2, 2023
Restore code from#52180
c377c44

Mateusz Burzyński (Andarist) mentioned this pull request Mar 22, 2024
Improve logic that chooses co- vs. contra-variant inferences #57909
Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Jake Bailey (jakebailey) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Jan 10, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2023

Uh oh!

Jake Bailey (jakebailey) commented Jan 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Jan 10, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) left a comment

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) commented Jan 10, 2023

Uh oh!

Jake Bailey (jakebailey) commented Jan 11, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 11, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 11, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 11, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Jan 11, 2023

Uh oh!

Jake Bailey (jakebailey) commented Jan 11, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 11, 2023

Compiler

TSServer

Startup

Uh oh!

Jake Bailey (jakebailey) commented Jan 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jake Bailey (jakebailey) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 10, 2023•
edited
Loading

Jake Bailey (jakebailey) commented Jan 10, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 11, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 11, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 11, 2023•
edited
Loading