Tighten relational operator more by RyanCavanaugh · Pull Request #52342 · microsoft/TypeScript

Ryan Cavanaugh (RyanCavanaugh) · 2023-01-20T22:04:21Z

Addendum to #52048 per discussion there. Evaluating the real-world code impact before discussing further

Ryan Cavanaugh (RyanCavanaugh) · 2023-01-20T22:06:25Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:27Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the diff-based user code test suite (tsserver) on this PR at 5f7d2d9. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:27Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the parallelized Definitely Typed test suite on this PR at 5f7d2d9. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:28Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the diff-based user code test suite on this PR at 5f7d2d9. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:28Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 5f7d2d9. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:28Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the diff-based top-repos suite (tsserver) on this PR at 5f7d2d9. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:28Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the diff-based top-repos suite on this PR at 5f7d2d9. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-20T22:06:28Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the perf test suite on this PR at 5f7d2d9. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-01-20T22:16:03Z

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the user test suite comparing main and refs/pull/52342/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-01-20T22:18:28Z

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the user test suite comparing main and refs/pull/52342/merge:

Something interesting changed - please have a look.

Details

fp-ts

dtslint/ts3.5/tsconfig.json

[NEW] error TS2365: Operator '<' cannot be applied to types 'boolean' and 'boolean'.
- src/boolean.ts#L178
[NEW] error TS2365: Operator '>' cannot be applied to types 'boolean' and 'boolean'.
- src/boolean.ts#L178

tsconfig.build-es6.json

[NEW] error TS2365: Operator '<' cannot be applied to types 'boolean' and 'boolean'.
- src/boolean.ts#L178
[NEW] error TS2365: Operator '>' cannot be applied to types 'boolean' and 'boolean'.
- src/boolean.ts#L178

tsconfig.json

[NEW] error TS2365: Operator '<' cannot be applied to types 'boolean' and 'boolean'.
- src/boolean.ts#L178
[NEW] error TS2365: Operator '>' cannot be applied to types 'boolean' and 'boolean'.
- src/boolean.ts#L178

webpack

tsconfig.json

[NEW] error TS2365: Operator '<' cannot be applied to types 'string | number' and 'string | number'.
- lib/util/comparators.js#L202
[NEW] error TS2365: Operator '>' cannot be applied to types 'string | number' and 'string | number'.
- lib/util/comparators.js#L203
[NEW] error TS2365: Operator '>' cannot be applied to types 'string' and 'string | number | []'.
- lib/util/semver.js#L377
[NEW] error TS2365: Operator '<' cannot be applied to types 'string' and 'string | number | []'.
- lib/util/semver.js#L377

tsconfig.types.json

[NEW] error TS2365: Operator '<' cannot be applied to types 'string | number' and 'string | number'.
- lib/util/comparators.js#L202
[NEW] error TS2365: Operator '>' cannot be applied to types 'string | number' and 'string | number'.
- lib/util/comparators.js#L203
[NEW] error TS2365: Operator '>' cannot be applied to types 'string' and 'string | number | []'.
- lib/util/semver.js#L377
[NEW] error TS2365: Operator '<' cannot be applied to types 'string' and 'string | number | []'.
- lib/util/semver.js#L377

TypeScript Bot (typescript-bot) · 2023-01-20T22:20:56Z

Heya Ryan Cavanaugh (@RyanCavanaugh), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

Ryan Cavanaugh (RyanCavanaugh) · 2023-01-20T22:44:21Z

OK, let's analyze.

fp-ts has this code

exportconstOrd: O.Ord<boolean>={equals: Eq.equals,compare: (first,second)=>(first<second ? -1 : first>second ? 1 : 0)}

This seems more straightforwardly written as (first, second) => +first - +second; it's like the author of this code was depending on one bad TS behavior vs another.

Webpack's is... subtle:

/** * @param {string|number} a first id * @param {string|number} b second id * @returns {-1|0|1} compare result */constcompareIds=(a,b)=>{if(typeofa!==typeofb){returntypeofa<typeofb ? -1 : 1;}if(a<b)return-1;if(a>b)return1;return0;};

The reasonable objection at the erroring line (a < b) is "An implicit coercion might be happening", but that can't happen here because of the typeof check at the top of the function body. We don't have any plausible way to talk about "Two variables which have been shown to have the same typeof" so I think a type assertion here is reasonable to ask for.

The other break in webpack, hereseems like it might also be correct-by-construction but the code is quite complex and I'm not really sure what's going on here.

RWC turned up several instances of relating Date to Date, which is coherent. Probably we'd see the same thing for moment instances on a broader testbed too. I think we could try testing for both sides to be assignable to { valueOf(): number }, since that is explicitly declared in most types of interest.

Ryan Cavanaugh (RyanCavanaugh) · 2023-01-20T23:28:35Z

This allows Date > Date but also allows Date > number, which is maybe suspicious or maybe fine -- Date > Date is an extremely coherent operation which we must reasonably allow, so the violation Date > number is really more of a question of units, since it seems sort of odd that you would have a number that meaningfully corresponds to Date's valueOf.

TLD;R we can't really blame this on implicit coercion, since the implicit coercion that occurs in Date > Date is idiomatic the same way that arr[0]'s number-to-string coercion is. So as long as all the operands in > implicitly coerce to the same primitive type, I think it's sensible to allow it. But we can't merge this PR today so I think it's out for 5.0 Beta.

TypeScript Bot (typescript-bot) · 2023-01-20T23:30:29Z

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the top-repos suite comparing main and refs/pull/52342/merge:

Something interesting changed - please have a look.

Details

palantir/blueprint

⚠️ Note that built also had errors ⚠️

Req #19165 - references
at getTypeAtPosition (/typescript-main/built/local/tsserver.js:75203:12)
at getContextualTypeForArgumentAtIndex (/typescript-main/built/local/tsserver.js:70335:215)
at getContextualTypeForArgument (/typescript-main/built/local/tsserver.js:70321:39)
at getContextualType2 (/typescript-main/built/local/tsserver.js:70762:16)
at getApparentTypeOfContextualType (/typescript-main/built/local/tsserver.js:70698:120)
at getContextualType2 (/typescript-main/built/local/tsserver.js:70777:22)
at getApparentTypeOfContextualType (/typescript-main/built/local/tsserver.js:70698:120)
at getContextualSignature (/typescript-main/built/local/tsserver.js:71065:18)
at getNarrowedTypeOfSymbol (/typescript-main/built/local/tsserver.js:69513:39)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69605:16)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-main/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-main/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77706:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)
at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
at checkExpression (/typescript-main/built/local/tsserver.js:77660:32)

Req #19165 - references
at tryGetTypeAtPosition (/typescript-52342/built/local/tsserver.js:75205:32)
at getTypeAtPosition (/typescript-52342/built/local/tsserver.js:75203:12)
at getContextualTypeForArgumentAtIndex (/typescript-52342/built/local/tsserver.js:70335:215)
at getContextualTypeForArgument (/typescript-52342/built/local/tsserver.js:70321:39)
at getContextualType2 (/typescript-52342/built/local/tsserver.js:70762:16)
at getApparentTypeOfContextualType (/typescript-52342/built/local/tsserver.js:70698:120)
at getContextualType2 (/typescript-52342/built/local/tsserver.js:70777:22)
at getApparentTypeOfContextualType (/typescript-52342/built/local/tsserver.js:70698:120)
at getContextualSignature (/typescript-52342/built/local/tsserver.js:71065:18)
at getNarrowedTypeOfSymbol (/typescript-52342/built/local/tsserver.js:69513:39)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69605:16)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at getEffectsSignature (/typescript-52342/built/local/tsserver.js:68216:22)
at getTypeAtFlowCall (/typescript-52342/built/local/tsserver.js:68555:25)
at getTypeAtFlowNode (/typescript-52342/built/local/tsserver.js:68441:18)
at getFlowTypeOfReference (/typescript-52342/built/local/tsserver.js:68398:45)
at checkIdentifier (/typescript-52342/built/local/tsserver.js:69648:22)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77710:16)
at checkExpression (/typescript-52342/built/local/tsserver.js:77664:32)
at checkNonNullExpression (/typescript-52342/built/local/tsserver.js:72141:29)
at checkPropertyAccessExpression (/typescript-52342/built/local/tsserver.js:72220:162)
at checkExpressionWorker (/typescript-52342/built/local/tsserver.js:77744:16)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

{"seq":19162,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":242845}}
{"seq":19163,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":243005,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":""}}
{"seq":19164,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":243231}}
{"seq":19165,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":245468}}

Repro Steps

git clone https://github.com/palantir/blueprint --recurse-submodules
In dir blueprint, run git reset --hard 6cfa0d407e0232573e1d6fad1716ec2092ac96d4
In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

TypeScript Bot (typescript-bot) · 2023-01-20T23:32:44Z

Ryan Cavanaugh (@RyanCavanaugh)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52342

_Metric	_main	₅₂₃₄₂	_Delta	_Best	_Worst
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{358,839k (± 0.01%)}	_{358,796k (± 0.01%)}	_{-43k (- 0.01%)}	_358,764k	_358,834k
_{Parse Time}	_{3.92s (± 1.72%)}	_{3.93s (± 1.06%)}	_{+0.00s (+ 0.08%)}	_3.87s	_3.98s
_{Bind Time}	_{1.17s (± 0.49%)}	_{1.17s (± 0.33%)}	_{-0.00s (- 0.00%)}	_1.17s	_1.18s
_{Check Time}	_{8.85s (± 0.33%)}	_{8.86s (± 0.43%)}	_{+0.02s (+ 0.19%)}	_8.80s	_8.90s
_{Emit Time}	_{7.62s (± 0.56%)}	_{7.65s (± 0.56%)}	_{+0.03s (+ 0.37%)}	_7.59s	_7.69s
_{Total Time}	_{21.57s (± 0.55%)}	_{21.61s (± 0.21%)}	_{+0.05s (+ 0.22%)}	_21.55s	_21.67s
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{195,467k (± 1.57%)}	_{194,387k (± 1.49%)}	_{-1,080k (- 0.55%)}	_192,276k	_198,125k
_{Parse Time}	_{1.62s (± 1.18%)}	_{1.62s (± 2.29%)}	_{+0.00s (+ 0.07%)}	_1.58s	_1.68s
_{Bind Time}	_{0.79s (± 0.52%)}	_{0.79s (± 0.70%)}	_{+0.00s (+ 0.49%)}	_0.79s	_0.80s
_{Check Time}	_{9.66s (± 0.67%)}	_{9.64s (± 0.93%)}	_{-0.01s (- 0.14%)}	_9.58s	_9.82s
_{Emit Time}	_{2.85s (± 4.11%)}	_{2.83s (± 4.99%)}	_{-0.02s (- 0.63%)}	_2.73s	_3.12s
_{Total Time}	_{14.92s (± 0.94%)}	_{14.90s (± 1.13%)}	_{-0.03s (- 0.17%)}	_14.71s	_15.16s
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,899k (± 0.01%)}	_{343,903k (± 0.01%)}	_{+4k (+ 0.00%)}	_343,864k	_343,967k
_{Parse Time}	_{2.91s (± 0.46%)}	_{2.93s (± 0.46%)}	_{+0.02s (+ 0.54%)}	_2.91s	_2.94s
_{Bind Time}	_{1.04s (± 1.19%)}	_{1.05s (± 1.05%)}	_{+0.00s (+ 0.44%)}	_1.03s	_1.06s
_{Check Time}	_{7.27s (± 0.48%)}	_{7.29s (± 0.29%)}	_{+0.02s (+ 0.26%)}	_7.27s	_7.31s
_{Emit Time}	_{4.36s (± 0.47%)}	_{4.35s (± 0.81%)}	_{-0.01s (- 0.15%)}	_4.31s	_4.40s
_{Total Time}	_{15.58s (± 0.31%)}	_{15.62s (± 0.34%)}	_{+0.03s (+ 0.22%)}	_15.56s	_15.69s
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,315k (± 0.00%)}	_{300,400k (± 0.01%)}	_{+86k (+ 0.03%)}	_300,385k	_300,430k
_{Parse Time}	_{2.25s (± 1.47%)}	_{2.24s (± 0.84%)}	_{-0.01s (- 0.59%)}	_2.21s	_2.26s
_{Bind Time}	_{1.18s (± 0.51%)}	_{1.18s (± 0.35%)}	_{+0.00s (+ 0.00%)}	_1.18s	_1.19s
_{Check Time}	_{6.86s (± 0.24%)}	_{6.96s (± 0.38%)}	_{+0.09s (+ 1.36%)}	_6.91s	_6.99s
_{Emit Time}	_{3.94s (± 0.67%)}	_{3.93s (± 0.52%)}	_{-0.01s (- 0.30%)}	_3.89s	_3.95s
_{Total Time}	_{14.23s (± 0.35%)}	_{14.30s (± 0.25%)}	_{+0.07s (+ 0.49%)}	_14.27s	_14.35s
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,107k (± 0.00%)}	_{476,170k (± 0.01%)}	_{+63k (+ 0.01%)}	_476,119k	_476,214k
_{Parse Time}	_{3.44s (± 1.79%)}	_{3.46s (± 1.75%)}	_{+0.02s (+ 0.63%)}	_3.34s	_3.50s
_{Bind Time}	_{0.98s (± 6.91%)}	_{0.98s (± 6.26%)}	_{-0.00s (- 0.01%)}	_0.95s	_1.11s
_{Check Time}	_{17.03s (± 0.64%)}	_{17.09s (± 1.09%)}	_{+0.07s (+ 0.40%)}	_16.94s	_17.33s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.45s (± 0.55%)}	_{21.53s (± 0.87%)}	_{+0.09s (+ 0.40%)}	_21.36s	_21.77s
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{546,937k (± 0.02%)}	_{546,833k (± 0.01%)}	_{-104k (- 0.02%)}	_546,768k	_546,952k
_{Parse Time}	_{4.40s (± 0.33%)}	_{4.42s (± 0.81%)}	_{+0.01s (+ 0.32%)}	_4.38s	_4.48s
_{Bind Time}	_{1.69s (± 0.90%)}	_{1.71s (± 1.21%)}	_{+0.02s (+ 1.15%)}	_1.67s	_1.73s
_{Check Time}	_{2.73s (± 0.76%)}	_{2.74s (± 0.60%)}	_{+0.00s (+ 0.16%)}	_2.72s	_2.77s
_{Emit Time}	_{0.08s (± 0.27%)}	_{0.08s (± 0.16%)}	_{+0.00s (+ 0.17%)}	_0.08s	_0.08s
_{Total Time}	_{8.90s (± 0.50%)}	_{8.94s (± 0.73%)}	_{+0.04s (+ 0.45%)}	_8.85s	_9.04s
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,196k (± 0.01%)}	_{358,235k (± 0.01%)}	_{+39k (+ 0.01%)}	_358,207k	_358,263k
_{Parse Time}	_{4.13s (± 0.26%)}	_{4.14s (± 0.73%)}	_{+0.01s (+ 0.26%)}	_4.12s	_4.20s
_{Bind Time}	_{1.24s (± 0.37%)}	_{1.24s (± 1.05%)}	_{+0.00s (+ 0.07%)}	_1.23s	_1.26s
_{Check Time}	_{9.51s (± 0.25%)}	_{9.55s (± 0.34%)}	_{+0.03s (+ 0.34%)}	_9.49s	_9.59s
_{Emit Time}	_{8.07s (± 0.80%)}	_{8.08s (± 0.52%)}	_{+0.00s (+ 0.02%)}	_8.03s	_8.13s
_{Total Time}	_{22.96s (± 0.40%)}	_{23.00s (± 0.38%)}	_{+0.05s (+ 0.20%)}	_22.90s	_23.15s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,336k (± 0.03%)}	_{194,234k (± 0.04%)}	_{-103k (- 0.05%)}	_194,137k	_194,398k
_{Parse Time}	_{1.79s (± 0.67%)}	_{1.80s (± 0.79%)}	_{+0.01s (+ 0.72%)}	_1.79s	_1.83s
_{Bind Time}	_{0.84s (± 0.58%)}	_{0.85s (± 1.27%)}	_{+0.01s (+ 0.66%)}	_0.84s	_0.86s
_{Check Time}	_{10.40s (± 0.46%)}	_{10.27s (± 0.70%)}	_{-0.13s (- 1.23%)}	_10.18s	_10.39s
_{Emit Time}	_{3.04s (± 0.71%)}	_{3.02s (± 0.63%)}	_{-0.02s (- 0.81%)}	_3.00s	_3.05s
_{Total Time}	_{16.07s (± 0.46%)}	_{15.93s (± 0.64%)}	_{-0.13s (- 0.83%)}	_15.83s	_16.12s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,253k (± 0.01%)}	_{343,226k (± 0.01%)}	_{-27k (- 0.01%)}	_343,189k	_343,258k
_{Parse Time}	_{3.12s (± 0.87%)}	_{3.11s (± 1.00%)}	_{-0.01s (- 0.37%)}	_3.06s	_3.14s
_{Bind Time}	_{1.10s (± 0.32%)}	_{1.10s (± 0.96%)}	_{+0.00s (+ 0.30%)}	_1.09s	_1.12s
_{Check Time}	_{7.89s (± 0.36%)}	_{7.94s (± 0.43%)}	_{+0.05s (+ 0.65%)}	_7.91s	_8.00s
_{Emit Time}	_{4.53s (± 0.41%)}	_{4.55s (± 0.65%)}	_{+0.02s (+ 0.55%)}	_4.50s	_4.58s
_{Total Time}	_{16.63s (± 0.26%)}	_{16.69s (± 0.50%)}	_{+0.06s (+ 0.36%)}	_16.57s	_16.81s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,661k (± 0.01%)}	_{299,734k (± 0.00%)}	_{+72k (+ 0.02%)}	_299,715k	_299,750k
_{Parse Time}	_{2.45s (± 1.45%)}	_{2.45s (± 1.22%)}	_{+0.00s (+ 0.14%)}	_2.41s	_2.48s
_{Bind Time}	_{1.27s (± 1.14%)}	_{1.27s (± 0.90%)}	_{+0.00s (+ 0.13%)}	_1.25s	_1.29s
_{Check Time}	_{7.49s (± 0.58%)}	_{7.56s (± 0.30%)}	_{+0.07s (+ 0.96%)}	_7.53s	_7.59s
_{Emit Time}	_{4.22s (± 0.77%)}	_{4.23s (± 0.50%)}	_{+0.01s (+ 0.28%)}	_4.20s	_4.26s
_{Total Time}	_{15.43s (± 0.48%)}	_{15.51s (± 0.35%)}	_{+0.09s (+ 0.56%)}	_15.42s	_15.58s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,388k (± 0.01%)}	_{475,431k (± 0.01%)}	_{+43k (+ 0.01%)}	_475,378k	_475,483k
_{Parse Time}	_{3.63s (± 0.18%)}	_{3.64s (± 0.25%)}	_{+0.00s (+ 0.09%)}	_3.63s	_3.65s
_{Bind Time}	_{1.00s (± 0.55%)}	_{1.00s (± 0.48%)}	_{-0.00s (- 0.17%)}	_1.00s	_1.01s
_{Check Time}	_{18.06s (± 1.40%)}	_{18.00s (± 0.36%)}	_{-0.06s (- 0.31%)}	_17.95s	_18.09s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.69s (± 1.12%)}	_{22.64s (± 0.31%)}	_{-0.05s (- 0.22%)}	_22.58s	_22.73s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{544,488k (± 0.01%)}	_{544,483k (± 0.01%)}	_{-5k (- 0.00%)}	_544,401k	_544,530k
_{Parse Time}	_{4.57s (± 0.47%)}	_{4.57s (± 0.93%)}	_{-0.00s (- 0.07%)}	_4.53s	_4.65s
_{Bind Time}	_{1.77s (± 0.31%)}	_{1.78s (± 0.42%)}	_{+0.01s (+ 0.34%)}	_1.77s	_1.79s
_{Check Time}	_{2.95s (± 0.55%)}	_{2.94s (± 0.74%)}	_{-0.00s (- 0.15%)}	_2.91s	_2.97s
_{Emit Time}	_{0.09s (± 0.11%)}	_{0.09s (± 0.16%)}	_{-0.00s (- 0.03%)}	_0.09s	_0.09s
_{Total Time}	_{9.38s (± 0.23%)}	_{9.37s (± 0.58%)}	_{-0.01s (- 0.09%)}	_9.31s	_9.47s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{351,807k (± 0.00%)}	_{351,808k (± 0.01%)}	_{+1k (+ 0.00%)}	_351,784k	_351,831k
_{Parse Time}	_{4.15s (± 0.34%)}	_{4.19s (± 0.37%)}	_{+0.04s (+ 0.85%)}	_4.16s	_4.21s
_{Bind Time}	_{1.27s (± 0.71%)}	_{1.27s (± 0.86%)}	_{+0.00s (+ 0.36%)}	_1.26s	_1.29s
_{Check Time}	_{9.80s (± 0.35%)}	_{9.80s (± 0.38%)}	_{+0.01s (+ 0.07%)}	_9.74s	_9.85s
_{Emit Time}	_{8.41s (± 0.90%)}	_{8.41s (± 0.63%)}	_{+0.00s (+ 0.03%)}	_8.35s	_8.50s
_{Total Time}	_{23.63s (± 0.29%)}	_{23.67s (± 0.33%)}	_{+0.05s (+ 0.20%)}	_23.56s	_23.78s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{189,360k (± 0.01%)}	_{189,325k (± 0.02%)}	_{-35k (- 0.02%)}	_189,288k	_189,390k
_{Parse Time}	_{1.84s (± 0.67%)}	_{1.83s (± 0.70%)}	_{-0.01s (- 0.46%)}	_1.82s	_1.85s
_{Bind Time}	_{0.87s (± 1.02%)}	_{0.86s (± 0.58%)}	_{-0.01s (- 1.24%)}	_0.86s	_0.87s
_{Check Time}	_{10.41s (± 0.58%)}	_{10.41s (± 0.72%)}	_{-0.00s (- 0.04%)}	_10.33s	_10.54s
_{Emit Time}	_{3.17s (± 0.93%)}	_{3.14s (± 0.72%)}	_{-0.03s (- 0.83%)}	_3.10s	_3.17s
_{Total Time}	_{16.29s (± 0.36%)}	_{16.24s (± 0.64%)}	_{-0.05s (- 0.31%)}	_16.13s	_16.42s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{337,960k (± 0.00%)}	_{337,994k (± 0.01%)}	_{+35k (+ 0.01%)}	_337,956k	_338,065k
_{Parse Time}	_{3.22s (± 1.24%)}	_{3.23s (± 1.30%)}	_{+0.01s (+ 0.16%)}	_3.17s	_3.29s
_{Bind Time}	_{1.13s (± 0.37%)}	_{1.13s (± 0.35%)}	_{-0.00s (- 0.14%)}	_1.13s	_1.14s
_{Check Time}	_{8.18s (± 0.30%)}	_{8.26s (± 0.40%)}	_{+0.08s (+ 0.98%)}	_8.20s	_8.29s
_{Emit Time}	_{4.80s (± 0.89%)}	_{4.82s (± 1.44%)}	_{+0.02s (+ 0.35%)}	_4.76s	_4.93s
_{Total Time}	_{17.33s (± 0.48%)}	_{17.43s (± 0.63%)}	_{+0.10s (+ 0.57%)}	_17.26s	_17.53s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,487k (± 0.01%)}	_{294,594k (± 0.01%)}	_{+107k (+ 0.04%)}	_294,555k	_294,630k
_{Parse Time}	_{2.70s (± 1.77%)}	_{2.72s (± 0.89%)}	_{+0.02s (+ 0.70%)}	_2.68s	_2.74s
_{Bind Time}	_{1.11s (± 0.41%)}	_{1.11s (± 0.51%)}	_{+0.00s (+ 0.05%)}	_1.10s	_1.12s
_{Check Time}	_{7.76s (± 0.52%)}	_{7.83s (± 0.42%)}	_{+0.06s (+ 0.78%)}	_7.77s	_7.85s
_{Emit Time}	_{4.58s (± 0.28%)}	_{4.60s (± 0.81%)}	_{+0.02s (+ 0.41%)}	_4.53s	_4.64s
_{Total Time}	_{16.15s (± 0.40%)}	_{16.25s (± 0.45%)}	_{+0.10s (+ 0.60%)}	_16.16s	_16.33s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{470,859k (± 0.00%)}	_{470,867k (± 0.00%)}	_{+8k (+ 0.00%)}	_470,850k	_470,874k
_{Parse Time}	_{3.82s (± 0.44%)}	_{3.85s (± 0.52%)}	_{+0.02s (+ 0.64%)}	_3.81s	_3.87s
_{Bind Time}	_{1.02s (± 0.18%)}	_{1.02s (± 0.64%)}	_{+0.00s (+ 0.36%)}	_1.01s	_1.03s
_{Check Time}	_{18.93s (± 0.53%)}	_{18.99s (± 0.71%)}	_{+0.07s (+ 0.35%)}	_18.84s	_19.13s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.77s (± 0.48%)}	_{23.86s (± 0.54%)}	_{+0.09s (+ 0.38%)}	_23.70s	_23.99s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{532,558k (± 0.00%)}	_{532,526k (± 0.00%)}	_{-32k (- 0.01%)}	_532,496k	_532,560k
_{Parse Time}	_{4.94s (± 0.38%)}	_{5.02s (± 0.95%)}	_{+0.08s (+ 1.58%)}	_4.95s	_5.09s
_{Bind Time}	_{1.67s (± 0.89%)}	_{1.67s (± 0.69%)}	_{-0.01s (- 0.46%)}	_1.65s	_1.68s
_{Check Time}	_{3.08s (± 0.46%)}	_{3.09s (± 0.74%)}	_{+0.01s (+ 0.36%)}	_3.06s	_3.11s
_{Emit Time}	_{0.10s (± 0.17%)}	_{0.10s (± 0.16%)}	_{+0.00s (+ 0.03%)}	_0.10s	_0.10s
_{Total Time}	_{9.81s (± 0.23%)}	_{9.88s (± 0.65%)}	_{+0.07s (+ 0.73%)}	_9.82s	_9.98s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₄₂	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52342

_Metric	_main	₅₂₃₄₂	_Delta	_Best	_Worst
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,398ms (± 6.86%)}	_{2,514ms (± 2.07%)}	_{+116ms (+ 4.85%)}	_2,461ms	_2,598ms
_{Req 2 - geterr}	_{5,200ms (± 6.38%)}	_{5,414ms (± 0.94%)}	_{+214ms (+ 4.11%)}	_5,366ms	_5,494ms
_{Req 3 - references}	_{360ms (± 6.68%)}	_{380ms (± 1.97%)}	_{+20ms (+ 5.50%)}	_370ms	_390ms
_{Req 4 - navto}	_{271ms (± 5.59%)}	_{279ms (± 3.23%)}	_{+9ms (+ 3.14%)}	_270ms	_293ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{206ms (±50.62%)}	_{176ms (±64.89%)}	_{🟩-30ms (-14.52%)}	_67ms	_285ms
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,719ms (± 1.50%)}	_{2,727ms (± 1.69%)}	_{+8ms (+ 0.29%)}	_2,680ms	_2,786ms
_{Req 2 - geterr}	_{4,000ms (± 0.54%)}	_{3,982ms (± 0.61%)}	_{-18ms (- 0.45%)}	_3,948ms	_4,022ms
_{Req 3 - references}	_{365ms (± 0.60%)}	_{362ms (± 0.76%)}	_{-3ms (- 0.91%)}	_359ms	_367ms
_{Req 4 - navto}	_{291ms (± 0.91%)}	_{294ms (± 0.32%)}	_{+3ms (+ 0.91%)}	_293ms	_295ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{82ms (± 0.77%)}	_{69ms (± 2.75%)}	_{🟩-12ms (-14.80%)}	_66ms	_71ms
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,308ms (± 0.73%)}	_{3,351ms (± 0.65%)}	_{+42ms (+ 1.27%)}	_3,327ms	_3,378ms
_{Req 2 - geterr}	_{1,427ms (± 1.70%)}	_{1,440ms (± 3.70%)}	_{+13ms (+ 0.93%)}	_1,373ms	_1,497ms
_{Req 3 - references}	_{222ms (±13.58%)}	_{200ms (±16.28%)}	_{🟩-22ms (- 9.79%)}	_177ms	_244ms
_{Req 4 - navto}	_{350ms (± 1.97%)}	_{350ms (± 2.00%)}	_{-0ms (- 0.06%)}	_343ms	_363ms
_{Req 5 - completionInfo count}	_{3,159 (± 0.00%)}	_{3,159 (± 0.00%)}	_{0 ( 0.00%)}	_3,159	_3,159
_{Req 5 - completionInfo}	_{443ms (± 1.31%)}	_{444ms (± 1.76%)}	_{+1ms (+ 0.26%)}	_435ms	_454ms
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,777ms (± 0.34%)}	_{2,747ms (± 1.24%)}	_{-30ms (- 1.09%)}	_2,686ms	_2,783ms
_{Req 2 - geterr}	_{5,806ms (± 0.46%)}	_{5,805ms (± 0.81%)}	_{-1ms (- 0.02%)}	_5,741ms	_5,874ms
_{Req 3 - references}	_{369ms (± 0.90%)}	_{372ms (± 1.51%)}	_{+3ms (+ 0.81%)}	_364ms	_381ms
_{Req 4 - navto}	_{269ms (± 1.70%)}	_{271ms (± 1.03%)}	_{+1ms (+ 0.50%)}	_267ms	_274ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{79ms (± 9.08%)}	_{227ms (±48.80%)}	_{🔻+148ms (+187.34%)}	_81ms	_309ms
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,898ms (± 1.05%)}	_{2,892ms (± 0.32%)}	_{-6ms (- 0.19%)}	_2,886ms	_2,907ms
_{Req 2 - geterr}	_{4,315ms (± 0.69%)}	_{4,306ms (± 0.69%)}	_{-10ms (- 0.22%)}	_4,262ms	_4,332ms
_{Req 3 - references}	_{378ms (± 0.89%)}	_{373ms (± 0.93%)}	_{-5ms (- 1.27%)}	_369ms	_378ms
_{Req 4 - navto}	_{297ms (± 1.07%)}	_{298ms (± 0.85%)}	_{+1ms (+ 0.31%)}	_294ms	_300ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{78ms (± 8.71%)}	_{75ms (± 1.10%)}	_{🟩-3ms (- 3.95%)}	_74ms	_76ms
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,464ms (± 0.77%)}	_{3,470ms (± 0.68%)}	_{+7ms (+ 0.19%)}	_3,442ms	_3,507ms
_{Req 2 - geterr}	_{1,516ms (± 0.61%)}	_{1,526ms (± 0.64%)}	_{+10ms (+ 0.65%)}	_1,513ms	_1,537ms
_{Req 3 - references}	_{273ms (± 0.93%)}	_{272ms (± 1.52%)}	_{-1ms (- 0.52%)}	_266ms	_276ms
_{Req 4 - navto}	_{326ms (± 0.75%)}	_{326ms (± 0.97%)}	_{-0ms (- 0.07%)}	_321ms	_331ms
_{Req 5 - completionInfo count}	_{3,159 (± 0.00%)}	_{3,159 (± 0.00%)}	_{0 ( 0.00%)}	_3,159	_3,159
_{Req 5 - completionInfo}	_{482ms (± 1.52%)}	_{488ms (± 1.14%)}	_{+6ms (+ 1.20%)}	_482ms	_497ms
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,855ms (± 0.43%)}	_{2,862ms (± 0.57%)}	_{+7ms (+ 0.26%)}	_2,840ms	_2,881ms
_{Req 2 - geterr}	_{6,217ms (± 0.56%)}	_{6,240ms (± 0.96%)}	_{+22ms (+ 0.36%)}	_6,156ms	_6,327ms
_{Req 3 - references}	_{386ms (± 0.40%)}	_{391ms (± 1.28%)}	_{+5ms (+ 1.29%)}	_385ms	_398ms
_{Req 4 - navto}	_{283ms (± 0.94%)}	_{277ms (± 0.97%)}	_{-6ms (- 1.95%)}	_273ms	_281ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{90ms (± 2.76%)}	_{82ms (± 7.86%)}	_{🟩-8ms (- 8.66%)}	_75ms	_90ms
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,011ms (± 0.70%)}	_{3,035ms (± 0.84%)}	_{+25ms (+ 0.83%)}	_3,010ms	_3,079ms
_{Req 2 - geterr}	_{4,605ms (± 0.34%)}	_{4,621ms (± 0.34%)}	_{+16ms (+ 0.34%)}	_4,595ms	_4,639ms
_{Req 3 - references}	_{399ms (± 1.22%)}	_{398ms (± 1.36%)}	_{-1ms (- 0.27%)}	_390ms	_404ms
_{Req 4 - navto}	_{296ms (± 1.08%)}	_{298ms (± 1.06%)}	_{+1ms (+ 0.48%)}	_293ms	_302ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{84ms (± 2.05%)}	_{84ms (± 1.05%)}	_{+1ms (+ 0.68%)}	_83ms	_85ms
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,779ms (± 0.70%)}	_{3,786ms (± 0.49%)}	_{+7ms (+ 0.19%)}	_3,771ms	_3,822ms
_{Req 2 - geterr}	_{1,482ms (± 0.30%)}	_{1,510ms (± 2.37%)}	_{+28ms (+ 1.88%)}	_1,467ms	_1,548ms
_{Req 3 - references}	_{128ms (± 3.50%)}	_{128ms (± 1.83%)}	_{-0ms (- 0.14%)}	_127ms	_133ms
_{Req 4 - navto}	_{367ms (± 0.55%)}	_{369ms (± 0.62%)}	_{+2ms (+ 0.61%)}	_365ms	_372ms
_{Req 5 - completionInfo count}	_{3,159 (± 0.00%)}	_{3,159 (± 0.00%)}	_{0 ( 0.00%)}	_3,159	_3,159
_{Req 5 - completionInfo}	_{500ms (± 1.13%)}	_{506ms (± 1.15%)}	_{+6ms (+ 1.19%)}	_500ms	_513ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₄₂	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52342

_Metric	_main	₅₂₃₄₂	_Delta	_Best	_Worst
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.49ms (± 0.22%)}	_{141.35ms (± 0.19%)}	_{-0.14ms (- 0.10%)}	_140.26ms	_144.74ms
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{225.44ms (± 0.27%)}	_{228.28ms (± 0.45%)}	_{+2.85ms (+ 1.26%)}	_224.56ms	_233.62ms
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{227.94ms (± 0.32%)}	_{230.55ms (± 0.30%)}	_{+2.60ms (+ 1.14%)}	_226.50ms	_234.98ms
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{208.73ms (± 0.27%)}	_{211.96ms (± 0.23%)}	_{+3.23ms (+ 1.55%)}	_208.82ms	_217.49ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₄₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2023-01-21T00:05:08Z

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the top-repos suite comparing main and refs/pull/52342/merge:

Something interesting changed - please have a look.

Details

Eugeny/tabby

19 of 29 projects failed to build with the old tsc and were ignored

app/tsconfig.json

error TS2365: Operator '<' cannot be applied to types 'Date' and 'Date'.
- app/lib/config.ts#L13
error TS2365: Operator '<' cannot be applied to types 'boolean' and 'boolean'.
- app/src/plugins.ts#L176

app/tsconfig.main.json

error TS2365: Operator '<' cannot be applied to types 'Date' and 'Date'.
- app/lib/config.ts#L13

tabby-plugin-manager/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'Date' and 'Date'.
- tabby-settings/src/services/configSync.service.ts#L175

tabby-settings/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'Date' and 'Date'.
- tabby-settings/src/services/configSync.service.ts#L175

tabby-settings/tsconfig.typings.json

error TS2365: Operator '>' cannot be applied to types 'Date' and 'Date'.
- tabby-settings/src/services/configSync.service.ts#L175

jquense/yup

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2365: Operator '>=' cannot be applied to types 'NonNullable<this["__outputType"]>' and 'Date'.
- src/date.ts#L89
error TS2365: Operator '<=' cannot be applied to types 'NonNullable<this["__outputType"]>' and 'Date'.
- src/date.ts#L104

lyswhut/lx-music-desktop

1 of 6 projects failed to build with the old tsc and were ignored

src/common/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L24
error TS2365: Operator '<' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L25

src/main/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L24
error TS2365: Operator '<' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L25

src/renderer-lyric/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L24
error TS2365: Operator '<' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L25

src/renderer/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L24
error TS2365: Operator '<' cannot be applied to types 'string | number' and 'string | number'.
- src/common/utils/index.ts#L25

palantir/blueprint

4 of 27 projects failed to build with the old tsc and were ignored

prisma/prisma

60 of 71 projects failed to build with the old tsc and were ignored

packages/fetch-engine/tsconfig.build.json

error TS2365: Operator '<' cannot be applied to types 'Date' and 'Date'.
- packages/fetch-engine/src/cleanupCache.ts#L37

packages/engines/tsconfig.build.json

error TS2365: Operator '<' cannot be applied to types 'Date' and 'Date'.
- packages/fetch-engine/src/cleanupCache.ts#L37

ReactiveX/rxjs

8 of 13 projects failed to build with the old tsc and were ignored

src/tsconfig.cjs.spec.json

error TS2365: Operator '>' cannot be applied to types 'T' and 'T'.
- src/internal/operators/max.ts#L52
error TS2365: Operator '<' cannot be applied to types 'T' and 'T'.
- src/internal/operators/min.ts#L52

src/tsconfig.esm5.rollup.json

error TS2365: Operator '>' cannot be applied to types 'T' and 'T'.
- src/internal/operators/max.ts#L52
error TS2365: Operator '<' cannot be applied to types 'T' and 'T'.
- src/internal/operators/min.ts#L52

src/tsconfig.types.json

error TS2365: Operator '>' cannot be applied to types 'T' and 'T'.
- src/internal/operators/max.ts#L52 in src/tsconfig.types.json
error TS2365: Operator '<' cannot be applied to types 'T' and 'T'.
- src/internal/operators/min.ts#L52 in src/tsconfig.types.json

refined-github/refined-github

tsconfig.json

error TS2365: Operator '<' cannot be applied to types 'Date' and 'Date'.
- source/features/tags-on-commits-list.tsx#L108

remix-run/react-router

17 of 19 projects failed to build with the old tsc and were ignored

scripts/release/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'Date' and 'Date'.
- scripts/release/github.ts#L203
error TS2365: Operator '<' cannot be applied to types 'Date' and 'Date'.
- scripts/release/github.ts#L203

Ryan Cavanaugh (RyanCavanaugh) added 3 commits January 20, 2023 13:47

Remove suspicious relational operator carve-out to see what happens
b7e9ddf

Also strings...
bf7829f

Baseline update
5f7d2d9

TypeScript Bot (typescript-bot) assigned Ryan Cavanaugh (RyanCavanaugh)Jan 20, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 20, 2023

Ryan Cavanaugh (RyanCavanaugh) added 2 commits January 20, 2023 15:06

Add a global valueOf(): number type and use that for these checks
2bc04f3

Baseline updates
cef60e3

Ryan Cavanaugh (RyanCavanaugh) closed this Aug 2, 2024

Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request Jun 18, 2025
Comparing arrays doesn't give any error #61889
Open

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Ryan Cavanaugh (RyanCavanaugh) commented Jan 20, 2023

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) commented Jan 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) commented Jan 20, 2023

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) commented Jan 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023

Last few requests

Repro Steps

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 20, 2023

Compiler

TSServer

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 20, 2023•
edited
Loading