Skip to content

Fixed an issue with top function type being callable with no arguments - #52387

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
Andarist:fix/top-function-type-not-callable
Mar 1, 2023
Merged

Fixed an issue with top function type being callable with no arguments#52387
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
Andarist:fix/top-function-type-not-callable

Conversation

@Andarist

@AndaristMateusz Burzyński (Andarist) commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

fixes#48840
reverts a part of https://github.com/microsoft/TypeScript/pull/35438/files (the tests added there still pass)

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 24, 2023
@Andarist

Mateusz Burzyński (Andarist) commented Jan 24, 2023

Copy link
Copy Markdown
ContributorAuthor

This has been labeled as "For Uncommitted Bug" but the associated issue is labeled with "Bug". This perhaps indicates a bug in the bot.

@fatcerberus

Bruce Pascoe (fatcerberus) commented Jan 28, 2023

Copy link
Copy Markdown

I always thought “For Uncommitted Bug” was literal: the issue has a Bug label but not a Committed label (note: not the same thing as “commit” in git terminology)

@Andarist

Mateusz Burzyński (Andarist) commented Jan 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Hm, i think it also gets For Uncommitted Bug if the issue has no label - and that’s what i assumed to be the main differentiator here. U might be right though - maybe it has to be assigned to a milestone (specific TS version or Backlog) for this label to not be added to the PR

@jakebailey

Jake Bailey (jakebailey) commented Jan 30, 2023

Copy link
Copy Markdown
Member

My understanding is that this particular label is mainly about whether or not it has been assigned to a milestone.

@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 1, 2023

Copy link
Copy Markdown
Member

Daniel Rosenwasser (@DanielRosenwasser) or Jake Bailey (@jakebailey) can you figure out if #48840should be moved into the backlog or a specific milestone? I know the bug came up in the recent design meeting, but I don't think we decided whether the bug was worth fixing.

@jakebailey

Jake Bailey (jakebailey) commented Feb 1, 2023

Copy link
Copy Markdown
Member

I think I'd like to see Anders Hejlsberg (@ahejlsberg) take a look at this in context of #52282 too, lest we end up with a surprising relation behavior.

@jakebaileyJake Bailey (jakebailey) mentioned this pull request Feb 6, 2023
Merged
@jakebailey

Jake Bailey (jakebailey) commented Mar 1, 2023

Copy link
Copy Markdown
Member

I would merge main since this predates the other function PRs but otherwise LGTM given we check the usual suspects.

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 0f8d091. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 0f8d091. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52387/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52387
Metricmain52387DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used359,738k (± 0.02%)359,802k (± 0.01%)~359,761k359,852kp=0.128 n=6
Parse Time3.51s (± 0.93%)3.50s (± 0.47%)~3.47s3.51sp=0.572 n=6
Bind Time1.13s (± 0.46%)1.13s (± 0.00%)~1.13s1.13sp=0.174 n=6
Check Time8.69s (± 0.38%)8.64s (± 0.64%)~8.59s8.71sp=0.170 n=6
Emit Time7.45s (± 0.36%)7.43s (± 0.78%)~7.38s7.54sp=0.170 n=6
Total Time20.78s (± 0.36%)20.70s (± 0.48%)~20.58s20.86sp=0.093 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used191,469k (± 1.57%)192,404k (± 1.58%)~189,529k195,242kp=0.471 n=6
Parse Time1.49s (± 0.69%)1.47s (± 0.71%)~1.46s1.49sp=0.098 n=6
Bind Time0.77s (± 0.53%)0.76s (± 1.07%)-0.01s (- 1.08%)0.76s0.78sp=0.038 n=6
Check Time9.35s (± 0.85%)9.28s (± 0.69%)~9.19s9.36sp=0.124 n=6
Emit Time2.72s (± 0.49%)2.73s (± 0.76%)~2.70s2.76sp=0.934 n=6
Total Time14.33s (± 0.60%)14.24s (± 0.33%)~14.19s14.32sp=0.104 n=6
Monaco - node (v18.10.0, x64)
Memory used343,859k (± 0.01%)343,861k (± 0.01%)~343,826k343,933kp=1.000 n=6
Parse Time2.64s (± 1.54%)2.63s (± 1.04%)~2.60s2.67sp=1.000 n=6
Bind Time1.01s (± 0.40%)1.01s (± 0.51%)~1.00s1.01sp=0.114 n=6
Check Time7.04s (± 0.54%)7.02s (± 0.57%)~6.96s7.07sp=0.748 n=6
Emit Time4.24s (± 0.80%)4.24s (± 0.85%)~4.20s4.30sp=0.687 n=6
Total Time14.93s (± 0.51%)14.90s (± 0.44%)~14.81s15.01sp=0.687 n=6
TFS - node (v18.10.0, x64)
Memory used299,885k (± 0.01%)299,886k (± 0.01%)~299,854k299,942kp=0.689 n=6
Parse Time2.04s (± 1.37%)2.04s (± 1.19%)~2.00s2.07sp=0.870 n=6
Bind Time1.14s (± 0.36%)1.13s (± 0.46%)~1.13s1.14sp=0.112 n=6
Check Time6.53s (± 0.46%)6.52s (± 0.58%)~6.47s6.57sp=0.628 n=6
Emit Time3.86s (± 1.11%)3.83s (± 0.88%)~3.80s3.89sp=0.225 n=6
Total Time13.57s (± 0.47%)13.53s (± 0.63%)~13.45s13.64sp=0.261 n=6
material-ui - node (v18.10.0, x64)
Memory used476,404k (± 0.00%)476,424k (± 0.00%)~476,391k476,449kp=0.173 n=6
Parse Time3.13s (± 0.48%)3.12s (± 0.71%)~3.09s3.15sp=0.188 n=6
Bind Time0.92s (± 1.15%)0.91s (± 0.57%)~0.90s0.91sp=0.142 n=6
Check Time17.07s (± 0.49%)17.03s (± 0.46%)~16.96s17.15sp=0.520 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.12s (± 0.37%)21.06s (± 0.37%)~20.99s21.18sp=0.376 n=6
xstate - node (v18.10.0, x64)
Memory used548,111k (± 0.02%)548,027k (± 0.02%)~547,875k548,187kp=0.298 n=6
Parse Time4.08s (± 0.53%)4.07s (± 0.65%)~4.04s4.11sp=0.687 n=6
Bind Time1.67s (± 0.38%)1.68s (± 0.87%)~1.66s1.70sp=0.156 n=6
Check Time2.75s (± 1.07%)2.76s (± 1.00%)~2.72s2.79sp=0.687 n=6
Emit Time0.08s (± 4.99%)0.08s (± 0.00%)~0.08s0.08sp=0.405 n=6
Total Time8.59s (± 0.51%)8.60s (± 0.47%)~8.52s8.63sp=0.334 n=6
Angular - node (v16.17.1, x64)
Memory used359,079k (± 0.00%)359,085k (± 0.01%)~359,051k359,178kp=0.423 n=6
Parse Time3.73s (± 0.31%)3.73s (± 0.50%)~3.71s3.76sp=0.287 n=6
Bind Time1.20s (± 0.34%)1.19s (± 0.68%)~1.18s1.20sp=0.248 n=6
Check Time9.46s (± 0.25%)9.46s (± 0.22%)~9.43s9.49sp=0.935 n=6
Emit Time7.90s (± 0.64%)7.93s (± 0.67%)~7.87s8.03sp=0.295 n=6
Total Time22.28s (± 0.17%)22.31s (± 0.31%)~22.24s22.44sp=0.747 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used192,371k (± 0.92%)191,319k (± 0.03%)~191,246k191,418kp=0.471 n=6
Parse Time1.58s (± 0.84%)1.57s (± 0.52%)~1.56s1.58sp=0.198 n=6
Bind Time0.83s (± 0.62%)0.82s (± 0.00%)-0.01s (- 0.81%)0.82s0.82sp=0.025 n=6
Check Time10.07s (± 0.70%)10.10s (± 0.89%)~9.98s10.21sp=0.470 n=6
Emit Time2.99s (± 0.65%)3.00s (± 0.83%)~2.97s3.03sp=0.517 n=6
Total Time15.47s (± 0.53%)15.50s (± 0.75%)~15.34s15.65sp=0.628 n=6
Monaco - node (v16.17.1, x64)
Memory used343,125k (± 0.01%)343,140k (± 0.00%)~343,116k343,163kp=0.229 n=6
Parse Time2.80s (± 0.57%)2.79s (± 0.23%)~2.78s2.80sp=0.179 n=6
Bind Time1.08s (± 0.48%)1.08s (± 0.97%)~1.06s1.09sp=0.142 n=6
Check Time7.70s (± 0.28%)7.68s (± 0.49%)~7.63s7.72sp=0.573 n=6
Emit Time4.43s (± 0.55%)4.41s (± 0.97%)~4.37s4.49sp=0.196 n=6
Total Time16.02s (± 0.20%)15.96s (± 0.39%)~15.90s16.07sp=0.092 n=6
TFS - node (v16.17.1, x64)
Memory used299,263k (± 0.00%)299,246k (± 0.01%)~299,215k299,292kp=0.128 n=6
Parse Time2.16s (± 0.68%)2.17s (± 0.85%)~2.15s2.19sp=0.367 n=6
Bind Time1.24s (± 0.67%)1.24s (± 1.35%)~1.21s1.26sp=0.612 n=6
Check Time7.20s (± 0.43%)7.18s (± 0.35%)~7.15s7.21sp=0.333 n=6
Emit Time4.33s (± 0.54%)4.31s (± 0.46%)~4.29s4.34sp=0.413 n=6
Total Time14.93s (± 0.21%)14.90s (± 0.17%)~14.86s14.93sp=0.127 n=6
material-ui - node (v16.17.1, x64)
Memory used475,661k (± 0.00%)475,648k (± 0.00%)~475,622k475,668kp=0.229 n=6
Parse Time3.30s (± 0.38%)3.29s (± 0.64%)~3.27s3.33sp=0.157 n=6
Bind Time0.96s (± 0.78%)0.96s (± 0.00%)~0.96s0.96sp=0.598 n=6
Check Time18.19s (± 0.60%)18.05s (± 0.39%)-0.14s (- 0.74%)17.99s18.15sp=0.044 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.45s (± 0.52%)22.30s (± 0.38%)~22.23s22.42sp=0.054 n=6
xstate - node (v16.17.1, x64)
Memory used545,758k (± 0.03%)545,727k (± 0.01%)~545,638k545,823kp=0.873 n=6
Parse Time4.29s (± 0.42%)4.28s (± 0.58%)~4.25s4.31sp=0.421 n=6
Bind Time1.77s (± 0.58%)1.76s (± 0.36%)~1.75s1.77sp=0.293 n=6
Check Time2.98s (± 0.69%)2.99s (± 0.46%)~2.97s3.01sp=0.454 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time9.13s (± 0.38%)9.11s (± 0.39%)~9.08s9.16sp=0.333 n=6
Angular - node (v14.15.1, x64)
Memory used352,821k (± 0.00%)352,815k (± 0.00%)~352,786k352,829kp=0.936 n=6
Parse Time3.73s (± 0.81%)3.69s (± 0.57%)~3.66s3.71sp=0.064 n=6
Bind Time1.25s (± 0.44%)1.24s (± 0.33%)~1.24s1.25sp=0.282 n=6
Check Time9.76s (± 0.57%)9.71s (± 0.59%)~9.64s9.78sp=0.195 n=6
Emit Time8.39s (± 1.06%)8.38s (± 0.66%)~8.29s8.46sp=0.936 n=6
Total Time23.13s (± 0.24%)23.01s (± 0.20%)-0.12s (- 0.50%)22.93s23.07sp=0.010 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used186,539k (± 0.02%)186,555k (± 0.01%)~186,532k186,571kp=0.378 n=6
Parse Time1.58s (± 0.33%)1.56s (± 0.48%)-0.02s (- 0.95%)1.55s1.57sp=0.010 n=6
Bind Time0.85s (± 0.96%)0.84s (± 0.00%)~0.84s0.84sp=0.073 n=6
Check Time10.20s (± 0.63%)10.21s (± 0.58%)~10.11s10.27sp=1.000 n=6
Emit Time3.13s (± 0.53%)3.12s (± 0.71%)~3.09s3.15sp=0.682 n=6
Total Time15.75s (± 0.50%)15.72s (± 0.43%)~15.63s15.83sp=0.378 n=6
Monaco - node (v14.15.1, x64)
Memory used338,119k (± 0.00%)338,145k (± 0.01%)~338,103k338,186kp=0.065 n=6
Parse Time2.89s (± 0.56%)2.88s (± 0.61%)~2.86s2.90sp=0.104 n=6
Bind Time1.10s (± 0.74%)1.10s (± 0.37%)~1.09s1.10sp=0.206 n=6
Check Time8.13s (± 0.76%)8.07s (± 0.30%)~8.04s8.10sp=0.092 n=6
Emit Time4.70s (± 1.05%)4.67s (± 0.57%)~4.64s4.72sp=0.421 n=6
Total Time16.83s (± 0.67%)16.71s (± 0.31%)~16.67s16.81sp=0.054 n=6
TFS - node (v14.15.1, x64)
Memory used294,285k (± 0.00%)294,270k (± 0.01%)~294,244k294,296kp=0.093 n=6
Parse Time2.38s (± 0.51%)2.37s (± 0.79%)~2.35s2.39sp=0.164 n=6
Bind Time1.07s (± 0.70%)1.06s (± 0.49%)~1.06s1.07sp=0.069 n=6
Check Time7.49s (± 0.36%)7.45s (± 0.61%)~7.39s7.51sp=0.106 n=6
Emit Time4.31s (± 0.68%)4.26s (± 0.69%)-0.05s (- 1.16%)4.21s4.30sp=0.019 n=6
Total Time15.26s (± 0.18%)15.14s (± 0.39%)-0.12s (- 0.80%)15.06s15.21sp=0.005 n=6
material-ui - node (v14.15.1, x64)
Memory used471,334k (± 0.00%)471,337k (± 0.01%)~471,279k471,386kp=0.748 n=6
Parse Time3.46s (± 0.38%)3.44s (± 0.51%)~3.43s3.47sp=0.118 n=6
Bind Time1.01s (± 0.51%)1.00s (± 0.81%)~0.99s1.01sp=0.523 n=6
Check Time19.00s (± 0.62%)18.97s (± 1.01%)~18.82s19.31sp=0.521 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.47s (± 0.50%)23.42s (± 0.85%)~23.26s23.78sp=0.332 n=6
xstate - node (v14.15.1, x64)
Memory used534,383k (± 0.00%)534,393k (± 0.00%)~534,366k534,422kp=0.809 n=6
Parse Time4.50s (± 1.56%)4.43s (± 1.06%)~4.39s4.52sp=0.076 n=6
Bind Time1.73s (± 4.31%)1.76s (± 2.88%)~1.66s1.79sp=0.744 n=6
Check Time3.14s (± 0.44%)3.13s (± 0.62%)~3.10s3.15sp=0.869 n=6
Emit Time0.10s (± 0.00%)0.10s (± 0.00%)~0.10s0.10sp=1.000 n=6
Total Time9.48s (± 0.50%)9.43s (± 0.37%)~9.37s9.46sp=0.147 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current523876
Baselinemain6

TSServer

Comparison Report - main..52387
Metricmain52387DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,364ms (± 0.45%)2,366ms (± 1.07%)~2,342ms2,407msp=0.809 n=6
Req 2 - geterr5,312ms (± 0.49%)5,293ms (± 0.79%)~5,239ms5,346msp=0.378 n=6
Req 3 - references338ms (± 0.76%)336ms (± 0.94%)~333ms342msp=0.220 n=6
Req 4 - navto285ms (± 0.36%)285ms (± 1.01%)~279ms287msp=1.000 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo75ms (± 4.81%)79ms (± 5.38%)~77ms88msp=0.188 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,531ms (± 0.81%)2,516ms (± 1.33%)~2,463ms2,561msp=0.378 n=6
Req 2 - geterr3,996ms (± 0.47%)3,994ms (± 0.67%)~3,971ms4,045msp=0.575 n=6
Req 3 - references353ms (± 0.71%)353ms (± 0.64%)~351ms357msp=0.935 n=6
Req 4 - navto293ms (± 0.66%)293ms (± 0.36%)~291ms294msp=0.742 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo68ms (± 0.60%)68ms (± 0.93%)~67ms69msp=0.673 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,190ms (± 0.48%)3,171ms (± 0.73%)~3,139ms3,199msp=0.228 n=6
Req 2 - geterr1,607ms (± 0.66%)1,600ms (± 0.61%)~1,592ms1,618msp=0.297 n=6
Req 3 - references104ms (± 1.44%)104ms (± 1.42%)~102ms106msp=0.615 n=6
Req 4 - navto360ms (± 0.62%)358ms (± 0.49%)~356ms361msp=0.128 n=6
Req 5 - completionInfo count3,136 (± 0.00%)3,136 (± 0.00%)~3,1363,136p=1.000 n=6
Req 5 - completionInfo432ms (± 0.59%)426ms (± 1.41%)~421ms438msp=0.065 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,491ms (± 1.58%)2,491ms (± 1.63%)~2,450ms2,550msp=1.000 n=6
Req 2 - geterr5,747ms (± 1.04%)5,716ms (± 0.48%)~5,673ms5,754msp=0.298 n=6
Req 3 - references349ms (± 0.54%)348ms (± 0.39%)~346ms350msp=0.510 n=6
Req 4 - navto281ms (± 0.52%)280ms (± 0.49%)~278ms282msp=0.118 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo84ms (± 0.49%)84ms (± 0.89%)~83ms85msp=0.389 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,688ms (± 0.60%)2,678ms (± 0.44%)~2,665ms2,693msp=0.226 n=6
Req 2 - geterr4,356ms (± 0.47%)4,354ms (± 0.59%)~4,306ms4,375msp=1.000 n=6
Req 3 - references365ms (± 0.81%)364ms (± 1.07%)~359ms369msp=0.809 n=6
Req 4 - navto289ms (± 0.48%)286ms (± 1.12%)~283ms291msp=0.250 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo74ms (± 1.14%)73ms (± 0.70%)~73ms74msp=0.533 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,339ms (± 0.50%)3,326ms (± 0.29%)~3,316ms3,341msp=0.109 n=6
Req 2 - geterr1,777ms (± 1.35%)1,761ms (± 1.37%)~1,743ms1,808msp=0.229 n=6
Req 3 - references112ms (± 2.28%)111ms (± 1.76%)~109ms114msp=0.625 n=6
Req 4 - navto344ms (± 1.32%)345ms (± 1.45%)~338ms352msp=0.936 n=6
Req 5 - completionInfo count3,136 (± 0.00%)3,136 (± 0.00%)~3,1363,136p=1.000 n=6
Req 5 - completionInfo435ms (± 0.92%)433ms (± 0.93%)~426ms437msp=0.568 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,570ms (± 0.64%)2,570ms (± 0.56%)~2,550ms2,584msp=0.873 n=6
Req 2 - geterr6,038ms (± 0.70%)6,022ms (± 0.83%)~5,980ms6,108msp=0.471 n=6
Req 3 - references368ms (± 0.97%)364ms (± 0.75%)~360ms367msp=0.164 n=6
Req 4 - navto277ms (± 1.26%)274ms (± 0.43%)-3ms (- 1.08%)273ms276msp=0.032 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo99ms (± 1.87%)100ms (± 1.87%)~96ms101msp=0.932 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,808ms (± 0.47%)2,812ms (± 1.01%)~2,779ms2,850msp=0.873 n=6
Req 2 - geterr4,450ms (± 1.92%)4,503ms (± 2.65%)~4,382ms4,620msp=1.000 n=6
Req 3 - references395ms (± 6.01%)379ms (± 0.59%)~375ms381msp=0.173 n=6
Req 4 - navto293ms (± 1.71%)293ms (± 1.10%)~288ms297msp=1.000 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo91ms (± 9.19%)92ms (±11.68%)~82ms102msp=0.746 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,648ms (± 0.32%)3,645ms (± 0.66%)~3,609ms3,671msp=1.000 n=6
Req 2 - geterr1,845ms (± 1.25%)1,832ms (± 1.35%)~1,803ms1,871msp=0.298 n=6
Req 3 - references129ms (± 2.79%)128ms (± 2.90%)~124ms134msp=0.806 n=6
Req 4 - navto373ms (± 1.02%)377ms (± 2.22%)~372ms394msp=0.683 n=6
Req 5 - completionInfo count3,136 (± 0.00%)3,136 (± 0.00%)~3,1363,136p=1.000 n=6
Req 5 - completionInfo449ms (± 2.91%)456ms (± 1.86%)~448ms472msp=0.297 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current523876
Baselinemain6

Startup

Comparison Report - main..52387
Metricmain52387DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time143.18ms (± 0.23%)142.38ms (± 0.20%)-0.80ms (- 0.56%)141.67ms147.94msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time227.79ms (± 0.17%)226.82ms (± 0.18%)-0.97ms (- 0.43%)225.84ms233.97msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time229.50ms (± 0.17%)228.52ms (± 0.15%)-0.99ms (- 0.43%)227.66ms233.43msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time210.24ms (± 0.20%)209.38ms (± 0.21%)-0.86ms (- 0.41%)208.55ms220.47msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current523876
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52387/merge:

Everything looks good!

@typescript-botTypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 1, 2023
@Andarist

Mateusz Burzyński (Andarist) commented Mar 1, 2023

Copy link
Copy Markdown
ContributorAuthor

I would merge main since this predates the other function PRs but otherwise LGTM given we check the usual suspects.

Synced this with main 👍

@jakebailey
Jake Bailey (jakebailey) merged commit 02885b1 into microsoft:mainMar 1, 2023
@Andarist
Mateusz Burzyński (Andarist) deleted the fix/top-function-type-not-callable branch March 1, 2023 17:40
@AndaristMateusz Burzyński (Andarist) mentioned this pull request Mar 3, 2023
Closed
@AndaristMateusz Burzyński (Andarist) mentioned this pull request Jun 6, 2023
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes
@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Awaiting requested review from DanielRosenwasser
@ahejlsbergAnders Hejlsberg (ahejlsberg)Awaiting requested review from ahejlsberg

Assignees

@jakebaileyJake Bailey (jakebailey)

Labels

For Backlog BugPRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression causes Function top-type to be callable with no arguments

6 participants

@Andarist@fatcerberus@jakebailey@sandersn@typescript-bot@DanielRosenwasser