Skip to content

Fix string completions depending on contextual signatures - #52717

Merged
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
Andarist:fix/string-completions-depending-on-context-sensitive-signature
Mar 8, 2023
Merged

Fix string completions depending on contextual signatures#52717
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
Andarist:fix/string-completions-depending-on-context-sensitive-signature

Conversation

@Andarist

@AndaristMateusz Burzyński (Andarist) commented Feb 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 10, 2023
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Andarist
Mateusz Burzyński (Andarist) commented Feb 10, 2023
View reviewed changes
Comment threadtests/cases/fourslash/completionsForStringDependingOnContexSensitiveSignature.ts
//// entry: sendTo((ctx) => ctx.child, { type: "/*2*/" }),
//// });

verify.completions({ marker: "1", includes: [`"EVENT"`] })

@AndaristMateusz Burzyński (Andarist)Feb 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one was already working since the omitted node~ was already producing { type: any } and thus didn't fail the applicability check, whereas when requesting the string completion the type was { type: '' } and it was failing the check and thus failing to provide the completions

@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 3, 2023

Copy link
Copy Markdown
Member

Can you explain what bug is fixed here? Preferably also filing a bug to track the problem.

@Andarist

Mateusz Burzyński (Andarist) commented Mar 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Nathan Shively-Sanders (@sandersn) filed a new issue here: #53073

@zardoyVitaly (zardoy) mentioned this pull request Mar 4, 2023
Open
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 6e4f0a4 into microsoft:mainMar 8, 2023
This was referenced Jun 9, 2023
Closed
Merged
Merged
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn approved these changes
@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes

Assignees

@sandersnNathan Shively-Sanders (sandersn)

Labels

For Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

String completions fail when they depend on the contextual signature

4 participants

@Andarist@typescript-bot@sandersn@andrewbranch