Uh oh!
There was an error while loading. Please reload this page.
Remove redundant code from getResolvedSignatureWorker - #52721
Remove redundant code from getResolvedSignatureWorker#52721Mateusz Burzyński (Andarist) wants to merge 1 commit into
getResolvedSignatureWorker#52721Conversation
TypeScript Bot (typescript-bot)
commented
Feb 10, 2023
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
91adbd2 to
226985fCompareAndrew Branch (andrewbranch)
commented
Feb 10, 2023
TypeScript Bot (@typescript-bot) user test |
Heya Andrew Branch (@andrewbranch), I've started to run the diff-based top-repos suite on this PR at 226985f. You can monitor the build here. Update: The results are in! |
Andrew Branch (andrewbranch)
left a comment
There was a problem hiding this comment.
getParseTreeNode returns undefined when the input node is transformed. This is here to prevent crashes when API consumers try to do something they shouldn’t do. I think we want to keep it.
Mateusz Burzyński (Andarist)
commented
Feb 11, 2023
In such a case, there is no point in this PR. More meaningful changes in this code are happening here anyway |
TypeScript Bot (typescript-bot)
commented
Feb 11, 2023
Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing Everything looks good! |
Mateusz Burzyński (Andarist)
commented
Feb 11, 2023
Andrew Branch (@andrewbranch) I got curious about this case - is there a way to write a unit~ test that would cover this scenario? 🤔 |
while investigating what extra tests I should add as part of #52679 i noticed that some pieces here might not be needed (at least according to the existing test suite)