Revert fix for intersections in template literals, fix differently by jakebailey · Pull Request #52836 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2023-02-18T05:49:45Z

This reverts #48044, which with nearly a year more experience no longer looks correct to my eyes (I regret merging it), and instead implements a different fix for the issue. This one instead avoids expanding out intersections, leaving them in place like the other non-string-y types.

Jake Bailey (jakebailey) · 2023-02-18T05:49:53Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at bb599af. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at bb599af. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at bb599af. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite (tsserver) on this PR at bb599af. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at bb599af. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at bb599af. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at bb599af. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-02-18T05:50:15Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite (tsserver) on this PR at bb599af. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-02-18T06:02:49Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52836/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-02-18T06:04:49Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52836/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-02-18T06:05:11Z

Heya Jake Bailey (@jakebailey), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

TypeScript Bot (typescript-bot) · 2023-02-18T06:46:16Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52836

_Metric	_main	₅₂₈₃₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,387k (± 0.01%)}	_{359,394k (± 0.01%)}	_~	_359,338k	_359,442k	_{p=0.628 n=6}
_{Parse Time}	_{3.50s (± 0.86%)}	_{3.49s (± 0.89%)}	_~	_3.44s	_3.53s	_{p=0.683 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.76%)}	_~	_1.16s	_1.18s	_{p=0.541 n=6}
_{Check Time}	_{8.77s (± 0.62%)}	_{8.69s (± 0.45%)}	_{-0.08s (- 0.87%)}	_8.63s	_8.74s	_{p=0.020 n=6}
_{Emit Time}	_{7.61s (± 0.92%)}	_{7.59s (± 0.37%)}	_~	_7.56s	_7.63s	_{p=0.871 n=6}
_{Total Time}	_{21.05s (± 0.62%)}	_{20.94s (± 0.29%)}	_~	_20.85s	_21.02s	_{p=0.106 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{190,827k (± 1.19%)}	_{190,855k (± 1.19%)}	_~	_189,912k	_195,477k	_{p=0.936 n=6}
_{Parse Time}	_{1.48s (± 0.66%)}	_{1.48s (± 0.90%)}	_~	_1.46s	_1.50s	_{p=0.620 n=6}
_{Bind Time}	_{0.79s (± 0.52%)}	_{0.79s (± 0.52%)}	_~	_0.79s	_0.80s	_{p=1.000 n=6}
_{Check Time}	_{9.42s (± 0.88%)}	_{9.42s (± 0.22%)}	_~	_9.40s	_9.45s	_{p=0.688 n=6}
_{Emit Time}	_{2.82s (± 1.62%)}	_{2.79s (± 1.12%)}	_~	_2.76s	_2.83s	_{p=0.374 n=6}
_{Total Time}	_{14.51s (± 0.77%)}	_{14.48s (± 0.32%)}	_~	_14.42s	_14.54s	_{p=0.470 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,979k (± 0.01%)}	_{343,986k (± 0.02%)}	_~	_343,886k	_344,078k	_{p=0.936 n=6}
_{Parse Time}	_{2.62s (± 1.17%)}	_{2.62s (± 0.95%)}	_~	_2.58s	_2.65s	_{p=0.872 n=6}
_{Bind Time}	_{1.03s (± 0.81%)}	_{1.03s (± 1.18%)}	_~	_1.02s	_1.05s	_{p=0.928 n=6}
_{Check Time}	_{7.12s (± 0.44%)}	_{7.09s (± 0.37%)}	_~	_7.06s	_7.13s	_{p=0.091 n=6}
_{Emit Time}	_{4.33s (± 0.35%)}	_{4.32s (± 0.54%)}	_~	_4.29s	_4.35s	_{p=1.000 n=6}
_{Total Time}	_{15.10s (± 0.30%)}	_{15.07s (± 0.37%)}	_~	_14.97s	_15.12s	_{p=0.628 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,028k (± 0.00%)}	_{300,045k (± 0.01%)}	_~	_300,027k	_300,087k	_{p=0.149 n=6}
_{Parse Time}	_{2.07s (± 1.48%)}	_{2.06s (± 0.78%)}	_~	_2.04s	_2.08s	_{p=0.331 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.35%)}	_~	_1.16s	_1.17s	_{p=0.114 n=6}
_{Check Time}	_{6.57s (± 0.30%)}	_{6.58s (± 0.35%)}	_~	_6.54s	_6.60s	_{p=0.325 n=6}
_{Emit Time}	_{3.93s (± 0.66%)}	_{3.93s (± 0.63%)}	_~	_3.90s	_3.97s	_{p=1.000 n=6}
_{Total Time}	_{13.75s (± 0.50%)}	_{13.74s (± 0.27%)}	_~	_13.70s	_13.79s	_{p=0.374 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,411k (± 0.01%)}	_{476,424k (± 0.01%)}	_~	_476,362k	_476,458k	_{p=0.470 n=6}
_{Parse Time}	_{3.15s (± 1.09%)}	_{3.15s (± 0.79%)}	_~	_3.10s	_3.17s	_{p=1.000 n=6}
_{Bind Time}	_{0.97s (± 0.42%)}	_{0.97s (± 0.65%)}	_~	_0.96s	_0.98s	_{p=0.673 n=6}
_{Check Time}	_{17.18s (± 0.32%)}	_{17.21s (± 0.49%)}	_~	_17.11s	_17.33s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.30s (± 0.21%)}	_{21.32s (± 0.44%)}	_~	_21.21s	_21.46s	_{p=0.748 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{548,608k (± 0.03%)}	_{548,528k (± 0.02%)}	_~	_548,364k	_548,693k	_{p=0.471 n=6}
_{Parse Time}	_{4.06s (± 0.37%)}	_{4.07s (± 0.18%)}	_~	_4.06s	_4.08s	_{p=0.060 n=6}
_{Bind Time}	_{1.72s (± 1.14%)}	_{1.73s (± 1.45%)}	_~	_1.69s	_1.75s	_{p=0.505 n=6}
_{Check Time}	_{2.81s (± 0.70%)}	_{2.82s (± 0.49%)}	_~	_2.80s	_2.84s	_{p=0.366 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.67s (± 0.33%)}	_{8.70s (± 0.16%)}	_~	_8.68s	_8.72s	_{p=0.078 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,760k (± 0.01%)}	_{358,747k (± 0.01%)}	_~	_358,712k	_358,793k	_{p=0.471 n=6}
_{Parse Time}	_{3.72s (± 0.63%)}	_{3.71s (± 0.22%)}	_~	_3.70s	_3.72s	_{p=0.869 n=6}
_{Bind Time}	_{1.22s (± 0.42%)}	_{1.23s (± 0.61%)}	_~	_1.22s	_1.24s	_{p=0.247 n=6}
_{Check Time}	_{9.54s (± 0.49%)}	_{9.51s (± 0.40%)}	_~	_9.46s	_9.56s	_{p=0.296 n=6}
_{Emit Time}	_{8.12s (± 1.35%)}	_{8.03s (± 0.72%)}	_~	_7.98s	_8.14s	_{p=0.090 n=6}
_{Total Time}	_{22.60s (± 0.48%)}	_{22.48s (± 0.35%)}	_~	_22.40s	_22.63s	_{p=0.065 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{191,518k (± 0.02%)}	_{192,651k (± 0.93%)}	_~	_191,430k	_195,104k	_{p=0.936 n=6}
_{Parse Time}	_{1.57s (± 0.67%)}	_{1.56s (± 0.96%)}	_~	_1.54s	_1.58s	_{p=0.933 n=6}
_{Bind Time}	_{0.84s (± 0.00%)}	_{0.84s (± 0.00%)}	_~	_0.84s	_0.84s	_{p=1.000 n=6}
_{Check Time}	_{10.13s (± 0.44%)}	_{10.12s (± 0.63%)}	_~	_10.02s	_10.18s	_{p=1.000 n=6}
_{Emit Time}	_{3.08s (± 0.96%)}	_{3.06s (± 1.02%)}	_~	_3.03s	_3.12s	_{p=0.219 n=6}
_{Total Time}	_{15.60s (± 0.34%)}	_{15.58s (± 0.50%)}	_~	_15.47s	_15.66s	_{p=0.630 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,256k (± 0.00%)}	_{343,265k (± 0.01%)}	_~	_343,202k	_343,295k	_{p=0.228 n=6}
_{Parse Time}	_{2.80s (± 0.52%)}	_{2.80s (± 0.64%)}	_~	_2.77s	_2.82s	_{p=1.000 n=6}
_{Bind Time}	_{1.11s (± 0.68%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.784 n=6}
_{Check Time}	_{7.77s (± 0.22%)}	_{7.78s (± 0.36%)}	_~	_7.75s	_7.82s	_{p=0.867 n=6}
_{Emit Time}	_{4.50s (± 0.57%)}	_{4.50s (± 0.76%)}	_~	_4.45s	_4.55s	_{p=1.000 n=6}
_{Total Time}	_{16.18s (± 0.17%)}	_{16.19s (± 0.35%)}	_~	_16.10s	_16.25s	_{p=0.469 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,386k (± 0.01%)}	_{299,377k (± 0.01%)}	_~	_299,356k	_299,403k	_{p=0.471 n=6}
_{Parse Time}	_{2.19s (± 0.53%)}	_{2.19s (± 0.85%)}	_~	_2.16s	_2.21s	_{p=0.363 n=6}
_{Bind Time}	_{1.26s (± 0.65%)}	_{1.26s (± 0.60%)}	_~	_1.25s	_1.27s	_{p=0.729 n=6}
_{Check Time}	_{7.21s (± 0.35%)}	_{7.19s (± 0.29%)}	_~	_7.16s	_7.21s	_{p=0.193 n=6}
_{Emit Time}	_{4.22s (± 0.56%)}	_{4.22s (± 0.63%)}	_~	_4.19s	_4.26s	_{p=0.935 n=6}
_{Total Time}	_{14.87s (± 0.37%)}	_{14.86s (± 0.25%)}	_~	_14.79s	_14.89s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,716k (± 0.01%)}	_{475,690k (± 0.00%)}	_~	_475,682k	_475,700k	_{p=0.520 n=6}
_{Parse Time}	_{3.33s (± 0.31%)}	_{3.32s (± 0.36%)}	_~	_3.31s	_3.34s	_{p=0.675 n=6}
_{Bind Time}	_{1.02s (± 0.50%)}	_{1.01s (± 0.54%)}	_{-0.01s (- 0.81%)}	_1.01s	_1.02s	_{p=0.038 n=6}
_{Check Time}	_{18.15s (± 0.45%)}	_{18.18s (± 0.38%)}	_~	_18.11s	_18.27s	_{p=0.689 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.50s (± 0.37%)}	_{22.53s (± 0.26%)}	_~	_22.46s	_22.60s	_{p=0.936 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,058k (± 0.02%)}	_{546,143k (± 0.02%)}	_~	_545,996k	_546,243k	_{p=0.173 n=6}
_{Parse Time}	_{4.24s (± 0.19%)}	_{4.25s (± 0.32%)}	_~	_4.23s	_4.27s	_{p=0.133 n=6}
_{Bind Time}	_{1.81s (± 0.29%)}	_{1.80s (± 0.29%)}	_~	_1.80s	_1.81s	_{p=0.311 n=6}
_{Check Time}	_{3.07s (± 0.63%)}	_{3.07s (± 0.63%)}	_~	_3.04s	_3.09s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.21s (± 0.20%)}	_{9.22s (± 0.22%)}	_~	_9.19s	_9.25s	_{p=0.373 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,281k (± 0.00%)}	_{352,277k (± 0.00%)}	_~	_352,267k	_352,298k	_{p=0.378 n=6}
_{Parse Time}	_{3.71s (± 0.41%)}	_{3.71s (± 0.34%)}	_~	_3.70s	_3.73s	_{p=0.512 n=6}
_{Bind Time}	_{1.28s (± 0.32%)}	_{1.28s (± 0.59%)}	_~	_1.27s	_1.29s	_{p=1.000 n=6}
_{Check Time}	_{9.82s (± 0.39%)}	_{9.83s (± 0.78%)}	_~	_9.74s	_9.97s	_{p=0.936 n=6}
_{Emit Time}	_{8.40s (± 0.73%)}	_{8.38s (± 0.49%)}	_~	_8.35s	_8.46s	_{p=0.572 n=6}
_{Total Time}	_{23.22s (± 0.28%)}	_{23.21s (± 0.46%)}	_~	_23.09s	_23.37s	_{p=0.809 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,203k (± 0.71%)}	_{186,645k (± 0.01%)}	_~	_186,624k	_186,661k	_{p=0.471 n=6}
_{Parse Time}	_{1.57s (± 0.52%)}	_{1.59s (± 0.86%)}	_~	_1.57s	_1.61s	_{p=0.058 n=6}
_{Bind Time}	_{0.85s (± 0.64%)}	_{0.85s (± 0.48%)}	_~	_0.85s	_0.86s	_{p=0.282 n=6}
_{Check Time}	_{10.17s (± 0.32%)}	_{10.24s (± 0.25%)}	_{+0.07s (+ 0.69%)}	_10.20s	_10.27s	_{p=0.010 n=6}
_{Emit Time}	_{3.18s (± 0.92%)}	_{3.18s (± 1.19%)}	_~	_3.13s	_3.23s	_{p=0.808 n=6}
_{Total Time}	_{15.78s (± 0.26%)}	_{15.86s (± 0.29%)}	_{+0.08s (+ 0.52%)}	_15.79s	_15.91s	_{p=0.024 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,099k (± 0.00%)}	_{338,113k (± 0.00%)}	_~	_338,098k	_338,131k	_{p=0.065 n=6}
_{Parse Time}	_{2.90s (± 0.28%)}	_{2.90s (± 0.86%)}	_~	_2.86s	_2.93s	_{p=0.933 n=6}
_{Bind Time}	_{1.12s (± 0.49%)}	_{1.12s (± 1.43%)}	_~	_1.11s	_1.15s	_{p=0.855 n=6}
_{Check Time}	_{8.14s (± 0.59%)}	_{8.11s (± 0.40%)}	_~	_8.08s	_8.15s	_{p=0.418 n=6}
_{Emit Time}	_{4.78s (± 0.50%)}	_{4.78s (± 0.72%)}	_~	_4.74s	_4.83s	_{p=0.747 n=6}
_{Total Time}	_{16.94s (± 0.37%)}	_{16.92s (± 0.45%)}	_~	_16.84s	_17.05s	_{p=0.469 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,322k (± 0.00%)}	_{294,312k (± 0.00%)}	_~	_294,303k	_294,321k	_{p=0.228 n=6}
_{Parse Time}	_{2.38s (± 1.04%)}	_{2.38s (± 0.68%)}	_~	_2.36s	_2.40s	_{p=1.000 n=6}
_{Bind Time}	_{1.11s (± 0.95%)}	_{1.10s (± 1.15%)}	_~	_1.09s	_1.12s	_{p=0.456 n=6}
_{Check Time}	_{7.54s (± 0.38%)}	_{7.55s (± 0.51%)}	_~	_7.50s	_7.60s	_{p=0.517 n=6}
_{Emit Time}	_{4.62s (± 0.54%)}	_{4.65s (± 1.21%)}	_~	_4.57s	_4.72s	_{p=0.571 n=6}
_{Total Time}	_{15.65s (± 0.26%)}	_{15.68s (± 0.62%)}	_~	_15.54s	_15.78s	_{p=0.520 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,221k (± 0.00%)}	_{471,231k (± 0.00%)}	_~	_471,217k	_471,256k	_{p=0.228 n=6}
_{Parse Time}	_{3.49s (± 0.35%)}	_{3.47s (± 0.43%)}	_~	_3.46s	_3.50s	_{p=0.119 n=6}
_{Bind Time}	_{1.04s (± 0.50%)}	_{1.04s (± 0.79%)}	_~	_1.03s	_1.05s	_{p=0.929 n=6}
_{Check Time}	_{19.13s (± 0.46%)}	_{19.09s (± 0.64%)}	_~	_18.99s	_19.33s	_{p=0.336 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.66s (± 0.40%)}	_{23.61s (± 0.59%)}	_~	_23.50s	_23.88s	_{p=0.172 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,492k (± 0.01%)}	_{534,458k (± 0.01%)}	_~	_534,352k	_534,494k	_{p=0.422 n=6}
_{Parse Time}	_{4.58s (± 0.18%)}	_{4.58s (± 0.33%)}	_~	_4.57s	_4.60s	_{p=1.000 n=6}
_{Bind Time}	_{1.72s (± 0.57%)}	_{1.72s (± 0.52%)}	_~	_1.71s	_1.73s	_{p=0.798 n=6}
_{Check Time}	_{3.16s (± 0.53%)}	_{3.17s (± 0.46%)}	_~	_3.15s	_3.19s	_{p=0.462 n=6}
_{Emit Time}	_{0.10s (± 0.00%)}	_{0.10s (± 4.01%)}	_~	_0.10s	_0.11s	_{p=0.405 n=6}
_{Total Time}	_{9.57s (± 0.21%)}	_{9.58s (± 0.19%)}	_~	_9.56s	_9.60s	_{p=0.516 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₈₃₆	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52836

_Metric	_main	₅₂₈₃₆	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,379ms (± 1.15%)}	_{2,371ms (± 0.73%)}	_~	_2,338ms	_2,386ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{5,371ms (± 0.57%)}	_{5,333ms (± 0.24%)}	_{-38ms (- 0.70%)}	_5,320ms	_5,353ms	_{p=0.013 n=6}
_{Req 3 - references}	_{341ms (± 0.99%)}	_{338ms (± 0.66%)}	_~	_336ms	_342ms	_{p=0.195 n=6}
_{Req 4 - navto}	_{281ms (± 0.65%)}	_{283ms (± 0.58%)}	_~	_281ms	_285ms	_{p=0.096 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{72ms (± 1.52%)}	_{71ms (± 1.14%)}	_~	_71ms	_73ms	_{p=0.177 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,503ms (± 0.78%)}	_{2,510ms (± 0.78%)}	_~	_2,488ms	_2,535ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,037ms (± 0.75%)}	_{4,013ms (± 0.69%)}	_~	_3,994ms	_4,067ms	_{p=0.173 n=6}
_{Req 3 - references}	_{353ms (± 0.51%)}	_{353ms (± 0.62%)}	_~	_350ms	_356ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{288ms (± 0.56%)}	_{289ms (± 0.64%)}	_~	_286ms	_291ms	_{p=0.681 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 0.81%)}	_{69ms (± 4.77%)}	_~	_66ms	_75ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,190ms (± 0.65%)}	_{3,186ms (± 0.41%)}	_~	_3,168ms	_3,204ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{1,640ms (± 0.71%)}	_{1,643ms (± 1.05%)}	_~	_1,620ms	_1,667ms	_{p=0.936 n=6}
_{Req 3 - references}	_{104ms (± 1.22%)}	_{104ms (± 2.67%)}	_~	_102ms	_109ms	_{p=0.617 n=6}
_{Req 4 - navto}	_{357ms (± 0.91%)}	_{356ms (± 0.54%)}	_~	_355ms	_360ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{426ms (± 1.09%)}	_{427ms (± 0.73%)}	_~	_424ms	_433ms	_{p=0.377 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,535ms (± 0.66%)}	_{2,520ms (± 0.44%)}	_~	_2,505ms	_2,534ms	_{p=0.106 n=6}
_{Req 2 - geterr}	_{5,757ms (± 0.62%)}	_{5,723ms (± 0.30%)}	_~	_5,699ms	_5,743ms	_{p=0.066 n=6}
_{Req 3 - references}	_{350ms (± 0.58%)}	_{355ms (± 1.54%)}	_~	_348ms	_363ms	_{p=0.107 n=6}
_{Req 4 - navto}	_{280ms (± 0.84%)}	_{279ms (± 0.62%)}	_~	_276ms	_281ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 3.80%)}	_{79ms (± 5.16%)}	_{🟩-5ms (- 5.96%)}	_75ms	_84ms	_{p=0.043 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,683ms (± 1.20%)}	_{2,684ms (± 0.59%)}	_~	_2,664ms	_2,698ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,377ms (± 0.50%)}	_{4,366ms (± 0.60%)}	_~	_4,344ms	_4,402ms	_{p=0.422 n=6}
_{Req 3 - references}	_{366ms (± 1.04%)}	_{364ms (± 0.74%)}	_~	_359ms	_366ms	_{p=0.196 n=6}
_{Req 4 - navto}	_{282ms (± 1.16%)}	_{283ms (± 1.46%)}	_~	_279ms	_289ms	_{p=0.871 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 0.87%)}	_{73ms (± 1.82%)}	_~	_71ms	_75ms	_{p=0.720 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,370ms (± 0.28%)}	_{3,368ms (± 0.31%)}	_~	_3,351ms	_3,383ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{1,839ms (± 3.77%)}	_{1,940ms (± 5.47%)}	_~	_1,780ms	_2,028ms	_{p=0.128 n=6}
_{Req 3 - references}	_{111ms (± 2.13%)}	_{111ms (± 1.32%)}	_~	_109ms	_113ms	_{p=0.934 n=6}
_{Req 4 - navto}	_{345ms (± 1.27%)}	_{343ms (± 1.53%)}	_~	_336ms	_351ms	_{p=0.628 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{431ms (± 0.82%)}	_{433ms (± 1.31%)}	_~	_427ms	_442ms	_{p=0.466 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,624ms (± 0.48%)}	_{2,619ms (± 0.52%)}	_~	_2,597ms	_2,631ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{6,095ms (± 0.55%)}	_{6,085ms (± 0.53%)}	_~	_6,045ms	_6,121ms	_{p=0.471 n=6}
_{Req 3 - references}	_{366ms (± 0.33%)}	_{367ms (± 1.49%)}	_~	_361ms	_377ms	_{p=0.744 n=6}
_{Req 4 - navto}	_{281ms (± 1.80%)}	_{277ms (± 0.27%)}	_~	_276ms	_278ms	_{p=0.102 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{101ms (± 0.63%)}	_{100ms (± 1.03%)}	_~	_99ms	_101ms	_{p=0.293 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,838ms (± 0.90%)}	_{2,843ms (± 0.25%)}	_~	_2,838ms	_2,857ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{4,619ms (± 2.63%)}	_{4,539ms (± 2.41%)}	_~	_4,446ms	_4,698ms	_{p=0.230 n=6}
_{Req 3 - references}	_{380ms (± 0.86%)}	_{389ms (± 5.65%)}	_~	_377ms	_433ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{293ms (± 1.31%)}	_{294ms (± 1.17%)}	_~	_288ms	_297ms	_{p=0.688 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 9.49%)}	_{88ms (± 9.52%)}	_~	_81ms	_101ms	_{p=0.627 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,684ms (± 0.86%)}	_{3,675ms (± 0.39%)}	_~	_3,656ms	_3,692ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{1,856ms (± 2.24%)}	_{1,852ms (± 1.66%)}	_~	_1,818ms	_1,896ms	_{p=1.000 n=6}
_{Req 3 - references}	_{127ms (± 3.89%)}	_{126ms (± 2.84%)}	_~	_122ms	_132ms	_{p=0.627 n=6}
_{Req 4 - navto}	_{376ms (± 1.62%)}	_{373ms (± 0.64%)}	_~	_369ms	_376ms	_{p=0.332 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{457ms (± 2.63%)}	_{445ms (± 1.87%)}	_~	_436ms	_455ms	_{p=0.065 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₈₃₆	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52836

_Metric	_main	₅₂₈₃₆	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.31ms (± 0.19%)}	_{142.86ms (± 0.22%)}	_{+0.54ms (+ 0.38%)}	_141.80ms	_148.55ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.77ms (± 0.18%)}	_{226.87ms (± 0.16%)}	_{+0.10ms (+ 0.05%)}	_225.91ms	_232.20ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.58ms (± 0.21%)}	_{228.58ms (± 0.17%)}	_~	_227.62ms	_234.50ms	_{p=0.576 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.39ms (± 0.18%)}	_{209.34ms (± 0.17%)}	_{-0.05ms (- 0.02%)}	_208.52ms	_214.06ms	_{p=0.044 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₈₃₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2023-02-18T07:25:35Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52836/merge:

Something interesting changed - please have a look.

Details

refined-github/refined-github

tsconfig.json

error TS2322: Type 'false' is not assignable to type 'Partial<{ actionUrl: string; customCSS: string; personalToken: string; logging: boolean; logHTTP: boolean; } & { [k: string]: boolean; }>[feature:${FeatureID}]'.
- source/helpers/hotfix.tsx#L80

TypeScript Bot (typescript-bot) · 2023-02-18T08:04:23Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52836/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2023-03-14T23:03:12Z

Wesley Wigham (@weswigham) Do you have any commentary on this in general? I'm doubting my choice here; it does allow you to write template types that contain intersections, which, you can only use by creating more template literals (as in my Path example).

However, I'm somewhat wondering if I should instead be treating these like unions, i.e. expand them out at the top where if you have say `a${A & B}b`, that it turns into `a${A}b` & `a${B}b`.

Wesley Wigham (weswigham)

Do you have any commentary on this in general? I'm doubting my choice here; it does allow you to write template types that contain intersections, which, you can only use by creating more template literals (as in my Path example).

Hm, I think only being able to interact with branded holes with other branded types is kinda the point of branding your literal types. Simultaneously, today you can use a template literal to "unbrand" a branded type (I don't know how prevalent that is, and, obviously if you look at the prompting issue, it isn't desirable to some). I'm not crushed by replacing the "unbranding" behavior with respecting brands, though, since you can also "unbrand" a branded literal type with something like

typeUnbrand<T,TBrand>=Textends infer Q&TBrand ? Q : never;typeQ=Unbrand<"a"&{ok: any},{ok: any}>;

which is, IMO, better, since you have to specify what brands you're removing from the type.

However, I'm somewhat wondering if I should instead be treating these like unions, i.e. expand them out at the top where if you have say a${A & B}b, that it turns into a${A}b & a${B}b.

No, I don't think that's right - intersected literals always become never, so the only meaningful intersections are branded literals. So if you split the brand and the literal apart, you'd have an object alone inside a template hole, like making a/${"b" & {path:any}}/c into a/b/c & a/${{path:any}}/c, and that later type has basically no meaning (in fact, by current rules, it just makes the type into string, which'll then evaporate entirely) - it's only useful when you consider it with what it's intersected with anyway.

Jake Bailey (jakebailey) · 2023-03-16T17:54:45Z

Thanks for the feedback! I've made the changes.

Nathan Shively-Sanders (sandersn) · 2023-03-20T15:40:49Z

This breaks fragmented-store on DT. I'll get more details and file a bug.

Jake Bailey (jakebailey) · 2023-03-20T15:44:21Z

Hm, I could have sworn I ran dt.

Jake Bailey (jakebailey) · 2023-03-20T15:48:20Z

(But, that is why I decided to merge yesterday afternoon; so I could get this feedback sooner rather than later.)

Jake Bailey (jakebailey) added 4 commits February 17, 2023 21:26

Add test
0c18a81

Add new test
1dd84d2

Revert PR 48044
8b1f1e5

Implement new fix for intersections
bb599af

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey)Feb 18, 2023

TypeScript Bot (typescript-bot) added the Author: Team label Feb 18, 2023

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 18, 2023

Remove TODO
1f07f63

This comment was marked as outdated.
Sign in to view

Jake Bailey (jakebailey) mentioned this pull request Feb 18, 2023
Performance regression from #48044 #52345
Closed

TypeScript Bot (typescript-bot) added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 18, 2023

Jake Bailey (jakebailey) added 2 commits February 18, 2023 10:08

Add new failing test from top100
8528a63

Add objectFlags to TemplateLiteral in order to propagate generic-ness
8d55d27

This comment was marked as outdated.
Sign in to view

Jake Bailey (jakebailey) marked this pull request as draft March 7, 2023 23:50

Wesley Wigham (weswigham) approved these changes Mar 14, 2023
View reviewed changes

Wesley Wigham (weswigham) requested changes Mar 14, 2023
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

Jake Bailey (jakebailey) added 2 commits March 14, 2023 16:08

Merge branch 'main' into fix-52345
014bf02

PR feedback maybe
026cd53

Jake Bailey (jakebailey) marked this pull request as ready for review March 14, 2023 23:53

Jake Bailey (jakebailey) requested a review from Wesley Wigham (weswigham)March 15, 2023 21:41

Wesley Wigham (weswigham) reviewed Mar 16, 2023
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated
Comment threadsrc/compiler/checker.ts Outdated

Jake Bailey (jakebailey) added 2 commits March 16, 2023 10:50

Merge branch 'main' into fix-52345
27ae967

PR feedback
15e3676

Jake Bailey (jakebailey) requested a review from Wesley Wigham (weswigham)March 16, 2023 20:51

Wesley Wigham (weswigham) approved these changes Mar 19, 2023
View reviewed changes

TypeScript Bot (typescript-bot) added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 20, 2023

Jake Bailey (jakebailey) merged commit 716b592 into microsoft:mainMar 20, 2023

Jake Bailey (jakebailey) deleted the fix-52345 branch March 20, 2023 02:48

Nathan Shively-Sanders (sandersn) mentioned this pull request Mar 20, 2023
#52836 breaks fragmented-store on DT #53382
Closed

This was referenced Mar 20, 2023
Remove incorrect handling of intersections in getStringMappingType #53383
Merged
Incorrect handling of template literals + intersections #53427
Closed

Jake Bailey (jakebailey) mentioned this pull request Jun 15, 2023
5.1.3 new "feature"? Branded types are preserved in const template literal #54648
Closed

Godai Takashina (sankantsu) mentioned this pull request Sep 24, 2023
Intrinsic string mapping type with type parameters is incorrectly resolved in conditional types #55847
Closed

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Nov 16, 2023
Design Meeting Notes, 11/15/2023 #56437
Closed

Hans Brende (HansBrende) mentioned this pull request Feb 2, 2025
Type containing templated, branded string is not assignable to itself #61098
Closed

Hans Brende (HansBrende) mentioned this pull request Mar 19, 2025
Fix #61098 #61113
Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Jake Bailey (jakebailey) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 18, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

TypeScript Bot (typescript-bot) commented Feb 18, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023

Compiler

TSServer

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023

refined-github/refined-github

tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023

Uh oh!

This comment was marked as outdated.

Uh oh!

Jake Bailey (jakebailey) commented Mar 14, 2023

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Mar 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 20, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 20, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jake Bailey (jakebailey) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 18, 2023•
edited
Loading

Jake Bailey (jakebailey) commented Mar 16, 2023•
edited
Loading