Exclude special index signature rule from strict subtype relation by ahejlsberg · Pull Request #53388 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2023-03-20T18:16:33Z

Anders Hejlsberg (ahejlsberg) · 2023-03-20T18:17:12Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2023-03-20T18:17:14Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at ae63c73. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T18:17:14Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at ae63c73. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T18:17:14Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at ae63c73. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-20T18:17:14Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at ae63c73. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T18:17:15Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at ae63c73. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T18:54:52Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/53388/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-03-20T20:11:31Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2023-03-20T20:27:31Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/53388/merge:

Something interesting changed - please have a look.

Details

typeorm/typeorm

tsconfig.json

error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'any[] | FindOptionsWhere<any>'.

TypeScript Bot (typescript-bot) · 2023-03-21T11:39:43Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53388

_Metric	_main	₅₃₃₈₈	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,070k (± 0.01%)}	_{361,067k (± 0.01%)}	_~	_361,029k	_361,111k	_{p=1.000 n=6}
_{Parse Time}	_{3.54s (± 0.70%)}	_{3.51s (± 0.49%)}	_{-0.03s (- 0.94%)}	_3.49s	_3.53s	_{p=0.018 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.48s (± 0.30%)}	_{9.46s (± 0.33%)}	_~	_9.42s	_9.51s	_{p=0.252 n=6}
_{Emit Time}	_{7.89s (± 0.49%)}	_{7.94s (± 0.72%)}	_~	_7.88s	_8.04s	_{p=0.171 n=6}
_{Total Time}	_{22.10s (± 0.17%)}	_{22.09s (± 0.29%)}	_~	_22.00s	_22.19s	_{p=0.627 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,554k (± 0.02%)}	_{192,500k (± 0.02%)}	_~	_192,422k	_192,532k	_{p=0.078 n=6}
_{Parse Time}	_{1.59s (± 0.40%)}	_{1.60s (± 0.85%)}	_~	_1.58s	_1.62s	_{p=0.388 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.50%)}	_~	_0.82s	_0.83s	_{p=1.000 n=6}
_{Check Time}	_{10.12s (± 0.35%)}	_{10.19s (± 0.58%)}	_{+0.07s (+ 0.64%)}	_10.11s	_10.29s	_{p=0.029 n=6}
_{Emit Time}	_{2.98s (± 1.01%)}	_{2.99s (± 0.62%)}	_~	_2.97s	_3.02s	_{p=0.686 n=6}
_{Total Time}	_{15.52s (± 0.35%)}	_{15.60s (± 0.35%)}	_{+0.08s (+ 0.52%)}	_15.52s	_15.67s	_{p=0.045 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,564k (± 0.01%)}	_{345,561k (± 0.00%)}	_~	_345,534k	_345,576k	_{p=0.688 n=6}
_{Parse Time}	_{2.73s (± 0.54%)}	_{2.72s (± 0.30%)}	_~	_2.71s	_2.73s	_{p=0.677 n=6}
_{Bind Time}	_{1.09s (± 0.69%)}	_{1.09s (± 1.07%)}	_~	_1.08s	_1.11s	_{p=0.796 n=6}
_{Check Time}	_{7.70s (± 0.38%)}	_{7.71s (± 0.34%)}	_~	_7.68s	_7.74s	_{p=0.520 n=6}
_{Emit Time}	_{4.45s (± 0.78%)}	_{4.46s (± 0.80%)}	_~	_4.43s	_4.53s	_{p=0.686 n=6}
_{Total Time}	_{15.97s (± 0.48%)}	_{15.98s (± 0.34%)}	_~	_15.93s	_16.07s	_{p=0.687 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,781k (± 0.01%)}	_{299,809k (± 0.01%)}	_{+28k (+ 0.01%)}	_299,769k	_299,834k	_{p=0.045 n=6}
_{Parse Time}	_{2.17s (± 0.47%)}	_{2.18s (± 0.79%)}	_~	_2.16s	_2.20s	_{p=0.452 n=6}
_{Bind Time}	_{1.25s (± 0.84%)}	_{1.24s (± 1.35%)}	_~	_1.22s	_1.26s	_{p=0.742 n=6}
_{Check Time}	_{7.16s (± 0.42%)}	_{7.19s (± 0.73%)}	_~	_7.14s	_7.26s	_{p=0.629 n=6}
_{Emit Time}	_{4.35s (± 1.03%)}	_{4.36s (± 0.91%)}	_~	_4.31s	_4.42s	_{p=0.687 n=6}
_{Total Time}	_{14.93s (± 0.30%)}	_{14.97s (± 0.58%)}	_~	_14.87s	_15.11s	_{p=0.571 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,415k (± 0.01%)}	_{476,455k (± 0.01%)}	_~	_476,380k	_476,530k	_{p=0.173 n=6}
_{Parse Time}	_{3.22s (± 0.42%)}	_{3.23s (± 0.36%)}	_~	_3.22s	_3.25s	_{p=0.113 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.95s (± 0.88%)}	_~	_0.95s	_0.97s	_{p=0.533 n=6}
_{Check Time}	_{17.97s (± 0.37%)}	_{17.92s (± 0.36%)}	_~	_17.81s	_17.99s	_{p=0.261 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.14s (± 0.36%)}	_{22.10s (± 0.34%)}	_~	_21.98s	_22.19s	_{p=0.336 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,611k (± 0.02%)}	_{550,568k (± 0.02%)}	_~	_550,501k	_550,756k	_{p=0.336 n=6}
_{Parse Time}	_{3.95s (± 0.26%)}	_{3.96s (± 0.35%)}	_~	_3.95s	_3.98s	_{p=0.086 n=6}
_{Bind Time}	_{1.79s (± 0.30%)}	_{1.81s (± 0.45%)}	_{+0.01s (+ 0.65%)}	_1.80s	_1.82s	_{p=0.025 n=6}
_{Check Time}	_{3.01s (± 0.61%)}	_{3.01s (± 0.50%)}	_~	_2.99s	_3.03s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.85s (± 0.25%)}	_{8.88s (± 0.21%)}	_~	_8.86s	_8.91s	_{p=0.086 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₈₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Anders Hejlsberg (ahejlsberg) · 2023-03-21T14:51:52Z

Tests and performance are unchanged, except for a new error in typeorm. In that code, FindOptionsWhere<any> is resolved to { [x: string]: any }. The error is caused by the fact that any[] is no longer a strict subtype of { [x: string]: any }, so the type in the false branch becomes any[] | FindOptionsWhere<any>, correctly revealing that where might be a zero length array in the false branch. So, new error seems entirely reasonable.

Daniel Rosenwasser (DanielRosenwasser) · 2023-03-22T22:13:48Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-03-22T22:13:50Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at ae63c73. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-22T22:15:23Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/150747/artifacts?artifactName=tgz&fileId=9EB6E7523EC88284C829E71D1C2E037D04E39129FD4B4A6E11C3B33AB1354E9102&fileName=/typescript-5.1.0-insiders.20230322.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53388-13".;

Daniel Rosenwasser (DanielRosenwasser) · 2023-03-22T22:18:45Z

Anders Hejlsberg (@ahejlsberg) sounds like what you're saying is that TypeORM is supposed to still handle the 0-length case, and can do so by

Would you be able to add an equivalentish test case to document this?

functionfoo(obj: Record<string,any>|Record<string,any>[]){if(Array.isArray(obj)&&obj.length){for(letkeyinobj){if(obj[key]!==undefined){console.log(obj[key])}}}else{for(letkeyinobj){if(obj[key]!==undefined){console.log(obj[key])}}}}functionbar(obj: Record<string,any>|Record<string,any>[]){if(Array.isArray(obj)){for(letkeyinobj){if(obj[key]!==undefined){console.log(obj[key])}}}else{for(letkeyinobj){if(obj[key]!==undefined){console.log(obj[key])}}}}

Daniel Rosenwasser (DanielRosenwasser) · 2023-03-22T22:39:39Z

Confirmed in the test playground that foo has errors, but bar is fine.

Daniel Rosenwasser (DanielRosenwasser) · 2023-03-22T22:43:39Z

I've added the tests, I'm running a task to update the baselines.

Daniel Rosenwasser (DanielRosenwasser) · 2023-03-22T23:50:47Z

the heck?

Daniel Rosenwasser (DanielRosenwasser) · 2023-03-22T23:55:15Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.0

TypeScript Bot (typescript-bot) · 2023-03-22T23:55:19Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-5.0 on this PR at 37911f8. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-22T23:59:48Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #53445 for you.

Component commits: e2aa5c6 Exclude special index signature rule from strict subtype relation ae63c73 Add tests 54703cd Add more test cases. 37911f8 Accepted baselines.

…e-5.0 (#53445) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

…to release-5.0 (microsoft#53445) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

Anders Hejlsberg (ahejlsberg) added 2 commits March 20, 2023 10:27

Exclude special index signature rule from strict subtype relation
e2aa5c6

Add tests
ae63c73

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg)Mar 20, 2023

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 20, 2023

Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser) and Ryan Cavanaugh (RyanCavanaugh)March 20, 2023 18:18

Anders Hejlsberg (ahejlsberg) added this to the TypeScript 5.0.3 milestone Mar 20, 2023

Add more test cases.
54703cd

Accepted baselines.
37911f8

Daniel Rosenwasser (DanielRosenwasser)force-pushed the fix53379 branch from 7f4fd9c to 37911f8Compare March 22, 2023 23:54

Daniel Rosenwasser (DanielRosenwasser) approved these changes Mar 22, 2023
View reviewed changes

TypeScript Bot (typescript-bot) mentioned this pull request Mar 22, 2023
🤖 Pick PR #53388 (Exclude special index signature rul...) into release-5.0 #53445
Merged

Anders Hejlsberg (ahejlsberg) merged commit 25550bd into mainMar 23, 2023

Anders Hejlsberg (ahejlsberg) deleted the fix53379 branch March 23, 2023 14:03

Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Mar 23, 2023
🤖 Pick PR#53388(Exclude special index signature rul...) into releas…
e34eaff
…e-5.0 (#53445) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
🤖 Pick PRmicrosoft#53388(Exclude special index signature rul...) in…
850a9bf
…to release-5.0 (microsoft#53445) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Anders Hejlsberg (ahejlsberg) commented Mar 20, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023

typeorm/typeorm

tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 22, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 22, 2023•
edited
Loading

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 22, 2023•
edited
Loading