Skip to content

Retry string completions from the inferred type by default - #53481

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:mainfrom
Andarist:fix/53475
Mar 28, 2023
Merged

Retry string completions from the inferred type by default#53481
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:mainfrom
Andarist:fix/53475

Conversation

@Andarist

@AndaristMateusz Burzyński (Andarist) commented Mar 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

fixes#53475

I'm using the same strategy to retry those requests as the one used in https://github.com/microsoft/TypeScript/pull/52875/files

cc Andrew Branch (@andrewbranch)

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 23, 2023
Andarist
Mateusz Burzyński (Andarist) commented Mar 23, 2023
View reviewed changes
Comment threadsrc/services/stringCompletions.ts
return { kind: StringLiteralCompletionKind.Types, types: literals, isNewIdentifier: false };
default:
return fromContextualType();
return fromContextualType() || fromContextualType(ContextFlags.None);

@AndaristMateusz Burzyński (Andarist)Mar 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a more conservative approach would be to do this:

caseSyntaxKind.ArrayLiteralExpression:
returnfromContextualType()||fromContextualType(ContextFlags.None);
default:
returnfromContextualType();

i went for a broad fix~ but perhaps some node types should not be subjects for those retries?

@jakebailey

Jake Bailey (jakebailey) commented Mar 27, 2023

Copy link
Copy Markdown
Member

Is this something we need to be backporting? Per #53475 (comment) this is a 5.0 regression, so it's probably good to get in before we send it out?

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Mar 27, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at ea75390. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite (tsserver) on this PR at ea75390. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite (tsserver) on this PR at ea75390. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/53481/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53481
Metricmain53481DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used362,330k (± 0.00%)362,346k (± 0.01%)~362,316k362,419kp=0.469 n=6
Parse Time3.37s (± 0.75%)3.36s (± 0.69%)~3.33s3.39sp=0.686 n=6
Bind Time1.12s (± 0.73%)1.11s (± 0.94%)~1.10s1.13sp=0.180 n=6
Check Time8.72s (± 0.74%)8.70s (± 0.65%)~8.64s8.79sp=0.575 n=6
Emit Time7.48s (± 0.47%)7.45s (± 0.66%)~7.38s7.49sp=0.222 n=6
Total Time20.69s (± 0.35%)20.62s (± 0.50%)~20.47s20.77sp=0.295 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used192,705k (± 1.53%)193,574k (± 1.59%)~190,717k196,436kp=0.810 n=6
Parse Time1.51s (± 1.08%)1.50s (± 0.50%)~1.49s1.51sp=0.212 n=6
Bind Time0.77s (± 0.97%)0.78s (± 1.08%)~0.77s0.79sp=0.652 n=6
Check Time9.63s (± 0.60%)9.69s (± 0.39%)~9.63s9.74sp=0.148 n=6
Emit Time2.73s (± 0.89%)2.74s (± 0.88%)~2.71s2.78sp=0.625 n=6
Total Time14.65s (± 0.67%)14.70s (± 0.30%)~14.62s14.75sp=0.226 n=6
Monaco - node (v18.10.0, x64)
Memory used346,414k (± 0.01%)346,445k (± 0.01%)~346,352k346,487kp=0.230 n=6
Parse Time2.58s (± 1.06%)2.60s (± 0.84%)~2.57s2.63sp=0.332 n=6
Bind Time1.01s (± 0.97%)1.00s (± 0.81%)~1.00s1.02sp=0.081 n=6
Check Time7.15s (± 0.39%)7.13s (± 0.21%)~7.11s7.15sp=0.373 n=6
Emit Time4.28s (± 0.63%)4.28s (± 0.78%)~4.24s4.33sp=0.809 n=6
Total Time15.02s (± 0.29%)15.02s (± 0.36%)~14.94s15.10sp=0.747 n=6
TFS - node (v18.10.0, x64)
Memory used300,667k (± 0.01%)300,664k (± 0.00%)~300,652k300,683kp=0.873 n=6
Parse Time2.06s (± 1.23%)2.06s (± 0.66%)~2.04s2.08sp=0.746 n=6
Bind Time1.14s (± 0.66%)1.14s (± 0.71%)~1.13s1.15sp=0.729 n=6
Check Time6.55s (± 0.20%)6.55s (± 0.43%)~6.52s6.59sp=0.936 n=6
Emit Time3.85s (± 1.06%)3.90s (± 0.85%)~3.85s3.94sp=0.092 n=6
Total Time13.60s (± 0.38%)13.65s (± 0.28%)~13.61s13.72sp=0.092 n=6
material-ui - node (v18.10.0, x64)
Memory used477,127k (± 0.00%)477,146k (± 0.01%)~477,027k477,199kp=0.078 n=6
Parse Time3.04s (± 2.30%)3.03s (± 2.52%)~2.93s3.09sp=0.934 n=6
Bind Time0.95s (± 7.95%)0.96s (± 8.51%)~0.90s1.07sp=0.935 n=6
Check Time17.23s (± 0.75%)17.31s (± 0.95%)~17.10s17.46sp=0.261 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.22s (± 0.70%)21.31s (± 0.75%)~21.09s21.46sp=0.336 n=6
xstate - node (v18.10.0, x64)
Memory used553,083k (± 0.03%)553,001k (± 0.03%)~552,817k553,200kp=0.378 n=6
Parse Time3.80s (± 0.64%)3.78s (± 0.36%)~3.76s3.80sp=0.625 n=6
Bind Time1.67s (± 0.82%)1.67s (± 0.33%)~1.67s1.68sp=0.341 n=6
Check Time2.85s (± 1.07%)2.84s (± 0.87%)~2.81s2.87sp=0.469 n=6
Emit Time0.08s (± 0.00%)0.08s (± 0.00%)~0.08s0.08sp=1.000 n=6
Total Time8.40s (± 0.57%)8.38s (± 0.39%)~8.34s8.42sp=0.423 n=6
Angular - node (v16.17.1, x64)
Memory used361,691k (± 0.01%)361,709k (± 0.01%)~361,673k361,741kp=0.230 n=6
Parse Time3.51s (± 0.74%)3.53s (± 0.81%)~3.47s3.55sp=0.295 n=6
Bind Time1.18s (± 0.64%)1.18s (± 0.99%)~1.17s1.20sp=0.734 n=6
Check Time9.50s (± 0.51%)9.56s (± 0.33%)+0.05s (+ 0.58%)9.52s9.60sp=0.036 n=6
Emit Time7.97s (± 0.60%)7.96s (± 1.05%)~7.87s8.08sp=0.630 n=6
Total Time22.16s (± 0.26%)22.23s (± 0.37%)~22.13s22.37sp=0.149 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used193,134k (± 0.74%)194,195k (± 0.94%)~192,505k195,986kp=0.748 n=6
Parse Time1.59s (± 0.47%)1.59s (± 0.97%)~1.56s1.60sp=0.796 n=6
Bind Time0.83s (± 0.66%)0.83s (± 0.62%)~0.82s0.83sp=0.640 n=6
Check Time10.35s (± 0.68%)10.37s (± 0.50%)~10.28s10.43sp=0.629 n=6
Emit Time2.99s (± 0.46%)3.00s (± 0.69%)~2.96s3.02sp=0.622 n=6
Total Time15.77s (± 0.42%)15.79s (± 0.37%)~15.72s15.87sp=0.630 n=6
Monaco - node (v16.17.1, x64)
Memory used345,726k (± 0.00%)345,719k (± 0.01%)~345,692k345,743kp=0.810 n=6
Parse Time2.74s (± 0.71%)2.72s (± 0.66%)~2.70s2.75sp=0.143 n=6
Bind Time1.08s (± 0.48%)1.09s (± 0.77%)~1.08s1.10sp=0.923 n=6
Check Time7.82s (± 0.53%)7.81s (± 0.21%)~7.79s7.83sp=0.935 n=6
Emit Time4.48s (± 1.06%)4.46s (± 1.03%)~4.42s4.54sp=0.629 n=6
Total Time16.12s (± 0.40%)16.08s (± 0.17%)~16.05s16.11sp=0.375 n=6
TFS - node (v16.17.1, x64)
Memory used300,032k (± 0.01%)300,019k (± 0.01%)~299,996k300,039kp=0.173 n=6
Parse Time2.17s (± 1.03%)2.18s (± 0.73%)~2.16s2.20sp=0.517 n=6
Bind Time1.24s (± 0.51%)1.25s (± 1.31%)~1.23s1.27sp=0.615 n=6
Check Time7.22s (± 0.46%)7.22s (± 0.43%)~7.18s7.27sp=0.871 n=6
Emit Time4.35s (± 0.48%)4.36s (± 0.71%)~4.32s4.41sp=0.514 n=6
Total Time14.98s (± 0.45%)15.01s (± 0.26%)~14.95s15.07sp=0.627 n=6
material-ui - node (v16.17.1, x64)
Memory used476,467k (± 0.01%)476,441k (± 0.00%)~476,425k476,464kp=0.173 n=6
Parse Time3.23s (± 0.58%)3.22s (± 0.41%)~3.21s3.24sp=0.113 n=6
Bind Time0.95s (± 0.43%)0.95s (± 0.43%)~0.95s0.96sp=1.000 n=6
Check Time18.29s (± 0.58%)18.32s (± 0.53%)~18.21s18.44sp=0.810 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.48s (± 0.49%)22.49s (± 0.47%)~22.39s22.63sp=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used550,569k (± 0.02%)550,617k (± 0.03%)~550,414k550,868kp=0.575 n=6
Parse Time3.94s (± 0.50%)3.94s (± 0.55%)~3.92s3.97sp=0.935 n=6
Bind Time1.76s (± 0.46%)1.76s (± 0.69%)~1.74s1.77sp=0.787 n=6
Check Time3.08s (± 0.57%)3.08s (± 0.46%)~3.06s3.10sp=0.807 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time8.88s (± 0.37%)8.88s (± 0.32%)~8.82s8.90sp=0.871 n=6
Angular - node (v14.15.1, x64)
Memory used355,554k (± 0.01%)355,550k (± 0.00%)~355,538k355,564kp=0.630 n=6
Parse Time3.63s (± 0.67%)3.65s (± 0.59%)~3.61s3.66sp=0.245 n=6
Bind Time1.22s (± 0.62%)1.22s (± 1.20%)~1.21s1.24sp=0.803 n=6
Check Time9.90s (± 0.24%)9.91s (± 0.56%)~9.84s9.99sp=0.872 n=6
Emit Time8.37s (± 0.83%)8.41s (± 0.56%)~8.35s8.49sp=0.327 n=6
Total Time23.13s (± 0.45%)23.19s (± 0.34%)~23.11s23.32sp=0.148 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used187,793k (± 0.02%)187,779k (± 0.01%)~187,763k187,801kp=0.574 n=6
Parse Time1.61s (± 0.32%)1.60s (± 0.86%)~1.59s1.62sp=0.933 n=6
Bind Time0.86s (± 0.64%)0.85s (± 0.60%)~0.85s0.86sp=0.640 n=6
Check Time10.48s (± 0.36%)10.46s (± 0.39%)~10.41s10.53sp=0.280 n=6
Emit Time3.16s (± 1.77%)3.13s (± 0.44%)~3.10s3.14sp=0.183 n=6
Total Time16.10s (± 0.49%)16.05s (± 0.35%)~15.98s16.14sp=0.171 n=6
Monaco - node (v14.15.1, x64)
Memory used340,629k (± 0.01%)340,614k (± 0.01%)~340,569k340,655kp=0.298 n=6
Parse Time2.85s (± 0.72%)2.84s (± 0.43%)~2.82s2.85sp=0.462 n=6
Bind Time1.10s (± 0.00%)1.09s (± 0.50%)~1.09s1.10sp=0.071 n=6
Check Time8.16s (± 0.30%)8.18s (± 0.61%)~8.12s8.24sp=0.292 n=6
Emit Time4.71s (± 0.73%)4.72s (± 0.31%)~4.70s4.74sp=0.566 n=6
Total Time16.82s (± 0.33%)16.84s (± 0.30%)~16.78s16.90sp=0.520 n=6
TFS - node (v14.15.1, x64)
Memory used295,078k (± 0.00%)295,088k (± 0.00%)~295,076k295,099kp=0.064 n=6
Parse Time2.40s (± 0.34%)2.39s (± 0.78%)~2.37s2.42sp=0.617 n=6
Bind Time1.07s (± 0.70%)1.07s (± 0.48%)~1.06s1.07sp=0.784 n=6
Check Time7.53s (± 0.50%)7.52s (± 0.23%)~7.50s7.55sp=0.808 n=6
Emit Time4.30s (± 0.77%)4.31s (± 0.91%)~4.27s4.38sp=0.514 n=6
Total Time15.29s (± 0.45%)15.30s (± 0.27%)~15.25s15.35sp=0.872 n=6
material-ui - node (v14.15.1, x64)
Memory used471,970k (± 0.01%)471,994k (± 0.00%)~471,965k472,016kp=0.471 n=6
Parse Time3.37s (± 0.58%)3.37s (± 0.49%)~3.34s3.39sp=0.935 n=6
Bind Time0.99s (± 0.82%)1.00s (± 0.82%)~0.99s1.01sp=0.666 n=6
Check Time19.14s (± 0.93%)19.31s (± 0.70%)~19.09s19.45sp=0.127 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.50s (± 0.83%)23.68s (± 0.54%)~23.45s23.79sp=0.148 n=6
xstate - node (v14.15.1, x64)
Memory used539,167k (± 0.00%)539,185k (± 0.00%)~539,164k539,204kp=0.128 n=6
Parse Time4.23s (± 0.71%)4.22s (± 0.95%)~4.17s4.29sp=0.747 n=6
Bind Time1.66s (± 0.62%)1.67s (± 0.62%)~1.65s1.68sp=0.560 n=6
Check Time3.19s (± 0.86%)3.19s (± 0.71%)~3.17s3.22sp=0.806 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time9.17s (± 0.47%)9.16s (± 0.44%)~9.11s9.22sp=0.936 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current534816
Baselinemain6

TSServer

Comparison Report - main..53481
Metricmain53481DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,396ms (± 0.46%)2,398ms (± 0.90%)~2,376ms2,436msp=0.748 n=6
Req 2 - geterr5,528ms (± 0.35%)5,580ms (± 0.45%)+52ms (+ 0.94%)5,547ms5,622msp=0.005 n=6
Req 3 - references337ms (± 1.85%)336ms (± 0.55%)~333ms338msp=0.685 n=6
Req 4 - navto280ms (± 0.42%)281ms (± 0.58%)~278ms283msp=0.511 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo83ms (± 2.41%)84ms (± 0.90%)~83ms85msp=0.652 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,511ms (± 1.54%)2,522ms (± 1.54%)~2,466ms2,581msp=0.689 n=6
Req 2 - geterr4,056ms (± 0.60%)4,086ms (± 1.06%)~4,028ms4,132msp=0.230 n=6
Req 3 - references349ms (± 1.19%)351ms (± 0.81%)~346ms354msp=0.373 n=6
Req 4 - navto290ms (± 0.60%)290ms (± 0.68%)~287ms293msp=0.328 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo81ms (± 2.90%)82ms (± 3.40%)~79ms85msp=0.374 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,995ms (± 0.57%)3,008ms (± 0.52%)~2,983ms3,025msp=0.229 n=6
Req 2 - geterr1,693ms (± 1.21%)1,709ms (± 1.48%)~1,669ms1,746msp=0.467 n=6
Req 3 - references107ms (± 2.00%)106ms (± 0.60%)~105ms107msp=0.654 n=6
Req 4 - navto356ms (± 0.46%)358ms (± 0.33%)+2ms (+ 0.66%)356ms359msp=0.035 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo384ms (± 1.05%)387ms (± 4.34%)~372ms418msp=1.000 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,500ms (± 1.11%)2,502ms (± 0.77%)~2,479ms2,525msp=0.810 n=6
Req 2 - geterr5,926ms (± 0.63%)5,923ms (± 0.44%)~5,896ms5,960msp=0.810 n=6
Req 3 - references344ms (± 0.40%)345ms (± 0.70%)~340ms347msp=0.252 n=6
Req 4 - navto279ms (± 0.39%)278ms (± 0.53%)~277ms280msp=0.287 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo74ms (± 0.55%)74ms (± 1.33%)~73ms75msp=0.930 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,685ms (± 0.80%)2,693ms (± 0.56%)~2,665ms2,706msp=0.296 n=6
Req 2 - geterr4,419ms (± 0.34%)4,424ms (± 0.60%)~4,383ms4,454msp=0.575 n=6
Req 3 - references365ms (± 0.36%)364ms (± 0.70%)~360ms367msp=0.515 n=6
Req 4 - navto288ms (± 0.41%)287ms (± 0.41%)~286ms289msp=0.185 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo78ms (± 1.78%)79ms (± 3.09%)~76ms81msp=0.680 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,148ms (± 0.32%)3,140ms (± 0.28%)~3,131ms3,155msp=0.199 n=6
Req 2 - geterr1,855ms (± 0.83%)1,859ms (± 0.75%)~1,840ms1,878msp=0.748 n=6
Req 3 - references113ms (± 1.04%)115ms (± 1.90%)~112ms118msp=0.072 n=6
Req 4 - navto342ms (± 0.57%)341ms (± 0.79%)~337ms344msp=0.681 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo395ms (± 0.59%)397ms (± 0.79%)~393ms401msp=0.145 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,610ms (± 0.46%)2,607ms (± 0.37%)~2,595ms2,617msp=0.630 n=6
Req 2 - geterr6,354ms (± 0.52%)6,383ms (± 0.45%)~6,337ms6,419msp=0.199 n=6
Req 3 - references364ms (± 1.04%)364ms (± 0.77%)~361ms368msp=0.871 n=6
Req 4 - navto286ms (± 2.23%)282ms (± 1.17%)~278ms288msp=0.332 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo96ms (± 3.97%)96ms (± 8.63%)~81ms102msp=0.374 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,819ms (± 0.65%)2,815ms (± 0.36%)~2,798ms2,823msp=0.470 n=6
Req 2 - geterr4,781ms (± 0.34%)4,760ms (± 1.69%)~4,597ms4,812msp=0.575 n=6
Req 3 - references371ms (± 0.23%)379ms (± 4.99%)~369ms417msp=0.358 n=6
Req 4 - navto289ms (± 0.42%)290ms (± 1.76%)~285ms297msp=1.000 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo75ms (± 0.73%)76ms (± 6.96%)~74ms87msp=0.441 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,455ms (± 0.43%)3,463ms (± 0.43%)~3,439ms3,481msp=0.298 n=6
Req 2 - geterr1,881ms (± 0.98%)1,889ms (± 0.86%)~1,857ms1,900msp=0.686 n=6
Req 3 - references125ms (± 0.41%)126ms (± 1.10%)~124ms127msp=0.351 n=6
Req 4 - navto371ms (± 0.63%)373ms (± 0.63%)~368ms374msp=0.405 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo408ms (± 0.78%)410ms (± 0.56%)~408ms414msp=0.168 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current534816
Baselinemain6

Startup

Comparison Report - main..53481
Metricmain53481DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time141.69ms (± 0.25%)141.88ms (± 0.37%)~140.87ms147.76msp=0.403 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time228.60ms (± 0.48%)231.59ms (± 0.19%)+3.00ms (+ 1.31%)228.77ms235.88msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time229.18ms (± 0.29%)232.39ms (± 0.24%)+3.21ms (+ 1.40%)227.87ms240.17msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time209.20ms (± 0.19%)212.95ms (± 0.20%)+3.75ms (+ 1.79%)211.64ms219.34msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current534816
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/53481/merge:

Everything looks good!

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Mar 28, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.0

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-5.0 on this PR at ea75390. You can monitor the build here.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Mar 28, 2023

Copy link
Copy Markdown
Member

I'll tentatively cherry-pick.

@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Mar 28, 2023
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #53551 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 28, 2023
@Andarist@typescript-bot
Cherry-pick PRmicrosoft#53481into release-5.0
34ae624
Component commits:
ea75390 Retry string completions from the inferred type by default
@Andarist

Mateusz Burzyński (Andarist) commented Mar 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks guys!

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Mar 28, 2023
TypeScript Bot@Andarist
🤖 Pick PR#53481(Retry string completions from the i...) into releas…
1e70bb8
…e-5.0 (#53551)
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@AndaristMateusz Burzyński (Andarist) mentioned this pull request Apr 24, 2023
Merged
@AndaristMateusz Burzyński (Andarist) mentioned this pull request May 4, 2023
Merged
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
TypeScript Bot@Andaristdar
🤖 Pick PRmicrosoft#53481(Retry string completions from the i...) in…
69ba323
…to release-5.0 (microsoft#53551)
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes

Assignees

No one assigned

Labels

For Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autocompletion is working in TS 4.7 to 4.9 but broken/gone in TS 5

5 participants

@Andarist@jakebailey@DanielRosenwasser@typescript-bot@andrewbranch