Reset type resolution stack when starting to compute variance by gabritto · Pull Request #53549 · microsoft/TypeScript

Gabriela Araujo Britto (gabritto) · 2023-03-27T21:57:29Z

Gabriela Araujo Britto (gabritto) · 2023-03-27T21:59:25Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite (tsserver) on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the perf test suite on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the extended test suite on this PR at 3a2bbb3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-27T21:59:27Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite (tsserver) on this PR at 3a2bbb3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-27T22:11:57Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/53549/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[MISSING] error TS7023: '_get' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
- lib/util/WeakTupleMap.js#L136

TypeScript Bot (typescript-bot) · 2023-03-27T22:14:10Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/53549/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-03-27T23:34:02Z

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2023-03-28T00:05:10Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/53549/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-03-28T01:17:09Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/53549/merge:

Something interesting changed - please have a look.

Details

vercel/hyper

⚠️ Note that built had errors ⚠️

Timed out after 600000 ms

🎉 New server no longer has errors 🎉

Jake Bailey (jakebailey) · 2023-03-28T03:34:39Z

Huh, does the previous comment imply that 5.0 is hanging in this repo?

Jake Bailey (jakebailey) · 2023-03-28T03:44:47Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-03-28T03:44:49Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 3a2bbb3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-28T03:46:30Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/151176/artifacts?artifactName=tgz&fileId=8D2E46C8B9243D607A68134078111BDC43ED99DC561A23F409F340BCA9DE1C6002&fileName=/typescript-5.1.0-insiders.20230328.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53549-16".;

Jake Bailey (jakebailey) · 2023-03-28T03:53:37Z

So, testing, this seems to almost fix #52892. Compare:

Before: Playground Link
After: Playground Link

Some of the errors go away, which is good, but uncommenting that static block still seems to change the result. Not sure why exactly, but it at least an improvement.

TypeScript Bot (typescript-bot) · 2023-03-28T05:17:07Z

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53549

_Metric	_main	₅₃₅₄₉	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{362,331k (± 0.01%)}	_{362,329k (± 0.01%)}	_~	_362,301k	_362,369k	_{p=0.873 n=6}
_{Parse Time}	_{3.36s (± 0.42%)}	_{3.38s (± 0.58%)}	_{+0.02s (+ 0.74%)}	_3.36s	_3.42s	_{p=0.033 n=6}
_{Bind Time}	_{1.12s (± 0.94%)}	_{1.12s (± 0.00%)}	_~	_1.12s	_1.12s	_{p=0.293 n=6}
_{Check Time}	_{8.69s (± 0.48%)}	_{8.69s (± 0.45%)}	_~	_8.65s	_8.75s	_{p=0.809 n=6}
_{Emit Time}	_{7.52s (± 0.96%)}	_{7.50s (± 1.14%)}	_~	_7.43s	_7.61s	_{p=0.630 n=6}
_{Total Time}	_{20.69s (± 0.55%)}	_{20.70s (± 0.58%)}	_~	_20.60s	_20.91s	_{p=0.936 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,703k (± 1.20%)}	_{192,680k (± 1.50%)}	_~	_190,762k	_196,494k	_{p=0.149 n=6}
_{Parse Time}	_{1.49s (± 1.68%)}	_{1.50s (± 0.70%)}	_~	_1.48s	_1.51s	_{p=0.805 n=6}
_{Bind Time}	_{0.77s (± 0.67%)}	_{0.77s (± 0.53%)}	_~	_0.76s	_0.77s	_{p=0.114 n=6}
_{Check Time}	_{9.58s (± 0.48%)}	_{9.65s (± 0.54%)}	_~	_9.58s	_9.72s	_{p=0.054 n=6}
_{Emit Time}	_{2.73s (± 1.00%)}	_{2.74s (± 0.44%)}	_~	_2.72s	_2.75s	_{p=1.000 n=6}
_{Total Time}	_{14.58s (± 0.29%)}	_{14.65s (± 0.42%)}	_~	_14.57s	_14.73s	_{p=0.066 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,421k (± 0.01%)}	_{346,452k (± 0.01%)}	_~	_346,415k	_346,475k	_{p=0.093 n=6}
_{Parse Time}	_{2.57s (± 1.20%)}	_{2.59s (± 1.21%)}	_~	_2.56s	_2.63s	_{p=0.468 n=6}
_{Bind Time}	_{1.01s (± 0.97%)}	_{1.01s (± 0.81%)}	_~	_1.00s	_1.02s	_{p=0.862 n=6}
_{Check Time}	_{7.15s (± 0.46%)}	_{7.13s (± 0.48%)}	_~	_7.08s	_7.17s	_{p=0.288 n=6}
_{Emit Time}	_{4.26s (± 1.19%)}	_{4.25s (± 0.73%)}	_~	_4.21s	_4.29s	_{p=0.630 n=6}
_{Total Time}	_{14.99s (± 0.65%)}	_{14.98s (± 0.47%)}	_~	_14.89s	_15.09s	_{p=0.936 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,677k (± 0.01%)}	_{300,663k (± 0.01%)}	_~	_300,633k	_300,686k	_{p=0.423 n=6}
_{Parse Time}	_{2.06s (± 0.80%)}	_{2.07s (± 0.71%)}	_~	_2.05s	_2.09s	_{p=0.188 n=6}
_{Bind Time}	_{1.14s (± 0.72%)}	_{1.14s (± 0.72%)}	_~	_1.13s	_1.15s	_{p=0.787 n=6}
_{Check Time}	_{6.53s (± 0.45%)}	_{6.55s (± 0.28%)}	_~	_6.52s	_6.57s	_{p=0.418 n=6}
_{Emit Time}	_{3.85s (± 0.91%)}	_{3.85s (± 0.95%)}	_~	_3.80s	_3.91s	_{p=0.935 n=6}
_{Total Time}	_{13.57s (± 0.39%)}	_{13.61s (± 0.34%)}	_~	_13.53s	_13.66s	_{p=0.258 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{477,185k (± 0.01%)}	_{477,180k (± 0.00%)}	_~	_477,150k	_477,199k	_{p=0.378 n=6}
_{Parse Time}	_{3.03s (± 2.23%)}	_{2.98s (± 2.38%)}	_~	_2.92s	_3.10s	_{p=0.376 n=6}
_{Bind Time}	_{0.93s (± 6.84%)}	_{1.01s (± 7.20%)}	_~	_0.92s	_1.08s	_{p=0.052 n=6}
_{Check Time}	_{17.14s (± 0.43%)}	_{17.28s (± 1.14%)}	_~	_17.09s	_17.63s	_{p=0.198 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.09s (± 0.35%)}	_{21.27s (± 1.05%)}	_~	_21.03s	_21.64s	_{p=0.128 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{552,950k (± 0.01%)}	_{553,027k (± 0.02%)}	_~	_552,802k	_553,139k	_{p=0.230 n=6}
_{Parse Time}	_{3.75s (± 0.73%)}	_{3.79s (± 0.49%)}	_~	_3.76s	_3.81s	_{p=0.062 n=6}
_{Bind Time}	_{1.66s (± 0.54%)}	_{1.67s (± 0.50%)}	_~	_1.65s	_1.67s	_{p=0.339 n=6}
_{Check Time}	_{2.83s (± 0.41%)}	_{2.86s (± 0.85%)}	_~	_2.83s	_2.89s	_{p=0.062 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.34s (± 0.32%)}	_{8.39s (± 0.37%)}	_{+0.05s (+ 0.64%)}	_8.35s	_8.44s	_{p=0.019 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,718k (± 0.01%)}	_{361,677k (± 0.01%)}	_{-41k (- 0.01%)}	_361,640k	_361,723k	_{p=0.045 n=6}
_{Parse Time}	_{3.53s (± 0.81%)}	_{3.52s (± 0.64%)}	_~	_3.50s	_3.56s	_{p=0.678 n=6}
_{Bind Time}	_{1.18s (± 0.99%)}	_{1.19s (± 0.69%)}	_~	_1.18s	_1.20s	_{p=0.401 n=6}
_{Check Time}	_{9.51s (± 0.22%)}	_{9.50s (± 0.42%)}	_~	_9.46s	_9.55s	_{p=0.517 n=6}
_{Emit Time}	_{7.96s (± 0.76%)}	_{7.97s (± 0.50%)}	_~	_7.90s	_8.01s	_{p=0.686 n=6}
_{Total Time}	_{22.18s (± 0.37%)}	_{22.18s (± 0.29%)}	_~	_22.10s	_22.28s	_{p=1.000 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,581k (± 0.88%)}	_{193,639k (± 0.86%)}	_~	_192,493k	_195,885k	_{p=0.471 n=6}
_{Parse Time}	_{1.58s (± 1.09%)}	_{1.60s (± 0.47%)}	_~	_1.59s	_1.61s	_{p=0.062 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.282 n=6}
_{Check Time}	_{10.30s (± 0.43%)}	_{10.37s (± 0.74%)}	_~	_10.22s	_10.43s	_{p=0.066 n=6}
_{Emit Time}	_{2.99s (± 0.61%)}	_{2.98s (± 0.54%)}	_~	_2.97s	_3.01s	_{p=0.215 n=6}
_{Total Time}	_{15.70s (± 0.35%)}	_{15.77s (± 0.35%)}	_{+0.07s (+ 0.44%)}	_15.66s	_15.81s	_{p=0.045 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,729k (± 0.01%)}	_{345,776k (± 0.01%)}	_{+47k (+ 0.01%)}	_345,741k	_345,794k	_{p=0.008 n=6}
_{Parse Time}	_{2.72s (± 0.43%)}	_{2.72s (± 0.50%)}	_~	_2.69s	_2.73s	_{p=0.864 n=6}
_{Bind Time}	_{1.08s (± 0.95%)}	_{1.09s (± 0.37%)}	_~	_1.08s	_1.09s	_{p=0.257 n=6}
_{Check Time}	_{7.80s (± 0.44%)}	_{7.84s (± 0.26%)}	_{+0.04s (+ 0.53%)}	_7.81s	_7.87s	_{p=0.030 n=6}
_{Emit Time}	_{4.45s (± 0.39%)}	_{4.48s (± 0.94%)}	_~	_4.42s	_4.54s	_{p=0.226 n=6}
_{Total Time}	_{16.06s (± 0.32%)}	_{16.13s (± 0.27%)}	_{+0.07s (+ 0.42%)}	_16.05s	_16.17s	_{p=0.037 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,020k (± 0.01%)}	_{300,022k (± 0.00%)}	_~	_300,002k	_300,035k	_{p=1.000 n=6}
_{Parse Time}	_{2.16s (± 0.62%)}	_{2.17s (± 0.94%)}	_~	_2.15s	_2.20s	_{p=0.290 n=6}
_{Bind Time}	_{1.24s (± 0.83%)}	_{1.23s (± 0.84%)}	_~	_1.22s	_1.25s	_{p=0.560 n=6}
_{Check Time}	_{7.22s (± 0.73%)}	_{7.20s (± 0.40%)}	_~	_7.16s	_7.24s	_{p=0.520 n=6}
_{Emit Time}	_{4.37s (± 1.05%)}	_{4.38s (± 0.70%)}	_~	_4.34s	_4.42s	_{p=0.687 n=6}
_{Total Time}	_{14.99s (± 0.63%)}	_{14.98s (± 0.32%)}	_~	_14.92s	_15.04s	_{p=0.936 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,458k (± 0.01%)}	_{476,479k (± 0.00%)}	_~	_476,454k	_476,503k	_{p=0.093 n=6}
_{Parse Time}	_{3.22s (± 0.38%)}	_{3.22s (± 0.48%)}	_~	_3.20s	_3.24s	_{p=0.739 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.95s (± 0.00%)}	_~	_0.95s	_0.95s	_{p=0.174 n=6}
_{Check Time}	_{18.21s (± 0.37%)}	_{18.17s (± 0.41%)}	_~	_18.07s	_18.30s	_{p=0.467 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.39s (± 0.28%)}	_{22.34s (± 0.38%)}	_~	_22.23s	_22.49s	_{p=0.422 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,607k (± 0.02%)}	_{550,485k (± 0.02%)}	_{-122k (- 0.02%)}	_550,419k	_550,647k	_{p=0.031 n=6}
_{Parse Time}	_{3.93s (± 0.49%)}	_{3.94s (± 0.44%)}	_~	_3.92s	_3.96s	_{p=0.318 n=6}
_{Bind Time}	_{1.76s (± 0.43%)}	_{1.75s (± 0.29%)}	_~	_1.75s	_1.76s	_{p=0.247 n=6}
_{Check Time}	_{3.09s (± 1.02%)}	_{3.08s (± 0.69%)}	_~	_3.05s	_3.11s	_{p=0.746 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.87s (± 0.60%)}	_{8.87s (± 0.32%)}	_~	_8.84s	_8.91s	_{p=0.685 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{355,570k (± 0.01%)}	_{355,563k (± 0.01%)}	_~	_355,536k	_355,599k	_{p=0.336 n=6}
_{Parse Time}	_{3.62s (± 1.12%)}	_{3.64s (± 1.09%)}	_~	_3.59s	_3.71s	_{p=0.422 n=6}
_{Bind Time}	_{1.22s (± 0.73%)}	_{1.22s (± 0.68%)}	_~	_1.22s	_1.24s	_{p=0.437 n=6}
_{Check Time}	_{9.90s (± 0.36%)}	_{9.93s (± 0.18%)}	_~	_9.91s	_9.95s	_{p=0.089 n=6}
_{Emit Time}	_{8.40s (± 1.18%)}	_{8.41s (± 0.90%)}	_~	_8.33s	_8.51s	_{p=0.873 n=6}
_{Total Time}	_{23.14s (± 0.56%)}	_{23.21s (± 0.49%)}	_~	_23.05s	_23.36s	_{p=0.261 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,789k (± 0.02%)}	_{187,760k (± 0.01%)}	_~	_187,722k	_187,802k	_{p=0.173 n=6}
_{Parse Time}	_{1.59s (± 0.52%)}	_{1.61s (± 0.32%)}	_{+0.01s (+ 0.73%)}	_1.60s	_1.61s	_{p=0.033 n=6}
_{Bind Time}	_{0.85s (± 0.61%)}	_{0.85s (± 0.60%)}	_~	_0.85s	_0.86s	_{p=0.069 n=6}
_{Check Time}	_{10.39s (± 0.25%)}	_{10.54s (± 0.52%)}	_{+0.15s (+ 1.44%)}	_10.45s	_10.62s	_{p=0.005 n=6}
_{Emit Time}	_{3.14s (± 0.63%)}	_{3.15s (± 0.55%)}	_~	_3.12s	_3.17s	_{p=0.368 n=6}
_{Total Time}	_{15.97s (± 0.19%)}	_{16.15s (± 0.40%)}	_{+0.18s (+ 1.13%)}	_16.05s	_16.25s	_{p=0.005 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{340,614k (± 0.01%)}	_{340,628k (± 0.01%)}	_~	_340,580k	_340,677k	_{p=0.521 n=6}
_{Parse Time}	_{2.81s (± 0.29%)}	_{2.84s (± 0.59%)}	_{+0.03s (+ 0.95%)}	_2.81s	_2.85s	_{p=0.026 n=6}
_{Bind Time}	_{1.10s (± 0.74%)}	_{1.10s (± 0.37%)}	_~	_1.09s	_1.10s	_{p=0.584 n=6}
_{Check Time}	_{8.15s (± 0.30%)}	_{8.18s (± 0.54%)}	_~	_8.15s	_8.26s	_{p=0.567 n=6}
_{Emit Time}	_{4.67s (± 0.63%)}	_{4.68s (± 0.65%)}	_~	_4.64s	_4.72s	_{p=0.520 n=6}
_{Total Time}	_{16.73s (± 0.23%)}	_{16.80s (± 0.24%)}	_{+0.07s (+ 0.40%)}	_16.74s	_16.86s	_{p=0.029 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{295,094k (± 0.00%)}	_{295,116k (± 0.00%)}	_{+22k (+ 0.01%)}	_295,108k	_295,124k	_{p=0.008 n=6}
_{Parse Time}	_{2.37s (± 1.12%)}	_{2.39s (± 0.72%)}	_~	_2.36s	_2.41s	_{p=0.188 n=6}
_{Bind Time}	_{1.06s (± 0.00%)}	_{1.06s (± 0.49%)}	_~	_1.06s	_1.07s	_{p=0.174 n=6}
_{Check Time}	_{7.52s (± 0.25%)}	_{7.53s (± 0.25%)}	_~	_7.51s	_7.56s	_{p=0.255 n=6}
_{Emit Time}	_{4.28s (± 0.55%)}	_{4.31s (± 1.30%)}	_~	_4.24s	_4.38s	_{p=0.259 n=6}
_{Total Time}	_{15.23s (± 0.33%)}	_{15.30s (± 0.42%)}	_~	_15.19s	_15.36s	_{p=0.093 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,986k (± 0.01%)}	_{471,974k (± 0.01%)}	_~	_471,935k	_472,009k	_{p=0.689 n=6}
_{Parse Time}	_{3.33s (± 0.49%)}	_{3.37s (± 0.35%)}	_{+0.03s (+ 1.00%)}	_3.35s	_3.38s	_{p=0.012 n=6}
_{Bind Time}	_{0.99s (± 0.90%)}	_{0.99s (± 1.22%)}	_~	_0.98s	_1.01s	_{p=0.676 n=6}
_{Check Time}	_{19.06s (± 0.46%)}	_{19.19s (± 0.50%)}	_{+0.13s (+ 0.69%)}	_19.09s	_19.34s	_{p=0.029 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.38s (± 0.39%)}	_{23.55s (± 0.45%)}	_{+0.17s (+ 0.73%)}	_23.44s	_23.72s	_{p=0.031 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{539,171k (± 0.01%)}	_{539,191k (± 0.01%)}	_~	_539,134k	_539,258k	_{p=0.575 n=6}
_{Parse Time}	_{4.23s (± 0.62%)}	_{4.24s (± 0.49%)}	_~	_4.20s	_4.26s	_{p=0.746 n=6}
_{Bind Time}	_{1.65s (± 0.46%)}	_{1.66s (± 0.54%)}	_~	_1.65s	_1.67s	_{p=0.149 n=6}
_{Check Time}	_{3.19s (± 1.14%)}	_{3.20s (± 0.36%)}	_~	_3.18s	_3.21s	_{p=0.459 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.16s (± 0.54%)}	_{9.19s (± 0.25%)}	_~	_9.15s	_9.21s	_{p=0.521 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₅₄₉	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53549

_Metric	_main	₅₃₅₄₉	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,393ms (± 0.44%)}	_{2,410ms (± 0.68%)}	_~	_2,392ms	_2,427ms	_{p=0.229 n=6}
_{Req 2 - geterr}	_{5,538ms (± 0.48%)}	_{5,545ms (± 0.50%)}	_~	_5,508ms	_5,580ms	_{p=0.688 n=6}
_{Req 3 - references}	_{335ms (± 0.72%)}	_{337ms (± 0.72%)}	_~	_333ms	_340ms	_{p=0.256 n=6}
_{Req 4 - navto}	_{281ms (± 0.65%)}	_{282ms (± 0.54%)}	_~	_280ms	_284ms	_{p=0.402 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 3.56%)}	_{82ms (± 3.72%)}	_~	_78ms	_86ms	_{p=0.935 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,508ms (± 0.93%)}	_{2,528ms (± 1.24%)}	_~	_2,469ms	_2,554ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{4,062ms (± 0.58%)}	_{4,075ms (± 0.52%)}	_~	_4,044ms	_4,103ms	_{p=0.378 n=6}
_{Req 3 - references}	_{349ms (± 0.71%)}	_{348ms (± 0.80%)}	_~	_344ms	_352ms	_{p=0.808 n=6}
_{Req 4 - navto}	_{290ms (± 0.26%)}	_{291ms (± 0.69%)}	_~	_289ms	_294ms	_{p=0.406 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 7.41%)}	_{78ms (± 4.65%)}	_~	_75ms	_84ms	_{p=0.517 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,999ms (± 0.51%)}	_{2,999ms (± 0.57%)}	_~	_2,984ms	_3,028ms	_{p=0.572 n=6}
_{Req 2 - geterr}	_{1,698ms (± 1.90%)}	_{1,700ms (± 1.05%)}	_~	_1,669ms	_1,722ms	_{p=0.688 n=6}
_{Req 3 - references}	_{107ms (± 1.83%)}	_{106ms (± 0.84%)}	_~	_105ms	_107ms	_{p=0.142 n=6}
_{Req 4 - navto}	_{357ms (± 0.45%)}	_{357ms (± 0.51%)}	_~	_354ms	_359ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{384ms (± 0.75%)}	_{382ms (± 1.84%)}	_~	_372ms	_390ms	_{p=0.872 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,504ms (± 0.76%)}	_{2,517ms (± 0.73%)}	_~	_2,482ms	_2,537ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{5,885ms (± 0.45%)}	_{5,899ms (± 0.55%)}	_~	_5,876ms	_5,964ms	_{p=0.689 n=6}
_{Req 3 - references}	_{345ms (± 0.40%)}	_{346ms (± 0.42%)}	_~	_344ms	_348ms	_{p=0.084 n=6}
_{Req 4 - navto}	_{278ms (± 0.53%)}	_{278ms (± 0.32%)}	_~	_277ms	_279ms	_{p=0.804 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 2.45%)}	_{74ms (± 0.55%)}	_~	_73ms	_74ms	_{p=0.390 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,652ms (± 0.44%)}	_{2,685ms (± 0.33%)}	_{+33ms (+ 1.23%)}	_2,668ms	_2,694ms	_{p=0.008 n=6}
_{Req 2 - geterr}	_{4,422ms (± 0.60%)}	_{4,419ms (± 0.62%)}	_~	_4,370ms	_4,448ms	_{p=0.936 n=6}
_{Req 3 - references}	_{364ms (± 0.36%)}	_{364ms (± 0.47%)}	_~	_362ms	_366ms	_{p=0.870 n=6}
_{Req 4 - navto}	_{287ms (± 0.52%)}	_{288ms (± 0.47%)}	_~	_287ms	_290ms	_{p=0.114 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 2.59%)}	_{77ms (± 1.91%)}	_~	_76ms	_80ms	_{p=0.485 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,149ms (± 0.59%)}	_{3,147ms (± 0.40%)}	_~	_3,130ms	_3,167ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,852ms (± 1.75%)}	_{1,847ms (± 0.73%)}	_~	_1,831ms	_1,869ms	_{p=1.000 n=6}
_{Req 3 - references}	_{113ms (± 0.87%)}	_{113ms (± 1.07%)}	_~	_112ms	_115ms	_{p=0.498 n=6}
_{Req 4 - navto}	_{342ms (± 0.61%)}	_{342ms (± 0.44%)}	_~	_341ms	_345ms	_{p=0.570 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{394ms (± 1.15%)}	_{394ms (± 0.98%)}	_~	_390ms	_399ms	_{p=0.870 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,610ms (± 0.50%)}	_{2,602ms (± 0.52%)}	_~	_2,586ms	_2,623ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{6,358ms (± 0.33%)}	_{6,351ms (± 0.34%)}	_~	_6,320ms	_6,377ms	_{p=0.574 n=6}
_{Req 3 - references}	_{364ms (± 0.40%)}	_{365ms (± 0.99%)}	_~	_361ms	_371ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{281ms (± 0.70%)}	_{282ms (± 0.70%)}	_~	_279ms	_285ms	_{p=0.411 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{99ms (± 8.37%)}	_{94ms (± 7.83%)}	_~	_82ms	_101ms	_{p=0.064 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,805ms (± 0.36%)}	_{2,828ms (± 0.51%)}	_{+23ms (+ 0.80%)}	_2,810ms	_2,842ms	_{p=0.013 n=6}
_{Req 2 - geterr}	_{4,791ms (± 0.22%)}	_{4,786ms (± 0.37%)}	_~	_4,768ms	_4,810ms	_{p=0.688 n=6}
_{Req 3 - references}	_{371ms (± 0.48%)}	_{371ms (± 0.31%)}	_~	_370ms	_373ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{289ms (± 1.19%)}	_{291ms (± 1.28%)}	_~	_287ms	_298ms	_{p=0.225 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 1.12%)}	_{74ms (± 1.02%)}	_~	_73ms	_75ms	_{p=0.209 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,453ms (± 0.41%)}	_{3,456ms (± 0.54%)}	_~	_3,427ms	_3,485ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,887ms (± 0.73%)}	_{1,867ms (± 1.10%)}	_~	_1,835ms	_1,894ms	_{p=0.093 n=6}
_{Req 3 - references}	_{125ms (± 0.44%)}	_{127ms (± 1.20%)}	_{+2ms (+ 1.61%)}	_125ms	_129ms	_{p=0.015 n=6}
_{Req 4 - navto}	_{373ms (± 0.24%)}	_{373ms (± 0.63%)}	_~	_370ms	_376ms	_{p=0.806 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{412ms (± 1.43%)}	_{406ms (± 0.77%)}	_~	_403ms	_410ms	_{p=0.090 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₅₄₉	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53549

_Metric	_main	₅₃₅₄₉	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.50ms (± 0.17%)}	_{142.14ms (± 0.21%)}	_{+0.65ms (+ 0.46%)}	_141.32ms	_145.64ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.47ms (± 0.15%)}	_{230.73ms (± 0.47%)}	_{+4.27ms (+ 1.88%)}	_226.86ms	_236.37ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.43ms (± 0.18%)}	_{231.41ms (± 0.39%)}	_{+2.98ms (+ 1.30%)}	_228.36ms	_238.29ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.21ms (± 0.17%)}	_{211.84ms (± 0.36%)}	_{+2.63ms (+ 1.26%)}	_209.00ms	_217.49ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₅₄₉	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Gabriela Araujo Britto (gabritto) · 2023-03-28T17:28:36Z

So, testing, this seems to almost fix #52892. Compare:
Before: Playground Link
After: Playground Link
Some of the errors go away, which is good, but uncommenting that static block still seems to change the result. Not sure why exactly, but it at least an improvement.

That is intriguing. But the correct behavior is to have the one error at A.B<A<T>>, no?

Jake Bailey (jakebailey) · 2023-03-28T17:31:31Z

I don't think so; uncomment the static block and note that the error goes away. But, it could be two issues in one.

Gabriela Araujo Britto (gabritto) · 2023-03-28T17:52:27Z

I don't think so; uncomment the static block and note that the error goes away. But, it could be two issues in one.

I meant to say I think the leftover bug is the fact that the error goes away in the presence of the static block, when it shouldn't go away.

Jake Bailey (jakebailey) · 2023-03-28T17:53:44Z

Ah, yes, correct.

reset type resolution stack when starting to compute variance
3a2bbb3

TypeScript Bot (typescript-bot) assigned Gabriela Araujo Britto (gabritto)Mar 27, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 27, 2023

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Mar 28, 2023
Design Meeting Notes, 3/3/2023 #53083
Closed

Gabriela Araujo Britto (gabritto) changed the title ~~reset type resolution stack when starting to compute variance~~Reset type resolution stack when starting to compute varianceMar 28, 2023

Gabriela Araujo Britto (gabritto) marked this pull request as ready for review March 28, 2023 19:41

Gabriela Araujo Britto (gabritto) requested review from Anders Hejlsberg (ahejlsberg) and Wesley Wigham (weswigham)March 28, 2023 19:41

Wesley Wigham (weswigham) approved these changes Apr 11, 2023
View reviewed changes

Gabriela Araujo Britto (gabritto) merged commit 2db688e into mainApr 11, 2023

Gabriela Araujo Britto (gabritto) deleted the gabritto/issue53470 branch April 11, 2023 21:05

Mateusz Burzyński (Andarist) mentioned this pull request Aug 12, 2024
Defer checking of class static blocks #59607
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Gabriela Araujo Britto (gabritto) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gabriela Araujo Britto (gabritto) commented Mar 27, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023

webpack

tsconfig.types.json

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 27, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 28, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 28, 2023

vercel/hyper

Uh oh!

Jake Bailey (jakebailey) commented Mar 28, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 28, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Mar 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 28, 2023

Compiler

TSServer

Startup

Uh oh!

Gabriela Araujo Britto (gabritto) commented Mar 28, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 28, 2023

Uh oh!

Gabriela Araujo Britto (gabritto) commented Mar 28, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gabriela Araujo Britto (gabritto) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 27, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 28, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 28, 2023•
edited
Loading

Jake Bailey (jakebailey) commented Mar 28, 2023•
edited
Loading