Skip to content

fix: class field is not accessible via super - #54056

Merged
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
Jack-Works:class-field-super
Sep 22, 2023
Merged

fix: class field is not accessible via super#54056
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
Jack-Works:class-field-super

Conversation

@Jack-Works

@Jack-WorksJack Works (Jack-Works) commented Apr 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

fixes#54054
fixes#35314
fixes#54900

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 28, 2023
@Jack-WorksJack Works (Jack-Works) mentioned this pull request Apr 29, 2023
Closed
@typescript-botTypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 29, 2023
@Guergeiro

Breno Salles (Guergeiro) commented Jun 2, 2023

Copy link
Copy Markdown

Just a question, does this handle the JS getter methods? Get methods work with super call in JS.

@Jack-Works

Jack Works (Jack-Works) commented Jun 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Just a question, does this handle the JS getter methods? Get methods work with super call in JS.

Only class fields are affected. getter and setters work normally.

@Jack-Works
Jack Works (Jack-Works)force-pushed the class-field-super branch 3 times, most recently from 8cd587c to 1a3b36bCompareJune 10, 2023 11:30
andrewbranch
Andrew Branch (andrewbranch) requested changes Jun 12, 2023
View reviewed changes
Comment threadtests/baselines/reference/esDecorators-classExpression-classSuper.2.errors.txt Outdated
@jackofsometradeTyrone Warren (jackofsometrade) mentioned this pull request Jul 6, 2023
Closed
@ekilah

Monroe Ekilah (ekilah) commented Jul 6, 2023•
edited
Loading

Copy link
Copy Markdown

I was referred to this fix from my issue:

I believe:

fixes #54900

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 7, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the diff-based top-repos suite on this PR at 2dc49db. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the parallelized Definitely Typed test suite on this PR at 2dc49db. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/54056/merge:

Something interesting changed - please have a look.

Details

appsmithorg/appsmith

7 of 9 projects failed to build with the old tsc and were ignored

app/client/packages/rts/tsconfig.json

microsoft/vscode

5 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Hey Andrew Branch (@andrewbranch), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 7, 2023

Copy link
Copy Markdown
Member

These errors might be interesting to look at.

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 7, 2023

Copy link
Copy Markdown
Member

In appsmith, the code presumably works at runtime because the compile target is es6 where class fields aren’t supported. VS Code uses useDefineForClassFields: false which I assume has the same effect for this context. We could choose to only issue this error when class fields will be untransformed, but (1) the code is wrong even if it will technically work, and (2) we don’t know anything about the emit of dependency code, so it would be better to do this consistently. Since we’re past 5.2-beta, I think we should wait until 5.3 to merge this breaking change.

@andrewbranchAndrew Branch (andrewbranch) added the Breaking Change Would introduce errors in existing code label Jul 7, 2023
@Jack-Works

Jack Works (Jack-Works) commented Jul 8, 2023

Copy link
Copy Markdown
ContributorAuthor

In appsmith, the code presumably works at runtime because the compile target is es6 where class fields aren’t supported. VS Code uses useDefineForClassFields: false which I assume has the same effect for this context. We could choose to only issue this error when class fields will be untransformed, but (1) the code is wrong even if it will technically work, and (2) we don’t know anything about the emit of dependency code, so it would be better to do this consistently. Since we’re past 5.2-beta, I think we should wait until 5.3 to merge this breaking change.

Sorry, I'm confused, in what case it can be valid? I cannot think of a setup that defines a class field on the prototype instead of the instance.

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 10, 2023

Copy link
Copy Markdown
Member

Hm, I assumed that a quirk of the transformation down to ES2015 would make it work somehow, but I think you’re right. Maybe this stuff isn’t working at all? This is very odd 🤔

@sandersn

Nathan Shively-Sanders (sandersn) commented Jul 14, 2023

Copy link
Copy Markdown
Member

Even stranger, the first error, in appsmith, looks like a typo.

sandersn
Nathan Shively-Sanders (sandersn) approved these changes Jul 14, 2023
View reviewed changes

@sandersnNathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this should go into 5.3 to avoid breaking vscode after the 5.2 beta.

In the meantime, I had one small nit about the test, but I'm not 100% what a better solution is.

Comment threadtests/cases/compiler/classFieldSuperNotAccessible.ts Outdated
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 5f818a9 into microsoft:mainSep 22, 2023
@Jack-Works
Jack Works (Jack-Works) deleted the class-field-super branch September 23, 2023 06:55
Marcus Ording (snovader) pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023
@Jack-Works@sandersn@snovader
fix: class field is not accessible via super (microsoft#54056)
4c9bccf
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@andrewbranchAndrew Branch (andrewbranch) mentioned this pull request Sep 26, 2023
Open
This was referenced Sep 26, 2023
Merged
Closed
@AndaristMateusz Burzyński (Andarist) mentioned this pull request Sep 27, 2023
Merged
Open
@LouieK22Martin (LouieK22) mentioned this pull request Feb 14, 2024
Merged
Osyris (osyrisrblx) added a commit to roblox-ts/roblox-ts that referenced this pull request Feb 14, 2024
@LouieK22@osyrisrblx
TypeScript 5.3 (#2617)
2c422eb
- Bumps `typescript` and `ts-expose-internals` to v5.3.3
- Removes the test diagnostic for `noSuperProperty` as the compiler
catches this now (microsoft/TypeScript/pull/54056)
- Make 1:1 changes for methods and fields
- Handles the `NoSubstitutionTemplateLiteral` node from
microsoft/TypeScript/pull/55930
Please take a look at the module resolution change. I'm not sure if this
will have downstream effects that I couldn't catch in testing.
Closes#2610
---------
Co-authored-by: Osyris <osyrisrblx@gmail.com>
Manohar Prajapati (msprajap) pushed a commit to mysql/mysql-shell-plugins that referenced this pull request Jul 1, 2024
@ruiquelhas
BUG#36211402 Avoid field assignment on "super"
667eb98
TypeScript/JavaScript uses prototype-based inheritance where fields are
stored in a flat structure and not in the scope of a particular class
definition in the hierarchy. This means that a field specified by a
parent class can be replaced by one specified by one of the children.
To signal this behaviour, starting in v5.3.0, the TypeScript compiler
prevents a class from assigning values to fields specified by a parent
class using "super"
(microsoft/TypeScript#54056).
This patch, upgrades the TypeScript compiler to the latest version and
fixes the remaining issues related to the topic mentioned above that
now result in compiler errors. Additionally, it also updates the launch
task that runs the compiler to ensure it uses a local version of the
compiler, as specified by the dependency graph of the VSCode Extension
package.
Change-Id: Ib3ef774028ec4587c6b8e5eaa2eb395188e0d5a1
Daniel Fischer (MyDanny) pushed a commit to mysql/mysql-shell-plugins that referenced this pull request Jul 24, 2025
@ruiquelhas
BUG#36211402 Avoid field assignment on "super"
8153aca
TypeScript/JavaScript uses prototype-based inheritance where fields are
stored in a flat structure and not in the scope of a particular class
definition in the hierarchy. This means that a field specified by a
parent class can be replaced by one specified by one of the children.
To signal this behaviour, starting in v5.3.0, the TypeScript compiler
prevents a class from assigning values to fields specified by a parent
class using "super"
(microsoft/TypeScript#54056).
This patch, upgrades the TypeScript compiler to the latest version and
fixes the remaining issues related to the topic mentioned above that
now result in compiler errors. Additionally, it also updates the launch
task that runs the compiler to ensure it uses a local version of the
compiler, as specified by the dependency graph of the VSCode Extension
package.
Change-Id: Ib3ef774028ec4587c6b8e5eaa2eb395188e0d5a1
Daniel Fischer (MyDanny) pushed a commit to mysql/mysql-shell-plugins that referenced this pull request Jul 29, 2025
@ruiquelhas
BUG#36211402 Avoid field assignment on "super"
6ad1973
TypeScript/JavaScript uses prototype-based inheritance where fields are
stored in a flat structure and not in the scope of a particular class
definition in the hierarchy. This means that a field specified by a
parent class can be replaced by one specified by one of the children.
To signal this behaviour, starting in v5.3.0, the TypeScript compiler
prevents a class from assigning values to fields specified by a parent
class using "super"
(microsoft/TypeScript#54056).
This patch, upgrades the TypeScript compiler to the latest version and
fixes the remaining issues related to the topic mentioned above that
now result in compiler errors. Additionally, it also updates the launch
task that runs the compiler to ensure it uses a local version of the
compiler, as specified by the dependency graph of the VSCode Extension
package.
Change-Id: Ib3ef774028ec4587c6b8e5eaa2eb395188e0d5a1
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn approved these changes
@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes
@navya9singhnavya9singhAwaiting requested review from navya9singh
@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Awaiting requested review from DanielRosenwasser

Assignees

@andrewbranchAndrew Branch (andrewbranch)

Labels

Breaking ChangeWould introduce errors in existing codeFor Backlog BugPRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

TypeScript 5.3.0

7 participants

@Jack-Works@Guergeiro@ekilah@andrewbranch@typescript-bot@sandersn@DanielRosenwasser