Skip to content

Handle module node found error reporting in incremental and watch scneario - #54115

Merged
Sheetal Nandi (sheetalkamat) merged 6 commits into
mainfrom
node10Result
May 9, 2023
Merged

Handle module node found error reporting in incremental and watch scneario#54115
Sheetal Nandi (sheetalkamat) merged 6 commits into
mainfrom
node10Result

Conversation

@sheetalkamat

@sheetalkamatSheetal Nandi (sheetalkamat) commented May 3, 2023

Copy link
Copy Markdown
Member

With this, the diagnostic chain has repopulateInfo property if present will be used by incremental builder to update the diagnostic chain.
I didnt think it was right to get new errors again from checker just so error reporting is correct and resulting in more work, so went ahead with approach of diagnostic chain having this info.
This change has following changes to make everything come together:

  1. ModuleNodeFound chain is now a helper and sets repopulate info which can be used by anyone to get the latest chain.
  2. In the tsbuildinfo we save this info instead of chain message, so that we can get the correct diagnostic when getting the errors from buildinfo for the file.
  3. In tsc --watch scenario we need to repopulate using existing diagnostic and source file
  4. failed lookups and affected locations of node10Result are accumulated in the resolution itself so that it can be watched. We also watch node10Result as if it was failed lookup.

Fixes#52810

Comment threadsrc/compiler/builder.ts Outdated
Comment threadsrc/compiler/program.ts
Comment threadsrc/compiler/types.ts Outdated
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the node10Result branch May 9, 2023 20:42
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node10Result on resolvedModule issues

4 participants

@sheetalkamat@andrewbranch@jakebailey@typescript-bot